GitLab

BUG=757977,738613,757938,648274
TBR=pdr@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I163c04bddfd2922adf78b87cb18749b5f02e9b4a
Reviewed-on: https://chromium-review.googlesource.com/627024Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496480}

Previously the mojo::edk::ChannelFuchsia was hard-wired to cope only
with file-descriptors for simple files, which wrap a single underlying
platform handle, e.g. a virtual memory object containing the file data.

This CL extends the implementation to cope with MXIO file-descriptors
which build on multiple platform resources, notably device files such as
"/dev/zero". We make some assumptions about the contents of the |info|
returned with the unwrapped handles, so this may need revisiting in
future.

Bug: 734791, 740791
Change-Id: I6aac82bb5b34995381d08bd5b0f8df44a156bc37
Reviewed-on: https://chromium-review.googlesource.com/624815Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496479}

This reverts commit 9de3fd9b.

Reason for revert: 

Given https://chromium-review.googlesource.com/c/chromium/src/+/627259, it is safe to revert this revert of 616100. For details see revert reason in CL 627259.

Original change's description:
> Revert "Fix UI bugs when hiding context menu submenus and their children"
> 
> This reverts commit 3f8c6daa.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Note from Catherine Mullings:
> 
> Btw, this other CL (https://chromium-review.googlesource.com/c/chromium/src/+/616100/) depends on 553578. If you revert 553578, you'll need to revert 616100 too
> 
> (and I've reverted 553578).
> 
> 
> Original change's description:
> > Fix UI bugs when hiding context menu submenus and their children
> > 
> > This CL fixes a bug on Mac so that when a context menu submenu is
> > hidden, it does not appear in the context menu. Related on Mac, this CL
> > fixes the case when a context menu submenu's children are hidden, so
> > that the context menu submenu contains the empty menu item, "(empty)".
> > 
> > The second bug indicated above is fixed on Linux as well in this bug.
> > 
> > Note that this patch depends on the on-going implementation being
> > reviewed here: https://chromium-review.googlesource.com/c/553578
> > 
> > Bug: 750802
> > Change-Id: Ic8c7c0a1c8da11adb3fc5dfb271f26b28c35a41c
> > Reviewed-on: https://chromium-review.googlesource.com/616100
> > Commit-Queue: catmullings <catmullings@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Trent Apted <tapted@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#496370}
> 
> TBR=sky@chromium.org,tapted@chromium.org,rdevlin.cronin@chromium.org,catmullings@chromium.org
> 
> Change-Id: Id431bc9898a3a1cdabb829ad7168d81c211383b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 750802
> Reviewed-on: https://chromium-review.googlesource.com/627016
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496387}

TBR=sky@chromium.org,tapted@chromium.org,rdevlin.cronin@chromium.org,dschuyler@chromium.org,catmullings@chromium.org

Change-Id: I24310cb1211e12c92f5207e5d8f895e31581a3d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 750802
Reviewed-on: https://chromium-review.googlesource.com/627186Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: catmullings <catmullings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496478}

In this CL, SchedulerWorkerPoolImpl::SchedulerWorker::Delegate now
implements the BlockingObserver interface. Note: In this CL, only
BlockingType::WILL_BLOCK will supported.

When ScopedBlockingCall is instantiated with WILL_BLOCK, 
SchedulerWorker::Delegate::BlockingScopeEntered will
increment |worker_capacity_| and create a new worker if needed. When
the ScopedBlockingCall object is destroyed, |worker_capacity_| is 
decremented back.

Bug: 738104
Change-Id: I19e1a2ba6cc11cf77cd8cc3de487b2f4a2bbc351
Reviewed-on: https://chromium-review.googlesource.com/612502
Commit-Queue: Jeffrey He <jeffreyhe@google.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496477}

Bug: None
Change-Id: I7cc3cebc78e157818b1ab261c6b948374bbdcbcc
Reviewed-on: https://chromium-review.googlesource.com/627032
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496476}

Bug: 754895
Change-Id: I9a7d8b8021e942e8ed3ae90f3dae5d640768bfd6
Reviewed-on: https://chromium-review.googlesource.com/614907
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496475}

Using wpt-import in Chromium df4145d3.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/505

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
dom-dev@chromium.org:
  external/wpt/dom
  external/wpt/html
kojii@chromium.org:
  external/wpt/css/css-writing-modes-3
xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com:
  external/wpt/css/geometry-1

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I4ec4755926b71ebcb6f9b05268722a1a0144d6ee
Reviewed-on: https://chromium-review.googlesource.com/626917
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496474}

Bug: 667892
Change-Id: Ibe58ddb8fbb688cc4103604b379552463c0ea926
Reviewed-on: https://chromium-review.googlesource.com/625544Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496473}

Unpacked extensions loaded through the ChromeTestExtensionLoader are loaded
twice. The redundant load is due to the  false default value of
|allow_file_access_|. However, unpacked extensions are by default, loaded with
file access. This mismatch causes the unpacked extensions to be reloaded in
ChromeTestExtensionLoader::CheckPermissions.

Prevent this reload by using Manifest::ShouldAllowFileAccess for cases where
clients don't explicitly set |allow_file_access_|.

BUG=757695

Change-Id: Ied4b25ccb89ff1410072186d360634609b8666e5
Reviewed-on: https://chromium-review.googlesource.com/625247Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496472}

Bug: 736853
Change-Id: I3c34dffb857e0a31ee71840302dd3caa9968a4ed
Reviewed-on: https://chromium-review.googlesource.com/575279
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496471}

https://pdfium.googlesource.com/pdfium.git/+log/4a6525492593..ed2f2769bf11

$ git log 4a6525492..ed2f2769b --date=short --no-merges --format='%ad %ae %s'
2017-08-22 rharrison Add pdfium::Optional to third_party/base

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I2c1d430f00562db48cb2e891d6909fdcfe46fa7d
Reviewed-on: https://chromium-review.googlesource.com/627386
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496470}

Add ability to disable the feature flag for end users. We will track
the UMA usage of this flag.

BUG=746581

Change-Id: Ib6650a990bd83ee2d1f3ae8772c207125a4f09ba
Reviewed-on: https://chromium-review.googlesource.com/624418
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496469}

If an unpacked extension is loaded unsuccessfully using the
ChromeTestExtensionLoader, it enters an endless loop since it keeps waiting for
the extension to be loaded successfully. This CL adds support for the
|should_fail_| parameter to unpacked extensions, so that load errors can be
tested for unpacked extensions as well.

BUG=757680

Change-Id: I3fd9009522a31368f741da8d72178f54b9cfc82b
Reviewed-on: https://chromium-review.googlesource.com/625070Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496468}

Bug: 514674
Change-Id: I5b8fbcb19ee512830f90be11defdbb003de3c9f7
Reviewed-on: https://chromium-review.googlesource.com/622465Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496467}

Current answer card implementation uses WebView to display results.
WebView by default handles all events internally as render host and
this prevents handling events in base app list view.  This CL provides
custom event routing that excludes coming events to render host view.

      propagated. Cursor is not changed on different WebView content and
      clicking the card opens corresponded web page.

Test: Manually, Answer card is displayed. SetIsMouseInView is
Bug: 712331
Change-Id: Id7343ed09ae134fcaa2bf85c0780f6d07803966c
Reviewed-on: https://chromium-review.googlesource.com/607712
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496466}

This reverts commit 873c4f8c.

To make the settings more consistent across different architectures.
So that the flag can be applied in more consistent way.

BUG=chromium:756673

Change-Id: Ie12a7c06b5ddcf1dd1f88c1f772cbd9b372c1ee1
Reviewed-on: https://chromium-review.googlesource.com/622029Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: YH Lin <yueherngl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496465}

This reverts commit e83bf884.

Reason for revert: 

Per discussion with dschuyler@. FindIt (https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10594) mistook the Win7 webkit build failure to be caused by CL 553578. CL 553578 adds a manifest.json, and there's a MANIFEST.json in the failure log. See the Heuristic Hints on the page.

However, the failure (https://chromium-swarm.appspot.com/task?id=3822bb5befc13310&refresh=10&show_raw=1) is referring to a different manifest.json (third_party\WebKit\LayoutTests\external\WPT_BASE_MANIFEST.json) and the webkit layout script is eventually able to generate that particular manifest.json. The Win7 Webkit layout test is failing because the script is "Unable to find test driver" for content_shell.exe and content_shell_crash_service.exe, which is unrelated to CL 553578.

Original change's description:
> Revert "[Extensions] Added visibility property to chrome.contextMenu items API"
> 
> This reverts commit 44248851.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> FindIt claims that this CL is causing a build failure (with 100% certainty). More info:
> https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10594
> 
> https://chromium-swarm.appspot.com/task?id=3822bb5befc13310&refresh=10&show_raw=1
> 
> 
> 
> Original change's description:
> > [Extensions] Added visibility property to chrome.contextMenu items API
> > 
> > Users of the chrome.contextMenu API should be able to programmatically
> > set the visiblility (shown, hidden) of context menu items on item
> > creation and update.
> > 
> > This CL introduces the |visible| property to createProperties
> > (chrome.contextMenus.create) and updateProperties
> > (chrome.contextMenus.udpate). Note, this change ensures that hidden
> > items are not counted against
> > chrome.contextMenus.ACTION_MENU_TOP_LEVEL_LIMIT.
> > 
> > Bug: 463476
> > Change-Id: I315bcf070516fe8667e51fbec7c8f539230afa23
> > Reviewed-on: https://chromium-review.googlesource.com/553578
> > Commit-Queue: catmullings <catmullings@chromium.org>
> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#496210}
> 
> TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,catmullings@chromium.org
> 
> Change-Id: I25265b68f8881f1bce650a395067ce05bab4cadd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 463476
> Reviewed-on: https://chromium-review.googlesource.com/626622
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496386}

TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,dschuyler@chromium.org,catmullings@chromium.org

Change-Id: I7324bd25d6e1271caa752c442453c6328ac4ffd0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 463476
Reviewed-on: https://chromium-review.googlesource.com/627259Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: catmullings <catmullings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496464}

Bug: 755336
Change-Id: I4dfb8860c0f0a1ba6855b3d7b7272f8e2f5c9fc1
Reviewed-on: https://chromium-review.googlesource.com/624674
Commit-Queue: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496463}

Several tests have been flaking, causing a 45% failure rate for the
WebKit Win7 dbg builder. Disabling those to green the bot again.

Bug: 757955
Change-Id: I8b4951380e68c9a043f3f2efcc4fe831e39c6b22
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/627299Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496462}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2b9cb61ce2f9e76a033fd5c1170c4a01d261b0a0
Reviewed-on: https://chromium-review.googlesource.com/627173Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496461}

Update extension_service_sync_unittest to use the semantic methods of
ExtensionBuilder.

Bug: 756488
Change-Id: Ie97834a2c01d1e7b2a3bbd04c5417de943f561a2
Reviewed-on: https://chromium-review.googlesource.com/626878
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496460}

Update extension_service_unittest to use the semantic methods of
ExtensionBuilder.

Bug: 756488

Change-Id: I743c26cd8ec0199835a3ce5f3b2d3bdc22455c1b
Reviewed-on: https://chromium-review.googlesource.com/626876
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496459}

If you were running mus/mash on a Chromebook with two displays then
there would be constant screen tearing. It turns out that the buffer for
one display was sometimes ending up on the other display. There are two
InProcessCommandBuffers, one for each display, that independently
allocated IDs from CreateImageCHROMIUM starting at 1. This resulted in
ID collisions.

Make all InProcessCommandBuffers allocate IDs for CreateImageCHROMIUM
from a global AtomicSequenceNumber to ensure there are no ID collisions.

Bug: 735631
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4501afe854041304b4860f0a2a67ca5c1a0e1df9
Reviewed-on: https://chromium-review.googlesource.com/621529
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496458}

Use a separate method when tracing raw pointers from generated bindings
code. These cases are not problematic and make it harder to isolate
interesting cases on codesearch.

Bug: chromium:757440
Change-Id: If337b884d7d2a20c7fc979cacd67678d8b5b9c7b
Reviewed-on: https://chromium-review.googlesource.com/626119
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496457}

BUG=756976

Change-Id: I37050ae2c933ef7b75f22cba94a31a83f35f4215
Reviewed-on: https://chromium-review.googlesource.com/626380Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496456}

Cache responses after data reduction proxy
bypass in Data Reduction Proxy (DRP).

Bug: 736004
Change-Id: Iefcac0c0858574d7be64b629cc6e656476cdcc64
Reviewed-on: https://chromium-review.googlesource.com/627107Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496455}

The previous CL crrev.com/496127 was reverted due to memory leak of
TestWindowDelegate.

The CL uses TestWindowDelegate::CreateSelfDestroyingDelegate() so that
the delegate will be deleted when the window is deleted.

Also the CL adds RunAllPendingInMessageLoop() so that it processes all
pending requests when StartDragAndDrop accedentally returned before
processing drag requests.

Bug: 750997
Test: DragDropControllerTest.EventTarget
Change-Id: I522c1b425fa6f4918a92705ace496958f8bab9c4
Reviewed-on: https://chromium-review.googlesource.com/624771Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Daichi Hirono <hirono@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496454}

Users of some Chrome OS devices have reported janky, unresponsive
behavior. We have seen in feedback reports from those users
multiple-second times reported in the ThreadWatcher.ResponseTime.UI
histogram.

I don't believe any throttling is needed as this should be a very rare
event on systems; UMA statistics suggest times of 1sec+ are less than
00.03% percent of reports.

For a recent feedback report (71050794671) with extremely heavy jank,
this would have been triggered ~80 times.

ThreadWatcher is not enabled on stable channel, so there's no risk
to those installs.

BUG=756207
TEST=Build

Change-Id: Id46e706defec7d464c5de0fbb2da318c6d4543a5
Reviewed-on: https://chromium-review.googlesource.com/624899Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Commit-Queue: Justin TerAvest <teravest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496453}

Note that I've filed crbug/757887 to do a better fix for this (and related
issues), as the fact this is subtle shows the API design should be improved,
but we'd like to get this fix in for M61.

Bug: 757681
Change-Id: Id48896ecefa7d7e463e14cbebb6fc3e174002367
Reviewed-on: https://chromium-review.googlesource.com/627236Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496452}

This is in preparation to add a second type of byte reading function,
where we continuously read and throw away bytes until the serial
connection reaches quiescence.

Bug: 757508
Change-Id: I2a7ec8194186527f3ee2beaf25a749017ba1bf36
Reviewed-on: https://chromium-review.googlesource.com/627185Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496451}

This CL removes the IDC_SHOW_SAVE_PASSWORDS_SETTINGS IDC command.
Also, in order to provide PasswordController a dispatcher, this CL 
moves the instantiation of PasswordController and all objects that 
depend on PasswordController to attachDispatcherDependentTabHelpers. 
This is required since dispatcher is nil during attachTabHelpers.

Bug: 738881
Change-Id: I292e678bc1ebf2c297674d50350fe8e4140fffe7
Reviewed-on: https://chromium-review.googlesource.com/624908
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496450}

This CL adds the AwVariationsConfigurationService(VCS) which is a bound
service that schedules the seed fetch job, keeps the Finch seed 
updated and shares it with all the WebViews on the system. WebViews will
bind to this service and ask for the Finch seed. When the seed request comes, 
it will first check if the current seed is in the WebView package data 
directory and return it directly if not expired. If the service seed is 
expired and there are no pending or running jobs, the service will schedule 
a seed fetch job to the AwVariationsSeedFetchService. When the new seed is 
fetched, the JobService will bind to the VCS and the new seed will be passed 
via IPC. The VCS stores the seed, passed via IPC, in the WebView package data directory.
The VCS and JobService are run in a separate process, attributed to the WebView package 
process. Because the functionality is just a prototype, the code will 
be landed behind a flag 'enable-webview-variations'.

Bug: 733857
Change-Id: Ie348030c0a143dfa6bb41d8050b42b687d02fd86
Reviewed-on: https://chromium-review.googlesource.com/614111
Commit-Queue: Kyle Milka <kmilka@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496449}

It can be reached, and it is even being handled.

Change-Id: If49c58db0847ce54b076d6dc71f1ecd39a1de50e
Reviewed-on: https://chromium-review.googlesource.com/625378Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496448}

Brings the bottom nav menu into a new third_party directory, so we can
make local modifications for Chrome Home.

Bug: 738492
Change-Id: I0855cf54a7a03db6b8fdcf928ff47e90415a666a
Reviewed-on: https://chromium-review.googlesource.com/624665Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496447}

Still missing: Copy data back into the LayoutObject tree.

Some layout tests now fail, since we're not using the legacy engine to lay out
multicol. Quite a few crash or freeze, too.

Also brought back some of the unit tests. They needed some changes, because of
the following:

1. We now create a fragment for each column, from an anonymous constraint
space. I.e. we have one more level of fragments, and it's the column fragments
that have their inline offset shifted to the correct column, rather than
setting it on the first child block, which is what we did last time these tests
worked.

2. Mistakes introduced when converting test to using setBodyInnerHTML() rather
than building the layout trees programmatically:
https://codereview.chromium.org/2725773002

3. New bugs. :)

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4df85d684f0ddb8f7f0f75d15230a1ab61e9f9a0
Reviewed-on: https://chromium-review.googlesource.com/591429
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496446}

GestureEventQueueWithSourceTest.GestureFlingCancelsFiltered

TBR: creis@chromium.org
Bug: 757557
Test: GestureEventQueueTest.TapGetsSuppressedAfterTapDownCancellsFling,
Change-Id: Id0a314cd191dfd5c9bda74e92133ed4a8efb77bc
Reviewed-on: https://chromium-review.googlesource.com/624677
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496445}

DrawQuad::opaque_rect and DrawQuad::needs_blending are both used to compute
whether a particular DrawQuad needs blending or not. It should be sufficient
to use only needs_blending to keep track of it.

A detailed explanation and analysis can be found here: 
https://docs.google.com/document/d/1kT9a-t6tVaotSVCr-J0kYALwiDLLl_UwIZJiSP39F2I

In the previous cl, all usages of opaque_rect are removed:
https://chromium-review.googlesource.com/c/618020

In this cl, DrawQuad::needs_blending is added to all DrawQuad::SetNew calls.

In the next cl, DrawQuad::opaque_rect will be removed entirely.


Bug: 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6fa880fa0ecdaae6ffb294b2e40542bf3bc287df
Reviewed-on: https://chromium-review.googlesource.com/621545Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496444}

Continuing on removing stuff from the browser side, this CL forwards four
more methods to the platform node side:

get_attributes, get_uniqueID, get_windowHandle, get_indexInParent

Bug: 703369
Change-Id: I5b1996b131733f4792611a5f9ce14d030f1f4d1c
Reviewed-on: https://chromium-review.googlesource.com/619988Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496443}

This moves and renames some remaining 'options' strings that are still
in use.

Bug: 728353
Change-Id: Ib7901e857c6d0e11aaa9378f5e2e8e49fc40e1ca
Reviewed-on: https://chromium-review.googlesource.com/622152Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496442}

BUG=chromium:753615
TEST=compiles

Change-Id: I4a830be764cebe7a7e25b1dc5c6b7d02ddf96969
Reviewed-on: https://chromium-review.googlesource.com/624570Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496441}