GitLab

When attempting to clamp the scroll offset during printing, save the
scroll offset before clamping, so that it can be restored after
printing.

Note that there are still issues to fix here. Right now, this CL doesn't
fix anything at all, but it will prevent a regression that would
otherwise be introduced by crrev.com/2362749. This is what's tested in
PrintBrowserTest.NoScrollingVerticalRl

PrintBrowserTest.NoScrolling tests scrolling of an iframe and a
scrollable DIV, and another scrollable DIV that turns into a
non-scrollable flexbox when printed. The iframe part also passes
without this CL, and the scrollable DIV ones fail both without and with
this CL (and is therefore disabled for now).

Same problem for framesets - still not fixed. Added a test.

The remaining known scrolling issues when printing are reported as
bug 1131598.

Based on WIP CL:2402190 by szager.

Bug: 1125972
Change-Id: I6c3f5853d329e4731b02b33d67cbd4b016f2675f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418651Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810103}

(1) calling HandwritingModelLoader(spec, receiver, callback).Load() is
a bad idea because the .Load() is async and the temporal object could be
released very soon. This Cl changes the whole class to be stateless, so
that calling HandwritingModelLoader::Load(spec, receiver, callback) won't suffer the same problem.

(2) unit tests are fixed accordingly.

Bug: 1054628
Change-Id: I56459b14e1fc4a6608d5ed264e6c650d1e076f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415914
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Reviewed-by: Xinglong Luan <alanlxl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810102}

This CL makes AgentSchedulingGroup and its host, implement the
mojom::RouteProvider and blink::mojom::AssociatedInterface interfaces.
This will make it possible in the future to register ASG-specific routes
instead of process-global routes, as well as ASG-specific associated
interfaces, as opposed to interfaces that are associated with the
process-global IPC channel.

Currently the implementations of these interfaces are not operational.
Later CLs will flesh out this implementation so we can begin migrating
interfaces over to the ASG scope.

Bug: 1111231
Change-Id: I3da0a31d31018b18ab616e02f351d3d0876c7694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415949
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Tal Pressman <talp@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810101}

Quirks mode layout is slower than no-quirks. This change should
not affect the appearance of the image preview document.

Bug: 1131185
Change-Id: I79e8b523fa518ddd7a230ea7f669df63e023b9e5
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425008
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#810100}

Previously, SaveDeltaSizeInfo() and LoadDeltaSizeInfo() take an optional
|file_obj| parameter, and uses it in a "with" block. This causes the
inject |file_obj| to get closed. This side-effect is undesirable for the
usual usage pattern of callers lending |file_obj| to functions. This CL
fixes the issue by using a one-level recursion to create |file_obj| if
it's not provided.

Change-Id: I2132aea64bb29edd49576dbaa4b0797a6afb80f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425224
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810099}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I19660691a5dca58f9ba7b7d7359ee810cbe467cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426368Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810098}

Before, an IPH bubble was shown when a second tab was opened. With
this CL it is shown as soon as possible after the WebUI tab strip is
initialized.

Bug: None
Change-Id: I2f3e7a7dd04229953af5eefe99e00dbcbbfaa8da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418566
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810097}

This CL adds tests for forcible worker termination during:

- Module top-level script evaluation,
- Evaluation of dynamic import()ed script evaluation
  (from module/classic workers),

The failure of
"Worker is terminated during top-level script evaluation (module)"
test on Chromium is tracked by crbug.com/1129793.

Bug: 1111134, 1129785, 1129793
Change-Id: I7babf738848a2de51a62679e080a389519fd5884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418751Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810096}

Introduces build flags to build the new IDL callback function
and IDL callback interface bindings.

Bug: 839389
Change-Id: I8714d28f1948bdee37cbde0c327f1ad57d406d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418499Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810095}

We should show max 2 downloads in holding space UI.
We should show max 3 screenshots in holding space UI.

Bug: 1131263, 1131265
Change-Id: I912b87f77bae136d7fcb3095dc7f0b70a83884f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427076
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810094}

Previously, the Wrapper message was defined to be:

   Wrapper { internal_request, internal_reply, reply, request }

However, internally, internal_request and internal_reply were the same
object, so it seemed a bit overkill.

Change Wrapper to just have a public_message or a private_message.
Although it's more type-safe to distinguish between request/reply, the
terminology can be confusing. Since the private messages don't distinguish
between request/reply, might as well do the same for the public messages too.

Also change the terminology from internal to public/private, since it better
corresponds to the existing terminology about public/private APIs.

Fix a bug where the protos were not being serialized at all.

Change-Id: I98e96dadf42ce8ccb1a1f28cdbdb06c2386ef2cf
Bug: 1019541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423828
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810093}

Replace the static initializer with helper functions, so that we don't
have to modify testing/scripts/check_static_initializers.py when
building by default on linux.

Bug: 1066176
Change-Id: I1beb107cab47b5d7ece7b10ce5e41b8a407e080f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425446
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810092}

This is the CL https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2393466
Will rebaseline and enable test again.

Bug: 1002914
Change-Id: I0310fd1277158059f9149d38ed97172b4861ef0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422348Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810091}

The feature is no longer used in the code.

Bug: 1126640
Change-Id: I87611bf977a6e7fcb2df2658675451f1b4a9ea32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427430
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810090}

This reverts commit 6a3c229f.

Reason for revert: Collided with https://crrev.com/810071

This CL renamed SetHasAccessBeenGranted(), but the other CL added
more calls to it.

Original change's description:
> [CrOS PhoneHub] Add setter functions to various manager classes
> 
> The added setters are going to be used by a future Cl that implements
> the PhoneStatusProcessor class.
> 
> Bug: 1106937
> Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346
> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810084}

TBR=khorimoto@chromium.org,jimmyxgong@chromium.org

Change-Id: I241a33162c008e5f7ab4de0621f1bdb6c0918965
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1106937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428103Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810089}

Bug: 813093
Change-Id: I9f9bbdd79924ad1de0d48956413b29de4b45cbf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424498Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810088}

Using wpt-import in Chromium fb330662.
With Chromium commits locally applied on WPT:
8f02a380 "Use allow attribute for delegation in web serial WPT"
8d82b92f "Origin isolation: add crash test for noopener popup windows"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: Ie9306f94a3e5447cf46cd6a592d540a6914af201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426549Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810087}

This CL takes the parsed json from crrev.com/c/2420192 and converts it
into Results objects that will later be used to create search results.

The next CL will add unit tests.

Bug: 1034842
Change-Id: I12dbfd295854475268bc71bc84b3a0e365150d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425688
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810086}

As ModuleRecord::Evaluate() returns a successful result
(with a promise rejected with an exception) for a module
script throwing an exception when kTopLevelAwait is enabled,
this CL fixes the expectation of ModuleRecordTest accordingly.

This also fixes ModuleRecordResolverImplTest to call
ParametrizedModuleTest::TearDown() appropriately.

Bug: 1111134, 1129743
Change-Id: I7f8267bd7966df58158f4cf70597276d2a0acd5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419055
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810085}

The added setters are going to be used by a future Cl that implements
the PhoneStatusProcessor class.

Bug: 1106937
Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810084}

With the ability to select multiple holding space items at a time, we
want to be able to open, pin, and unpin items in bulk.

Bug: 1129981
Change-Id: Ifa0f80de5f3a30c87678858d66c697b8852381a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426085
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810083}

Reland as is because the fix was in the parent CL:
https://crrev.com/c/2426864/2

Original commit message:
> [Nearby] Trigger onboarding when first enabling Nearby
>
> This CL adds a pref to track if onboarding was run by this user before.
> If it has not, when enabling for the first time, onboarding is run first
> by navigating to the subpage and showing in a dialog. Once onboarding
> has been done once, the user can freely toggle on/off without
> triggering onboarding. However, onboarding will still run if the user
> triggers the pod button and the feature is disabled. This matches the
> Android behavior.
>
> Additionally, this CL fixes a bug with the premature closing of the
> shared receiveManager which needs to stay alive and connected after the
> dialog closes otherwise getReceiveManager returns a remote with a closed
> pipe.
>
> Bug: b/154866951
> Change-Id: I1e3cbd15f4995f019b3476c2f7a69f67d6eb1888
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424763
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: James Vecore <vecore@google.com>
> Cr-Commit-Position: refs/heads/master@{#809623}

Change-Id: I91e3a3749ae15ae6bf7879c259e3622e74eba337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427004Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#810082}

Only allow approved topics to be displayed. All topics are defaulted to
false and must be enabled by finch params.

BUG=b:167458920
TEST=turn on ambient mode with "GeoPhotosEnabled" param set to false.

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I2ce8057999279d4792840ce99cd379edba2955ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422583
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810081}

At a high level, this enables creating handles from either local paths
or external paths. An external path is a path that can be used as
virtual path in a kFileSystemTypeExternal file system URL. These
external paths are intentionally not wrapped in an isolated file system,
as doing so would make it much harder to keep track of this virtual path,
and we need the virtual path to be able to serialize these handles to
IndexedDB.

(local paths are still wrapped in an isolated file system, although some
of the previous CLs that enabled not using one in this case has made
that no longer needed either. In the future I hope to be able to
eliminate/replace isolated file systems entirely).

This adds a PathType enum/parameter to CreateFile/DirectoryEntryFromPath
methods in NFSEntryFactory/NFSManagerImpl. This parameter makes it clear
if the path is a local path or an external path.

And changes the result FileSystemChooser returns from simply being a
base::FilePath to being a combination of a FilePath and a PathType.
This is then used by NFSManagerImpl to create the right type of
FileSystemURL/entry.

Currently all the permissions code still just deals with raw
base::FilePaths without indication if a path is a virtual/external or
local path. This shouldn't matter, since on ChromeOS (the only place
we use external paths) these paths will never overlap anyway, but we
might want to revisit this in the future.

This could have been implemented by having FileSystemChooser return the
appropriate FileSystemURL directly (and changing the NFSEntryFactory API
to be in terms of FileSystemURL); that was not done because in my ideal
end state FileSystemURL wouldn't be used anywhere in the native file
system code. I.e. it would purely be an implementation detail, but the
interface between the native file system code and file system backends
wouldn't depend on it anymore. Still working out the details for that.

Bug: 1093653
Change-Id: I201703d427a5368e67b0410428f366d1dca91aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354596Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810080}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8134d1f70669..c23abb18bf27

2020-09-23 chrche@microsoft.com Calling localization API on grid setting titles
2020-09-23 chrche@microsoft.com Avoid term "Framework" being translated

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I240fc2691b9cf66149aea1164e4127a4d9a81053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810079}

Bug: None
Change-Id: If388c4ca16c76c7793ca17f15afa8aa6c6ec5199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423762Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810078}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ia3528bd03480f080027975fa31b3dfd1f86a887e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427869Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810077}

Bug: 1129795
Change-Id: Ibff0827b206b9a0290fcdbcaccb3c57cae2a00da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413725
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810076}

Roll Chrome Linux PGO profile from chrome-linux-master-1600883819-6d81c41c506f5dfe6d7f3151056b14ae70cf74e3.profdata to chrome-linux-master-1600905490-263a31e7c986c96eb226e442771660364e68ddae.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I038c1f2f5b8a9f081210f9d2e2eeedb905e1492a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427746Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810075}

The Related Searches flag has expired, and we want it to stay active.
This extends it until M89.
BUG=1069096

Change-Id: Ib437a8f7b00833516be113d9a2216a0f9fa72880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412830
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810074}

Roll Chrome Mac PGO profile from chrome-mac-master-1600883819-b4e54673a8ac66af896b73e5221cf1b275c98c77.profdata to chrome-mac-master-1600905490-fdb2e7b3449a423d26d1d15a08c032508e6d13fa.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I0ed53d6c7cc3caee025cbc87ef699fa9b2d91d44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427528Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810073}

Printer URIs with a "socket" protocol cannot have a path component.
However, our UI allows a user to provide a queue name (a path) for all
types of printers. Moreover, this field has a non-empty default value.
This causes a validation error of provided printer URIs with a "socket"
protocol when a user doesn't clean the field by hand. This patch solves
the problem by automatically removing a path component from provided
URI when the protocol is set to "socket".

BUG=chromium:1129047
TEST=tested on atlas

Change-Id: I92d8afbaaf4f0e74d102b1384ef7378d34b15496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423344
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810072}

This CL adds the notification opt in view on the Phone Hub panel to
provide another entry point for user to grant access for notifications
from the phone. This CL also introduces a |PhoneHubViewID| enum for
easy access to main components of the bubble view during unittests.

Screenshot: https://screenshot.googleplex.com/3XBngS9RArKjD44.png

BUG=1106937,1126208

Change-Id: Ie440ebad2080382f48e48778eb94f559474aa5ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424647
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810071}

https://quiche.googlesource.com/quiche.git/+log/d18fe67a2b86..9a74ee9f6be4

$ git log d18fe67a2..9a74ee9f6 --date=short --no-merges --format='%ad %ae %s'
2020-09-23 fayang Discard initial key right after a HANDSHAKE packet has been sent and unify the fixes for missing initial keys. This goal is to make sure an endpoint never tries to serialize initial frames (could be pending frames or re-serialize initial packet in the coalescer) while initial key gets dropped.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=dschinazi@chromium.org

Change-Id: Idf244b113439019dec06702ea5b5faba186a7b1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427547
Commit-Queue: Fan Yang <fayang@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Fan Yang <fayang@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810070}

Failing on more than n builders so disabling the test completely.

Bug:  1131545
Change-Id: I089905b189e9dcece65ad2d5e7e174fccaa9565d

TBR=wychen@chromium.org

Change-Id: I089905b189e9dcece65ad2d5e7e174fccaa9565d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427441Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810069}

https://android.googlesource.com/platform/external/perfetto.git/+log/61c15b0ea08f..4e32ab4dd7c3

2020-09-23 dproy@google.com Merge "metrics: Implement getting prototext formatted metric result"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I50d7118fdf734852d9e91e554efa05cb8ab3fbee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427473Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810068}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009230800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/2a08myhDLFnYjNwtbn3d4RoitoxiNvUZkfWohkxJIP8C

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa
Bug: b/141204984,b/157703611,b/159170892,b/159873698,b/159892033,b/167632244,b/167933216,b/169015908,b/169121815,b/169131919,b/169188037
Tbr: media-app@grotations.appspotmail.com
Change-Id: I1b56db47c9fcb4375d2bbd9c26a91da54aaf513f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426294Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810067}

Breakpad change landed. Revert workaround.

Bug: 1105559
Test: components/crash/content/tools/generate_breakpad_symbols.py --build-dir=out/andrd --binary=out/andrd/lib.unstripped/libcontent_shell_content_view.so --symbols-dir=/tmp/foo --platform=android
Change-Id: I519534002898a97b15a57b9b87ac78ef3f216dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427349
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810066}

Due to an upcoming change in glibc, we won't be able to support
dlopening after engaging the sandbox unless a very new kernel.

So we preload the libimedecoder in the sandbox hook and remove the
permissions of its shared library dependencies from the sandbox.


TEST=builds and run on vm.

Bug: 837156
Change-Id: I64bcb651c055553390785d8cb1eaa2e516157a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423826Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810065}

https://pdfium.googlesource.com/pdfium.git/+log/1d3378762d82..5b2e586ff35d

2020-09-23 tsepez@chromium.org Perform GC on teardown of FXCG_UnitTest.
2020-09-23 tsepez@chromium.org Declare CXFA_FMLexer as stack-allocated
2020-09-23 vmiklos@collabora.co.uk Add FPDF_GetTrailerEnds() API
2020-09-23 tsepez@chromium.org Use members in CFXA_TabParam sorting code
2020-09-22 tsepez@chromium.org Make CXFA_TabParam private to cxfa_ffpageview.cpp
2020-09-22 tsepez@chromium.org Use sets of members in CFXA_Node node shuffling code.
2020-09-22 tsepez@chromium.org Rename XFA_GetWidgetFromLayoutItem() to CXFA_FFWidget::FromLayoutItem()
2020-09-21 tsepez@chromium.org Make iterator a stack variable in CFDE_TextEditEngine::RebuildPieces()
2020-09-21 tsepez@chromium.org Remove forward declarations of CFDE_RenderDevice.
2020-09-21 thestig@chromium.org Improve FPDFSysFontInfoEmbedderTest.DefaultTTFMap.
2020-09-21 tsepez@chromium.org Create a cppgc::Heap for xfa fuzzers
2020-09-21 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from a54f10f750ba to 0de987471899 (51 revisions)
2020-09-21 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Jinja2 from 61cfe2ac6c91 to a82a4944a7f2 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1130100
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I017abb70ef678f0ca460305d8cf46f3d250db946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427239
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810064}