- 21 Oct, 2019 40 commits
-
-
Nick Burris authored
The 99th percentile of TouchpadPinch latency exceeds the 100ms max. This patch updates to TouchpadPinch2 with a max of 1 second, or 1000ms. Change-Id: I58bcc7fd8ee441043bdb0482f15e58c70368f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834679Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#707910}
-
Evan Stade authored
Use ProfileManagerObserver::OnProfileAdded instead. Also worth noting that this removes an obsolete superclass from UserCloudPolicyManagerChromeOS, i.e. KeyedService. Both KeyedService and ConfigurationPolicyProvider have a "virtual void Shutdown()" so this removes that collision (not that it was doing any harm). Bug: 268984,171406 Change-Id: Ia0b3dd4dd34a0f62e84dd057928d61c5677231d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854525 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#707909}
-
Aran Gilman authored
Bug: 952034 Change-Id: I6debbcb4e8474cacdcd8b5add471a9c04c0a4dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853862 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707908}
-
Ryan Sturm authored
When a navigation to the wrong URL begins, the prerender in NavigationPredictor should be stopped, and no new prerenders should begin. Due to mojo magic, it is hard to stop the case of a navigation starting followed by load event finishing followed by commit. As such, that case will still begin a prerender, but it should be relatively rare. Bug: 1016212 Change-Id: I1e406c877dd7c8d73d8d29efdbcfc2bde35bbdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872744Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707907}
-
Jonathan Backer authored
Change-Id: Ie1d9dadc454b36fdd4bf1c3f07e336fd49536f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872739Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707906}
-
Justin Cohen authored
crrev.com/c/1863950 introduced a visibility check, that causes multitasking tests to fail. Since the goal of 1863950 was to migrate to EG2 and keep the tests the same, removing visibility check here. Bug: 1016283 TBR: eugenebut@chromium.org Change-Id: I45e7fff55fce5fd987dc712931809bad442bf164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872565 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#707905}
-
Olga Gerchikov authored
The original CL caused flakiness of /virtual/threaded/animations/animationworklet* tests (crbug.com/1014966). The reason for the flakiness is change in timing of main thread effect local time update. Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1826872 The reverted CL is in Patchset 1. Patchset 2 fixes the tests by explicitly waiting for the effects to change. This CL changes how local time of composited worklet animations is updated on main thread: instead of polling local time on main thread, the local time is posted via animation events by the composited thread to the main thread. Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing Changes made: - Expanded AnimationEvent to support worklet animation time update event type. - Reused existing mechanism of posting animation events to the main thread to support new event type. - Removed "peek" logic. - Enabled tests that previously failed. Bug: 943787 Change-Id: I9a2965f204cad15b405be82305c38788c0eafd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864518Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707904}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d2ab0dfbb1b..d578b2973f62 git log 1d2ab0dfbb1b..d578b2973f62 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-21 shaochuan@chromium.org Make betty-pi-arc-release non-experimental Created with: gclient setdep -r src/third_party/chromite@d578b2973f62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0d6bc00b0fd0565be50a6808d2d6cefc3b972f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707903}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/72cc71cd70d4..eef5e4ffc239 git log 72cc71cd70d4..eef5e4ffc239 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 mbonadei@webrtc.org Remove dep between test:test_support and rtc_base_approved. 2019-10-21 ssilkin@webrtc.org Reset end-of-frame flag in non-VCL packet. 2019-10-21 danilchap@webrtc.org Avoid DEPRECATED_SingleThreadedTaskQueueForTesting::CancelTask in VideoAnalyzer 2019-10-21 danilchap@webrtc.org Clarify NetworkControl interface: result of each function must be used 2019-10-21 danilchap@webrtc.org Update call Rampup tests not to rely on DEPRECATED_SingleThreadedTaskQueueForTesting 2019-10-21 jakobi@webrtc.org Change failing rtc::dchecked_cast to rtc::saturated_cast. Created with: gclient setdep -r src/third_party/webrtc@eef5e4ffc239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:999807,chromium:None,chromium:1016147 Change-Id: I2ef7e4c518655482bcfca9b90757a353c3c8baa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872235Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63aaa927a3c7..e5b6f3adef16 Created with: gclient setdep -r src-internal@e5b6f3adef16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I577532fb8f460aefc0ddaf948068c7f1fbdff2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872122Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707901}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a80ba25e67b..f228038ddeb4 git log 4a80ba25e67b..f228038ddeb4 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 courtneygo@google.com Treat Pixel 2 XL and Pixel 2 the same Created with: gclient setdep -r src/third_party/angle@f228038ddeb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I2e7b544d2a6602264d9c22625ed57e5f4aeeb05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872123Reviewed-by:
-
Ben Mason authored
This reverts commit 55a4bb68. Reason for revert: Causing crashes - crbug.com/1016233 Original change's description: > Kill quiet permission requests if a new request is made > > Bug: 1014026 > Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706445} TBR=engedy@chromium.org,andypaicu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014026 Change-Id: I4e0f0120e3f7d2b9711d122bb186012c5d06464d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871632Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#707899}
-
Hwanseung Lee authored
Use enum class instead of enum for ShadowType enum class is more type safety. Bug: 940736 Change-Id: Ib816aa59a3b1ad67738050a1b9d5fd00b7140482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868535 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#707898}
-
Alison Maher authored
Only invalidate for high contrast and dark mode if the system colors changed, if the preferred color scheme changed, if the state of high contrast changed, or if the state of dark mode changed. Bug: 970285 Change-Id: I6da9787b84ba3790a94df5b961c6e1ec2a762270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869758Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707897}
-
edchin authored
When closing the last incognito tab, the incognito page is no longer the active page. It should be updated. Bug: 1011054 Change-Id: If2df5c8398bbc13ea533652296dbf124a63d650c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872158 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#707896}
-
Chris Lu authored
Bug: 1014959 Change-Id: I4c6d1ef64376815412082a7c430f8df929598d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869670Reviewed-by:
-
Matt Menke authored
These timeouts are ancient. The test infrastructure has its own timeouts, which should make these obsolete. Also, this may help with https://crbug.com/869227, where starting the Python test server times out. Bug: 869227 Change-Id: I9ea4f3174bcaa86daf09b965c82921432d8d556a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869717 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#707894}
-
Ahmed Mehfooz authored
Ux requirement Change-Id: If4d4e4320dc88d6d4380a7154cf105109834c3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867629Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@google.com> Cr-Commit-Position: refs/heads/master@{#707893}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf414fd4..91b5a03b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icce8c0213eb9d124c1d70f80475e1ebfc0a3a8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871893Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707892}
-
Francois Doray authored
These histograms are useful to diagnose regressions to Startup.FirstWebContents.NonEmptyPaint2. In particular, we need these histograms to analyze the impact on the ongoing project of merging chrome.dll and chrome_child.dll. Per discussion with rkaplow@: "startup performance is important enough that the barrier to have then be very long lived is low. Plus - they are the opposite of spammy. So I would keep them unless you don't think they'll ever be useful." Bug: 969963, 972795 Change-Id: Ice95c0e6ff68b0762a345119e5f95d3a8dfa5f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872313 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
HasFinishedInitialSetup() is expected to be removed and replaced by IsFirstSetupComplete(). Replacing HasFinishedInitialSetup() in: + first_run_egtest.mm + settings_table_view_controller.mm Bug: 951313 Change-Id: Id509a68e0bbb72702c7df8e3581f64c7996ccb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833610Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#707890}
-
Rayan Kanso authored
Instructions for enabling Android shortcuts: https://developer.android.com/guide/topics/ui/shortcuts/creating-shortcuts This is the first step for enabling shortcuts. The server will populate shortcuts.xml depending on the Manifest shortcuts provided (and also generate additional string resource files). Bug: 1010471 Change-Id: I2e0a6118a22869766e4b5e849dabc6533cd2d306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864805Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#707889}
-
Mark Cogan authored
Currently the usual way to turn a CommandDispatcher pointer into something that can have methods called on it is to static_cast() it into id<Protocols>, which compiles but has no runtime correct check. +conformsToProtocol: can't be used here, since that just checks a class interface, and doesn't work on a dynamic object like CommandDispatcher. This CL adds a function-like helper macro for use with CommandDispatcher. It does both typecasting and a runtime check that the dispatcher can handle the methods in the protocol. A macro is necessary to generate the correct static_cast expression that matches the protocol whose methods are being checked. Believe me, if there was another way to do this, I'd use it, The helper matches the behavior of ObjCCastStrict, returning nil and DCHECKing if the dispatcher doesn't handle the specified protocol. Note that while the dispatcher's startDispatchingToTarget:forProtocol: method doesn't handle protocols that the passed protocol conforms to, CallableDispatcher does, so composite protocols can be used when the callable needs to conform to multiple protocols. Change-Id: I49953ed89d76cbe6e714abec226161f927ebb60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866751 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707888}
-
Yue Zhang authored
Bug: 1016045 Change-Id: I001e8fde3058b318f81af9061f3747e10f5e39f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870050Reviewed-by:
-
Sammie Quon authored
This reverts commit 9b44d19a. Reason for revert: This was reverted to revert a upstream change that breaks lsan/msan bots. The upstream change with the fix has landed, so reverting this. Original change's description: > Revert "overview: Clipping for windows using new grid layout." > > This reverts commit 9ed68bfb. > > Reason for revert: Revert to revert upstream change > https://chromium-review.googlesource.com/c/chromium/src/+/1872011 > > Original change's description: > > overview: Clipping for windows using new grid layout. > > > > Extracts parts of the regular grid layout function into a helper, which > > is then used by the new grid layout function. > > > > Test: manual > > Bug: 1011973 > > Change-Id: I7bdf40227bbd1df467ea9d56bc84e58b01c12f33 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867271 > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#707460} > > TBR=xdai@chromium.org,sammiequon@chromium.org > > No-Try: true > Bug: 1011973 > Change-Id: I675fb57809d190ca9266d012885269dcea2401c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872012 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707787} TBR=xdai@chromium.org,sammiequon@chromium.org,eirage@chromium.org Change-Id: I30fda5ce6ec77e08cd6d1978fefa74a4c65dc850 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872567Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#707886}
-
Vladislav Kaznacheev authored
Tests in OverviewWindowDragControllerDesksPortraitTabletTest used to return early if kShelfHotseat feature is enabled by default. This CL makes this test suite parametrized and runs is with kShelfHotseat enabled and disabled. Enabled branch still returns early, but disabled runs normally. Bug: 1011128 Test: OverviewWindowDragControllerDesksPortraitTabletTest Change-Id: Ic705435207bb26c8dd98f8debad0960ec25c339c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871733Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#707885}
-
Nicolás Peña Moreno authored
After the removal of the LongTaskV2 flag, SubTaskAtrribution is never used. This CL removes the class and related code. Bug: 738493 Change-Id: I2ecb5146bc6375daa6d131ed700fc0b257282186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869013 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#707884}
-
Ella Ge authored
Test flaky on Mac and Linux debug bot TBR=masonfreed@chromium.org No-Try: true Bug: 1016457 Change-Id: I7a09aade8fedcc3dd21ab06a2d1af379706e6d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871637Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707883}
-
Evan Stade authored
This reverts commit f72a8099. Reason for revert: in-flight conflict with 734ea5e7 Original change's description: > WebLayer: add tests for DownloadDelegate > > Credit to sky@ for EventUtils.java (salvaged from > 47bd294d, which got reverted) > > Bug: none > Change-Id: Iadb75c6b9c77185536c753504b6cefa1ba4796de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866987 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707864} TBR=sky@chromium.org,estade@chromium.org Change-Id: I5d2d6604fb0e2e633ac65109d23da7eb2826e6a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872746Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#707882}
-
Ian Barkley-Yeung authored
We're responsible for the feedback component, so we should own it. R=jkardatzke@chromium.org Bug: None Change-Id: I37bd77b513032927976a2b58cfd753b5428ad81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868843 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707881}
-
Nicolás Peña Moreno authored
virtual/layout_ng_experimental/fast/multicol/span/abspos-containing-block-outside-spanner.html can timeout, as shown at https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/400058 Bug: 591099 Change-Id: Ib76017bdf7cb0c0157c2b03907a1849bf4e80197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872153Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707880}
-
Ella Ge authored
Add a new prediction evaluation system to compare a predicted point to a real point that occurred at the same timestamp. The new class PredictionMetricsHandler buffers last predicted and real events received to associate at each predicted point an interpolated real event. The CL introduces 5 new metrics to compare a predicted point to a real point : OverPredictionMetric, UnderPredictionMetric, WrongDirectionMetric, PredictionJitterMetric and VisualJitterMetric. Here is a link to the corresponding design doc: https://docs.google.com/document/d/172-3YZUIRK5OdUilDiUzc06tUObQa3EoMRniaV_queE/edit?usp=sharing The OverPredictionMetric measures the overshoot distance in pixels between a predicted scroll position and the corresponding interpolated real scroll position that occurred at the prediction time. The UnderPredictionMetric measures the undershoot distance in pixels between a predicted scroll position and the corresponding interpolated real scroll position that occurred at the prediction time. The WrongDirectionMetric measures whether the prediction is in the same direction as the real trajectory at the same prediction time. The PredictionJitterMetric measures the Euclidean distance in pixels between two successive variations of scroll deltas which are the difference between a predicted scroll position and its corresponding interpolated real position that occurred at prediction time. The VisualJitterMetric measures the Euclidean distance in pixels between two successive variations of scroll deltas which are the difference between a predicted scroll position and the interpolated real position that occurred at frame time. Bug: 996353 Change-Id: Ia3676bcbf4308b64ccc83bb6b77097c3876b337a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764409Reviewed-by:
-
Xiang Ji authored
Change-Id: Idd3ac9f20e100368603e5d890d5726410e0c4121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869969Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#707878}
-
Ilia Samsonov authored
Moving this logic to TestEventListener will avoid executing overriding SetUp and TearDown methods. Change-Id: I98f625dc86280c2f2f590a0cac55d46e46a4fa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804070 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#707877}
-
Sammie Quon authored
This is a reland of fac39a19 Original change's description: > overview: Fixed aspect ratio for overview items in splitview. > > Overview items now match the aspect ratio of the window bounds if they > get snapped. This will happen if splitview is active on either side, or > if the window is getting dragged close enough to an edge. A videos of > before and after this patch is in the bug. > > Follow up: > Make this work for tablet mode with 6 or more windows. In that case > the positioning logic follows a different path. > Match the exact dimensions in the spec, this patch only does rough > clipping. > > Test: added tests, manual > Bug: 1011973 > Change-Id: I3d9d341c54b58d0e86440045ad1408ca3a0fd27d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849175 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707426} Bug: 1011973 Change-Id: I6ff9ce5c4ecebf2a2006abd26821c5c12b82e5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872453Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#707876}
-
Philip Rogers authored
The heads up display (hud) layer is used to show layer overlay information such as the fps meter and repaint rects. This layer should be excluded from the 3d layers view. This code has not been implemented behind IsInspectorLayer because the hud layer is used for more than just the inspector, such as when --show-paint-rects is used. This has been tested manually by ensuring no extra layer is present. Bug: 1015918 Change-Id: I044ad1c7dc61385bdeb0fae916c7515dbd8aee4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869820Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#707875}
-
Miyoung Shin authored
This CL converts Camera3CallbackOps{Ptr, Request} in media to the new Mojo type, and uses pending_remote<Camera3CallbackOps> in camera3.mojom. Bug: 955171 Change-Id: I2653e925a82b1c3c17d8676f3d0c13e1418676b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862442 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707874}
-
Matt Menke authored
HTTP auth credentials will need to be separated by NetworkIsolationKey, as otherwise they can be used much like a cross-site cookie. Also rename the method to LookupServerBasicAuthCredentials, as it no longer returns auth credentials for proxies (That change was in an earlier CL). The one consumer of this API (MediaResourceGetterImpl) still needs to be updated to get the right NetworkIsolationKey. Figuring out how to do this may take some work, so this is not done in this CL, though it will need to be resolved before we can enable separating the auth cache by NetworkIsolationKey, at least on Android. Bug: 993806 Change-Id: Ifc3eec8a4cdd2f38112116c0dc9d7e7c5c296566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865406 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#707873}
-
Martin Robinson authored
Orca would like to use this text attribute to detect when text is expressed with a superscript or subscript. This matches the behavior of Firefox's ATK support. Bug: 1014198 Change-Id: I034437426252ca54774e0cef2aca8442eb72f3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862439 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#707872}
-
Eric Willigers authored
Command id IDC_LOAD_NEW_TAB_PAGE is no longer used. Change-Id: Ia6746b248845863ff3f2f3bf57b60aafc10fbcec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868567 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
