- 22 Aug, 2019 2 commits
-
-
Julie Jeongeun Kim authored
This CL is a part of converting Mojo types to new Mojo types. It cleans up ShareServiceRequest and uses PendingReceiver<mojom::blink::ShareService>. Bug: 978694 Change-Id: I79ee3ac57cb60cda4390c01d44c3d54bd43dcb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760845Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#689259}
-
Joel Hockey authored
These don't need to be crashes in prod Bug: 996263 Change-Id: I266c7986cba170f638d7d382f1ca5bfb71c3f883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763554 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689258}
-
- 21 Aug, 2019 38 commits
-
-
Gayane Petrosyan authored
Add warning comment to prevent use of problematic types in seralized theme data. Bug: 988055 Change-Id: I1c7658d5818a6f71c0218f4c17a1adbcda0d3279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764327 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689257}
-
Ayu Ishii authored
This change adds SMSReceiverOutcome to UKM to help us better understand how URLs are using this feature and its impact. It will also help us identify URLs that have particularly low success rates so we can evaluate how we can improve the feature. UKM Collection Review Document [Google Only]: https://docs.google.com/document/d/1EmUzkzy4bB0h6T4QT-KTsygV_AQWv2Vb5rJE38QAYA0/edit?usp=sharing Bug: 976332 Change-Id: Ib4a1c13b7a1afc00cc1232ced3e76ffe42b07a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736139Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#689256}
-
Daksh Idnani authored
Bug: 985486, 984780, angleproject:3701 Change-Id: Ie513cb2d8b79a52c54581c2c86748cd74ce7c7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764183Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689255}
-
Thomas Tangl authored
Histogram name: Profile.Menu.ClickedActionableItem - The new histogram will replace the user actions recorded for some of the buttons(bug link added in the comments). - Using a histogram makes it easier to analyse the use of the profile menu. Bug: 966388 Change-Id: I790cc89334c05d91a90f96b153236ff8c1735df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762234 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#689254}
-
Mason Freed authored
On non-flipped framebuffer devices (e.g. Mac in some cases), the mask image was previously being wrapped into an SkImage with the incorrect value for flip_texture. This is now correct, which fixes a bug with masking of backdrop-filter. I also improved the backdrop-with-mask WPT test to catch this problem. Bug: 974857 Change-Id: I5c7cdedac29dfe1a9d9c214169fde718799649fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761557 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689253}
-
Andrey Kosyakov authored
This reverts the order of visiting of layout objects for pseudo-element children to the one we've had before https://chromium-review.googlesource.com/c/chromium/src/+/1757208 to prevent regressions in the protocol clients. Change-Id: Ia652c04708eeef7372f466dfddd997aa688e0528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764355 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#689252}
-
Joel Hockey authored
Moved pwa.html to be at /html/pwa.html to suit libapps normal directory layout. See crrev.com/c/1757753. Tbr: calamity@chromium.org Bug: 846546 Change-Id: Ia996e671fa1afc2c891e1a4d7136458f9382ce48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763511 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#689251}
-
Adrienne Walker authored
This is a DCHECK + workaround for issue 988590. https://chromium-review.googlesource.com/c/chromium/src/+/1749703 solves root of the problem, and will avoid this DCHECK for this particular content. Bug: 988590 Change-Id: I0e66ba388c11bbc3805ead42343d7fe7af7a79da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752873 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689250}
-
Glen Robertson authored
install_manager_bookmark_app_browsertest.cc was actually testing PWA install bubble behaviour, which is already tested in hosted_app_browsertest.cc and pwa_install_view_browsertest.cc. Tests for launcher behaviour were moved to a better home in chrome_launcher_controller_browsertest.cc This was resolved in prep for https://chromium-review.googlesource.com/c/chromium/src/+/1746116 Change-Id: I03a7dfcead67c0174241b8cbd4192035b71be15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760843Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#689249}
-
Allen Bauer authored
Previous behavior would always select the parent node when a child was deleted. Unless the node was a child of the root node and the root wasn't visible, then select the first child of the root node. Now the behavior will select the child node after the deleted node(s). If the deleted node was the last node and more children remain, then select the new last node. If there are no remaining children, then select the parent node. Scenario 1 - Simple delete of child node root +--child1 +--child1 +--|child2| <--- Delete this node. +--child3 Result: root +--child1 +--child1 +--|child3| Scenario 2 - Delete of a immediate child of the non-visible root. >Child1 >Child2 >|Child3| <--- Delete this node. >Child4 Result: >Child1 >Child2 >|Child4| Scenario 3 - Delete of last child node (other children remain). root +--child1 +--child1 +--child2 +--|child3| <--- Delete this node. Result: root +--child1 +--child1 +--|child2| Scenario 4 - Delete of last child node (no children remain). root +--child1 +--|child1| <--- Delete this node. Result: root +--|child1| Bug: 991304 Change-Id: I26bf90fd89b3d0d946bf73b7c1047621ca35308a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761299 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689248}
-
Luum Habtemariam authored
Didn't realize this test suite became dependent on cups at some point; this change enforces this. Bug: chromium:945409, chromium:988567 Test: unittests built successfully Change-Id: I109fb2c667daf6cf7178c4cd1e67ef8f4c40658d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764633Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#689247}
-
Oystein Eftevaag authored
If the startup tracing rule is added to a preemptive config, then tracing just gets immediately started (due to the mode) and then stopped (due to startup tracing sending a trigger). We only want startup tracing to be activated when tracing isn't automatically started. R=ssid@chromium.org Bug: 983307 Change-Id: I36a5c10aa9a1c6b16a330dd96677e71af16e146c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762600 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#689246}
-
Akihiro Ota authored
This change does three things: 1. Add a feature flag for ChromeVox sub-node language switching. 2. Check for this flag inside ChromeVox LanguageSwitching to determine the language switching behavior (either node-level or sub-node switching). 3. Adds tests to cover both behaviors. Bug: 923068 Change-Id: I8b8b3cbef6d4bd3d8229f616c481b9009d911f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750108Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#689245}
-
Rahul Arakeri authored
Clicking on a scrollbar arrow when the scroller has reached max offset currently chains the input to it's parent scroller. The fix here is to avoid scroll chaining if did_lock_scrolling_layer_ is true. Note that this fix is only for non-animated scrolling (i.e "smooth scrolling" disabled). Bug: 965829 Change-Id: I5c9fe09c6687d8a2216c19d18e63c673d0c27be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652303 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689244}
-
Takuto Ikuta authored
Bug: 996219 Change-Id: I3530e49059e5547a7571a47a94971b24308ac834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763512Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689243}
-
Erik Chen authored
This CL is a refactor that moves construction of RenderWidget to RenderFrameImpl for local main frame construction. This has the slight behavior change of affecting the timing at which various objects can constructed and initialized. This CL is in preparation for moving ownership of RenderWidget to RenderFrame. Change-Id: I4c80f4c762e622cc3412978d4943e8e8ba9637e7 Bug: 995981, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764254Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689242}
-
Vikas Soni authored
CodecSurfaceBundle now owns CodecBufferWaitCoordinator instead of TextureOwner. This is because when switching codecs, we re-use same TextureOwner to create a new CodecBufferWaitCorrdinator in VideoFrameFactoryImpl which was an issue. This could lead to multiple CodecBufferWaitCoordinator to be in flight at once. Hence instead of creating CodecBufferWaitCoordinator every time we switch codecs, we just use the one which CodecSurfaceBundle has. Bug: 996382 Change-Id: I614a2dbb54203f397dbbb9c1d6fa772e4b0146d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764412 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#689241}
-
Shivani Sharma authored
This is a reland of 6199b09d with a fix for the crash in crbug.com/993543 Original change's description: > Httpcache transaction's mode to be set to WRITE before creating entry > > https://bugs.chromium.org/p/chromium/issues/detail?id=986211#c49 describes the > code path that may lead to mode_ being set to NONE(do not use entry) and state > being set to STATE_CREATE_ENTRY. > > While the intention of DoRestartPartialRequest() is to set the mode to WRITE before > setting the state to STATE_CREATE_ENTRY, ResetPartialState() ends up overwriting the > mode_ to NONE via HttpCache::Writers::EraseTransaction. Both are doing the correct > thing independently so changing the order of mode_ = WRITE and calling > ResetPartialState() should fix the issue. > > This leads to another dcheck to be hit which is that RecordHistograms should only > be invoked once. To fix that this CL also moves the calling site of RecordHistograms() > to the destructor of HttpCache::Transaction which makes the invariant that RecordHistograms > should only be called once, easier to follow in the code. > > TEST: net_unittests --gtest_filter=*RangeGET_OverlappingRangesCouldntConditionalize > Bug: 986211 > Change-Id: I176b6187dc69aa23de73d45263da104da622e0bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739410 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Commit-Queue: Shivani Sharma <shivanisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685901} Bug: 993543 Change-Id: I186e7dec8c0eeca5d42cf0e5217d3afc9e12d33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757367 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#689240}
-
Tommy Nyquist authored
The inline update flow experiment for Android has taken longer than planned to roll out, so this is still happening. Until we have launched this feature, we should keep the flag around for ease of testing and debugging. BUG=900770 Change-Id: I63ca7f53d6efd5edfce23b61c3ec3f40043c202a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763134 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#689239}
-
Reilly Grant authored
This change fixes a CHECK in MessagePumpLibevent that is triggered by the SerialIoHandlerPosix closing its file descriptor while there is a FileDescriptorWatcher::Controller still active. When SerialPortImpl later attempts to cancel pending read operations these controllers are removed but now reference an invalid file descriptor, triggering the CHECK. Bug: 996033 Change-Id: If6fee86239fab91c248712a564b12e32b3f61294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762839 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#689238}
-
Francois Doray authored
An experiment conducted in July 2019 revealed that on Android, changing the reclaim time from 30 seconds to 5 minutes: - Reduces jank by 5% at 99th percentile - Reduces first input delay by 5% at 99th percentile - Reduces input delay by 3% at 50th percentile - Reduces navigation to first contentful paint by 2-3% at 25-95th percentiles On Windows and Mac, we instead see no impact or small regressions. More results at https://groups.google.com/a/google.com/d/msg/chrome-scheduler/zhu6q8fvjno/-ugY1FU2AQAJ. Bug: 945681 Change-Id: Ifa35e38be87d72633639bc6a06d80b87e84c580b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749882 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#689237}
-
Alexandre Courbot authored
New V4L2 stateless video decoders depend on the request API in order to submit jobs to the decoder. Requests are created from the media device associated to a V4L2 decoder, so said devices need to be accessible by the GPU process. Whitelist /dev/media-dec* devices so that requests can be created and stateless decoders used. Bug:917279 Bug:b:123551776 Test: video decoding working on Kukui. Change-Id: Ib98d890fb663399d610c0e99b1e4e96a6405c600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763272 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689236}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0dd1307fc04f..a1b7d649aa4c git log 0dd1307fc04f..a1b7d649aa4c --date=short --no-merges --format='%ad %ae %s' 2019-08-21 dberris@chromium.org PinpointScheduler: Cap timing samples to 50 2019-08-21 dberris@chromium.org PinpointScheduler: Use task_slices better 2019-08-21 dberris@chromium.org PinpointScheduler: Backwards compatibility for run_test Created with: gclient setdep -r src/third_party/catapult@a1b7d649aa4c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:977488,chromium:988912,chromium:988912,chromium:996300 Change-Id: I1403fb6addfaf633aa88908dd71ad3f57a1e58e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764247Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689235}
-
Yann Dago authored
Bug: 994227 Change-Id: Ibdcc254da4834e0ccaa4804a55e864ec940c5380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757365 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689234}
-
Peter Kasting authored
The only meaningful change here is time_view.cc, which was unconditionally doing (potentially unnecessary) relayout. Bug: 942298 Change-Id: Ia27826644e8e50a8690ece66d330bd30ba513aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762837Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689233}
-
David Grogan authored
A row flex box's cross size of {fit,min,max}-content isn't definite, which affects the inline size of orthogonal children. Bug: 845235 Change-Id: Id08a1cf6d23e9e295e87c52d426079bc7e886b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758992Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689232}
-
Bo Liu authored
eglCreateSyncKHR related errors are the #1 gpu-related crash on android webview. This CL does two things: * Check the EGLDisplay is not null before calling eglCreateSyncKHR * Create a glFinish fence and use it as fallback if eglCreateSyncKHR fails for any reason. Bug: 995376 Change-Id: I1916f253d6d7ac06eaf0750ac0c431fc4c081894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759148Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689231}
-
Navid Zolghadr authored
Add UMA metric to count how often click target is changed due to interactive element being in the ancestor path of the click target calculation. Change-Id: I2a6c9e5bc33fcaaa131a88e98e5db1ae1afec120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752168Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689230}
-
Evan Stade authored
This reverts commit 3171eca4. Reason for revert: caused https://crbug.com/996116 Original change's description: > Remove some NotificationService notifications from ProfileManager. > > ProfileManager doesn't need its own boolean tracking whether all > browsers are being shut down as it can just check > browser_shutdown::IsTryingToQuit(). Thus it doesn't need to listen > to NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST and > NOTIFICATION_BROWSER_CLOSE_CANCELLED. It also doesn't need to save > the active profiles when those notifications are sent out because > saving the profiles when a browser is opened or closed should be > sufficient. > > Bug: 268984 > Change-Id: I2a81be1c1f04440ee4e8fc05375742d52cac9169 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730191 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686163} TBR=avi@chromium.org,pastarmovj@chromium.org,skuhne@chromium.org,estade@chromium.org Bug: 268984 Change-Id: I47c3051e4ecac15fb0b403988ed7a363cb9dada0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764548Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689229}
-
Julie Jeongeun Kim authored
This CL converts WebSocketConnectorPtr and WebSocketConnectorRequest to new Mojo types. It updates methods and members for WebSocketConnector to new Mojo types. It still keeps CreateWebSocketConnector methods to use service_manager::BinderRegistry with TODO. Bug: 955171, 978694 Change-Id: Ia7553f1819f90383a92a0fb4fe6c68918a233c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761898Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#689228}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f25a1c68473b..23742c0958dd git log f25a1c68473b..23742c0958dd --date=short --no-merges --format='%ad %ae %s' 2019-08-21 chrisforbes@google.com Fix linux build with gcc-8.2 2019-08-21 geofflang@chromium.org Support RGB formats with IOSurface client buffer surfaces. Created with: gclient setdep -r src/third_party/swiftshader@23742c0958dd The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:995142 Change-Id: Ib5daec1d5ce25cd035e8abbb8863a7ea7acd2bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689227}
-
Joe Mason authored
This is a reland of e5f1b06d It was reverted in https://crrev.com/c/1760644 for causing test failures on CI builders that couldn't be reproduced on other machines. This patch disables the failing tests. A followup will reenable the tests with extra debugging to diagnose the failures on the CI builders. Then it was relanded and reverted again in https://crrev.com/c/1764124 because it raced on the CQ with an API change to CreateSequencedTaskRunner. TBR=wfh TBR_REASON=Reland of test-only proto change that was already reviewed. Original change's description: > Implement ProtoChromePromptIPC. > > Bug: 969139 > Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@google.com> > Cr-Commit-Position: refs/heads/master@{#688357} Bug: 969139 Change-Id: I989a66205db61caefd7777d0046226e3244dc4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764471Reviewed-by:
Joe Mason <joenotcharles@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#689226}
-
Jinsuk Kim authored
This CL logs UMA histogram for various user actions performed for gesture navigation as proposed in the PRD: - GestureNavigation.Abandoned - GestureNavigation.Completed - GestureNavigation.Reversed - GestureNavigation.Sheet.Peeked - GestureNavigation.Sheet.Selected - GestureNavigation.Sheet.Viewed - GestureNavigation.Sheet.Used - GestureNavigation.Triggered Before this, partial actions were logged (Overscroll.Navigated3/Cancelled3) which were from an old desktop experiment to recycle the histogram. This is not really necessary, and prone to a problem if there's any change in the one it depends on. This CL defines a new set of UMA histogram entries above to make it independent. This will work in conjunction with cl/264091291. Also fixed some bugs/polished code in the navigation feature while testing the histogram: - Navigation sheet should be fully expanded when user lifts his finger while the sheet is in peeked state. The arrow puck then should fade away at that position. For this, NavigationSheet.isPeeked() is required for SideSlideLayout to decide which animation to start and what to log. NavigationSheet provides isPeeked() instead of isExpanded(). - NavigationSheetCoordinator.hide/setVisible(false) always go in pair. This CL moves the latter inside the former method. - NavigationHandler.onTouchEvent was not calling NavigationSheet.release, which caused a bug for native pages. Added it. Bug: 937946 Change-Id: I7a2075fc5952c4a691ef8ec9ad5b7943b790a8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758042Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#689225}
-
Navid Zolghadr authored
Bug: 984222 Change-Id: I3e032bd55c6b024ccad4ea42f5d743106f021bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761775Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689224}
-
Sharon Yang authored
The Fuchsia SemanticsManager uses a ViewRef to identify a View in registration. This change allows a ViewRef to be associated with a View created by the WebEngine. Bug: 990432 Change-Id: Ib7554deb9054aeeabb1322008e6c7566807d6faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742988Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#689223}
-
Evan Stade authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3490 TBR=caseq@chromium.org Bug: 847114 Change-Id: I2ebf3486557e74d94e0eb7f0fd2e73ab10f84ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764671Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689222}
-
Chris Cunningham authored
Bug: 992235 Change-Id: Ic17fb19707e8c3e20763ecb974a729d52ba2428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761330Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#689221}
-
tby authored
We don't have a pure frequency predictor on the chrome side yet, which we'd like to use for part of the upcoming files ranking model. Bug: 921444 Change-Id: I43f6d2ed86845878fe50142a790cfd19caa83c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761894Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#689220}
-