GitLab

This is prep for tooltip improvement: https://codereview.chromium.org/924433002/ (WIP)

* Consolidated GetMaxWidth
* Eliminate screen type argument. This can be obtained from tooltip window.
* Move tooltip truncate code from TooltipManager to TooltipController

BUG=None
TEST=no functional change. all test should pass.

Review URL: https://codereview.chromium.org/916423002

Cr-Commit-Position: refs/heads/master@{#317081}

The BMM PNaCl toolchain doesn't currently support waitid.  Arguably it
should because it's in POSIX, but the userland/Linux signal ABI
mismatch makes it non-trivial because of the siginfo_t.  Since we
don't need the siginfo_t anyway, we can just use waitpid instead.

While here, use WIFEXITED and WEXITSTATUS for interpreting status
instead of directly comparing it to the expected exit code.

Review URL: https://codereview.chromium.org/928963003

Cr-Commit-Position: refs/heads/master@{#317080}

* Fix null pointer access when a shortcut is added via
  a manifest.  It was relying on the WebContents() being
  accessible immediately after stopping the observation of
  the WebContents.

* When adding a shortcut on the homescreen through web app
  banners, stop firing Intents to send the user to the
  home. Instead show a toast to indicate that a shortcut is
  being added to their homescreen.  The string was chosen by UI
  and is described on the bug.

* Hopefully fix the ShortcutHelperTests.

BUG=457424,303486
TEST=ShortcutHelperTest

Review URL: https://codereview.chromium.org/934183002

Cr-Commit-Position: refs/heads/master@{#317079}

I've replaced measuring GetProfile() (which includes cached profiles) with SetupProfile() which is more useful to track. I've added metrics to track the expensive components under SetupProfile(), which are
-chrome::RegisterProfilePrefs
-chrome_prefs::CreateProfilePrefs
-ProfileImpl::OnPrefsLoaded.

There currently are UMA histograms called Startup.SlowStartupPreferenceLoading, but I'm setting up different versions of these. They are tracking almost but not exactly the same things, but the current ones are only triggered for slow startups.
I considered modifying these to add a control version, but I thought adding new ones was better because:
-The histograms I'm adding have better names since they are called what they are actually checking
-I'm measuring at what I think is a better place (inside the method itself instead of near the caller.
-The new histograms are easily comparable for the work I'm doing since they are for all data (can just check percentile data).

Also changed the TRACE argument from path.value().c_str() to path.MaybeAsASCII() since the former was only giving the address inside the trace (I'm guessing it never worked).

If someone wants to have themselves also be added as an owner to any of the new histograms let me know.

BUG=454789

Review URL: https://codereview.chromium.org/937713003

Cr-Commit-Position: refs/heads/master@{#317078}

We add tests that verify that VisualStateCallbacks are
delivered correctly during fullscreen transitions.

BUG=459044

Review URL: https://codereview.chromium.org/941713002

Cr-Commit-Position: refs/heads/master@{#317077}

1) Report total errors while reporting import task statistics.
2) Report addView when volume changes.
3) Send hit when history file changes.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/933553003

Cr-Commit-Position: refs/heads/master@{#317076}

This CL adds a regression test for CL 897113003, ensuring that
consumers are notified that the device-global invalidation service
is no longer to be used before it gets destroyed.

BUG=455504
TEST=New unit test

Review URL: https://codereview.chromium.org/941633002

Cr-Commit-Position: refs/heads/master@{#317075}

This behavior is introduced by a772ed62.
It makes ExternalPrefLoader not being ready when user sign in to Chromebook for
the first time and accidentally blocks all installation of external extensions
if Chrome Sync is turned off, including force installed extensions by policy.

BUG=457539
TEST=manual

Review URL: https://codereview.chromium.org/931663007

Cr-Commit-Position: refs/heads/master@{#317074}

BUG=none

Review URL: https://codereview.chromium.org/933413002

Cr-Commit-Position: refs/heads/master@{#317073}

Previously, in RenderWidgetHostViewAura, upon receipt of a touch ack,
we would convert the WebTouchEvent associated with the ack into
ui::TouchEvents.

With the eager GR, this is no longer necessary.

BUG=407645
TEST=GestureRecognizerTest.*

Review URL: https://codereview.chromium.org/503883004

Cr-Commit-Position: refs/heads/master@{#317072}

It was using a single global worker thread pool in a non-threadsafe
manner.

This imposed the restriction that all instances of SimpleCache must be
initialized on a single thread, or weird things may, in very rare and
unlikely cases, occur.

BUG=442321

Review URL: https://codereview.chromium.org/851013003

Cr-Commit-Position: refs/heads/master@{#317071}

Revert of Handle RenderProcessHostImpl::SetBackgrounded on Windows (patchset #4 id:60001 of https://codereview.chromium.org/926663002/)

Reason for revert:
This patch set re-enabled ChromeRenderProcessHostTest.Backgrounding, which is now failing on XP bots.

Example logs:
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/35740/steps/browser_tests%20on%20Windows-XP-SP3/logs/ChromeRenderProcessHostTest.Backgrounding
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/35740/steps/browser_tests%20on%20Windows-XP-SP3/logs/ChromeRenderProcessHostTest.Backgrounding

Original issue's description:
> Handle RenderProcessHostImpl::SetBackgrounded on Windows
>
> This was disabled on Windows because:
>
>  - http://crrev.com/274071 made it such that it was asynchronous via the renderer (as only
> the process itself can set itself in background mode on Windows).
>
>  - And then this was removed for Windows as part of issue 381820 as true background mode on
> Windows was achieved by having the renderer itself change its process priority (which
> doesn't work as the unbackgrounding request can be stuck behind other priority tasks
> running in background mode).
>
> Also, the test for this was disabled in between (see issue 394368) -- the asynchronicity
> introduced in r274071 probably causing the flakes.
>
> Overall there is no need to have the renderer enter PROCESS_MODE_BACKGROUND_BEGIN itself,
> IDLE_PRIORITY_CLASS should be sufficient as its the same as far as CPU priority is
> concerned and IO is irrelevant in the renderers.
>
> Thus we can get background mode for hidden renderers without running into issue 381820.
>
> Experiment with IDLE_PRIORITY_CLASS/BELOW_NORMAL_PRIORITY_CLASS vs the status quo.
>
> Watching the relevant perf bots (tab_switching.top_10 -> MPArch.RWH_TabSwitchPaintDuration)
> and UMA metrics MPArch.RWH_TabSwitchPaintDuration which shouldn't regress.
> And others (e.g., SessionRestore related) which will hopefully improve.
>
> Enable the experiment by default in the absence of Finch to get perf waterfall coverage.
>
> The experiment will be called "BackgroundRendererProcesses" and have 4 groups:
>  ["Disallow", "AllowBelowNormalFromBrowser",
>   "AllowIdleFromBrowser", "AllowBackgroundModeFromRenderer"]
>
> It will be a per-session (rather than per-profile) experiment, randomly assigning a user
> to a group every new Chrome session.
>
> BUG=394368, 458594
>
> Committed: https://crrev.com/aaf738a2cce69ce952386b48e3bc252bd307ef43
> Cr-Commit-Position: refs/heads/master@{#317042}

TBR=wfh@chromium.org,jam@chromium.org,gab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=394368, 458594

Review URL: https://codereview.chromium.org/940993002

Cr-Commit-Position: refs/heads/master@{#317070}

BUG=459672

Review URL: https://codereview.chromium.org/930373006

Cr-Commit-Position: refs/heads/master@{#317069}

This CL uses @NativeClassQualifiedName in CronetUrlRequestContext.java to reduce
JNI code. After the refactoring, cronet_url_request_context.cc is merged
with cronet_url_request_context_adapter.cc, since the former mostly contains
JNI code that will be generated by @NativeClassQualifiedName.

BUG=458276

Review URL: https://codereview.chromium.org/922283002

Cr-Commit-Position: refs/heads/master@{#317068}

This CL performs a DEPS roll of cros_system_api package.

BUG=459609

Review URL: https://codereview.chromium.org/939173002

Cr-Commit-Position: refs/heads/master@{#317067}

Expose the preference for WebRTC's routing to extensions' privacy API. Disabling this preference prevents local IPs to be leaked when using WebRTC.

BUG=457629

Review URL: https://codereview.chromium.org/940893003

Cr-Commit-Position: refs/heads/master@{#317066}

This pulls in the following Native Client changes:

044b4c0: (mazda@chromium.org) Implement irt_clear_cache for ARM Non-SFI mode.
ebe73dc: (shinyak@chromium.org) Emit deferred log even when Error is raised.
cd4c4d8: (tfarina@chromium.org) Rename source_prereqs to inputs in the rules.gni file.
4eb5734: (dschuff@chromium.org) Update newlib revision in tools/REVISIONS to 2cc581b
2c9f793: (mseaborn@chromium.org) Cleanup: Move nacl_desc_custom.h into src/public/

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/938823003

Cr-Commit-Position: refs/heads/master@{#317065}

BUG=152454
TEST=none

Review URL: https://codereview.chromium.org/925383003

Cr-Commit-Position: refs/heads/master@{#317064}

BUG=439239
TEST=manual

Review URL: https://codereview.chromium.org/938043002

Cr-Commit-Position: refs/heads/master@{#317063}

We were calling Android GCM's unregister API, which clears all of an app's subscriptions (all sender ids and subtypes). Since from Android's point of view, the app is Chrome, if any webapp unsubscribed from push messaging, all webapps would be unsubscribed!

Instead now we call the unsubscribe API, which only unsubscribes a specific (sender_id,subtype) pair (where the subtype corresponds to GCMDriver's app_id). So now if a Service Worker calls pushSubscription.unsubscribe(), it'll only unsubscribe that SW's push subscription.

In order for this to work, we now also call the corresponding subscribe API (accepting a single sender_id) instead of register.

GoogleCloudMessagingV2.java is still temporary code, that will be removed once we switch to the Google Play Services client library.

BUG=457374

Review URL: https://codereview.chromium.org/914693002

Cr-Commit-Position: refs/heads/master@{#317062}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f421ec6..297aaf9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/941703002

Cr-Commit-Position: refs/heads/master@{#317061}

This is the final patch for removing location and making
SkPicture const in drawing display items, and the first patch
in adding scroll display item support in cc.

R=ajuma@chromium.org
BUG=458240

Review URL: https://codereview.chromium.org/939463003

Cr-Commit-Position: refs/heads/master@{#317060}

The semantic of this function matches the usual semantic of if better
than or, since or usually returns the first of its arguments that is
true, while if evaluates a condition and returns a second or third
argument depending of the truth value of its first ditto.

R=dtseng@chromium.org
BUG=

Review URL: https://codereview.chromium.org/939153002

Cr-Commit-Position: refs/heads/master@{#317059}

Since MetricsServicesManager::IsMetricsReportingEnabled is correct, it is
called directly.

BUG=457430

Review URL: https://codereview.chromium.org/916133003

Cr-Commit-Position: refs/heads/master@{#317058}

BUG=412331

Review URL: https://codereview.chromium.org/938033002

Cr-Commit-Position: refs/heads/master@{#317057}

This should fix
BUG=459722

Please note I'm rolling this without waiting for the ASan/Win FYI bot to cycle
(takes ~4 hours) to reduce the time it takes the LKGR ASan builder to turn green
(assuming r229860 is most likely OK).  If it isn't OK, we'll need to roll once
again when we know the next stable LLVM revision.

TBR=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/911323004

Cr-Commit-Position: refs/heads/master@{#317056}

The component's goal is to provide omnibox suggestions based on the
clipboard's content.

BUG=None.

Review URL: https://codereview.chromium.org/930323003

Cr-Commit-Position: refs/heads/master@{#317055}

- remove unused consumer code wrapping base/ios/ios_util.h
- remove superfluous #include of base/ios/ios_util.h

BUG=429756
TBR=thakis

Review URL: https://codereview.chromium.org/940033003

Cr-Commit-Position: refs/heads/master@{#317054}

PlatformKeysService now supports persisting whether an extension is allowed to sign data with a key an unlimited number of times.

Currently, these permissions are only granted in the accompanying browser test and not in production, because UI is still missing.

BUG=450167

Review URL: https://codereview.chromium.org/905523002

Cr-Commit-Position: refs/heads/master@{#317053}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cd87c51..f421ec6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/943583002

Cr-Commit-Position: refs/heads/master@{#317052}

Also add HttpStreamParser unit tests for 0 byte final chunks.

BUG=405678

Review URL: https://codereview.chromium.org/921453003

Cr-Commit-Position: refs/heads/master@{#317051}

BUG=402344, 458695
TEST=manually

Review URL: https://codereview.chromium.org/940933002

Cr-Commit-Position: refs/heads/master@{#317050}

BUG=459695
TEST=manually tested

Review URL: https://codereview.chromium.org/939073002

Cr-Commit-Position: refs/heads/master@{#317049}

BUG=459647

Review URL: https://codereview.chromium.org/943613002

Cr-Commit-Position: refs/heads/master@{#317048}

Add a Preference to allow WebRTC only bind to "any address" (all 0s). This way, no local IP or private ISP's public IP leaked when VPN is the default route.

Add webrtc.multiple_routes_disabled preference to RendererPreferences. Default is false. When set to true, a new port allocator flag will be passed to P2PPortAllocator which will have WebRTC only bind to all 0s (any address) IP and the default route will be used as how chrome/http is routed.

Each rtc_peer_connection_handler is associated with a WebFrame and it leads to a webview and then the mapping RenderViewImpl which has RendererPreferences that we care.

The corresponding webrtc change is at https://webrtc-codereview.appspot.com/39129004

BUG=333752

Review URL: https://codereview.chromium.org/916873004

Cr-Commit-Position: refs/heads/master@{#317047}

When reloading a page whose url leads to an error page, a different
pathway is taken in NavigationControllerImpl. We must be careful to
check for unreachable urls in
NavigationControllerImpl::RendererDidNavigateToExistingPage() in this
case, and mark them as error pages.

BUG=458036

Review URL: https://codereview.chromium.org/917043004

Cr-Commit-Position: refs/heads/master@{#317046}

Everything seems to link now.

Tested with the following command lines:

$ gn gen out-gn
$ ninja -C out-gn/ jingle_unittests
$ out-gn/jingle_unittests

This fixes one more TODO(GYP).

BUG=None
TEST=see above
R=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/929433006

Cr-Commit-Position: refs/heads/master@{#317045}

BUG=459429
TBR=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/941683003

Cr-Commit-Position: refs/heads/master@{#317044}

Fix one misplaced header include and use PASSWORD_MANAGER_ENABLE_SYNC
macro to properly guard the other place of sync usage to fix a linking
issue when PASSWORD_MANAGER_ENABLE_SYNC is disabled.

Review URL: https://codereview.chromium.org/943533002

Cr-Commit-Position: refs/heads/master@{#317043}

This was disabled on Windows because:

 - http://crrev.com/274071 made it such that it was asynchronous via the renderer (as only
the process itself can set itself in background mode on Windows).

 - And then this was removed for Windows as part of issue 381820 as true background mode on
Windows was achieved by having the renderer itself change its process priority (which
doesn't work as the unbackgrounding request can be stuck behind other priority tasks
running in background mode).

Also, the test for this was disabled in between (see issue 394368) -- the asynchronicity
introduced in r274071 probably causing the flakes.

Overall there is no need to have the renderer enter PROCESS_MODE_BACKGROUND_BEGIN itself,
IDLE_PRIORITY_CLASS should be sufficient as its the same as far as CPU priority is
concerned and IO is irrelevant in the renderers.

Thus we can get background mode for hidden renderers without running into issue 381820.

Experiment with IDLE_PRIORITY_CLASS/BELOW_NORMAL_PRIORITY_CLASS vs the status quo.

Watching the relevant perf bots (tab_switching.top_10 -> MPArch.RWH_TabSwitchPaintDuration)
and UMA metrics MPArch.RWH_TabSwitchPaintDuration which shouldn't regress.
And others (e.g., SessionRestore related) which will hopefully improve.

Enable the experiment by default in the absence of Finch to get perf waterfall coverage.

The experiment will be called "BackgroundRendererProcesses" and have 4 groups:
 ["Disallow", "AllowBelowNormalFromBrowser",
  "AllowIdleFromBrowser", "AllowBackgroundModeFromRenderer"]

It will be a per-session (rather than per-profile) experiment, randomly assigning a user
to a group every new Chrome session.

BUG=394368, 458594

Review URL: https://codereview.chromium.org/926663002

Cr-Commit-Position: refs/heads/master@{#317042}