GitLab

The previous patch ahd this reversed.

BUG=174572
TBR=epenner,piman

Review URL: https://codereview.chromium.org/12256026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157270
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12220130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496
TBR=cpu
Review URL: https://codereview.chromium.org/12230011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174937
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/12263023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182350 0039d316-1c4b-4281-b951-d872f2087c98

this CL adds a glue interface so that AutofillDialogController can be more agnostic about where its data is coming from.

BUG=174937
TBR=thestig@chromium.org
committed

Review URL: https://codereview.chromium.org/12208070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182348 0039d316-1c4b-4281-b951-d872f2087c98

Relanding this as the original attempt caused a bunch of browser test and other failures because of an infinite
recursion crash. This occurred because the newly added helper function chrome::ShouldUseNativeFrame invoked the
ShouldUseNativeFrame function on the native widget passed in which as per this change calls back into the helper function
leading to an infinite recursion crash.

Fix is to only invoke the helper if the underlying native widget implementation of ShouldUseNativeFrame returns true.
This typically returns true if the aero theme is to be used on Windows.

To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
DesktopBrowserFrameAura::ShouldUseNativeFrame override.

The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function ShouldUseNativeFrame
in the chrome namespace in the newly added files browser_frame_common_win.h/.cc.
This is invoked from BrowserFrameWin and from the DesktopBrowserFrameAura overrides.

BUG=175372
R=sky
Review URL: https://codereview.chromium.org/12261017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182347 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12230015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182346 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/12041062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182345 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12262016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182344 0039d316-1c4b-4281-b951-d872f2087c98

Create a new type of disk_cache to be used by the GL Shader
cache. This cache acts similar to the regular DISK_CACHE
except the rank of the entry is not updated if the entry
is not modified. This means we can read entries as we
iterate and the iterators do not get shuffled around.

BUG=166763


Review URL: https://chromiumcodereview.appspot.com/12224017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182343 0039d316-1c4b-4281-b951-d872f2087c98

changed and sync setup handler needs to handle the new one.

BUG=175672


Review URL: https://chromiumcodereview.appspot.com/12221153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182342 0039d316-1c4b-4281-b951-d872f2087c98

When you connect to a tab's websocket, Chrome no longer reports a websocketDebuggerUrl. TabListBackend wasn't treating this case correctly, causing its tab list to have "None" tabs, which led to all sorts of fun corruption.

BUG=166243,174922
TEST=Unit test included. ./run_tests testMultipleTabs

Review URL: https://codereview.chromium.org/12260020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=171453
TEST=unit tests
TBR=jamescook

Review URL: https://codereview.chromium.org/12221155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182337 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-single-core/intl2/times: http://build.chromium.org/f/chromium/perf/xp-release-single-core/intl2/report.html?history=150&rev=178880

TBR=cmp@chromium.org
BUG=176148
Review URL: https://codereview.chromium.org/12230031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182336 0039d316-1c4b-4281-b951-d872f2087c98

> Enhance net internals/net log output for QUIC.
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12207020

TBR=rch@chromium.org
Review URL: https://codereview.chromium.org/12252024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182335 0039d316-1c4b-4281-b951-d872f2087c98

3*3*3 = 1B
There are exactly 27 staight lines on a smooth cubic surface.
273 = 19,683 and 1+9+6+8+3=27
27 is the number of bones in the human hand.
The atomic number of cobalt.
The atomic weight of aluminum.
The planet Uranus has 27 moons
Pythagoras and Plato say that the number 3 in the cubed (i.e. 27) and number 2 in the cubed (i.e., 8) represent the Cosmos.
27 signs of the zodiac in Indian astrology
According to Feng Shui, to raise money, keep in the house 27 identical coins.
The code for international direct-dial phone calls to South Africa
27 countries are in the European Union
The 27th U.S.A state - Florida
The designation (US 27) of a United States national highway from Fort Wayne, Indiana to Miami, Florida
Many talented and famous rock/blues musicians died at age 27. These include Robert Johnson, Brian Jones, Jimi Hendrix, Janis Joplin, Jim Morrison, Ron McKernan, Kurt Cobain, and Amy Winehouse. The musicians who died at this age are often referred to as the 27 Club.
The number of species Captain Jean-Luc Picard has made contact with in the series Star Trek: The Next Generation

Credit Wikipedia: http://en.wikipedia.org/wiki/27_(number)

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182333 0039d316-1c4b-4281-b951-d872f2087c98

Adding empty virtual destructor to CloudPrintURLFetcherFactory
to align it with Chromium coding style.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12230020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182332 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12207020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182331 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-single-core/intl2/times: 
http://build.chromium.org/f/chromium/perf/xp-release-single-core/intl2/report.html?history=150&rev=178582

TBR=cmp@chromium.org
BUG=176133
Review URL: https://codereview.chromium.org/12261024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182330 0039d316-1c4b-4281-b951-d872f2087c98

Apps cannot handle files via WebIntents declarations anymore.

BUG=173194


Review URL: https://chromiumcodereview.appspot.com/12218136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176122
TBR=kalman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/12256025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182328 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-single-core/intl1/times: http://build.chromium.org/f/chromium/perf/xp-release-single-core/intl1/report.html?history=150&rev=178582

TBR=cmp@chromium.org
BUG=176133
Review URL: https://codereview.chromium.org/12253016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182327 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182324 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of SpdyFramer::GetControlFrameStreamId(), which cleans up the code and also makes it easier to move forward with SPDY 4 work.

This lands server change 42008414.

Review URL: https://codereview.chromium.org/12207148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182323 0039d316-1c4b-4281-b951-d872f2087c98

Revert 182318 - Broke linux build: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Builder/builds/18695/steps/compile/logs/stdio
> ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons().
> 
> BUG=175897
> TEST=NONE
> 
> Review URL: https://chromiumcodereview.appspot.com/12208144

TBR=ncj674@motorola.com
Review URL: https://codereview.chromium.org/12207163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182322 0039d316-1c4b-4281-b951-d872f2087c98

1570: mac strip test: Update expectations for Xcode 4 toolchain.
1571: xcodebuild: Fix most rebuild tests on Xcode 4.
1572: xcode tests: Update exit codes for Xcode 4.
1573: Fix test/mac/gyptest-app.py with Xcode 4.2.
1574: xcode: Add support for storyboard files
1575: Detect all ninja's include dirs in Eclipse generator.

BUG=none
TBR=mark

Review URL: https://codereview.chromium.org/12261016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182321 0039d316-1c4b-4281-b951-d872f2087c98

On OS_CHROMEOS when the permission_broker checks a set of devices the
UsbService needs to wait for the async work to complete before responding.
This worked on OS_CHROMEOS desktop builds because the stub implementation of
PermissionBrokerClient wasn't racing to modify the devices vector.

BUG=chromium-os:38836

Review URL: https://chromiumcodereview.appspot.com/12226137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182320 0039d316-1c4b-4281-b951-d872f2087c98

Pyauto is deprecated. We'll add some of these tests back as browser
tests. Some don't make sense because they are very specific to Google
and not Chrome Instant generally (such as the case insensitivity test).

We're not losing much test coverage here because many of these tests
already exist as browser tests (e.g.: testing that Instant doesn't
preview URLs, testing a non-Instant supporting engine).

BUG=165843,168809
R=phajdan.jr@chromium.org
TEST=none

Review URL: https://chromiumcodereview.appspot.com/12223125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182319 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionInstallDialog should create the accept button if it requested in prompt.GetDialogButtons().

BUG=175897
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/12208144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182318 0039d316-1c4b-4281-b951-d872f2087c98

Browsers built prior to r176905 don't support the tracing mechanism used by telemetry.
Prevent the test from failing, since this is an expected scenario.

BUG=170284
TEST=tools/telemetry/run_tests --browser=android-content-shell testGotTrace -vv


Review URL: https://chromiumcodereview.appspot.com/11931015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182317 0039d316-1c4b-4281-b951-d872f2087c98

* Browser has new properties supports_extensions and extensions (of type ExtensionDict)
* BrowserBackend ctor takes additional arg supports_extensions. 
* BrowserBackend has new properties supports_extensions and extension_dict_backend (of type ExtensionDictBackend)
* BrowserBackend._WaitForBrowserToComeUp waits for all extensions to load and be interactive.
* BrowserBackend.ExtensionsNotSupportedException is raised for android browser and content shell.
* Add class ExtensionToLoad which is a wrapper for an extension_path.
* Add extension_to_load (of type ExtensionToLoad) to BrowserOptions.
* Add SupportsOptions to PossibleBrowser, to test extensions support. Returns False for android and content_shell when BrowserOptions.extensions_to_load is not empty 
* Add ExtensionPage which derives from WebContents
* Add ExtensionDictBackend which is a dictionary of ExtensionPage instances with extension ids as keys.
* Add ExtensionDict which passes through to ExtensionDictBackend, except it uses ExtensionToLoad instances as keys.
* Import crx_id for determining extension id from extension path.
* Simple extension manifest.json and background.js for unit tests.
* Unit tests for single and multiple extensions.

BUG=169954
TEST=browser test.
Review URL: https://codereview.chromium.org/11882033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182316 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175935
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12255014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=run_tests
Review URL: https://codereview.chromium.org/12253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/12217143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182312 0039d316-1c4b-4281-b951-d872f2087c98

it's failing flakily on the Chrome OS ASAN bots.

BUG=176082
TBR=satorux@chromium.org

Review URL: https://codereview.chromium.org/12257015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182311 0039d316-1c4b-4281-b951-d872f2087c98

Storing MPEG-4 B-frames in AVI has always been a bit of a hack and by default av_read_frame() will return non-timestamped video packets for such content. AVFMT_FLAG_GENPTS takes advantage of AVI's constant framerate to generate presentation timestamps at the expense of parsing delay.

BUG=169570

Review URL: https://codereview.chromium.org/12209111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182310 0039d316-1c4b-4281-b951-d872f2087c98

This has to be committed *after* https://codereview.chromium.org/12221127/

BUG=161094


Review URL: https://chromiumcodereview.appspot.com/12218109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182309 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174097
TEST=manually checked on goobuntu

Review URL: https://codereview.chromium.org/12248012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182307 0039d316-1c4b-4281-b951-d872f2087c98

This is split out from https://codereview.chromium.org/11881042

BUG=124830
TEST=None

Review URL: https://codereview.chromium.org/12087017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182305 0039d316-1c4b-4281-b951-d872f2087c98