- 07 Nov, 2018 40 commits
-
-
Eric Karl authored
Adds begin/end functions to the GL command buffer for shared image access. Currently, begin/end is a no-op in all SharedImageRepresentations, this will be fixed up in a follow up. This change just adds the commands and parameter validation in the validating and passthrough command decoders. Bug: 891059 Change-Id: Idb4bd900fa56bd470ad44ad955267e76860792cd Reviewed-on: https://chromium-review.googlesource.com/c/1313668 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606030}
-
Christian Dullweber authored
Lots of deletion code supports a nullable filter but we pass a proper filter even when there is an empty blacklist. To avoid checking the empty filter for every type of data we should just pass a nullable filter. Change-Id: I2a580e17f3b8e18a4a1181705907abea2617b6d3 Reviewed-on: https://chromium-review.googlesource.com/c/1322769 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#606029}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0fc9f7540077..add61bdaac69 Created with: gclient setdep -r src-internal@add61bdaac69 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62b8b88d50abc8f6365da5c2d10ce1081424e2e3 Reviewed-on: https://chromium-review.googlesource.com/c/1322930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606028}
-
Vasilii Sukhanov authored
The flag was used only in the tests and had a dedicated production code. Bug: 845458 Change-Id: I27265ad5a69eecb31663b5fb1526c696f1b35d3d Reviewed-on: https://chromium-review.googlesource.com/c/1322831Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606027}
-
Rayan Kanso authored
Few more minor changes that didn't make it in cr/1297412. Bug: 850512 Change-Id: I7a1070135aa4d10a238c8c12fd4a95ffeac34343 Reviewed-on: https://chromium-review.googlesource.com/c/1320130 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606026}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c8d3e17aba1..67f5c0ceac22 git log 5c8d3e17aba1..67f5c0ceac22 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6e8ec338eb25..825d344daa31 (1 commits) 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 77b2436e28f4..1bf18ce9e2ca (2 commits) 2018-11-07 caryclark@skia.org fix paint docs 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-07 mtklein@google.com remove SkScalarFastInvert Created with: gclient setdep -r src/third_party/skia@67f5c0ceac22 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I97247d038e1401a8fcf85457942ae47c77755515 Reviewed-on: https://chromium-review.googlesource.com/c/1322314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606025}
-
Sam McNally authored
For the first DriveFS, mount, mount_start_ is retained across mount attempts to record the total time taken to launch. When the DriveFS mount fails while offline, retries are delayed until online again. If a retry for the first launch is delayed in this fashion, the original start time is retained, causing spurious long first mount time metrics to be reported. Avoid this by clearing mount_start_ when delaying retries due to being offline. Clear it when disabling drive too. Bug: 892524 Change-Id: I47db55ca5b17965267ef813e2e70b7f7d90b662a Reviewed-on: https://chromium-review.googlesource.com/c/1322345Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606024}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e9640bf..8eba77ea Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76fbbf54027b9ba0cc9a1ddb115ac3ca1c849e76 Reviewed-on: https://chromium-review.googlesource.com/c/1322849Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606023}
-
philipel authored
Cleanup related to https://webrtc-review.googlesource.com/c/src/+/108861 Bug: webrtc:9946 Change-Id: I888142e2909a12232e7385edc1644d314ced7d10 Reviewed-on: https://chromium-review.googlesource.com/c/1317857 Commit-Queue: Philip Eliasson <philipel@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#606022}
-
David 'Digit' Turner authored
A bug matched the Filipino locale with the Finish language, which caused Chrome Canary, which uses bundles, to crash at load time when the device's locale is set to Finish. BUG=901837 R=benmason@chromium.org,yfriedman@chromium.org,tiborg@chromium.org,ajha@chromium.org Change-Id: Ib07f95e686bbae02cc2bd17c785818e03741042e Reviewed-on: https://chromium-review.googlesource.com/c/1317863Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#606021}
-
Stephane Zermatten authored
This change defines the following end states: - expected: a script is run that contains a stop action with a tell before. This leaves the message from the tell on the screen for 5s then shuts everything down. - expected: a script is run that contains a stop action with no tell before This shuts everything down immediately. - unexpected: navigation to another page, not triggered by a script - unexpected: back button - unexpected: new tab This shows a specific error message for 5s, before shutting everything down. - error: a script failed - error: we waited for a long time for scripts, but got nothnig. - error: there cannot be any runnable scripts on the current page, not even if the page changes. This shows the default error message for 5s, before shutting everything down. Bug: 806868 Change-Id: I9b6afd061705c3c9bd98694a696914c137397af5 Reviewed-on: https://chromium-review.googlesource.com/c/1311928 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606020}
-
Anna Malova authored
Bug: 853793 Change-Id: I45aa3b2ad9729d26faa496f3e8fd522ef492d109 Reviewed-on: https://chromium-review.googlesource.com/c/1299146 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#606019}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8f7f3c91f72..0fc9f7540077 Created with: gclient setdep -r src-internal@0fc9f7540077 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d32959ac61bcd65c8a542cb012eda2025493dc7 Reviewed-on: https://chromium-review.googlesource.com/c/1322365Reviewed-by:
-
Gabriela Melchior authored
These tests should ensure that bounds are being checked for span functions and that these guarantees don't decay. R=palmer@chromium.org BUG=817982 Change-Id: Ief96bcc56a78187c615cbb15e906320290eafc59 Reviewed-on: https://chromium-review.googlesource.com/c/1317894Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriela Melchior <gabimelchior@google.com> Cr-Commit-Position: refs/heads/master@{#606017}
-
Keishi Hattori authored
Converts Canvas* and Image* class allocations from new to MakeGarbageCollected. Bug: 757708 Change-Id: I0e324ba213af3ce3ab892bc8f1bf6d3712d6ead6 Reviewed-on: https://chromium-review.googlesource.com/c/1319652 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606016}
-
Vaclav Brozek authored
This CL implements the part of the design https://goo.gl/Mc2KRe, which handles the situations when the autofill server marks two fields as usernames, and the parser needs to decide which is relevant. Bug: 895781 Change-Id: I37ef3bc55697c108b1761bf45e28deb9a20a2c1d Reviewed-on: https://chromium-review.googlesource.com/c/1318894Reviewed-by:
-
Camille Lamy authored
This CL updates the checks in NavigationControllerImpl::CreateNavigationRequestFromLoadParams so that we can distinguish which of the main frame vs subframe case is triggering. It also adds additional checks in FrameNavigationEntry url starts to diverge from the computed url_to_load. NavigationControllerImpl: :NavigateWithoutEntry to understand when the Bug: 896028 Change-Id: I4bf4fbb9e0dc668e88456181fae425c6cb79570a Reviewed-on: https://chromium-review.googlesource.com/c/1318978Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606014}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4b49707cb5ca..4d2d5b4bbe38 git log 4b49707cb5ca..4d2d5b4bbe38 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 lowell@google.com Fix unhelpful error when gn.py run in wrong directory. Created with: gclient setdep -r src/third_party/depot_tools@4d2d5b4bbe38 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8854c0571e2b5bfdd0102b9730c6a568306a7712 Reviewed-on: https://chromium-review.googlesource.com/c/1322317Reviewed-by:
-
Rayan Kanso authored
The test is timing out on Android. More details in the bug. TBR=kylechar@chromium.org Bug: 902674 Change-Id: I080e46a5b15d1e4742793ce3ca4f992147a8b90a Reviewed-on: https://chromium-review.googlesource.com/c/1322830Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606012}
-
Alexander Hendrich authored
This CL is a followup to 1296539 and fixes a TypeError in webRequestInternal.eventHandled() caused by this CL. onHeadersReceived_ previously only returned headers when they contained a SAML_HEADER, but the fix CL always returned all headers. Bug: 900950, 887061 Change-Id: Ic39e2bd6a98c6e2e3411812f7cd90310c32e1d3b Reviewed-on: https://chromium-review.googlesource.com/c/1314471Reviewed-by:
-
Fredrik Söderquist authored
Hopefully these tests are no longer flaky, but as a cautionary step, mark them as Pass/Fail for now and keep an eye on them. TBR=schenney@chromium.org Bug: 306222 Change-Id: Ia0e87564e2113dfaa50cd723654786805026924d Reviewed-on: https://chromium-review.googlesource.com/c/1322789Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#606010}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4d5651f6d0c..d8f7f3c91f72 Created with: gclient setdep -r src-internal@d8f7f3c91f72 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib4b88409e01b3be0384d38e9671e09029dbedbb5 Reviewed-on: https://chromium-review.googlesource.com/c/1322315Reviewed-by:
-
Stuart Langley authored
Preparation for adding FolderFeatures as another parameter that can be set on a TestEntryInfo object. Bug: 884020 Change-Id: I1fec6cc38f024df83b5b3c065f1b6ec5e8462347 Reviewed-on: https://chromium-review.googlesource.com/c/1322341 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606008}
-
Marc Treib authored
This pref was only used for legacy supervised users, based on supervised_users::kRecordHistoryIncludesSessionSync. Legacy supervised users don't exist anymore, so no need to keep this around. Bug: none Change-Id: I34a3661bba4e9ebc4e89677749f4c0ee001d908d Reviewed-on: https://chromium-review.googlesource.com/c/1314492 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#606007}
-
Colin Blundell authored
This include causes complications when splitting //components/signin/core/browser:test_support into "internals" and "externals" targets: test_signin_client.h will go into the "internals" target, which should not depend on //components/signin/core/browser, which the included file is part of. Happily, this include isn't used and can be removed :). Bug: 901859 Change-Id: Ia9cd8381773801932af31856e45f9aa2a54b38c5 Reviewed-on: https://chromium-review.googlesource.com/c/1319590Reviewed-by:
-
Siddhartha authored
This data is useful to understand startup regressions from users. Storing of service name in base factory is not a lot of overhead considering that the strings are already part of binary. BUG=900688 TBR=blundell@chromium.org Change-Id: I240900515431fc56f005c7198ce0aea0645b3a62 Reviewed-on: https://chromium-review.googlesource.com/c/1311613Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606005}
-
Yoshifumi Inoue authored
This reverts commit f481306a and disables following tests on Windows: * RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler * UserScriptListenerTest.NavigationWaitsForContentScriptsToLoad Reason for revert: Causes BrowserMainLoopTest, CreateThreadsInSingleProcess to fail every time content_unittests is run, if DCHECKs are enabled. Original change's description: > Reland "Start ServiceManger before creating BrowserMainLoop." > > This relands commit aa60c219. The original CL > (https://crrev.com/c/1113802) got reverted becuase FeatureList and field > trials are not setup properly in early startup in Android WebView, but > ServiceMangerContext has checked features. See crbug.com/899376. The fix is > in a separate CL: https://crrev.com/c/1305876. Another related precursor CL > is: https://crrev.com/c/1308096. > > This CL is an exact copy of the original CL. > > The original cl description is: > This CL instantiates the ServiceManagerContext before creating > the BrowserMainRunner. It splits the startup path into two, > with/without starting the full browser. The changes are implemented > behind a flag "allow-start-service-manager-only". > > Bug: 846846,729596 > TBR: jam@chromium.org > Change-Id: I5214af850d4ef256c9d223db059ed009a42de714 > Reviewed-on: https://chromium-review.googlesource.com/c/1305822 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604969} TBR=gab@chromium.org,jam@chromium.org,hanxi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846846, 729596, 902311 Change-Id: I8b46711602a240023f4a03a69aa70f66d4eee726 Reviewed-on: https://chromium-review.googlesource.com/c/1322343Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606004}
-
Stephane Zermatten authored
BatchElementChecker:StopTrying was introduced as a work around when finding elements failed when run in parallel. On ScriptTracker, this required delaying re-checks and even executing scripts until a clean script end, which is complex to get right. Now that finding elements can safely be run in parallel, a BatchElementChecker can safely be deleted to interrupt any pending checks. This simplifies ScriptTracker. Bug: 806868 Change-Id: I87e61932a9dee178c5ad9337a315f9891c43bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/1319670 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#606003}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit. That means that they also share the same anonymous namespace (which is per translation unit, not per file which would have been better). In https://chromium-review.googlesource.com/c/1316836 and https://chromium-review.googlesource.com/c/1315534 two peerconnection tests each added a kWriteBufferSize and a kDelegateReadBufferSize with different values which broke some jumbo build configurations (unluckily not the one in CQ but some in fyi builders). This renames the variables to have more unique names. TBR=shampson@chromium.org,hbos@chromium.org Bug: 874296 Change-Id: Ifc8af2be440f7a959b948c05e18deaf55aeefad2 Reviewed-on: https://chromium-review.googlesource.com/c/1322709Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#606002}
-
Mohamed Amir Yosef authored
This CL renames PasswordModelTypeController class. Currently it is used for the Pseudo USS implementation as an intermediate stage till releasing the full-blown USS implementation for passwords. We should reserve that name for the full-blown implementation. Bug: 902349 Change-Id: I01b9df1e9e4afcb0307f58a95172769a9f249f18 Reviewed-on: https://chromium-review.googlesource.com/c/1320170Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606001}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33b8d56d7282..e4d5651f6d0c Created with: gclient setdep -r src-internal@e4d5651f6d0c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia2455817e9288e74be2b2235802a10841d2882df Reviewed-on: https://chromium-review.googlesource.com/c/1322313Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b563adf6..2e9640bf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5162ec394e9d6da2164c4fa9c10daa35c31b31d6 Reviewed-on: https://chromium-review.googlesource.com/c/1322359Reviewed-by:
-
Hitoshi Yoshida authored
We no longer use GYP, and it is confusing to keep having APIs or comments for it. Bug: None Change-Id: I0d2cd0f4c5b41edeab3ea65785a5eec9a4324b44 Reviewed-on: https://chromium-review.googlesource.com/c/1322344Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yi Su authored
Enable SearchEngineTabHelper to add new TemplateURL to TemplateURLService by following steps: 1. When a searchable URL is generated from <form> submission, save it to SearchEngineTabHelper; 2. If the navigation caused by <form> successfully finishes, create a new TemplateURL by recorded searchable URL and add it to TemplateURLService, then erase the recorded url. Failed navigation will be ignored because in that condition the generated searchable URL will probably lead user into an error page; Bug: 433824 Change-Id: I1835f2e12e9bc3a1d613011b5b7dd38206c019ad Reviewed-on: https://chromium-review.googlesource.com/c/1317909Reviewed-by:Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605997}
-
Koji Ishii authored
NGLineTruncator truncates lines by suppressing fragments to be clipped. However, when such fragments have SelfPaintingLayer, they are still painted by LayerPainter. This patch moves such fragments to the outside of the clipping area, the same way we used to use until r581177. Note that we used to move to line_width before r581177, but it's not enough when the block has padding. This patch moves to NearlyMax instead. Bug: 899902 Change-Id: I6192f230e2da3af11346acb5795483f9cc3a6a6a Reviewed-on: https://chromium-review.googlesource.com/c/1319889 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#605996}
-
Yoshifumi Inoue authored
This patch marks point-mapping/3d-point-mapping-{3,origins}.html flaky on Mac10.13 Retina. NOTRY=true TBR=yosin@chromium.org Bug: 902645 Change-Id: I9fc46621c034f932c791d4932907dcbcf88ebe4a Reviewed-on: https://chromium-review.googlesource.com/c/1322261Reviewed-by: -
Gauthier Ambard authored
This is a preliminary step to start using it for the "Switch to this tab" feature. Bug: 893121 Change-Id: I58f9095b689dbd0a59fffcb20bca7924dd239d7f Reviewed-on: https://chromium-review.googlesource.com/c/1319675Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#605994}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/52a091f41950..4b49707cb5ca git log 52a091f41950..4b49707cb5ca --date=short --no-merges --format='%ad %ae %s' 2018-11-07 yyanagisawa@chromium.org autoninja: use ninja in the autoninja.py directory Created with: gclient setdep -r src/third_party/depot_tools@4b49707cb5ca The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/77176746 TBR=agable@chromium.org Change-Id: I34b7cac49c620fda5354d08808403471f5651ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1322369Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ecee6235c38..33b8d56d7282 Created with: gclient setdep -r src-internal@33b8d56d7282 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5f83c3eaca20e48cb6fdaa4d6dda20e1f3fac0de Reviewed-on: https://chromium-review.googlesource.com/c/1322371Reviewed-by:
-
Marc Treib authored
Less duplication == good. Most of the things in autofill::TestSyncService were already supported, a few missing ones are added in this CL. TBRing trivial change in payment_request_browsertest_base.h TBR=mathp Bug: 859874 Change-Id: I51c140c86efb95494f84eb38142d54fc32f74b14 Reviewed-on: https://chromium-review.googlesource.com/c/1319592 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605991}
-
