Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 14 Oct, 2014 27 commits
  3. 13 Oct, 2014 13 commits
    • jbauman's avatar
      Use UI message loop for in process GPU thread on Windows · f5f241f9
      jbauman authored 
      WGL needs to create a window and should pump its message loop, so use a UI message loop.

BUG=273220

Review URL: https://codereview.chromium.org/643373002

Cr-Commit-Position: refs/heads/master@{#299395}
      f5f241f9
    • amistry's avatar
      Support hotwording on google.com and the new tab page. · 69ec4478
      amistry authored 
      The audio_client.js content script is copied from the existing hotword_helper
extesion, with the only change being the hotword extension ID to point to this
new extension.

BUG=397019

Review URL: https://codereview.chromium.org/600523004

Cr-Commit-Position: refs/heads/master@{#299394}
      69ec4478
    • skia-deps-roller's avatar
      Roll src/third_party/skia 6c07907:07894c4 · b285628a
      skia-deps-roller authored 
      Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6c07907..07894c4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/656553002

Cr-Commit-Position: refs/heads/master@{#299393}
      b285628a
    • tapted's avatar
      MacViews: Disable PluginDiscovery in views_examples_with_content_exe · 9f1e45ad
      tapted authored 
      TransformPathForFeature in child_process_host_impl.cc expects to find
`Chromium Helper XX` inside the .app bundle, but
views_examples_with_content_exe is a standalone executable. The example
app doesn't need plugins so this CL disables plugin discovery to avoid:

Check failed: kMacOSName == macos_path.BaseName().value() (MacOS vs.
Debug)

This occurs when particular pages are loaded in the WebView example,
triggered via content::PluginLoaderPosix::LoadPluginsInternal().

The change is made in views_content_client, which affects app_list_demo
and views_examples_with_content_exe.

BUG=395507

Review URL: https://codereview.chromium.org/655433002

Cr-Commit-Position: refs/heads/master@{#299392}
      9f1e45ad
    • andresantoso's avatar
      Revert of Mac: Update sheet position when bookmark bar is shown or hidden.... · 92af67fd
      andresantoso authored 
      Revert of Mac: Update sheet position when bookmark bar is shown or hidden. (patchset #1 id:1 of https://codereview.chromium.org/502413004/)

Reason for revert:
Broke certificate info positioning when switching tabs (http://crbug.com/419371).
I will need to come up with a better fix for this, but it looks complicated and that bug is a M39 stable blocker so reverting this first.

Original issue's description:
> Mac: Update sheet position when bookmark bar is shown or hidden.
>
> In r272421, I changed sheet repositioning on window resize to be based on
> NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification
> because it tracks window resizing much more smoothly.
>
> That caused this problem where if the browser window is vertically maximized
> (or is in fullscreen), the window size does not change when the bookmark bar
> is shown or hidden.
>
> The old code has a different bug however. If the browser window is not
> vertically maximized, showing or hiding the bookmark bar does not change the
> browser content view's frame. It moves up or down to follow the window resize
> but its frame relative to its superview remains the same.
>
> I settled for adding code to explicitly update the sheet's position when the
> bookmark bar is shown or hidden.
>
> BUG=407509
>
> Committed: https://crrev.com/5648b809d1c50e3de754b96abe7cf2b60150ff4d
> Cr-Commit-Position: refs/heads/master@{#292421}

TBR=avi@chromium.org
BUG=407509

Review URL: https://codereview.chromium.org/653733002

Cr-Commit-Position: refs/heads/master@{#299391}
      92af67fd
    • jamuraa's avatar
      New error strings for chrome.bluetoothLowEnergy · c3888bee
      jamuraa authored 
      Also use a new method for callback chaining, which is slightly less
flexible but much less "callback hell".

BUG=377232
R=armansito@chromium.org

Review URL: https://codereview.chromium.org/628983003

Cr-Commit-Position: refs/heads/master@{#299390}
      c3888bee
    • vadimt's avatar
      Adding instrumentation to locate the source of jankiness. · 775c3028
      vadimt authored 
      Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL specifically instruments some presumably most popular callbacks invoked by “callback.Run(result);” line in TCPClientSocket::DidCompleteReadWrite.

BUG=418183
TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/652853002

Cr-Commit-Position: refs/heads/master@{#299389}
      775c3028
    • jbauman's avatar
      Don't create child window for WGL. · d62145de
      jbauman authored 
      This causes a deadlock, so it's not usable. Getting rid of the window at least allows --in-process-gpu to work.

BUG=273220

Review URL: https://codereview.chromium.org/649863002

Cr-Commit-Position: refs/heads/master@{#299388}
      d62145de
    • zmo's avatar
      Disallow active attrib aliasing at shader program link time. · 460b593e
      zmo authored 
      BUG=415688
TEST=gpu_unittests, webgl_conformance_tests
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/651543003

Cr-Commit-Position: refs/heads/master@{#299387}
      460b593e
    • vmpstr's avatar
      cc: Bump up pending tree now tiles order for smoothness mode. · 0ad654fa
      vmpstr authored 
      In smoothness takes priority mode, we should ensure to return tiles
that are required for activation sooner than eventually bin. The reason
for this is that we don't want to starve activation and the prepainting
required for smoothness should already be covered by the soon bin.

Additionally, we have to ensure not to mark these tiles as violating
memory policy, since required for activation tiles need special
treatment (unfortunately). The reason for this is that activation is
currently tied to updating our recordings and smoothness mode would
otherwise starve activation even if we're past the recording region.

BUG=422819
R=reveman

Review URL: https://codereview.chromium.org/651503004

Cr-Commit-Position: refs/heads/master@{#299386}
      0ad654fa
    • gunsch's avatar
      Reorganizes Chromecast code to better reflect functional dependencies. · f44ffcbe
      gunsch authored 
      Motivation:
* chromecast/service/ directory had interplay with chromecast/shell/browser
  code, since the service is all run in the browser process and mildly
  coupled (involves starting WebContents instances, etc,). Made more sense
  for chromecast/service to live in chromecast/shell/browser.
* chromecast/shell/ directory is needless hierarchy, since the entire
  chromecast/ directory represents the Chromecast content-embedder.

Highlights:
* chromecast/shell/{app,browser,common,renderer} --> chromecast/*
* chromecast/shell/browser/resources --> chromecast/app/resources
* chromecast/shell/settings --> chromecast/app/resources
* chromecast/shell/android --> chromecast/browser/android
* chromecast/metrics --> chromecast/browser/metrics
* chromecast/service --> chromecast/browser/service

R=lcwu@chromium.org,gusfernandez@chromium.org,byungchul@chromium.org
TBR=xhwang@chromium.org,asvitkine@chromium.org,thestig@chromium.org,jam@chromium.org,yfriedman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/638803002

Cr-Commit-Position: refs/heads/master@{#299385}
      f44ffcbe
    • bokan's avatar
      Made top controls work with virtual viewport pinch-to-zoom. (Chromium) · ef97146f
      bokan authored 
      This change adjusts the scroll bubbling logic in LayerTreeHostImpl so
that outer viewport layer scrolls affect the top controls. Additionally,
the outer viewport's size is adjusted to match the inner viewport's
aspect ratio until a resize occurs.

Blink side: https://codereview.chromium.org/643473002
BUG=364109

Review URL: https://codereview.chromium.org/641873003

Cr-Commit-Position: refs/heads/master@{#299384}
      ef97146f
    • blink-deps-roller's avatar
      Roll src/third_party/WebKit c5733ed:ef3851c (svn 183623:183626) · eaa91cae
      blink-deps-roller authored 
      Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c5733ed..ef3851c

TBR=caseq@chromium.org,apavlov@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/656543004

Cr-Commit-Position: refs/heads/master@{#299383}
      eaa91cae