- 10 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/627f4a6b8dc3..dd9c4208af2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I64053deb55f08f4ab88e02e9d14497de10ee1b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835527}
-
Jason Lin authored
VmCameraMicManager displays camera and mic notifications based on VMs' media capture state. And CameraMicTrayItemView is meant to follow VmCameraMicManager and displays camera and mic indicators on the systray. CL 2576232 changes the notifications behavior such that when a VM is accessing both camera and mic, only a camera icon notification is displayed. In this case, we don't want CameraMicTrayItemView to display the mic indicator unless a mic icon notification is also displayed. To fix this issue, this CL lets CameraMicTrayItemView follows the notification state (via VmCameraMicManager::IsNotificationActive()) instead of the device state (via VmCameraMicManager::IsDeviceActive()). bug: b/167491603 Change-Id: I514f7be204d74cc43ac67d12bc2ce7215bf50cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581180 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835526}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607536746-da55b5a139e52763d98214355eab95e70f45f788.profdata to chrome-mac-master-1607558393-ecfec5cb12c3793b6b05707a914c348608cba34b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib3f9e36ef30a13b82d3904e01f28d6ec2bb1a27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582949Reviewed-by:
-
Kenton Lam authored
Updated and added new enum value to prepare for implementation of system emoji picker. This emoji picker will be used when a physical keyboard is connected. Existing code records this metric in Google3, we are adding a new emoji picker in Chrome OS and will use this metric to compare usage of the two. Adding the additional enum entry now as metric is about to expire, implementation to follow. Bug: 1153740 Change-Id: I4c97873f70caa4f7fb355d089ead72ded3abccb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580660 Commit-Queue: Kenton Lam <kentonlam@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#835524}
-
Clark DuVall authored
The histogram files had ContextCreateTime, but Java had CreateContextTime. Oops. Bug: 1150600 Change-Id: I6eac406e7d29bc46809623696bc0c7007212ebfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583136 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#835523}
-
Yu-Hsuan Hsu authored
Add two new CRAS_CLIENT_TYPE: CRAS_CLIENT_TYPE_LACROS and CRAS_CLIENT_TYPE_PLUGIN. BUG=b:167941044 Change-Id: If68c7b7429e0b6082bdc1ed5fd2571bf64c7dc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573263Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835522}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba2b567f001f..d5e21940e048 2020-12-10 dberris@chromium.org chromeperf: Increase parallelism by 1.5x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1156554 Tbr: wenbinzhang@google.com Change-Id: I0048c1a9247e6e340deb0a3e67fdef729cda748d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582951Reviewed-by:
-
Matt Reynolds authored
If script does not maintain a reference to a HIDDevice object, it may be garbage collected even if there is an open connection to the device with an input report event listener. This CL makes HIDDevice ActiveScriptWrappable so it can prevent itself from being GCed if the device is open and an event listener is registered. Bug: 1156239 Change-Id: Ia2d394e66f9e52efc871bdb639e003ed6bb27254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576793Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#835520}
-
Anupam Snigdha authored
When selection positions span across contexts with different editability regions, the block formatting command tries to split the nodes and perform indenting by copying over content to start position from where the end position is. This leads to a crash while verifying node split output in |RangeForParagraphSplittingTextNodesIfNeeded|. Fix is to check whether the start and end positions are inside the same editable region or not and if they don't share the same editable context, then just bail out. Bug: 996134 Change-Id: I298ae6c8b0c631620266e3f201c0f3c8849d3300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582866 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#835519}
-
edchin authored
This was originally created in Nov 2018 in this CL: https://chromium-review.googlesource.com/c/1351787 This metric is no longer being used and has already expired since M73. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: I2af72cca6842323a4ec9eb37b20dc8cdcdd27f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580917 Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835518}
-
Mason Freed authored
The previous bar had a 100% width, which made the right edge visible if the window was scrolled. With this implementation, the control is the first row in the table, so the width is max-content. (Simply making <body> max-width doesn't work, because then when trying to line-wrap, the table is too wide and doesn't wrap anything.) Fixed: 1154219 Change-Id: I8d35eb632c59f7dc8c8e8c76c3575018669d82da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582636 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Travis Skare authored
Linux-only for now, one showed on Android in the past but not as frequently. Bug: 1157241,1157239 TBR: mlamouri@google.com Change-Id: Ibf33f33a207cf3276907e8abadab1d224dc8baa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583156Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#835516}
-
Mason Freed authored
This CL primarily replaces CreateV0ShadowRootForTesting() with AttachShadowRootInternal(ShadowRootType::kOpen) in one place: core/editing/testing/editing_test_base.cc. That is the base class for many derived editing tests, which then needed to be updated, mostly by replacing <content> elements with <slot> elements, and updating the slot selection attributes accordingly. Some tests, notably ones that do Flat Tree traversal and then look for particular nodes in the flat tree, fail when this change is made. These are (or should be) test-only failures, as the only change being made is to switch from Shadow DOM v0 to (supported) Shadow DOM v1 in the test. It is likely that these tests just need to be updated to look for the <slot> elements in the flat tree, instead of expecting fully-replaced <content> elements. A separate bug (crbug.com/1157146) tracks the 6 tests that were disabled in this CL: EditingUtilitiesTest.NextNodeIndex EditingUtilitiesTest.firstEditablePositionAfterPositionInRoot EditingUtilitiesTest.lastEditablePositionBeforePositionInRoot EditingUtilitiesTest.tableElementJustBefore PositionTest.NodeAsRangeLastNodeShadow StyledMarkupSerializerTest.AcrossShadow Bug: 966758,937746,1157146 Change-Id: Idc49a66068850c8f80fd3d4ba405e60352553782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581200 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: -
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/8bb622..5c3a0b9 TBR=jshin@chromium.org Bug: v8:10447 Change-Id: I715e375e6778a4ff038aedb3e35404e1a7ff91dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582536Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835514}
-
Nate Fischer authored
No change to production logic. This disables a flaky test in ContinuousSearchTabHelperTest. This test was newly added, so maybe it just needs a closer look to deflake fully. Tbr: ckitagawa@chromium.org Bug: 1157325 Test: None Change-Id: Ib7711bb0460782ea5d0779ea58f1cb543251e026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583138Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835513}
-
Joel Riley authored
If next adjacent valid text node is not contained within a paragraph, Select-to-speak will still navigate to it. This is useful in Android apps and system UI, where there is a lack of paragraph-like structures. Also contain navigation within root (such as browser tab). AX-Relnotes: N/A Bug: 1143819 Change-Id: I6e36c9cd075480dd95cb49013b78942a1edae2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580509 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835512}
-
Majid Valipour authored
This allows WebOTP backend to be configured via finch trial infra. Bug: 1153880 Change-Id: I645171b4635595a48091ff3f40a63839321cf5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564007 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#835511}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/627f4a6b8dc3..dd9c4208af2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2941eb8526b0f3849f6eddc7cbea029e5485e168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583028Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/378653f844d4..067a12f05951 2020-12-09 cclao@google.com Reland "Vulkan: Use specialization constant for halfRenderAreaWidth" 2020-12-09 cclao@google.com Vulkan: Add dirty bits instead of direct access FBO state 2020-12-09 syoussefi@chromium.org Suppress test requiring VK_EXT_transform_feedback on Nvidia/win7 2020-12-09 courtneygo@google.com Add VK-GL-CTS autoroller link to wrangler doc 2020-12-09 syoussefi@chromium.org Fix varying packing of I/O block fields If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I5704b13b4e03d026216903e44ae8ce80d782942c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582878Reviewed-by:
-
Nate Fischer authored
No change to production logic. This disables two tests which are flaking on the bf cache bot. Tbr: mlamouri@chromium.org Bug: 1157320 Test: None Change-Id: Ie6c76747f1b468fd30dac4a792b2bf287bade88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582835Reviewed-by:
-
John Palmer authored
Bug: 1152237 Change-Id: I67905020b6ad54a6ddb1ff474376fc7411095c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576663Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#835507}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. This CL moves logic for navigating the browser() window and waiting for exo to register the window into a standalone utility file: chrome/browser/lacros/browser_test_util.h. This is in preparation for reuse by other lacros_chrome_browsertests. This CL removes some now redundant version checking logic. Change-Id: Ic69478c205d6d2736cf4f2c42d2edcfbfc6c422e Bug: 1155662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582811Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835506}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/201bcee38a94..c2a1746b42d9 2020-12-10 csmartdalton@google.com Implement stroke tessellation with indirect draws 2020-12-09 reed@google.com Assert that SkPath is always internally consistent 2020-12-09 johnstiles@google.com Add support for isinf/isnan intrinsics to SPIR-V. 2020-12-09 johnstiles@google.com Add tests for SkSL intrinsic functions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I16dfdb31f59cff592df02b659dbcc85f25d16282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583486Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c1c04e0eb7d..26392d8577ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com,skare@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131897,chromium:1150968 Tbr: meredithl@google.com,skare@google.com Change-Id: I0e43c75d54472b7b4b13486ccae3cf1d07e4db71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582948Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Travis Skare <skare@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835504}
-
Alexander Cooper authored
There's a few timeouts that were previously bumped up (as part of Issue 952491), due to the intro animation on Windows Mixed Reality causing the indicators to appear and disappear while that animation was running. At that time WMR was the only runtime, and so these bumped timeouts were gated by both the buildflag and by the feature. While Chrome's WMR support is being removed, OpenXR can still run on top of WMR, where this increased timeout would be needed. As such, the check on the WMR feature flag is removed, and the ifdef is changed to check Windows specifically, rather than the WMR buildflag (which will hopefully soon be deleted). Bug: 1122233 Change-Id: I1edad682e844356112986f0fa3d879952362722a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582531 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#835503}
-
Aaron Knobloch authored
FuchsiaIntlProfileWatcher and confirm both the initialization values were correctly reported, as well as updates to the underlying PropertyProvider were sent to the registered ProfileChangeCallback. Bug: 1156404, b/168161909 Test: intl_profile_watcher_unittest Test: Added a small bit of code to utilize the Change-Id: I39fd7b462e7b0571b1acb242a7a0c8253213ec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577884 Commit-Queue: Aaron Knobloch <aknobloch@google.com> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835502}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/768ced1d5798..3c56ca23d926 2020-12-10 vidorteg@microsoft.com [Loc] Migrate node_main panel to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I147dc56a95902b3c51de5b04db2499660c79b1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583485Reviewed-by:
-
Xianzhu Wang authored
This reverts commit c4797aea. Reason for revert: caused performance regressions crbug.com/1156598 Original change's description: > Ensure graphics layer collection when stopping lifecycle update throttling > > This is the counterpart of crrev.com/c/2572783, for M88+, to ensure the > new GraphicsLayer created for an iframe will be collected. This is > mainly to add the test, but to make the test pass, similar code is > added in BeginLifecycleUpdates() to ensure safety. > > Bug: 1152920 > Change-Id: I4098bdbce87c7354cd1f157047a6475ee7bd46fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577612 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834562} TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152920, 1156598 Change-Id: I12a26e06d7bd435d17fee58695f06d5c6a22ee64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582813Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835500}
-
Tom Anderson authored
This is a first step toward reducing round trips on state changes and during DnD and tab dragging. Followup changes will: * Add the ability to set properties * Add a event-related unit tests * Before this can be done, event dispatching needs to be refactored to remove reliance on X11EventSource. * This will also allow us to move PropertyCache from //ui/base/x to //ui/gfx/x. BUG=739898 R=sky Change-Id: I3bdd3a7200b7c7d6785b0b5cdced0c1673d76ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578117 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#835499}
-
Jacob Kopczynski authored
Bug: chromium:1127088 Change-Id: Ia8c22a2004f892ba36a6c172c4a90cd3f094b995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583132Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Cr-Commit-Position: refs/heads/master@{#835498}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607525538-a962c6e7f864d3587aeaa1e7bb0caf9929474c9a.profdata to chrome-win64-master-1607536746-29bce53663c3c2f323cb6f75c47555236b300f05.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I594e37a1398fea707926efa3d2dbd90161a91863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583074Reviewed-by:
-
David Black authored
Previously holding space item id was a concatenation of type and file path. Moving forward, holding space items will be retained across moves and renames of their backing files, so a decoupled unique ID is desired which can be stable throughout the lifetime of the holding space item. This change is backwards compatible w.r.t persistence. Bug: 1136173 Change-Id: If1d3f218fe61dcc96f9336f8be6a0b197ab3c0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583155Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#835496}
-
Curt Clemens authored
Bug: 1157108 Change-Id: I5c75ab32256fd662befe14c7d99e76a388069e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580512Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#835495}
-
Mitsuru Oshima authored
This can cancel the animation running because the new layer doesn't have animation. We may also want to 'clone' animation, but that'd be a separate task. Bug: 1149748 Change-Id: Ia018f112b8a6d268a93a2d678086254d3097e6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538547Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#835494}
-
Rouslan Solomakhin authored
Before this patch, the icon representing the allowed card networks (e.g., visa, mastercard) had a touch target of 38x24dp, which is smaller than the 48x48dp required for accessibility. This patch changes the icon column sizes from 38dp to 48dp, adds 5dp horizontal padding and 13dp vertical padding to each icon, and removes extra margins around the now larger icon touch targets. After this patch, the touch target for each icon is 48x48dp. Bug: 977272 Change-Id: Ieb4cf01ae3afaa225a36adf1aeadd5dca336c108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580584 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#835493}
-
Jacob Kopczynski authored
Won't get them from purple to green but should get them from red to green. Bug: chromium:1127088 Change-Id: I6384f7ef1409196c4d543cd516905d05dbd4bfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583134 Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
-
Josh Nohle authored
(1) Add metric Nearby.Share.Payload.FinalStatus to track whether a payload transfer succeeded, failed, or was cancelled, agnostic of transfer medium. Previously, we always sliced this by the upgraded medium. (2) Rename some Nearby.Share.Transfer[...] metrics to Nearby.Share.Payload[...]. The "Transfer" infix is broader than payload exchange. For example, "Transfer" metrics capture events such as the remote device rejected the share request, whereas "Payload" metrics are only recorded after actual file or text bytes start to be exchanged. (3) Reduce the number of Nearby.Share.Payload.TransferRate/TotalSize histograms by no longer independently slicing by each variation. For example, we will still have Nearby.Share.Payload.TransferRate.Phone and Nearby.Share.Payload.TransferRate.Receive, but not Nearby.Share.Payload.TransferRate.Receive.Phone. This reduces the number of generated histograms from 240 to 13. (4) Clean up the metric logger utility file by alphabetizing the methods and making the metric name strings more obvious. Manually verified all Nearby Share metrics are as expected. Bug: 1105579 Change-Id: Id0a7f8d3e05228bb7d14fbc508ab2c9b02b378a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571443Reviewed-by:
-
Noel Gordon authored
Construct the file manager delegate with its owning file manager WebUI to allow convenient access to browser structures provided by the WebUI such as its WebContents, current user Profile, etc, which will be used to implement delegate services. Bug: 1113981 Change-Id: I3a16694032fc2fdbc81fe01434d6860f6f84b49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581168Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835490}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f4c21136e60a..83498ed6d228 2020-12-09 natsu@google.com Treat AHB YUV as external format 2020-12-09 natsu@google.com Handle AHARDWAREBUFFER_FORMAT_YV12 2020-12-09 srisser@google.com Update SPIR-V version to VK_1_1_SPV_1_4 2020-12-09 natsu@google.com Handle VkExternalFormatANDROID in VkCreateImage 2020-12-09 srisser@google.com Add decorate operations new to SPIR-V 1.4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If34e5a1f3191d9e212122e2b5dd0183c5d965e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583078Reviewed-by:
-
Thiabaud Engelbrecht authored
This CL adds metrics to allow us to track how many eligible images we have in renderers. This requires keeping track of these images, which is done in this patch along with the metrics. Bug: 1154295 Change-Id: I9c529f31b7d106741595afe57cd4c13d1f5606be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564938 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#835488}
-
