- 26 Sep, 2020 40 commits
-
-
Yao Xiao authored
Implement the API to get the floc (i.e. interestCohort) that represents the cohort of the user's browsing interest. The floc is currently a per-profile value, but it should only be allowed to query if the cookies permission allows, therefore it's designed/defined to be an async API on "document". Explainer: https://github.com/jkarlin/floc Bug: 1062736 Change-Id: I088ef38038a4e27a5c40ba730a5dc37baa3cb12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389221 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810957}
-
Min Qin authored
This allows us to update tile order based on user input. Bug: 1096224 Change-Id: I137ddb2e74048c0ba214b560b986e216a77abff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423057Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#810956}
-
Lei Zhang authored
Initialize |g_clock| on first use instead of at runtime. Bug: 537099 Change-Id: Id6cbd61f05649029f7c9281b0efbf5595bc23077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429262 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810955}
-
Olga Sharonova authored
Bug: 1132225 Change-Id: I85fe9a1b402fba7fbc29d54d877a61bb2f1b1350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431029Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#810954}
-
Guido Urdaneta authored
Media Device ID salts should be reset for every new document, but navigations within the same document should not reset the salt since it causes problems for some applications. Bug: 1127548 Change-Id: I88e6af831fd8e5b02136d415e371b01d4dfd512e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432028 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810953}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I75117bb455869c950071365b222fd4f75e8baaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433244Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810952}
-
Sammie Quon authored
Logs presentation time while updating the UI. Adds a new smoothness for when animation which happens when lifting fingers off the touchpad. For chained animations, the logic from before is unchanged, so there will be one smoothness number in "Ash.Desks...DeskActivation" for a chain of animations. Test: manual Bug: 1111445 Change-Id: I9a1e76aa0f81edbe871601de78abc936536e4c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414553 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#810951}
-
Michael Spang authored
The definitions in ozone.gni were intended to be private to //ui/ozone, but there's no visibility checking for gni files so there's we've grown a number of these imports. Remove them where we can easily do so. Change-Id: Id7e9f924ef3bd7a37f446708e00aac21f51e8f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429865Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810950}
-
Darwin Huang authored
The constructor's argument order was flipped. Please see the "fill(6)" constructor for more info: http://www.cplusplus.com/reference/string/string/string/ Previously, this would cast 'X' to a size_t, and buf_len to a char. Tbr: fukino Change-Id: I69b71753338cde2810b6ed0b940650d683f0c20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432748 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810949}
-
Thomas Lukaszewicz authored
This CL sets TabStripRegionView to inherit from AccessiblePaneView rather than View. This is a necessary change to allow the TabSearchButton to be accessible via keyboard navigation when focus enters the tab strip region (entered via f6 on windows). In doing so, the TabStrip itself no longer needs to inherit from AccessiblePaneView and now inherits from View. This change should have no functional effect on how focus is handled in the tab strip (absent Tab Search). This also advances the goal of moving the NTB out of the TabStrip and into the TabStripRegionView as this will ensure the NTB remains keyboard accessible when moved to the tab strip region. Bug: 1131689 Change-Id: I5f1ab031116724341009d10469e6d7479cf05883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427876 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810948}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f7a0128b9441..cb9160484da5 2020-09-25 tsepez@chromium.org Use Optional<> return from CXFA_LocaleMgr::GetConfigLocaleName(). 2020-09-25 tsepez@chromium.org Introduce common superclass GCedLocaleIface 2020-09-25 tsepez@chromium.org Garbage collect CXFA_LocaleMgr. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1b468e9fbcbb3e5d0fde4fd25b9bf8e453fea3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433072Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810947}
-
Frank Liberato authored
Also modifies callback to take a `Measurement` struct, since the number of reported values was getting large. Last, adds explicit calls to the roughness reporter from the submitter when we stop rendering, so that it knows to stop the window. Change-Id: Idb00046511c5cee0c351172ec6e786d35e870457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410963Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#810946}
-
Matthew Mourgos authored
This CL changes how the notification indicator in the app list is painted. The circle border has been removed, and now a drop shadow has been added. Before this change, the notification indicator was drawn with a fixed size, which was not correct when the app list icons scaled to different sizes. Now, the notification indicator's size is determined as a ratio of the icon's total size, this ensures the indicator is always drawn to the correct size and position. Bug: 1131074, 1131072 Change-Id: I63e9f12845230579abe4703a60f4b08f6bf431c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429980 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#810945}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/236c96a322d8..2841e0538b44 2020-09-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iea2f6adc4696cacdfcd3b0bdc5905ce3b9bcbd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432957Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e577a1c6..e79440e7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie3929fa2298800768e15fe4edaf99751c3be36b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810943}
-
Tim Song authored
This class translates the PhoneHubManager state into the corresponding UI state and view that is shown in the tray bubble. Each state has it's own view class and the PhoneHubTray bubble transitions through these content views as the UI state changes. This CL also refactors PhoneConnectedView into it's own class. BUG=1106937,1126208 Change-Id: Ie012077a1905f80be91fbfb0b084d89219bd6c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427060 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810942}
-
Bruce Dawson authored
Simple functions like RenderAccessibilityManager::FatalError tend to generate code which is identical to other similar functions, and the linker helpfully "folds" them all together in order to save space. When displaying call stacks the debugger or other tools just choose one of the function names, without even mentioning that this is just a random guess, and great confusion ensues. In this case about a dozen different functions are all folded together and this is leading to a misleading and possibly inconsistent crash signature. base::debug::Alias is a reasonably reliable way of making the function unique so that it won't be folded. AX-Relnotes: N/A Bug: 1094848 Change-Id: I4814b718a11fcd18fd1414f1e1349d1cb18d31fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432760 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810941}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3199eca93a544a40987d51f87502108ca377a814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433071Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4224b3bbc76c..fc4e3cf24f9b 2020-09-25 courtneygo@google.com Vulkan: fix ASSERT issue in ResourceSerialFactory 2020-09-25 jmadill@chromium.org Capture commit position into Android Manifest. 2020-09-25 syoussefi@chromium.org Vulkan: Disable MSRTT on AMD/Windows 2020-09-25 m.maiya@samsung.com Vulkan: Add GL_EXT_buffer_storage extension support 2020-09-25 jmadill@chromium.org Suppress flaky Multithread Android end2end_test. 2020-09-25 jmadill@chromium.org Rename version/commit headers. 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from c9f4fb2fccda to 02da53e45d9e (7 revisions) 2020-09-25 jmadill@chromium.org Add ANGLE commit position to version.h. 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 67525bded1de to 9e17b9d07a25 (10 revisions) 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a09406249fa3 to b94db86cf9b3 (1 revision) 2020-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 4dcc12d1a441 to bacaef3237c5 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132366 Tbr: syoussefi@google.com Change-Id: I59cb94fbb77410ba5c498acff6c64ed570d6b2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432793Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601066350-493c228f7ec3e1753262b764503b9735ef24657c.profdata to chrome-win32-master-1601078369-47e552b1186c97497a87b26292e838c6fba2ff82.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I68e0b05557a43a74668461689a74127a461d8748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432955Reviewed-by:
-
Brandon Jones authored
This method only served to pause inline sessions from updating their poses in VRB. Now that VRB has been removed we no longer need it. Bug: 1017477 Change-Id: I1d93ce690550b5e8c282c4ceacb731b59799dc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422708Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810937}
-
Khushal Sagar authored
Instead of relying on the sync token returned by AcceleratedStaticBitmapImage to ensure synchronization with the raster stream used by skia, perform this when the mailbox is returned. This is temporary to allow merging a safer change to 86 release branch. R=dalecurtis@chromium.org Bug: 1131123 Change-Id: I639a0d864fae29ddb32182aeda5ba2e854b1f5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433049 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Reverts CL:2148035 as it seems to relate to some IPC crashes. The reason is unknown, but this safely reverts the change for now. See repro steps for crash in issue 1094848. The repro steps work on Canary but not for own-built versions. TBR: dmazzoni@chromium.org Bug: 1131848,1094848 Change-Id: I5d13fb13f7b5e9473bdad1f8f80c11a6ca449df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433026 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
wutao authored
This patch adds a mask layer to generate gradient fade effect on the media string. Bug: b/167236615 Test: added new tests Change-Id: I4c812c678031d0680c039c2c629aca082550ca9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414670 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810934}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601034748-5f32abe1706fc69f825acfb2aace1a93eeb5474f.profdata to chrome-mac-master-1601078369-ffc6308083b80c42d5e1d99c83f54bc820d7ceab.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8dfd49dd1a4e04980c85a5fb59f27049512c736a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433068Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1131881 Change-Id: Ia152dc0a76d1f9ad6eff87f74fef2ad17b327b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432755Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I8efb8969075297d3ac604ad90f80c26f49fee8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431967 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810931}
-
Mason Freed authored
Per some recent spec discussions/changes, declarative shadow roots should manually set the "available to element internals" flag, rather than assuming that in the check. See [1]. [1] https://github.com/whatwg/html/pull/5912#discussion_r489750553 Bug: 1042130 Change-Id: If50fa8bff4cddb566edf95cbd1b1a8f1afe11b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429852 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810930}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib68aa86d6ea08ab6febdd61d768dcc151d0a2906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431669Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810929}
-
Dirk Pranke authored
The GN roll in https://crrev.com/c/2360685 started enforcing visibility of configs, and this caused the compile to break on 'ChromiumOS ASAN Release'. This CL fixes the visibility rule accordingly. Bug: 1132431 Change-Id: Ic702f7a48b4de80a5dba46345ced9f9d9220763d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432670Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810928}
-
Lukasz Anforowicz authored
This CL introduces CastExtensionURLLoaderFactory::Create static method that allows creating an CastExtensionURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<CastExtensionURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing CastExtensionURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I6802fe556698bcba84e8332bcaae4665410c2f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410579 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#810927}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601034748-03f3a1d8372e4cec2560424c34442e7c7e8238b8.profdata to chrome-linux-master-1601078369-72819caf89b317b2996377bd72281bf52f735fa7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I0002816530a7084d890ce01e9dee858170d2c2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432950Reviewed-by:
-
Reilly Grant authored
This reverts commit 412cff1e. Reason for revert: Figured out why the change had no effect. Original change's description: > Revert "serial: Add option to switch enumeration methods" > > This reverts commit fdbcb258. > > Reason for revert: The new flag didn't resolve the issue. > > Original change's description: > > serial: Add option to switch enumeration methods > > > > A potential solution for issue 1119497 is to switch from enumerating > > devices implementing GUID_DEVINTERFACE_COMPORT to using the "bus > > enumerator" identified by GUID_DEVINTERFACE_SERENUM_BUS_ENUMERATOR. > > > > I'm putting this behind a flag so that developers can try it out in > > canary-channel. If it works I can enable it by default and keep the flag > > around for a couple releases in case it causes other problems. > > > > Bug: 1119497 > > Change-Id: Icad9008799ed331c3da15e5a70e0184144c47a58 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417460 > > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > > Auto-Submit: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808368} > > TBR=reillyg@chromium.org,odejesush@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1119497 > Change-Id: I3e39d5de932e94b980e7fb5f6de71a2cfa45b0f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423053 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809207} Bug: 1119497 Change-Id: I39bb97d5e1cc5ca5dc971ba2dfad3e9eb987141d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432005 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#810925}
-
Xi Han authored
In this CL, we remove the check of stack tab switcher in TabUiFeatureUtilities#supportInstantStart(). Thus instant start can be enabled in MVP++. These changes can be verified by: - StartSurfaceTest#testShow_SingleAsHomepage_V2__Instant*. The following changes are made to support stack tab switcher in instant start: 1) Defer the creation of TabList in StackLayoutBase. It allows the StackLayoutBase/StartSurfaceStackLayout to be created pre-native. 2) Add pending observer list in TabModelFilterProvider. Any observer which is added before the TabModelFilterProvider is initialized, will be cached and notified when the initialization is completed. 3) StartSurfaceLayout and StackLayoutBase will create its SceneLayer if hasn't yet before calling updateSceneLayer(). Bug: 1116449, 1076449 Change-Id: I42a730045d4b9799d4bb08dc7d7dc947956f42ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356167Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810924}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c826e1a6. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I7c8842c2773604122cbf1b5677e3369dd83c235d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432387Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810923}
-
Findit authored
This reverts commit 9d061cca. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810917 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlkMDYxY2NhZTAxZGQ2NWE2NjQxMmEyOTE0ZmJhZmFiOTMxOGUwOTUM Sample Failed Build: https://ci.chromium.org/b/8868132345808855984 Sample Failed Step: compile Original change's description: > Roll src/net/third_party/quiche/src/ ba9d95e43..f2e0d90a9 (3 commits) > > https://quiche.googlesource.com/quiche.git/+log/ba9d95e4328b..f2e0d90a970b > > $ git log ba9d95e43..f2e0d90a9 --date=short --no-merges --format='%ad %ae %s' > 2020-09-25 fayang Notify debug_visitor once any 0-RTT packet gets acknowledged. Client only (server + TLS does not send 0-RTT packets). > 2020-09-25 wub Add flag --ip_version_for_host_lookup to quic_client to indicate the preferred IP version of host address, if host lookup is needed. > 2020-09-25 quiche-dev Fix a latent query-of-death in a GFE+QUIC+Leto codepath > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > Change-Id: I8c71cc9b663b6c2287661a999b7f72a02ecf6579 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432758 > Commit-Queue: Renjie Tang <renjietang@chromium.org> > Commit-Queue: David Schinazi <dschinazi@chromium.org> > Auto-Submit: Renjie Tang <renjietang@chromium.org> > Reviewed-by: David Schinazi <dschinazi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810917} Change-Id: I089d72f0478d9d8b992a18845d6eb9edbe0e8366 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432326 Cr-Commit-Position: refs/heads/master@{#810922}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I5868cb8f31024ff4009be22a58640ab184e800f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432763Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810921}
-
Findit authored
This reverts commit 22e4c40d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810904 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzIyZTRjNDBkNWE1NmU4Njg1MDk1MmFlZDNiMDdhZGE3YzNlYzczNzQM Sample Failed Build: https://ci.chromium.org/b/8868133565492231744 Sample Failed Step: compile Original change's description: > [libvpx] Use HighBD config for ARM64 Mac > > Also adds unit tests to cover HighBD support on various platforms. > > Bug: 1128445 > Change-Id: I9951a49f0fca311f48ff55c1618f3d18343dfca8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427556 > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: James Zern <jzern@google.com> > Cr-Commit-Position: refs/heads/master@{#810904} Change-Id: I8182741ee91739c9ff313adf35ad9ab8044e081a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432878 Cr-Commit-Position: refs/heads/master@{#810920}
-
Hui Yingst authored
This CL adds supports for navigating to view destinations with fit type 'XYZ' (See table 151 in ISO 32000-1 standard for more details about syntax of "XYZ"), which specifies the coordinates of the page's origin inside the view window and the zoom factor of the page. Bug: 55776,748852 Change-Id: I4f449f006ec9dda4be282aea75c2a6e36a35b87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390997Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810919}
-
Kelvin Jiang authored
This CL logs when declarativeContent actions are added to determine usage of the API and its various action types. Note: showPageAction is not logged because it is converted internally into showAction. Bug: 1127585 Change-Id: I764bc0a518097f20f0b2522bafdf4509653b6afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415227 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810918}
-
