GitLab

TBR=simonhatch@chromium.org

Review-Url: https://codereview.chromium.org/2946463003
Cr-Commit-Position: refs/heads/master@{#480265}

Doing another VS2017 test over the week end now to see if a recently
discovered code-gen bug has been fixed. The VS 2017 package now uses
VS 2017 Update 3 Preview 2 (was Preview 1 last time). At least one
code-gen bug was fixed by Preview 2 but this bug may be a new one.

This CL is currently purely for testing purposes and will be reverted by
the end of the week end.

R=scottmg@chromium.org
BUG=683729,727671

Review-Url: https://codereview.chromium.org/2862723004
Cr-Commit-Position: refs/heads/master@{#480264}

TBR=nednguyen@google.com

Review-Url: https://codereview.chromium.org/2940423002
Cr-Commit-Position: refs/heads/master@{#480263}

Add an explicit enable command line flag in
ShellMainDelegate::BasicStartupComplete to enable this feature
for layout tests, because it is already enabled for layout tests.

R=asvitkine
TBR=avi (content/), xiyuan (chrome/browser/chromeos/login)
BUG=713889

Review-Url: https://codereview.chromium.org/2945453002
Cr-Commit-Position: refs/heads/master@{#480262}

... instead of posting tasks to FILE thread.

Bug: 689520
Change-Id: Ib2f602ac69076bf1701e7670f348260b407542c7
Reviewed-on: https://chromium-review.googlesource.com/535154Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480261}

TBR=nednguyen@google.com

Review-Url: https://codereview.chromium.org/2945603003
Cr-Commit-Position: refs/heads/master@{#480260}

Bug: 718564, 709137
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I03720b7e354d4e3d6dba621a01d40a941513c961
Reviewed-on: https://chromium-review.googlesource.com/538977
Commit-Queue: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480259}

TBR=simonhatch@chromium.org

Review-Url: https://codereview.chromium.org/2943223002
Cr-Commit-Position: refs/heads/master@{#480258}

Bug: 718564
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0d5efd019607fab0a94860ceb868986b369cdb90
Reviewed-on: https://chromium-review.googlesource.com/538926Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480257}

This allows our builders to opt out of building test targets when
building cast_test_lists. This is needed for filtering the tests that
are built on Chromecast infrastructure.

BUG=b/62722273

Change-Id: I920d27d3722d6a424a88e01d71295f9572f1f393
Reviewed-on: https://chromium-review.googlesource.com/538879Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Commit-Queue: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480256}

This CL splits WebAPK updates into two phases:
Phase #1: Compute the proto to send to the WebAPK Minting Server
Phase #2: Send the proto to send to the WebAPK Minting Server and talk to
Google Play

Phase #1 puts the data needed to do an update into an easily serializable
format. This enables a follow up CL to put the output of Phase #1 into a
org.chromium.components.background_task_scheduler.TaskInfo os.Bundle for use
with BackgroundTaskScheduler

BUG=713655

Review-Url: https://codereview.chromium.org/2933783002
Cr-Commit-Position: refs/heads/master@{#480255}

This CL fixes a nullptr dereference in some RenderProcessHost tracking
code.

BUG=734043

Review-Url: https://codereview.chromium.org/2944603002
Cr-Commit-Position: refs/heads/master@{#480254}

Made changes to s/performance/speed/, and added a speed_tracks.md file.
I expect it will need some edits, but it should serve the purpose for
now.

BUG=None
TEST=None

Change-Id: Ide102ab6e8fd326f5de52f946d2fae8774bf1d94
Reviewed-on: https://chromium-review.googlesource.com/538260Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ben Henry <benhenry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480253}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e9dc4c57fb00..57e600c76c9f

$ git log e9dc4c57f..57e600c76 --date=short --no-merges --format='%ad %ae %s'
2017-06-16 benjhayden Manage focus in overlays.
2017-06-16 rnephew [Telemetry] Allow story expectation names longer than 50 characters if its a url.
2017-06-16 nednguyen Fix style of telemetry/__init__.py

Created with:
  roll-dep src/third_party/catapult
BUG=733991,713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I36965ba9628ee21568d9d7ad1a57d87a39309164
Reviewed-on: https://chromium-review.googlesource.com/539056
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480252}

BUG: 723263
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iecab2e5ecbccf7cf604fa0528cf1ac29cccb1802
Reviewed-on: https://chromium-review.googlesource.com/538979Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480251}

PNaCl is on a path to deprecation, and GoogleDriveFs is compiled from PNaCl,
so comments are added to the implementation code to inform that GoogleDriveFs
is not going to be further developed.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Review-Url: https://codereview.chromium.org/2937083003
Cr-Commit-Position: refs/heads/master@{#480250}

Followed steps in bug. Notable changes:
- headers compilable as c99.

Bug: 707030
Change-Id: I30e7e66b3bc49f099619724899541846918509ab
Reviewed-on: https://chromium-review.googlesource.com/538923Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480249}

This reverts commit 5b9839ca.

Reason for revert: broken test

Original change's description:
> Mojo: Adapt C++ bindings to new message APIs
> 
> Replaces use of MojoAllocMessage with MojoCreateMessage et al in
> preparation for supporting lazy serialzation in the C++ bindings.
> 
> This eliminates the last remaining usage of deprecated system APIs
> (MojoAllocMessage, MojoGetMessageBuffer, MojoReadMessage, and
> MojoWriteMessage.)
> 
> Message serialization logic such as header encoding is merged into
> the Message implementation.
> 
> BUG=725321
> 
> Change-Id: I323ec330ed58f271a6769e7068a28be842688567
> Reviewed-on: https://chromium-review.googlesource.com/536415
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480214}

TBR=rockot@chromium.org,yzshen@chromium.org

Change-Id: I7ac1d6e7b2adf00d15eaf41ee2e6192efdc671f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 725321
Reviewed-on: https://chromium-review.googlesource.com/539094Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480248}

BUG=733827

Change-Id: I90c108079685d8fdaece8c8f6125d48415692cc8
Reviewed-on: https://chromium-review.googlesource.com/538552
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480247}

Moving away from using the BrowserThread's PostTaskAndReply, to
instead using a task runner to post a task to the IO thread.

BUG=689520

Change-Id: Id43dd20f3f0363be2617e75f3a3c5729ad9fade6
Reviewed-on: https://chromium-review.googlesource.com/537754Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480246}

Instead of caching the reader mode manager when the feature is shown,
this change has the infobar query the tab get the correct manager for
the current activity. This fixes an issue in multi-window mode where
the infobar would open reader mode in the incorrect window.

BUG=733965

Change-Id: Ie13de8a2cfa65c5baca182fd5dad8304a7ea465c
Reviewed-on: https://chromium-review.googlesource.com/538066Reviewed-by: Dan Alcantara <dfalcantara@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480245}

This reverts commit ef084887.

Reason for revert: depends on a cl which needs to be reverted

Original change's description:
> Remove deprecated Mojo system APIs
> 
> Renames MojoReadMessageNew and MojoWriteMessageNew to MojoReadMessage
> and MojoWriteMessage, respectively. The old versions of the latter named
> APIs are removed.
> 
> Also removes MojoAllocMessage, and the short-lived
> MOJO_GET_SERIALIZED_MESSAGE_CONTENTS_FLAG_IGNORE_HANDLES flag which is
> no longer necessary.
> 
> BUG=725321
> 
> Change-Id: I53771248b9edc0e5d66abe49a772b3c98e0fced9
> Reviewed-on: https://chromium-review.googlesource.com/537959
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480222}

TBR=jcivelli@chromium.org,rockot@chromium.org

Change-Id: I53054e87ff3743c3c18167dd08d2d82ac7f57150
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 725321
Reviewed-on: https://chromium-review.googlesource.com/539093Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480244}

https://pdfium.googlesource.com/pdfium.git/+log/1e25e122849b..2bf942d8c21b

$ git log 1e25e1228..2bf942d8c --date=short --no-merges --format='%ad %ae %s'
2017-06-16 thestig Avoid a crash inside wcsftime() on Windows.

Created with:
  roll-dep src/third_party/pdfium
BUG=733245


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Idef6a3a3f2bb27b134e1608a671b3b1173287231
Reviewed-on: https://chromium-review.googlesource.com/538999
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480243}

NOTRY=true

Bug: 732898
Change-Id: I90921402b7924e7be8b70e508c6f6dea0123b2db
Reviewed-on: https://chromium-review.googlesource.com/538882Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480242}

If you click copy to clipboard then press escape, an error will
be generated because hideClipboard() tries to close an already
closed modal dialog; instead check if it's open.

BUG=none
TEST=Open a player listed in chrome://media-internals; click the
"copy to clipboard button", press escape, observe no console
error message in JavaScript console.

Change-Id: Ice8176897aab3f1cf0d0340594ac95a480f16de6
Reviewed-on: https://chromium-review.googlesource.com/539022Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480241}

This CL converts all #ifndef NDEBUG to #if DCHECK_IS_ON() in 
"src/ios/chrome/browser/upgrade/upgrade_center.mm" so that the DCHECKs
are enabled if compiled with dcheck_always_enabled=true.

Bug: 
Change-Id: Ibead33a6a33719bed467a59b01a1f1f477ba5cc4
Reviewed-on: https://chromium-review.googlesource.com/534533
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480240}

BUG=733642

Change-Id: Ib9192137676c68b89f0fe4dce9843127e43f4b4e
Reviewed-on: https://chromium-review.googlesource.com/537144Reviewed-by: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480239}

This is done for data validation including but not limited to the
cookies servicification effort.

BUG=721395, 723734
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2898953008
Cr-Commit-Position: refs/heads/master@{#480238}

https://skia.googlesource.com/skia.git/+log/93323eb401dc..5f970fe6bed7

$ git log 93323eb40..5f970fe6b --date=short --no-merges --format='%ad %ae %s'
2017-06-16 bsalomon Fix logic error when drawing path as nested rects
2017-06-16 halcanary ICC: SkICC::WriteToICC Description Tag is function of input

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I1c626f113cc005bac998d21b49d2ef8fcf4b99f2
Reviewed-on: https://chromium-review.googlesource.com/538903Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480237}

There is no need to use a custom class to represent USB device filters.
The Mojo type plus a set of functions to perform filter matching are all
that is necessary. This allows us to delete a bunch of code and break a
circular dependency between //device/usb and the typemaps defined in
//device/usb/public/interfaces.

Bug: 731009
Change-Id: If2522e775d5521ef7fb42b63165daa4d51963074
Reviewed-on: https://chromium-review.googlesource.com/527487Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480236}

The issue is that memcpy() was used to copy (N+1) bytes from a source
that was N bytes to a destination that was (N+1) bytes. The fix is only
copying N bytes.

BUG=672263,734225

Review-Url: https://codereview.chromium.org/2943793002
Cr-Commit-Position: refs/heads/master@{#480235}

It is valid for the DSE to be null if DefaultSearchProviderEnabled
is false in the policy (see chrome://policy).

Check and appropriately handle null in all cases.

TEST=1.) Set "DefaultSearchProviderEnabled": false
     2.) Go to settings,
     3.) search engine marked as managed, disabled, and empty
TEST=1.) Set "DefaultSearchProviderEnabled": true,
         "DefaultSearchProviderSearchURL": "http://www.google.com/?q={searchTerms}",
         "DefaultSearchProviderKeyword": "google"
     2.) Go to settings
     3.) search engine marked as managed, disabled, show google

BUG=720504

Review-Url: https://codereview.chromium.org/2938403002
Cr-Commit-Position: refs/heads/master@{#480234}

BUG=733898
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng

Review-Url: https://codereview.chromium.org/2943043002
Cr-Commit-Position: refs/heads/master@{#480233}

Add logic to handle state machine corruption resolution on startup.
This patch does the following:

- Adds logic to resolve the two state machines (DownloadService and
DownloadManager).
- Iterates over all downloads in the Model at startup and figures out
the correct state.
- Once the correct state has been identified, takes the appropriate
action on the download entries.

Bug: 
Change-Id: I3fd668934ac6bfab94fc1665c3ade73de4871067
Reviewed-on: https://chromium-review.googlesource.com/538079
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480232}

Document::Shutdown() calls LocalDOMWindow::ClearEventQueue(), which
nulls out the context's event queue, before calling
ExecutionContext::NotifyContextDestroyed(). The latter eventually calls
IDBRequest::ContextDestroyed(), which aborts the request. As an aborted
IDBRequest is removed from its' IDBTransaction result queue, it may
unblock another request whose result is already available. If the
unblocked request hasn't received a NotifyContextDestroyed() call yet,
it will hang onto an ExecutionContext whose event queue has been nulled
out. Under these particular circumstances,
IDBRequest::EnqueueResultInternal will attempt to enque an event into
the ExecutionContext's null event queue.

The crash is fixed by adding a check for the null event queue case to
IDBRequest::ShouldEnqueueEvent which, conveniently, already exists.

BUG=733642

Change-Id: I1047e927fc99d5ee62880b524b45661aecdba475
Reviewed-on: https://chromium-review.googlesource.com/538965Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480231}

Switching back to proto2 greatly reduced the size. Also moving
the proto definitions in timestamp.proto to where are referenced also saved a bunch. Note that moving other proto files did not save much.

BUG=733783

Review-Url: https://codereview.chromium.org/2940393002
Cr-Commit-Position: refs/heads/master@{#480230}

BUG=716381,734193
TEST=chrome://media-internals still works

Change-Id: I1f8f1bf4bb209b84ec718ced4a34ca3190457e71
Reviewed-on: https://chromium-review.googlesource.com/538899Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480229}

Change-Id: I3607f210658c4bb9a9b9b2aeac086b664e985af3
Reviewed-on: https://chromium-review.googlesource.com/539054
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480228}

This fixes the presubmit, which was broken by a recent Closure copmiler
roll.

TBR=dmazzoni@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2939043004
Cr-Commit-Position: refs/heads/master@{#480227}

Adds a simple display for temporary and persistent storage information.

Bug: 619521
Change-Id: Ia6caabe553a4f0313fdb75d135fc021c6c19593c
Reviewed-on: https://chromium-review.googlesource.com/526735
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480226}