- 11 Apr, 2019 33 commits
-
-
Austin Eng authored
Bug: 877147 Change-Id: I7e6575b419bb1487bbcb5154a2a4ad4a45d199d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554122Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#649746}
-
Aleks Totic authored
I am trying to figure out why laying out a large table takes up twice as much memory in NG. My test case is a 100K cells table (attached to bug). When profiling, I've noticed that NGPhysicalTextFragment had rare data 96340 times. NGPaintFragment NGInkOverflowModel was being created 88360 times This patch is my attempt to improve this. With the patch: NGPhysicalTextFragment rare data is down to 82084 NGInkOverflowModel is down to 74080 The reason RareData was being created was that ink_overflow.ExpandEdgesToPixelBoundaries() local_ink_overflow = ConvertToLocal(ink_overflow) local_rect.Contains(local_ink_overflow) was false whenever ink_overflow was fractional (because it expanded). Expanding edges only if local_rect does not contain local_ink_overflow without expansion reduced the number of RareData created > 15%. There is another problem with ascents/location that causes more cache misses. I'll need @kojii's help with it. Bug: 931663 Change-Id: I586ca26024338a97263f9d324d62a4a50d53895a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535294 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#649745}
-
Austin Eng authored
This patch allows WebGPU to allocate command space up to the transfer buffer size instead of being limited to the initial starting transfer buffer size. This patch also creates SharedMemoryLimits::ForWebGPUContext(). Because WebGPU sends the majority of its commands via the transfer buffer, it is preferrable to have a larger minimum transfer buffer size and smaller command buffer. Change-Id: I31bb74dfb1075a2b6f159985b297695d57e71ed3 Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559455 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649744}
-
Nigel Tao authored
One part (in chrome/services/app_service) is the interface. The other part (in chrome/browser/apps/app_service) is the implementation, including profile-specific implementation. For example, App Publisher implementations depend on the profile, and the App Service Proxy is a convenient place to initialize those App Publishers. The latter subclasses (implements) the former. Future commits may add further subclasses of the former, especially fakes or mocks to use within tests. BUG=826982 Change-Id: Ia23c3e2a3836e56749673f2f6792e5ef160da87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552211Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649743}
-
David Staessens authored
This CL adds additional documentation to the video_decode_accelerator_tests command, describing supported parameters such as --vmodule and --metadata. TEST=ran new VDA tests on nocturne BUG=None Change-Id: Ic5a54ca404a41a6f31a47d29640a4683f83ffa8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558735 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649742}
-
Ryo Hashimoto authored
exo::Surface might be unavailable when: - Just after the Activity starts - It's getting recreated when resizing the window. BUG=925769 TEST=manually Change-Id: Ie6dbf9349aeec6f65366fb3d1f077135c0439dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493689Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#649741}
-
Noel Gordon authored
Use Promise.all to write the test image files to the file system. This allows the writes to happen in parallel. Test setup time before: 3 sec and after: 2.2 sec. The setup time is HTML fetch-bound, not I/O bound, and parallel writes only improve the I/O (write speed) component of the setup time. Bug: 935285 Change-Id: I872a111477c6fff1c692d45ed3b93d6b68d6d476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562810Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649740}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/34cbc5442a11..e6b23e45b380 git log 34cbc5442a11..e6b23e45b380 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 ynovikov@chromium.org Skip Texture2DTestES3.TextureImplPropogatesDirtyBits on Win AMD GL Created with: gclient setdep -r src/third_party/angle@e6b23e45b380 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie76c6755eb24651637551b10facb60e923963184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649739}
-
David Staessens authored
This CL adds documentation to the video_decode_accelerator_perf_tests command, describing how to run the tests. TEST=ran new VDA tests on nocturne BUG=925714 Change-Id: I8c06e9f74dea9a0462cb1b1d68de2aea2ff12d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553128 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/73904e05a2db..911b1a37708e git log 73904e05a2db..911b1a37708e --date=short --no-merges --format='%ad %ae %s' 2019-04-11 primiano@google.com Merge "traced_probes: fix CpuReaders not waking up on non-first tracing session" Created with: gclient setdep -r src/third_party/perfetto@911b1a37708e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I85e9d5502e60cadb9c450c195ff696a681cc24c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561873Reviewed-by:
-
Zhenyao Mo authored
During that period of time, COMPUTERNAME in full environment printout is listed as SWARM761-C4 instead of the real bot. This CL collects bot name from multiple places and selects one as "BUILD***". BUG=867155 TEST=manual R=kbr@chromium.org NOTRY=true Change-Id: I5ffda633449ae869885643b3927dead9f8b58758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562894Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649736}
-
David Jacobo authored
Bug: None Change-Id: I8263599f3f217e19c66fb207662a0752d8686b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562298Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649735}
-
Becca Hughes authored
Use the summary text for the artist as per the mocks. Also makes the summary text customisable outside of NotificationHeaderView. BUG=897836 Change-Id: I6b3ad378e2809844014b4b3757d16b8600e78a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554189Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#649734}
-
Shu Chen authored
Bug: 937167 Change-Id: Ibd115f247572f3d0d9e87d594594b92e98d03a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560932 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649733}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/790137c1..950150cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib111db958d2ff19262c9033f93e12cbc01cbeee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562115Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649732}
-
Timothy Loh authored
This CL adds an entry for Plugin VM in the basic settings section, as well as a sub-page which contains a button to toggle allowing printer access (not currently wired up to anything as we are still waiting on the back-end to be available). These settings entries are behind having Plugin VM set up, so will not show normally. BUG=950431 Change-Id: I40592a3420035a9746334616ddfd9a9e71a02f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553262 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649731}
-
Nektarios Paisios authored
So that ChromeVox and Select to Speak will continue to work with the new selection code, anchor and focus should be swapped if focus comes before anchor in the accessibility tree. This is achieved by introducing a new AXTreeData member, sel_is_backward, and new selectionStart/End automation APIs. R=dmazzoni@chromium.org, dtseng@chromium.org Change-Id: I7e322549760c1f8028d0d7115fe0fce1c428cd1d Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551714 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#649730}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bbbacd7c39f2..aa5c0d19ac94 git log bbbacd7c39f2..aa5c0d19ac94 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 tsepez@chromium.org Remove unused argument from CXFA_FFWidget::IsMatchVisibleStatus() Created with: gclient setdep -r src/third_party/pdfium@aa5c0d19ac94 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2dda90030186a77b93d434c5b9959cff51eae93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562603Reviewed-by:
-
Kevin Marshall authored
Update logic in gen_build_defs.py to match the SDK manifest data format transition. Bug: 951021 Change-Id: Ifaf5599e5cdecc9b32a6e285f3ca8ba36e9c48f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562759Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#649728}
-
Shu Chen authored
The InputMethodEngine needs to work with mojo-based & non-mojo-based clients in a hybrid mode. For example, the app_list window seems not using WindowTreeHostMus. Therefore, the engine needs to: - track the mojo client breakage, and can switch back to legacy mode to use IMEBridge. - mutes the FinishInput call as necessary when a non-mojo client calls FocusIn before the mojo client calls FinishInput. Otherwise it will confuse the IME extension (e.g. receives "onfocus" and later "onblur"). Bug: 937167 Change-Id: I9dc54156b6075d1636e8984d941948a680b365e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559414 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
-
David Bienvenu authored
Bug: 873414 Change-Id: Iaffc14914d658866e9d1c7e1e794a8754a5ce9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559168 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#649726}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b60f2a72fcb3..dc0c991440db git log b60f2a72fcb3..dc0c991440db --date=short --no-merges --format='%ad %ae %s' 2019-04-10 rmhasan@google.com Reland "Adds optional expectations_files and tags fields to the JSON results" Created with: gclient setdep -r src/third_party/catapult@dc0c991440db The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=skyostil@chromium.org Change-Id: I61f3e4dbee9621776cae3443089c343ed04bbe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561796Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb5bcca99989..be94a4842692 git log fb5bcca99989..be94a4842692 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@be94a4842692 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ibb8440687d66c8e7888d0aac21e9b113c540f3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561794Reviewed-by:
-
Umesh Patil authored
This was causing the no_NO and sv_SE locales to be combined into no_NOsv_SE. Bug: b/130313218 Change-Id: I679e4568f0aa8b573abf96c7588350101d3f967a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562117Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649723}
-
Abhishek Bhardwaj authored
This change adds a switch that prevents CPU throttling for the ARC container. This is needed for some ARC tests that timeout when the container is throttled. BUG=b:118696077 TEST=Manual testing. Change-Id: Ic78a8f3cc00d2b33ce8d083bfd6b84f9de246ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561050Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649722}
-
Jinsuk Kim authored
Previously Tab constructor was passed the parent tab's ID. This CL changes that by passing the parent Tab instance instead. Main motivation is to get rid of the references to TabModelSelector in Tab, which violates access in hierarchy. TabModelSelector now provides a static method for call sites that used |Tab.getModelSelector|. which is removed in this CL. Bug: 925242 Change-Id: I978d5e18078f3deddccb2b07d8d0efe302387ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516120Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#649721}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0743a1400d8b..4f74c21e2e9f git log 0743a1400d8b..4f74c21e2e9f --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4f74c21e2e9f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ied4ac41a7b07c9bcf670eb975c1609b5e0cda705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561793Reviewed-by:
-
Min Qin authored
AllDownloadEventNotifier will listen to SimpleDownloadManagerCoordinate. And report all the download events to its observers. BUG=942770 Change-Id: I29b1e573d9c1f0e8b05002499410f296b6873765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560446Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Eric Aleshire authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. I add a new helper which assists in creating NSErrors. Bug: 922813 Change-Id: Ib2fc2bb0b016afc416ccbbdae19c4acbcaf48350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553085 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649718}
-
David Staessens authored
Currently the video_decode_accelerator_tests return '0' if the test failed to even start because of missing video files or wrong parameters. This CL changes the return value so the tests will be properly marked as 'failed' in these cases. TEST=ran new VDA (perf) tests on nocturne BUG=879065 Change-Id: Ibd7fae645872c02415ee5a8dadf2cd082eb36939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551735 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Min Qin authored
If a download is on external sdcard, FileProvider won't be able to generate a content URI for the file. On some devices this will raise an exception. This CL just catches all exception in case that happens. BUG=893053 Change-Id: I3fdc35a049226970f0027dc7598a274135d9c0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562252Reviewed-by:
-
David Staessens authored
This CL increases the verbosity of error messages when loading a video or its metadata failed when running the video_decode_accelerator_tests or the video_decode_accelerator_perf_tests. This makes debugging failing tests a bit easier. TEST=ran new VDA (perf) tests on nocturne BUG=None Change-Id: I29a437d9ae95e6cd403be6844a89730e99a22dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560873 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Patrick Noland authored
Bug: 943635 Change-Id: Ib8fb4068256dd3b064e46778859bb251714dcfe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562831Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#649714}
-
- 10 Apr, 2019 7 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b4b3ea05ebde..f4c3f4562eee git log b4b3ea05ebde..f4c3f4562eee --date=short --no-merges --format='%ad %ae %s' 2019-04-10 enga@chromium.org Disable RenderPassTest.TwoRenderPassesInOneCommandBuffer on OpenGL and Metal Created with: gclient setdep -r src/third_party/dawn@f4c3f4562eee The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950768 TBR=cwallez@chromium.org Change-Id: I1dd35d2b59762160589fd7fd0fe85c35f5d62720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562068Reviewed-by:
-
chaopeng authored
The crash report shows DirectManipulation may call DirectManipulationEventHandler OnViewportStatusChanged to READY state after DirectManipulationHelper Destroyed then crash because we called Reset to invalidate DMHelper. In this CL, we pass the viewport size to DMEventHandler and use it to reset viewport at gesture end. Also DMEventHandler does not need to store pointer of DMHelper. Bug: 951293 Change-Id: I39a3402659b9ae117ab45288b68dd5d595e58457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562153 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL adds impression store that talked to the level database that persists impression types. Bug: 930968 Change-Id: I6e1074901f78a8a4fc23fd33d77507426edc89fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560490 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Bug: 947154 Change-Id: If5d8ce33b7c54e0b33e89354ec81c23f92990138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559208 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649710}
-
Scott Violet authored
This makes it easier to correlate changes in ash with that in the browser. BUG=951015 TEST=none Change-Id: I3d0ce9f15a69cd83f837b2ea10f6dc1f1c0f8d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562754Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649709}
-
sczs authored
There's a crash where the containerStack array is being created using a nil Object. Since all 3 the objects are created in the same scope the possible reason is that the reference to this objects is being released before being added to the ViewHierarchy, so no strong reference is ever created. An alternative would be keep the button as weak but create a local variable that holds the button in the meantime. This alternative was chosen to be consistent with the other properties and since there shouldn't be a way the UIButton can have a strong reference to the VC. Bug: 951170 Change-Id: Ib9d172dafc1282d2e08ef75fbc1f1f7a67951016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562750 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#649708}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b9516868546e..bbbacd7c39f2 git log b9516868546e..bbbacd7c39f2 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 thestig@chromium.org Use early returns in CXFA_LayoutPageMgr::CreateViewRecord(). 2019-04-10 thestig@chromium.org Add CXFA_LayoutPageMgr::CreateViewRecordSimple(). Created with: gclient setdep -r src/third_party/pdfium@bbbacd7c39f2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iabadd6968115251d32c6cdb62acd9e58823d4b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561784Reviewed-by:
-
