- 03 Nov, 2020 40 commits
-
-
Mohamed Heikal authored
The extra_application_definitions is still used by downstream manifests even if not used upstream. Change-Id: I610bb6c50df2ed828c503b4567c1bc0bfc3a8f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517624Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823590}
-
Alexander Lapshenkov authored
For GCC 8.4.0 is important to get all the first initializer in designated init-list in case of implicit construction. Correct compile if use explicit construction. Error example (GCC 8.4.0): -c ../../ui/events/platform/x11/x11_event_source.cc -o obj/ui/events/platform/x11/x11/x11_event_source.o ../../ui/events/platform/x11/x11_event_source.cc: In function ‘void ui::{anonymous}::InitializeXkb(x11::Connection*)’: ../../ui/events/platform/x11/x11_event_source.cc:78:4: error: no matching function for call to ‘x11::Xkb::SelectEvents(<brace-enclosed initializer list>)’ }); Change-Id: I80ea8d5f0a14bb8edc1e89e66eb6d1034bd1fec3 Bug: 819294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516219Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#823589}
-
Elly Fong-Jones authored
Instead, have HUDDisplayView::Toggle explicitly create and configure a WidgetDelegate. This change also adds callbacks for widget initialization steps to WidgetDelegate. Bug: 1075649 Change-Id: Ia48270e7d7431abbfdf0c6d58988d4846a1ed8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511409Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#823588}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. This CL also includes a simplied flow by consolidating TpmAttestationDoesKeyExist and TpmAttestationGetCertificate, of which results come from the same methods of attestation service anyway. BUG=b:158955123 TEST=chromeos_unittests. Change-Id: I29734d7a2b5546e60f9af599c656ade7dc6ea210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513949 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823587}
-
James Vecore authored
This is Nearby Share launch bug where the discussion for this change happened: https://crbug.com/1071222 Change-Id: I2c15ad2377016b9c9bd5001f7549c1be45dc67e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512548 Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823586}
-
Clemens Arbesser authored
This adds the UI only. This is not yet functional, because the link to native is not yet implemented. I plan to submit the necessary native CLs first and then do the required JNI plumbing to stitch everything together. Keeping things separate makes for easier developing and (hopefully) reviewing. See screenshot of the UI in the attached bug. Bug: b/171776026 Change-Id: Ic7da1904a6a3c33d19c780c7dd5b9450599ba443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510053 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#823585}
-
Ben Mason authored
Bug: 1131716 Change-Id: Ief5778daf229c1da55f78c8b58a13f0e9f49d1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517699Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#823584}
-
Mohsen Izadi authored
Currently, as soon as we notice a frame needs to be produced while processing an event, a copy of its EventMetrics is saved for reporting. The plan is to add the timestamp of when the processing of the event is done (on both compositor and main threads) to this object to be included in reports. To allow this, the copy of the object should be saved after the processing is done and the timestamp is added. This CL changes EventsMetricsManager to get a callback for its scoped monitor instead of a pointer to the metrics object. The callback will be called when the scoped monitor is destroyed (i.e. when the event processing is finished). The client code can update metrics object as appropriate and return it to EventsMetricsManager if necessary. Also, if the metrics object is supposed to be saved, the client code can safely move the object to EventsMetricsManager as it won't need it anymore. Bug: 1054009 Change-Id: I503bf64171f08f8233d7f738304b0e2e3a96da31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488549Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823583}
-
Robbie McElrath authored
This CL adds the ability to specify a script in an android_aar_prebuilt rule that can modify prebuilt jar files, and adds a script to change Fragment.getActivity() and Fragment.requireActivity() to return an Activity instead of a FragmentActivity. This is the first CL in a chain that will allow us to remove the fake activity we create when embedding Fragments that cross classloader boundaries. Bug: 1123216 Change-Id: I4b9d3ca5f9c3a4d86e08d64f49d601c08fca9a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432413Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ed8bd0453f73..d550bebee919 2020-11-03 courtneygo@google.com Fix build error with Chromium & ANGLE (#2446) 2020-11-02 dev@creatingtrouble.com Add new SpirvToolsDisassemble API interface + Improve Doc on existing API interface (#2442) 2020-11-02 justsid@widerwille.com Support for CapabilityShaderViewportIndex and CapabilityShaderLayer (#2432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I23d0f1bd2ee18ebc9b77832e8bfb6a7e7e8df8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517600Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823581}
-
Clemens Arbesser authored
The intended use case is for a single instance of this class to be shared with all trigger scripts. The combined set of selector conditions will be extracted and is then repeatedly evaluated as necessary. Trigger scripts will simply access the cached results, rather than invoke their computation themselves. This keeps the actual element lookup separate from the trigger scripts, and should also be much more efficient for the common use case where two trigger scripts only differ by is_first_time_user or some other static trigger condition. Bug: b/171776026 Change-Id: I48fad77e32abdfbf39f9414d159b31047b6fba32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514422 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Michael Checo authored
Spec: http://shortn/_3CsQ13LODA Screenshot: http://shortn/_wsgjicXnSz Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: Ifc823668a2576e3dc36d08494c06f75db53d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511490 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#823579}
-
Mark Yacoub authored
Make the name more explicit. BUG=N/A TEST=ozone_unittests Change-Id: I99d670333dae9244c34e02ea62e869c7b4e85644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517419Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#823578}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9bed95f88a26..df4236e338ac 2020-11-03 aerotwist@chromium.org TypeScriptify LiveHeapProfile.js 2020-11-03 jacktfranklin@chromium.org Introduce enableLegacyPatching flag for CSS patching 2020-11-03 tvanderlippe@chromium.org Use TypeScript-authored files in issues/ 2020-11-03 aerotwist@chromium.org TypeScriptify GCActionDelegate.js 2020-11-03 aerotwist@chromium.org TypeScriptify Layers3DView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511,chromium:1127902 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f53f7466e97b151624a42cf7e47877638eb341f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516918Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/86f1234a4be8..df4c267aa2c7 2020-11-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-03 ziegs@chromium.org ambassador: add ambassador to puff branch builder 2020-11-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-02 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I7610fe85db86e5fce31dc29e33493c455cb3c9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517599Reviewed-by:
-
Michael Thiessen authored
This reverts commit 9f35be80. Reason for revert: clank rolls all failed, not sure why the clank bot I added didn't fail on my change. Original change's description: > Remove content/ CriteriaNotSatisfiedException > > Part 3 of a 3-sided change to move CriteriaNotSatisfiedException to > base/ > > Bug: 1134178 > Change-Id: Ie76869351d8a09bd92205e3aef3ffea65220c01a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515520 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823553} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: I0ae020b9af62053f500a9f304c8fb9f9552c657e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517382Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823575}
-
Chris Sharp authored
Specify defaults for: DeviceAllowRedeemChromeOsRegistrationOffers ExternalProtocolDialogShowAlwaysOpenCheckbox MaxInvalidationFetchDelay NtlmV2Enabled SafeBrowsingForTrustedSourcesEnabled SamlInSessionPasswordChangeEnabled ShowAppsShortcutInBookmarkBar SpellcheckEnabled SpellcheckServiceEnabled WPADQuickCheckEnabled Bug: 1139046 Change-Id: Ic3c3b568baa61dd691e94daff631471540221bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512549Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#823574}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a77ad8657484..eb999bce4f0f 2020-11-03 robertphillips@google.com Fix GrThreadSafeCache's abandonContext behavior If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: Ie82b7f9131b3b7f71c09e4ef87e06feb2deea77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516914Reviewed-by:
-
Mario Bianucci authored
Delegated ink trails should only ever been drawn on the root render pass as all of their points are transformed to be in the root coordinate space and they are drawn on top of everything. Therefore, make sure that they are only drawn on the root render pass. Bug: 1144354 Change-Id: Ic954e7d9b93895b493c03a89d4fab4e3711b1ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511757Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823572}
-
Etienne Bergeron authored
Linux requires the presence of a base::DiscardableMemoryAllocator for some fonts handling. This initialization code is taken from the gfx_unittest harness see: ui/gfx/test/run_all_unittests.cc The fuzzer incorrectly reports them as bugs since a nullptr is deferenced. Bug: 1144855 Change-Id: Idfc0888b69fac8a3380659b5469bff0acaa6e806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511697 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#823571}
-
Ian Kilpatrick authored
This patch adds tests for -webkit-fill-available, and changes the legacy implementation to behave like NG does. Bug: 981321 Change-Id: If45f4021c2bcc6d738b7b4cadb24eb285f599860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514381 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#823570}
-
Jeffrey Kardatzke authored
This adds the H265Decoder (modeled after the H264Decoder) with only handling of SPS/SPS. BUG=chromium:1141237,b:153111783 TEST=media_unittests Change-Id: Ia2dc95675b9c200626e96c500ed91fb4ba27b6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515040Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#823569}
-
Clemens Arbesser authored
This CL also adds more log messages to make debugging those kinds of errors easier in the future. The bug was introduced in a refactoring some time ago, where the special handling for empty access tokens was lost and there was no unit test to catch this. Bug: b/170934170 Change-Id: Ib251a84fd032f6b72b278bc87aad2a8f48c8df9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517441 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Majid Valipour authored
Matchs content/public/android/java/src/org/chromium/content/browser/sms/OWNERS Bug: None Change-Id: I95165d25f01225c2ba07f3e749d6a9c085d918f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517380 Auto-Submit: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823567}
-
James Hollyer authored
Pointer Lock Options was not set up to run tests while enabled. This CL fixes that and then fixes the necessary tests so that all runs smoothly when the flag is enabled by default. Bug: 1124396 Change-Id: Ie1d9b431b89a4cce77023d9c3aadad4e2d824be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431459Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Chris Sharp authored
List the defaults for: AccessibilityImageLabelsEnabled AdsSettingForIntrusiveAdsSites AllowScreenWakeLocks ClientCertificateManagementAllowed CrostiniArcAdbSideloadingAllowed DeviceCrostiniArcAdbSideloadingAllowed Bug: 1139046 Change-Id: Ib9325f5739f1c353356af4fd574d126db3f2042b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514619 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/33fdba02..ba40ae7e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2f3e4f59a04026e3030436bec38e7a683ec63fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517140Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823564}
-
Peter Kasting authored
Bug: 772945 Change-Id: I44ef7ea9c2e4e7f770860016fc5f1e205e2d1212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516882 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823563}
-
Aleks Totic authored
Make all rows share the same TableConstraintSpaceData by replacing it if we are reusing the fragment. Bug: 958381 Change-Id: I7647d69d930218f1dfaac2cefdd8a49ba936ceaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511431 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#823562}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/W59w4eCMof8bZydvlzS33CNelnDp1ZjryOeIUy5x1Z8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162468431,b/170172788 Tbr: media-app@grotations.appspotmail.com Change-Id: Idb89546d3bfe436d6bd94717a2810598af329c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516912Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823561}
-
Jan Wilken Dörrie authored
This change implements checking a password for weakness after it has been modified in the Desktop Password Check UI. In case the new password is / remains weak, and will be added / kept in the section of weak passwords. Fixed: 1142377 Change-Id: I03ffc9c087059926fe3f12a50594317235f5383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514379 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#823560}
-
Denis Kuznetsov authored
Bug: 1144159 Change-Id: I8e945efe328bface5181a3e42155b88801a1c794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510134 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#823559}
-
David Van Cleve authored
The CSP data structures in Blink currently use a value of 0 to denote an unspecified or default-valued port in CSP source expressions. However, origins can also have ports explicitly set to 0. In order to resolve behavior inconsistencies between blink::SecurityOrigin, which currently doesn't support port 0, and url::Origin, which does, we're updating blink::SecurityOrigin to distinguish port-0 origins from origins with unspecified (default-valued) ports. This makes SourceListDirectiveTest.GetSources CSP tests fail, because it means that a "self" CSPSource created by ContentSecurityPolicy::SetupSelf from an origin with the default port will no longer have the same port as a CSPSource created by parsing a host-source source expression with no port. To fix this, we update CSPSource's port_ member to have a new default state denoting an unspecified or default-valued port, distinct from the value 0 which now specifically represents port 0. Bug: 1136678 Change-Id: Ic386fc2ba31e13c95676ecf050e24874d4af132e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477044 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823558}
-
Vidhan authored
Added tests for inserting the states data consisting of UTf8 strings in AlternativeStateNameMapUpdater. Bug: 1111960 Change-Id: Iee96de3ceb3b6c3726d7bffc685aab29293c23f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513215Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#823557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2c5003d7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I6bc3af89ca1ffbb19e1bc550c2822535eba1e2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517139Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823556}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I25cb100a0724ae4d66aa8759f97124d9fcfb3b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515135Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#823555}
-
Caitlin Fischer authored
The status quo test compares the actual header with the header returned by GetClientDataHeaders(). However, as discussed in [1], the important thing to verify is that the GOOGLE_WEB_PROPERTIES_SIGNED_ID-associated VariationID is included in the header when expected. Similarly, update the UserNotSignedIn test to check that the ID is not included in the header. Also, remove CreateTrialAndAssociateId() from the browser test file since it now exists in variations_test_utils.h. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2461906/comment/d6233bfd_454a08ff/ Bug: 1134444 Change-Id: I22101a138f930e2b1cfaf4ba3f74211eb87c9a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508338Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#823554}
-
Michael Thiessen authored
Part 3 of a 3-sided change to move CriteriaNotSatisfiedException to base/ Bug: 1134178 Change-Id: Ie76869351d8a09bd92205e3aef3ffea65220c01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515520Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823553}
-
Michael Checo authored
Spec: http://shortn/_O6M4tRc5EQ Screenshot: http://shortn/_mosolq202i Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: Icb29009332fea0de87eefacd82259ab695109a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506302 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#823552}
-
Peter Marshall authored
We are no longer passing the API key to the frontend to perform the survey so this CL deletes getAPIKey which is not used. The devtools frontend now triggers the existing Chrome HaTS impl to run the survey. CanShowSurvey will be used to determine whether we show the survey link in the devtools frontend, and then ShowSurvey will be used when the link is clicked. Bug: 1112738 Change-Id: Ia456e419c2678cfe6c90976d82af8d37f1ac435f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509570 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#823551}
-
