Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 07 Jun, 2016 22 commits
  3. 06 Jun, 2016 18 commits
    • erikchen's avatar
      Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const... · 41b2e7da
      erikchen authored 
      Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const (patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15: error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue of type 'const blink::CSSValue *'
    CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20TSan%20Builder/builds/23734/steps/compile/logs/stdio

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
>
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
>
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
>
> BUG=526586
>
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586

Review-Url: https://codereview.chromium.org/2042113002
Cr-Commit-Position: refs/heads/master@{#398156}
      41b2e7da
    • jessicag's avatar
      Add user agent to System Context Getter as suggested by metrics team. · 117048d2
      jessicag authored 
      Currently the user agent is set to empty string which results in the
upload being ignored by the metrics service.

Setting this value will allow for processing and display of metrics
for Blimp.

BUG=592757

Review-Url: https://codereview.chromium.org/2041933002
Cr-Commit-Position: refs/heads/master@{#398155}
      117048d2
    • fdoray's avatar
      Remove use of deprecated MessageLoop methods in rlz. · 67dc362c
      fdoray authored 
      MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2033863003
Cr-Commit-Position: refs/heads/master@{#398154}
      67dc362c
    • sebmarchand's avatar
      Use /LTCG:Incremental to speed up the non-clobber official builds. · 98fccebb
      sebmarchand authored 
      /LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this.

Review-Url: https://codereview.chromium.org/2045683002
Cr-Commit-Position: refs/heads/master@{#398153}
      98fccebb
    • rkjnsn's avatar
      Refactor ResizingHostObserver tests · 7142e66c
      rkjnsn authored 
      Remove a couple of possible sources of dangling pointers and make the
tests cleaner and more compact.

Review-Url: https://codereview.chromium.org/2038183002
Cr-Commit-Position: refs/heads/master@{#398152}
      7142e66c
    • sashab's avatar
      Make CSSComputedStyledeclaration::getPropertyCSSValue return const · 5896ec29
      sashab authored 
      Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

BUG=526586

Review-Url: https://codereview.chromium.org/2034013002
Cr-Commit-Position: refs/heads/master@{#398151}
      5896ec29
    • dschuyler's avatar
      [MD settings] google-grey to paper-grey · 38ed4344
      dschuyler authored 
      This CL replaces some uses of the non-existent
--google-grey-600 with --paper-grey-600

BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2010283003
Cr-Commit-Position: refs/heads/master@{#398150}
      38ed4344
    • fdoray's avatar
      Remove use of deprecated MessageLoop methods in blimp. · f928849b
      fdoray authored 
      MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2034703003
Cr-Commit-Position: refs/heads/master@{#398149}
      f928849b
    • thakis's avatar
      Switch CrWinClang to gn again. · 9b6d81f1
      thakis authored 
      This relands parts of https://codereview.chromium.org/1947183004/
Now that clobber runs as a separate step before runhooks, swarming should work
on gn clobber bots.

BUG=498033

Review-Url: https://codereview.chromium.org/2043743003
Cr-Commit-Position: refs/heads/master@{#398148}
      9b6d81f1
    • pdr's avatar
      Prevent synchronous image change notifications during paint · 45eef1a2
      pdr authored 
      Image changed notifications are used by animated images to notify
LayoutObject clients that they need to repaint. These notifications
typically result in paint invalidations. Animated bitmap images have
some logic[1] to handle "falling behind" which would synchronously
fire image changed notifications during paint. This results in missed
paint invalidations as well as a changing layout tree out from under
the paint system.

This patch moves the synchronous image change notifications to an
immediate task which occurs after paint has completed.

[1] When painting animated gifs on a heavily loaded system (or a debug
build), pauses in the system can cause the animation to get behind.
When this happens, we want to advance the animation and catch-up but
prevent the next frame from using the same catch-up logic which could
get us in an infinite catch-up loop.

BUG=616700

Review-Url: https://codereview.chromium.org/2038243002
Cr-Commit-Position: refs/heads/master@{#398147}
      45eef1a2
    • dpranke's avatar
      Flip Win bots on tryserver.chromium.perf to GN. · 52cf5270
      dpranke authored 
      TBR=dtu@chromium.org
BUG=605318

Review-Url: https://codereview.chromium.org/2045693003
Cr-Commit-Position: refs/heads/master@{#398146}
      52cf5270
    • jbudorick's avatar
      [Android] Ensure test names are unique during retry determination. · eba90f11
      jbudorick authored 
      BUG=604568

Review-Url: https://codereview.chromium.org/2032253004
Cr-Commit-Position: refs/heads/master@{#398145}
      eba90f11
    • enne's avatar
      Revert of mac: ensure ui::Compositor exists for visible RWHVs (patchset #12... · d5d349f0
      enne authored 
      Revert of mac: ensure ui::Compositor exists for visible RWHVs (patchset #12 id:220001 of https://codereview.chromium.org/2005013002/ )

Reason for revert:
Causes blank tabs, tab switching perf tests

BUG=617497,617427

Original issue's description:
> mac: ensure ui::Compositor exists for visible RWHVs
>
> RenderWidgetHostViewMac is careful about creating ui::Compositor and so
> currently only does this in Show and SwapCompositorFrame.  However, if
> it the RenderWidgetHostView is created while the RenderWidgetHost is
> visible, then Show will early out and never create a ui::Compositor.
>
> This causes problems with begin frame scheduling, which wants to have
> the Display (which is created as part of creating the ui::Compositor's
> output surface currently) own the real begin frame source that drives
> everything.  In that world, if no ui::Compositor exists, no frames ever
> are sent or swapped.  So, the ui::Compositor needs to be created first.
>
> Also, if the ui::Compositor is correctly created during Show (or the
> constructor), then there's no need to ensure that it exists during
> swap compositor frame, and so that can be safely removed.
>
> R=asvitkine@chromium.org,ccameron@chromium.org
>
> Committed: https://crrev.com/9af6c23da7070f9423d5cf25856ed27f7d5d8e5e
> Cr-Commit-Position: refs/heads/master@{#397755}

TBR=phajdan.jr@chromium.org,asvitkine@chromium.org,ccameron@chromium.org,danakj@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2040013002
Cr-Commit-Position: refs/heads/master@{#398144}
      d5d349f0
    • erikchen's avatar
      telemetry, mac: Add more simple scrolling power tests. · 3885ecfd
      erikchen authored 
      These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2034123002
Cr-Commit-Position: refs/heads/master@{#398143}
      3885ecfd
    • yuweih's avatar
      Script to inline shader into C header file · 26219410
      yuweih authored 
      OpenGL compiles shader code as text at runtime. It is inconvienent to
edit shader code as const char[] inside the C++ source code.

This CL contains script that reads file contents, turns them into const
char[], and combine them into a header file.

BUG=385924

Review-Url: https://codereview.chromium.org/2036023003
Cr-Commit-Position: refs/heads/master@{#398142}
      26219410
    • janeliulwq's avatar
      Changed two icons for desktop user menu on Linux/Windows: · b877548e
      janeliulwq authored 
      1. Changed the icon for the "Manage people" button;
2. Changed the icon for sync error on the titlebar.

See design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz

This CL is dependent on https://codereview.chromium.org/2028473002/

BUG=615893

Review-Url: https://codereview.chromium.org/2019053002
Cr-Commit-Position: refs/heads/master@{#398141}
      b877548e
    • fdoray's avatar
      Revert of Remove use of deprecated MessageLoop methods in ipc. (patchset #1... · 471891bc
      fdoray authored 
      Revert of Remove use of deprecated MessageLoop methods in ipc. (patchset #1 id:1 of https://codereview.chromium.org/2037853002/ )

Reason for revert:
MessageLoopForIO::current() has a DCHECK but ThreadTaskRunnerHandle::Get() doesn't. See discussion https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Wj_cNO2l2qE

Original issue's description:
> Remove use of deprecated MessageLoop methods in ipc.
>
> MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
> are deprecated. This CL makes the following replacements to
> remove some uses of these methods:
>
> "MessageLoop(ForUI|ForIO)::current()->PostTask" ->
>   "ThreadTaskRunnerHandle::Get()->PostTask"
> "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
>   "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
> "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
>   "ThreadTaskRunnerHandle::Get()->DeleteSoon"
> "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
>   "ThreadTaskRunnerHandle::Get()->ReleaseSoon"
>
> In files where these replacements are made, it adds these includes:
>   #include "base/location.h"
>   #include "base/single_thread_task_runner.h"
>   #include "base/threading/thread_task_runner_handle.h"
>
> And removes this include if it is no longer required:
>   #include "base/message_loop/message_loop.h"
>
> Why ThreadTaskRunnerHandle::Get() instead of
> MessageLoop::current()->task_runner()?
>  - The two are equivalent on threads that run a MessageLoop.
>  - MessageLoop::current() doesn't work in base/task_scheduler
>    because the scheduler's thread don't run MessageLoops.
>    This CL will therefore facilitate the migration of browser
>    threads to base/task_scheduler.
>
> Steps to generate this patch:
> 1. Run message_loop_cleanup.py (see code on the bug).
> 2. Run tools/sort-headers.py on modified files.
> 3. Run git cl format.
>
> BUG=616447
> R=cpu@chromium.org
>
> Committed: https://crrev.com/2eb9714a01e03a8b091a8ea34f023e24f62e5a9f
> Cr-Commit-Position: refs/heads/master@{#398040}

TBR=cpu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616447

Review-Url: https://codereview.chromium.org/2038363004
Cr-Commit-Position: refs/heads/master@{#398140}
      471891bc
    • catapult-deps-roller's avatar
      Roll src/third_party/catapult/ 8f31b02e7..2b7a13d86 (1 commit). · 1115180c
      catapult-deps-roller authored 
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8f31b02e7cdf..2b7a13d86594

$ git log 8f31b02e7..2b7a13d86 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2044663002
Cr-Commit-Position: refs/heads/master@{#398139}
      1115180c