GitLab

BUG=

Review URL: https://codereview.chromium.org/341603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278209 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/212303003,
update_screen.cc doesn't need the command line switch related
headers anymore. So we can remove these.

BUG=349033

Review URL: https://codereview.chromium.org/334403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322395

Change-Id: Ie0376052892349f18db5d60737f6329b8c92eb1c

Review URL: https://codereview.chromium.org/333003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278207 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278206 0039d316-1c4b-4281-b951-d872f2087c98

r278198 broke official build bots. This change should fix it.

BUG=134215
TBR=wez@chromium.org

Review URL: https://codereview.chromium.org/342873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278205 0039d316-1c4b-4281-b951-d872f2087c98

r278198 broke official build bots. This change should fix it.

TBR=wez@chromium.org
BUG=134215

Review URL: https://codereview.chromium.org/340303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385222
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/342853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278201 0039d316-1c4b-4281-b951-d872f2087c98

We hook onMaximized so that if the user maximizes the window, it automatically full-screens. This allows us to get the same behaviour if the user double-clicks the title bar or uses some other OS shortcut to maximize the window as we get if they clicks the maximize button. However, it's not a particularly clean transition to full-screen mode, especially on Mac, and I suspect it's the root cause of the referenced bug (though I can't repro it). This CL simplifies the common case of maximizing via the window control, which gives a much smoother UX.

BUG=384678

Review URL: https://codereview.chromium.org/338373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134215
R=weitaosu@chromium.org, wez@chromium.org

Review URL: https://codereview.chromium.org/342583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278198 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces the abstract API definitions for BluetoothGattConnection
and BluetoothDevice::CreateGattConnection, which are used to manage the life
time of a GATT connection among multiple apps that request it.

BUG=384620

Review URL: https://codereview.chromium.org/336933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278197 0039d316-1c4b-4281-b951-d872f2087c98

Currently we do a walk over all tiles in the pending tree's pile, but
there can be 1 million x 1 million tiles on some pages, which makes this
method take multiple _seconds_ to complete.

These loops were added in r184525 which gave the tradeoffs that led to
them, which are that we want to only use a single pile for all the tiles
on this layer, but we don't want raster tiles on the active layer (when
this activates) that can't be rastered by the pile they are attached to.

Instead of walking every pile-tile, to find the tiles that are not
present in the current recording and invalidate them, we expand
invalidations outside the interest rect to cover the full recording tiles,
and we expand invalidation inside the interest rect to include any raster
tiles that don't have a recording (such as in the offscreen animating gif
case). We give this expanded invalidation to the pending layer, causing
it to drop rastered tiles from the active tree that intersect with an
unrecorded area.

R=enne
BUG=371839

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277964

Review URL: https://codereview.chromium.org/294163009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373917
R=rsleevi@chromium.org
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/340883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278195 0039d316-1c4b-4281-b951-d872f2087c98

To support imageWriterPrivate on Mac for the Chromebook Recovery Tool we will have to write to USB drives on Mac.  OS X allows us to open a single FD with elevated privileges through running the authopen command.

Unmounting and claiming the disk are a bit more complicated as they require use of the Disk Arbitration framework.

Disk Arbitration is an asynchronous interface.  In order to simplify the code we use a mutex to block.

The core logic is derived from the previous recovery tool.  See googleclient/chrome/chromeos_recovery/mac/ChromeOSRecovery/AppController.mm in the internal Google repositories.

BUG=376398
BUG=318451

Review URL: https://codereview.chromium.org/294163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278194 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/342773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278193 0039d316-1c4b-4281-b951-d872f2087c98

The URLRequestJobManager will now crash if there is not one.
This is part of the work aimed at eliminating the JobManager.

BUG=142945

Review URL: https://codereview.chromium.org/332833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278192 0039d316-1c4b-4281-b951-d872f2087c98

This test fails consistently on Linux Tests (dbg) (1)

[ RUN      ] PDFExtensionTest.BasicPlugin
...
[1023:1023:0618/142028:INFO:CONSOLE(0)] "[SUCCESS] testPageSize", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://127.0.0.1:42118/pdf/test.pdf (0)
[17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully.
[17:17:0618/142028:ERROR:pepper_uma_host.cc(106)] Host or histogram name is not allowed to use the UMA API.
[17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully.
memory allocation bug: object at 0x7f5a852272c0 has never been allocated
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f9e4351c8b5 base::debug::StackTrace::StackTrace()
#1 0x00000462f8f2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f9e2fb2f4a0 \u003Cunknown>
#3 0x7f9e2fbe1a43 __poll
#4 0x7f9e30917ff6 \u003Cunknown>
#5 0x7f9e30918124 g_main_context_iteration
#6 0x7f9e434e49e5 base::MessagePumpGlib::Run()
<truncated, full output is in gzipped JSON output at end of step>
#31 0x7f9e34f05dc7 content::RunNamedProcessTypeMain()
#32 0x7f9e34f074df content::ContentMainRunnerImpl::Run()
#33 0x7f9e34f0528b content::ContentMain()
...

> Re-enable PDFExtensionTest.BasicPlugin
> 
> This test was disabled because it was failing. A few changes have been made:
> -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
> -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
> -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).
> 
> BUG=303491
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186
> 
> Review URL: https://codereview.chromium.org/290803007

TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/346693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278191 0039d316-1c4b-4281-b951-d872f2087c98

I'm excluding this instead of suppressing it to keep it consistent with lsan, and  to avoid hiding real issue on other tests.

BUG=386080
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/340213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278187 0039d316-1c4b-4281-b951-d872f2087c98

> [fsp] Cleanup handling errors for operation requests.
> 
> This CL removes redundant internal functions which are identical, and replaces
> them with one.
> 
> Moreover, the new general purpose error API function, passes now the entire
> value to the request manager. This is because, very soon, we are going to
> pass extra information with every error and success responses and we want to
> have access to them in the RequestManager.
> 
> NOTRY=true
> TEST=unit_tests, browser_tests: *FileSystemProvider*
> BUG=373165, 384201
> 
> Review URL: https://codereview.chromium.org/335753004

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/342003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278186 0039d316-1c4b-4281-b951-d872f2087c98

Added new V2 QA app. Removed old canary that we no longer use.

BUG=385726
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/344643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278185 0039d316-1c4b-4281-b951-d872f2087c98

The crash in the bug seems to be triggered by empty labels. This should avoid the crash if that's the case.

R=dmichael@chromium.org, kenrb@chromium.org
TBR=xians@chromium.com

BUG=383074

Review URL: https://codereview.chromium.org/323313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278184 0039d316-1c4b-4281-b951-d872f2087c98

(It was missed on initial profile refactor.)

BUG=374914
R=mef@chromium.org

Review URL: https://codereview.chromium.org/341653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278183 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting@chromium.org,gbillock@chromium.org
BUG=382921,375401

Review URL: https://codereview.chromium.org/343773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278182 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't support PNaCl yet.

TBR=raymes@chromium.org

BUG=367896,386271

Review URL: https://codereview.chromium.org/347623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278181 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for https://codereview.chromium.org/341573003/
On Lucid, libelf-dev:i386 couldn't be installed in parallel to the 64bit
version. So nacl has a hack to remove -m32 flags from a target that depends
on libelf, to make a target_arch=ia32 on a 64bit system with multilibs work.

In precise, libelf-dev:i386 can be installed in parallel, so do so as a
prerequisite for removing this hack.

BUG=368384
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/347663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278180 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove EnableThreadedCompositing from the browser. (https://codereview.chromium.org/337783002/)

Reason for revert:
Broke virtual/implsidepainting/inspector/timeline, made them use single threaded compositor (and impl side painting).

Original issue's description:
> Remove EnableThreadedCompositing from the browser.
> 
> Now only --disable-threaded-compositing exists, which is only present
> for layout tests. The --enable-threaded-compositing flag moves to
> become a content shell flag only, as it's only used for DumpRenderTree.
> 
> Change any checks in the renderer process for kEnableThreadedCompositing
> to instead be !kDisableThreadedCompositing since that is the only
> flag left.
> 
> Remove the whole threaded compositing thing from about:gpu and
> about:flags.
> 
> R=piman
> BUG=384381,346363
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278151

TBR=piman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384381,346363

Review URL: https://codereview.chromium.org/344703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278178 0039d316-1c4b-4281-b951-d872f2087c98

Restrict increase of button inset to linux only. This will allow the Windows Classic theme to maintain its look, while the updated linux look is still available. This returns the inset size on non-linux platforms to their state pre r272576

BUG=381821

Review URL: https://codereview.chromium.org/336553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=noelallen@chromium.org, sbc@chromium.org
TEST=udpate_nacl_manifest_test.py TestUpdateManifest.testUpdateBionic

Review URL: https://codereview.chromium.org/343703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379862
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/343743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278168 0039d316-1c4b-4281-b951-d872f2087c98

This fixes tty output handling for ppapi_simple-based applications.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/341893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374383
R=bbudge@chromium.org, danakj@chromium.org

Review URL: https://codereview.chromium.org/341893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278165 0039d316-1c4b-4281-b951-d872f2087c98

(1) 1-time migration of MACs from local state to Preferences/Protected Preferences.
(2) Migrate MACs between Preferences/Protected Preferences according to configuration changes.

Proposed follow-up tasks are:

(1) Introduce TrackedPreferencesMigrationDelegate
(2) Introduce protections to prevent unintended stamping of the super MAC.
(3) Expanded test coverage of PrefHashFilter
(4) Expanded test coverage for legacy migration in TrackedPreferencesMigrationTest

BUG=372547, 368480
R=asvitkine@chromium.org, gab@chromium.org

Review URL: https://codereview.chromium.org/324493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278164 0039d316-1c4b-4281-b951-d872f2087c98

Causes compile errors on Linux

TBR=jamesr

Review URL: https://codereview.chromium.org/331383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278163 0039d316-1c4b-4281-b951-d872f2087c98

I only tested this on Linux. Some of the other platforms still have TODOs and parts missing. We can fill these out when they're required.

BUG=
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/339263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278157 0039d316-1c4b-4281-b951-d872f2087c98

[This reland also fixes an issue with the label drawn on top of the old
profile switching menu. It also expands ExtensionApiTest.Bookmarks
disabling from just Windows to Windows and Linux.]

This also converts the TextButtons in the BookmarkBarView to
LabelButtons, since they need to have the same base class as MenuButton
does. This also standardizes on fade eliding instead of fade eliding
sometimes and ellipsis eliding in other cases.

This patch has the effect that everything on the bookmark bar also
renders with GTK+ borders in GTK theme mode on Linux.

BUG=155363,331924,385934,383452
R=msw@chromium.org, noms@chromium.org
TBR=msw@chromium.org, sky@chromium.org
First Review URL: https://codereview.chromium.org/298813002

Review URL: https://codereview.chromium.org/344643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370596
For c/b/resources:

R=asvitkine@chromium.org, michaelpg@chromium.org
TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/335953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278154 0039d316-1c4b-4281-b951-d872f2087c98

Due to the 11 bit limitations for exponents in double precision, it's possible
to overflow when calculating the backoff amount. Check for this overflow and
drop back to the max backoff delay if necessary.

BUG=373181
R=cbentzel@chromium.org

Review URL: https://codereview.chromium.org/337803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278153 0039d316-1c4b-4281-b951-d872f2087c98

Now only --disable-threaded-compositing exists, which is only present
for layout tests. The --enable-threaded-compositing flag moves to
become a content shell flag only, as it's only used for DumpRenderTree.

Change any checks in the renderer process for kEnableThreadedCompositing
to instead be !kDisableThreadedCompositing since that is the only
flag left.

Remove the whole threaded compositing thing from about:gpu and
about:flags.

R=piman
BUG=384381,346363

Review URL: https://codereview.chromium.org/337783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278151 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384430

Review URL: https://codereview.chromium.org/345433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278150 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/339943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278149 0039d316-1c4b-4281-b951-d872f2087c98

* This adds support for AEC dump files in multiple tabs and if multiple getUserMedia calls are made in one tab.
* Each AEC dump consumer registers with the browser to recieve a file handle when AEC dump is enabled.
* Add dedicated aec dump message filter an messages file.
* Works with and without track-processing.

NOTRY=true

BUG=350347

Review URL: https://codereview.chromium.org/334743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278148 0039d316-1c4b-4281-b951-d872f2087c98