GitLab

BUG=chromium:671511
TEST=unit_tests --gtest_filter='Arc*'
TEST=trybot

Review-Url: https://codereview.chromium.org/2580713004
Cr-Commit-Position: refs/heads/master@{#441891}

Now that Navigator's suppelemnt can access the Navigator object via host(),
it doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2615153002
Cr-Commit-Position: refs/heads/master@{#441890}

Note: This affects the sizing of the icons some, requiring a few layout changes, but they are mostly minor.

Tested in MD Settings, Options (old settiings), OOBE, and chrome://network.

BUG=611258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592383003
Cr-Commit-Position: refs/heads/master@{#441889}

Makes these callbacks visible from other .cpp files.

BUG=617892

Review-Url: https://codereview.chromium.org/2617933002
Cr-Commit-Position: refs/heads/master@{#441888}

The complexity of the old tests had gotten out of hand; Telemetry's
benchmark infrastructure was not a good match for what were ideally
imperative-style tests.

These tests were ported one-by-one and tested along the way. They
should be a 1:1 match in terms of functionality. In the new test
harness, skip expectations work properly and don't run the test body
on any platform, so some of the logic which avoided yielding certain
tests on certain platforms has instead been expressed as test
expectations.

Delete the has_transparent_visuals_gpu_process and
no_transparent_visuals_gpu_process tests, which had become no-ops.

This is the last reference to the python code in
content/test/gpu/page_sets. Delete it and the associated lint
presubmit check.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2611263002
Cr-Commit-Position: refs/heads/master@{#441887}

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487, 678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2618523004
Cr-Commit-Position: refs/heads/master@{#441886}

This change refactors CSSValueInterpolationType to not override
CSSInterpolationType::maybeConvertSingle() and instead
use the more specific conversion functions as is the norm.

This change is part of supporting smooth interpolation of
registered custom properties. More complex behaviour will be
added to CSSInterpolationType::maybeConvertSingle() which must
be shared with the CSSValueInterpolationType subclass.

There are no changes in behaviour made by this patch.

BUG=671904

Review-Url: https://codereview.chromium.org/2614613002
Cr-Commit-Position: refs/heads/master@{#441885}

BUG=653398
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2618633002
Cr-Commit-Position: refs/heads/master@{#441884}

We no longer rely on setTimeout timing.

BUG=248938

Review-Url: https://codereview.chromium.org/2615123002
Cr-Commit-Position: refs/heads/master@{#441883}

BUG=

Review-Url: https://codereview.chromium.org/2617823003
Cr-Commit-Position: refs/heads/master@{#441882}

left/padding/width/height...
Replaced NGSizeIndefinite with Optional<LayoutUnit>

Fixed a couple of minor bugs where AvailableSize was incorrect.

Passing ~30 more tests.

BUG=635619

Review-Url: https://codereview.chromium.org/2616613003
Cr-Commit-Position: refs/heads/master@{#441881}

https://pdfium.googlesource.com/pdfium.git/+log/4a551f5570b3..469f6da247ff

$ git log 4a551f557..469f6da24 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 tsepez use unique_ptr in cxfa_layoutprocessor.h

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2614103003
Cr-Commit-Position: refs/heads/master@{#441880}

Added CSSPropertyAPITextUnderlinePosition which implements
CSSPropertyAPI for the text-underline-position property.
Parsing logic is the same as before, just was moved from
CSSPropertyParser to the .cpp file. Added flag to
CSSProperties.in so that the .h file will be generated.

BUG=668012

Review-Url: https://codereview.chromium.org/2614903002
Cr-Commit-Position: refs/heads/master@{#441879}

Currently a callback passed on the second time is discarded when StopWorker
message is sent twice. This patch fixes it by not calling EWInstance::Stop twice
and not sending the StopWorker message before StartWorker message.

BUG=674443
TEST= ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master 'http/tests/serviceworker/chromium/resolve-after-window-close.html' --no-retry-failures --order=random --iterations=100 --exit-after-n-crashes-or-timeouts=1

Review-Url: https://codereview.chromium.org/2578023002
Cr-Commit-Position: refs/heads/master@{#441878}

NOTRY=true
TBR=sashab@chromium.org

BUG=663855

Review-Url: https://codereview.chromium.org/2617883003
Cr-Commit-Position: refs/heads/master@{#441877}

doesn't appear in test results (thanks to Alan for pointing it out).

Instead we should focus on writing good test descriptions.

BUG=

Review-Url: https://codereview.chromium.org/2617083002
Cr-Commit-Position: refs/heads/master@{#441876}

These UseCounters will allow an investigation into how often alert(),
confirm(), and prompt() are called for sites with different engagement
levels.

BUG=644268

Review-Url: https://codereview.chromium.org/2610813006
Cr-Commit-Position: refs/heads/master@{#441875}

BUG=348655

Review-Url: https://codereview.chromium.org/2568133007
Cr-Commit-Position: refs/heads/master@{#441874}

https://pdfium.googlesource.com/pdfium.git/+log/c4fcad23b143..4a551f5570b3

$ git log c4fcad23b..4a551f557 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 tsepez Remove two unused members in cpdf_streamcontentparser.
2017-01-05 dsinclair Cleaning up memory allocation in CXFA_FM2JSContext - III

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2611163004
Cr-Commit-Position: refs/heads/master@{#441873}

If the window is in the trusted pinned mode,
we do not expect that can enter into another mode, e.g.
maximized/minimized/fulscreen mode, without explicit
unpin action by client.

BUG=665943
TEST=Ran trybots. Tested in ARC kiosk mode, and the apps can continue
     to run on a pinnded window.

Review-Url: https://codereview.chromium.org/2590123002
Cr-Commit-Position: refs/heads/master@{#441872}

IgnorableExceptionState is equivalent to DummyExceptionStateForTesting.
We should just use DummyExceptionStateForTesting.

BUG=

Review-Url: https://codereview.chromium.org/2614013003
Cr-Commit-Position: refs/heads/master@{#441871}

(1) Add counters for popup actions (desktop only in this CL.)
(2) Add unittest.

"Dismiss" is not counted, because it's not very meaningful for desktop
popup actions; There is no single dismiss button, and count in
destructor will count all the displays.

BUG=650132

Review-Url: https://codereview.chromium.org/2588273002
Cr-Commit-Position: refs/heads/master@{#441870}

This CL tests that the views external protocol dialog behaves correctly
when it is Accepted, Canceled, and Closed. In particular, the status of
the dialog's checkbox is verified; when the dialog is Closed without
a definite user choice of Accept or Cancel, it is ensured that the
checkbox is always reported as unchecked. This is to prevent dismissing
the dialog from accidentally persisting a permanent block on external
protocols.

The dialog is not used on ChromeOS, so the test is only run on Linux,
Windows, and MacViews.

BUG=671658

Review-Url: https://codereview.chromium.org/2610793002
Cr-Commit-Position: refs/heads/master@{#441869}

https://crrev.com/2558743002 fixed loading.mobile on Nexus5 WebView and
page_cycler_v2 on Nexus5/Nexus6 WebView, but loading.mobile on Nexus6
WebView is still failing.

BUG=676612
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2613153005
Cr-Commit-Position: refs/heads/master@{#441868}

We force a style recalc at the start, so a transition occurs.

We wait for the compositor before declaring the test complete.

BUG=248938

Review-Url: https://codereview.chromium.org/2614883005
Cr-Commit-Position: refs/heads/master@{#441867}

Revert of Make FTP directory parser less strict (patchset #3 id:40001 of https://codereview.chromium.org/2608213002/ )

Reason for revert:
Fails on all platforms.

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/62042

Original issue's description:
> Make FTP directory parser less strict
>
> FTP directory listing returns empty result if encoding detection or
> conversion fails. This CL puts less strict constraint on conversion
> so that the whole list can survive some filenames with broken chars
> and be shown to users. Other browsers seem to work this way.
>
> The broken chars can happen due to wrong encoding detection, which
> cannot be avoided 100%, as reported in the bug.
>
> BUG=676762
> R=mmenke@chromium.org, phajdan.jr@chromium.org
>
> Review-Url: https://codereview.chromium.org/2608213002 .
> Cr-Commit-Position: refs/heads/master@{#441856}
> Committed: https://chromium.googlesource.com/chromium/src/+/ed3ef90ecc3c01246a3d838fbeefdab72c94c228

TBR=phajdan.jr@chromium.org,mmenke@chromium.org,jinsukkim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=676762

Review-Url: https://codereview.chromium.org/2614103002
Cr-Commit-Position: refs/heads/master@{#441866}

These UseCounters will allow an investigation into how often
navigator.vibrate is called for sites with different engagement levels.

BUG=655415

Review-Url: https://codereview.chromium.org/2614913005
Cr-Commit-Position: refs/heads/master@{#441865}

This CL adds delete bookmarks and folders function and copy URL function.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2613683002
Cr-Commit-Position: refs/heads/master@{#441864}

By default, closing a dialog on Views using the Esc key behaves as if
the secondary button was pressed. In the external protocol handler, this
can create a state where the user inadvertently blocks external
protocol launching for a particular scheme with no way to allow them
again. This occurs when they tick the checkbox to always open links, but
then use Esc to close the dialog. Until UI to edit external protocol
settings is implemented, this permanently prevents any dialogs from
the page for that scheme.

This CL addresses part of the bug by ensuring that closing the external
protocol dialog without interacting with the buttons ignores the checkbox
state.

BUG=671658

Review-Url: https://codereview.chromium.org/2559783003
Cr-Commit-Position: refs/heads/master@{#441863}

This converts 1 of the 2 existing ChromeViewMsg_SetContentSettingRules
uses. Converting the other will be a separate commit.

BUG=577685

Review-Url: https://codereview.chromium.org/2582203003
Cr-Commit-Position: refs/heads/master@{#441862}

https://pdfium.googlesource.com/pdfium.git/+log/7855a2c57745..c4fcad23b143

$ git log 7855a2c57..c4fcad23b --date=short --no-merges --format='%ad %ae %s'
2017-01-04 dsinclair [libtiff] Fixup unitialized access issue
2017-01-05 dsinclair Cleaning up memory allocation in CXFA_FM2JSContext - II
2017-01-05 tsepez Banish CFX_Points, CFX_PointsF, and CFX_RectFArray to XFA-side only.
2017-01-05 npm Fix bCJK calculation in Windows MapFont

BUG=677377

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2615183002
Cr-Commit-Position: refs/heads/master@{#441861}

BUG=670150
TEST=manually with and without the background video track optimization flag.

Record time between the play or seek and when the player has enough
data for both audio and video renderers.

Review-Url: https://codereview.chromium.org/2552493002
Cr-Commit-Position: refs/heads/master@{#441860}

Reland of Make run_webkit_tests random order by default for all platforms (patchset #1 id:1 of https://codereview.chromium.org/2617563002/ )

Reason for revert:
Re-land

Original issue's description:
> Revert of Make run_webkit_tests random order by default for all platforms (patchset #2 id:20001 of https://codereview.chromium.org/2591933002/ )
>
> Reason for revert:
> fast/text/ellipsis-stroked.html started failing on some Linux and Mac bots.
>
> Original issue's description:
> > Make run_webkit_tests random order by default for all platforms.
> >
> > BUG=671805
> > R=dpranke@chromium.org,qyearsley@chromium.org
> >
> > Committed: https://crrev.com/86c477efe2039ae9f9970313769f337d8606ca95
> > Cr-Commit-Position: refs/heads/master@{#441424}
>
> TBR=dpranke@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=671805
>
> Committed: https://crrev.com/c51ad71bc112439aedbc8c8e1906f9ea098da9cc
> Cr-Commit-Position: refs/heads/master@{#441465}

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671805

Review-Url: https://codereview.chromium.org/2612083003
Cr-Commit-Position: refs/heads/master@{#441859}

Revert of cros: Small visual tweaks for material design palette. (patchset #2 id:20001 of https://codereview.chromium.org/2608343002/ )

Reason for revert:
Fails to build on Linux ChromiumOS Builder (dbg) since SkColorSetARGB is not a constexpr function

Original issue's description:
> cros: Small visual tweaks for material design palette.
>
> BUG=678034
>
> Review-Url: https://codereview.chromium.org/2608343002
> Cr-Commit-Position: refs/heads/master@{#441800}
> Committed: https://chromium.googlesource.com/chromium/src/+/9abb5f3f351b0d3831f79da9980a00db4d7d4815

TBR=stevenjb@chromium.org,jdufault@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678034

Review-Url: https://codereview.chromium.org/2614063005
Cr-Commit-Position: refs/heads/master@{#441858}

If a PDF file is loaded via a link click with a history.replacestate call
in the pagehide/pageshow event for the main html page, we get a DidStartNavigation
notification on the guest webcontents created for the EmbeddedObserver.
Currently we abort the stream if it is a top level navigation.
It seems like we should not abort the stream if the navigation is within the same page.

The problem does not occur if the PDF is opened in a different tab or window

Should fix the black PDF issues with M55.

BUG=677580
TEST=Covered by browser test PDFExtensionTest.OpenPDFOnLinkClickWithReplaceState

Review-Url: https://codereview.chromium.org/2611643004
Cr-Commit-Position: refs/heads/master@{#441857}

FTP directory listing returns empty result if encoding detection or
conversion fails. This CL puts less strict constraint on conversion
so that the whole list can survive some filenames with broken chars
and be shown to users. Other browsers seem to work this way.

The broken chars can happen due to wrong encoding detection, which
cannot be avoided 100%, as reported in the bug.

BUG=676762
R=mmenke@chromium.org, phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2608213002 .
Cr-Commit-Position: refs/heads/master@{#441856}

https://skia.googlesource.com/skia.git/+log/3afa628e50e3..b38db9a48db0

$ git log 3afa628e5..b38db9a48 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 brianosman Revert "Hard code bicubic coefficients in the shader"

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2614043003
Cr-Commit-Position: refs/heads/master@{#441855}

There's no longer a PageState mismatch from bug 617239, so we can
re-enable the test expectations for these tests.

BUG=236848, 617239
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2614913002
Cr-Commit-Position: refs/heads/master@{#441854}

This is so a single line comment can be used to exclude <if> in .js
files. I've added tests for both <include> and <if>. They need to be
commented for clang-format purposes.

BUG=678778
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2615953002
Cr-Commit-Position: refs/heads/master@{#441853}

ViewResourceAdapter re-uses bitmaps where possible. The app icons
drawn into the quick action ImageView have transparent backgrounds,
so when the bitmap is re-used some of pixels do not get re-drawn
making it look like two app icons are layered on top of each other.

Setting a background on the quick action ImageView causes all
pixels to get redrawn when the bitmap is captured.

BUG=678708

Review-Url: https://codereview.chromium.org/2615753005
Cr-Commit-Position: refs/heads/master@{#441852}