- 02 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/813ef3dc0d5e..fcafd5b49266 2020-11-02 rharrison@google.com Roll 6 dependencies (#1144) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: If81b91776cce18dabffaf0eb9b6b37a697054d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823212}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a41e47b6f39..5d35d2afddac 2020-11-02 alexrudenko@chromium.org Add justify-content icons to the styles panel 2020-11-02 aerotwist@chromium.org TypeScriptify JavaScriptREPL.js 2020-11-02 aerotwist@chromium.org TypeScriptify CookieItemsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3903b007259087e46d99fa49a5e7c5102a16b096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514175Reviewed-by:
-
Patrick Noland authored
This will allow it to continue to function as logic migrates out of LocationBarLayout. SearchActivity-specific logic remains in SearchActivityLocationBarLayout for now. Change-Id: I1a32a6fbfd584590b982ecb4c8639664e752819d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495785 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#823210}
-
Sam Maier authored
This is a reland of ecd51275 This reland should be safe - the revert looks to be for an unrelated problem, probably a 2 sided patch that temporarily broke. Original change's description: > Re-enabling aar .info file checker > > Bug: 1143257 > Change-Id: I88d02690152aa3dabeece3d6cd937d1e3f61a1a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508329 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822760} Bug: 1143257 Change-Id: Id9af6e8b9f00a3cb0554ecd1fa9250983af0e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514358 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823209}
-
Ying Ye authored
Devices sometimes need to upload extra debugging information within a crash report. This CL makes it optional for devices to upload additional states. Bug: internal b/171233251 Test: triggered crash and checked crash report Change-Id: I696fa84e6719a3e6ec336bd2b3f07d622e7fd75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507576Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Ying Ye <yingye@google.com> Cr-Commit-Position: refs/heads/master@{#823208}
-
Mason Freed authored
With this CL, several changes will be shipped: 1. There is now an ElementInternals.shadowRoot attribute, which gives custom element authors access to the element's shadowRoot, even in the case of closed shadow roots. Note that shadow roots that are attached prior to the custom element constructor being run will *not* be accessible via this attribute. 2. The attachInternals() API can no longer be called *prior* to the custom element constructor being run. This preserves the security of the ElementInternals interface, by preventing inline script from "stealing" it before the custom element is upgraded. This feature now has landed specs [1]/[2] and three LGTMs on the I2S thread [3]. Shipping it! [1] https://github.com/whatwg/html/pull/5909/files [2] https://github.com/whatwg/html/pull/5912/files [3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/uWcvDbzyIBk Fixed: 1140609 Bug: 1042130 Change-Id: I634fa8e9b45ec501fc87d5c05728b96e7f409d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508849Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#823207}
-
Jordan Oroshiba authored
Updating the icons and removing headline used for previous Page Info page Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1077766#c75 Bug: 1077766 Change-Id: Ib9463a832bc3680b45ec4b69c01d3e8e119ca2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468343 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#823206}
-
Dave Tapuska authored
This mode is only used for flash. So we can now remove this dead code. BUG=1143755 Change-Id: Ice89932b0060c3170fc2707caf888fce59d0fd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508289Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#823205}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dcd4fb3a509b..584ab491091a 2020-11-02 jmadill@chromium.org GN: Export tracing include directory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1144469 Tbr: sadrul@google.com Change-Id: I435cd4c6540ed6bdc0f4d221135467a945cb0fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514166Reviewed-by:
-
Peter Boström authored
Also replaces some overrides with simple setters of modality and close button. Bug: 1128500 Change-Id: Id6c7d64553970d076966c52da9646a034f877a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511630 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#823203}
-
Jan Wilken Dörrie authored
This reverts commit d3742a4b. Reason for revert: https://crbug.com/1144431 Bug: 1144431 Original change's description: > [base] Add NO_UNIQUE_ADDRESS attribute > > This change adds the HAS_CPP_ATTRIBUTE and NO_UNIQUE_ADDRESS macros to > base/compiler_specific.h. This allows using the C++20 no_unique_address > attribute in prior dialects if the compiler supports it. > > Bug: None > Change-Id: I6aff82e7b195f5eaf93551049c9dfa6a3fd1fbc6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510396 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822768} TBR=dcheng@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I375099e835dbc7d4cab98cc15faf66124335bb0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514208 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823202}
-
Elizabeth Popova authored
Change-Id: Idf26e18bb75a8761c99099b7c247309b1a690e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514399Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#823201}
-
Nohemi Fernandez authored
Adds test to cover the Advanced Sync Settings section of the "Manage Sync" page. Bug: 1125631 Change-Id: Ic4cde0a1bc03e111a71dc5a04bf3c3865ba1941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507550 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#823200}
-
Ben Pastene authored
crrev.com/i/3372943 allocates the machines, so this should wait for that to land before proceeding. Bug: 1140727 Change-Id: Id91cbeb7091fb9368dffc2d577bc9cf4873721af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510434Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#823199}
-
Shubham Agrawal authored
With this change, PiiElider does not elide those suspected URLs which resolve to a class or a method name (for the latter, we check if the substring ending right before the last period resolves to a class name). Bug: 1108920 Change-Id: I002c1e243ba33b5576e52f6479b54290bbbfbdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363811Reviewed-by:
-
Ian Kilpatrick authored
If we ran simplified layout, or triggered layout from a subtree-root the baseline of the fragment may have changed. While most of the time this doesn't have any visible side-effect, there may be an arbitrary ancestor which relies on this baseline, causing elements to be baseline aligned incorrectly. This patch does two things: 1) When simplified layout is triggered from simplified layout, check if the Baseline shifted, and return nullptr. 2) When we are being laid out as a subtree root (as an inflow element), check if the Baseline shifted, and mark our containing block chain for layout. Bug: 1137905 Change-Id: I8c8fa2c981e9001cf6ec7f685d4451e1fe13c848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509644Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#823197}
-
Mikel Astiz authored
This patch deprecates metric Bookmarks.Count.OnProfileLoad.DuplicateUrl in favor of the new similar metric Bookmarks.Count.OnProfileLoad.DuplicateUrl2. Differences include: 1. Among bookmarks with the same URL, one of them is now excluded as duplicate (to distinguish the authoritative copy from duplicates). 2. A higher max bucket is used, now 100K instead of 10K, in consistency with metric Bookmarks.Count.OnProfileLoad.DuplicateUrl. 3. The implementation doesn't use hashing of URLs, since there's a simple and efficient way to implement the same logic in UrlIndex. This may influence slightly the recorded metrics, if users ran into hash collisions. 4. Because the implementation is trivially efficient, the feature toggle is cleaned up (was enabled by default anyway). Change-Id: If736305846f3deac74439834b546cb5b9d0601f4 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510401Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#823196}
-
Jeroen Dhollander authored
The code to initialize the |AssistantManager| was quite complex because it had to handle the fact that |AssistantManager| was created on a background thread, and that this background task could be triggered multiple times before it ever finished. To simplify this the |AssistantManager| (and its related classes) is now owned by an |AssistantManagerController| that will: * Ensure the |done_callback| is invoked only once, even if multiple controllers are created (we achieve this by storing the controller in a unique_ptr and ensuring it only calls the callback if the controller was not deleted, meaning only the last controller will call the callback). * Not access the |assistant_manager_| field from the background thread, meaning it can always safely be accessed from the main thread. This simplification will make it easier to move the Libassistant process to a sandbox. Bug: b/171748795 Test: chromeos_unittest --gtest_filter="AssistantManagerServiceTest.*" Change-Id: Icfce1163d5253713094145b5d7e7c637057527c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500452 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823195}
-
Jesse McKenna authored
This change fixes an issue where PWA custom icons were not showing up in the Open With menu on Windows when a PWA is registered as a file handler on Windows. A PWA's custom icon is located at: <user data>/<profile>/Web Applications/<app ID>/<app name>.ico Currently, the value of DefaultIcon as registered with Windows is: <user data>/<profile>/Web Applications/<app ID>/<app name>.exe/<app name>.ico Windows fails to find the icon file and instead displays a generic icon. This is caused by GetIconFilePath() being passed |app_launcher_path| (which has value <app name>.exe) as its |web_app_path| parameter. This change replaces that argument with the path to <user data>/<profile>/Web Applications/<app ID>. Bug: 1143966 Change-Id: I4744b9866c85f570c3e9bd794d83a6abb6cd97eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508648Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#823194}
-
Jordan Oroshiba authored
Replacing the URL with the text for preview UI message text, replacing favicon with the lite page logo. Screenshot: https://crbug.com/1077766#c82 Bug: 1077766 Change-Id: Ic236e12ac678881b6bace346bbaf5d89b7c7052b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503577 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit f55e9981. Reason for revert: https://crbug.com/1144431 Bug: 1144431 Original change's description: > [base] Use NO_UNIQUE_ADDRESS in flat_tree > > This change makes use of NO_UNIQUE_ADDRESS in flat_tree, allowing the > removal of an internal class which just existed to make use of the empty > base optimization. > > Bug: 682254 > Change-Id: Iabf91d4acee95c7ba4e929d23528d95b0ced1612 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509757 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822948} TBR=dcheng@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 682254 Change-Id: If3b15e15241e8f8b5d99b80caadbb25153648f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514147Reviewed-by:
-
Zach Trudo authored
In ExtensionInstallLogUploader the ReportQueueConfig wasn't correctly building the ReportQueueConfig. Bug: chromium:1078512 Change-Id: Ifd0b495536b3b5b5153193a4e9d29e3a1b66b0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505682 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#823191}
-
Rohit Agarwal authored
This CL removes the deprecated Profile#getOffTheRecordProfile method which invoked Profile#getPrimaryOTRProfile internally. The remaining callers of getOffTheRecordProfile are updated to directly call getPrimaryOTRProfile instead. The code requiring primary OTR profile would rely on invoking the method Profile#getPrimaryOTRProfile explicitly instead. Bug: 1060940 Change-Id: I72301c22b48e51262678673cbd4066a835c76089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513650 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#823190}
-
Matt Jones authored
This patch migrates all of the layout/compositor-specific animation classes and tests to the new "layouts" module. Bug: 1070281 Change-Id: If9fb504933f1e0adcc38a2e4b34800f7193a572d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503830 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#823189}
-
Tanmoy Mollik authored
This cl creates a version of the SigninPromo Test when MOBILE_IDENTITY_CONSISTENCY is enabled. Bug: 1142467 Change-Id: I5c7d6503c5e6c2867a43713a0ba2f957f541513e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505811Reviewed-by:
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: I02646e7e9b7428a5f9ad41a07e80ef00ca5ef2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505394 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823187}
-
Andre Le authored
Update battery icon in phone status to indicate phone's battery saver mode. This includes: - Moving BatteryImageSource in ash/system/power to a public class so that Phone Hub can extends. - Creating PhoneHubBatteryImageSource and showing battery saver mode. Bug: 1106937,1126208 Change-Id: I93bbf244148c1dc51fe5d5ee18293da2fff9c0ea Fixed: 1143374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507384Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#823186}
-
Dominique Fauteux-Chapleau authored
This is to better represent what the function actually does. This is only a rename and doesn't change any existing behaviour. Bug: 1098437 Change-Id: I06888a8e6994dcaf327c48e14681b953a8cd5dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510194 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823185}
-
Nicolas Ouellet-Payeur authored
This is needed to enable DestroyProfileOnBrowserClose by default in automated tests (crrev.com/c/2503629). ConfigurationRefresher did not clean up its SyncObserver properly when it received the OnSyncShutdown() event, causing a failed DCHECK() in browser tests. Bug: 88586 Change-Id: Ib37846afd26470563d58639e9fddff4928ffe907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510797Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#823184}
-
Dave Tapuska authored
The response from CreatePopupWidget is no longer used. So this method can be async. The browser will still allocate routing IDs for popup widgets though because there are a few global tables that it uses to track widgets based on the routing ID. BUG=1097816 Change-Id: I4a2dea41e7c796423d7072a72753b4e168f8261d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510790Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#823183}
-
Mirko Bonadei authored
Without this, the test fails to run because the filter file doesn't get isolated. Bug: 1143697 Change-Id: I810319036b68e5cd073652c1abc800f9f6eee1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514150Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#823182}
-
Francois Doray authored
My team is working on power consumption at least for the next year. This CL extends the expiry of histograms that we'll use to track our efforts. Fixed: 1138308 Change-Id: Ie4c59081f3cac36b99b952ec5c88bdabbe16aa87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510780 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Leo Lai authored
FakeCryptohomeClient doesn't have any exsiting test items after re remove TpmAttestationSignSimpleChallenge. BUG=b:158955123 TEST=build ok. Change-Id: Ib533e261d1733f4449e2b3a783757279a35eefdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504011 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/5bee67fced90..74023424daa4 2020-11-02 dneto@google.com Remove stale TODO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sarahmashay@google.com Change-Id: If9b9664e8b9de096024f38efc3df20bf37d7bbde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514234Reviewed-by:
-
Nicolas Ouellet-Payeur authored
This is needed to enable DestroyProfileOnBrowserClose by default in automated tests (crrev.com/c/2503629). This caused issues during shutdown in browser tests, because TestSyncService behaved differently than ProfileSyncService. Bug: 88586 Change-Id: Ie3c6f202d251411eb316edd77180855ec0e9bc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511072Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in deep_scanning_browsertest.cc to use Connector policies directly instead of the indirect helpers that map to legacy policies. It also removes now unused DeepScanningClient{Request|Response} references from those tests. Bug: 1109242 Change-Id: I39f7d0cb1231d8f494ac7c58460eafee91691a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510239Reviewed-by: -
Jérôme Lebel authored
When the sign-in is successful in add_account_signin_coordinator.mm, an identity is needed. Change-Id: Ie1c930a7f07f4b1c14ae1a48c638df7c4644aa0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514398 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#823176}
-
Jan Krcal authored
This is a reland of d42167eb Compared to the original CL, this CL minimizes the changes in the test that was failing on Win7. Original change's description: > [Dice sync delegate] Split sync confirmation and sync disabled > > This CL splits the ShowSyncConfirmation() function of the dice turn on > sync helper delegate into one that shows the normal sync confirmation > and one that shows a error message that sync is disabled by the admin. > > Since both the dialogs are implemented by the same webUI page, there > is not much behavioral change. The only change is for the delegate > for the signed-in profile creation flow which opens a new browser > window and shows the dialog in this window instead of showing it in > the creation flow window. > > In follow-up CLs, the variant of the UI will be passed as a param > to the WebUI page replacing the logic to decide which variant to show. > > Bug: 1126913 > Change-Id: Ibac9a339c4fb071f960f15864482c818247f5719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487100 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820222} Bug: 1126913 Change-Id: I741140df31b8ca91fe5eb1a05a643fc0d2401f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495069 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823175}
-
Glenn Hartmann authored
BUG=1140066 Change-Id: I68726e9d31bf935e1bba04a8b07f8e86057b3e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510529 Auto-Submit: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic782c3df395360cc3c6c01540edcabb68a8bcbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514173Reviewed-by:
-
