- 20 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2051b8bf0523..e24557f51eec git log 2051b8bf0523..e24557f51eec --date=short --no-merges --format='%ad %ae %s' 2019-09-20 nisse@webrtc.org Declare api:libjingle_peerconnection_api dependency on media:media_base Created with: gclient setdep -r src/third_party/webrtc@e24557f51eec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I0e7c07f5beef0ac3be534a4cfc2f14f59f23e3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698418}
-
Marina Sakai authored
To access private properties of a V8 object, we need a v8::Private as a key for each property. V8PrivateProperty provides its wrapper class "Symbol" as a shorthand API. Currently, V8PrivateProperty has two types of APIs to get Symbol. One is a macro-generated function, which needs to be managed by hand. And the other is string-based mapping, which defers the management of the mapping to V8. This CL adds a new API to get a Symbol (wired with a unique v8::Private) from a key pointer. All the current Symbol getters will be replaced with this new API. Also uses it to access private properties to keep-alive objects. Bug: 715418, 1005601 Change-Id: I29735fdf5b8748c6dc7f57f91f8c5ebd5e5991b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810511 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#698417}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c4ff5ddab07..8f2d41d1be9d git log 6c4ff5ddab07..8f2d41d1be9d --date=short --no-merges --format='%ad %ae %s' 2019-09-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src caca1d1cc46e..f7a48b153f2a (1 commits) Created with: gclient setdep -r src/third_party/angle@8f2d41d1be9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I024f35ec1dac5dc27f1e86f5a36ee4626bcd99fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815672Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/052b14753bfa..b819e877d74f Created with: gclient setdep -r src-internal@b819e877d74f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie64cd68d76beb49c4ad5943f693e552dc8dcc1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816180Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698415}
-
Jeonghee Ahn authored
Fixed bug where adjacent elements were incorrectly get HOVER. The left-top position of an element is not perfect coordinates for fake mouse hover. So I added 1 pixel. I'm not sure this solution is correct for all cases. But, I can't leave this bug. If there is a better way, please guide me. Bug: 982187 Change-Id: I60501ffeb07baba85e97e52fa9a4c69cea7ca1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782206Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Cr-Commit-Position: refs/heads/master@{#698414}
-
Thomas Tangl authored
The outer margins view is replaced by specifying the outer margins using the property kMarginsKey. Bug: 995720 Change-Id: I1c2ad9414dd24188aa528f85aa367872672cfdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813356Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#698413}
-
Ian Struiksma authored
renderframe count updates. new cipd version update to DEPS as well as made some fixes to recipe files Enabled: modcloth timberland collage newegg ticket_master walmart_ca worldmarket (re-recorded) Bug: 996478,984664 Change-Id: I59d76f0e7e55997614938e31e857b5b7003a83a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815500 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#698412}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5272dd9. With Chromium commits locally applied on WPT: cc2a9ab7 "Add missing step_func in wpt/svg/animations/scripted/onhover-syncbases.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: If9b44d0c9f8a66ad5b9c9f4195b57b4fec5a7243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815796Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/debdeb70..e3d2c1e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1148d6243d1394bff388d554573f844b4dbdd2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815795Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698410}
-
Wei-Yin Chen (陳威尹) authored
This is an identical reland of 1dc90fac after http://crbug.com/1004663 is fixed. Original change's description: > Populate the distilled content slightly earlier > > Before this CL, the distilled content is injected on DidFinishLoad(), > or when the distillation finishes if it's later than DidFinishLoad(). > When the DidFinishLoad() event propagates to TalkBack, the distilled > content is usually not there yet, so TalkBack would announce the > content of the place-holding page. > > This CL populates the distilled content in DocumentLoadedInFrame() > instead of DidFinishLoad(). DocumentLoadedInFrame() is late enough to > execute JavaScript, and is early enough so that it's more likely that > the title and content can be picked up by TalkBack instead of the > placeholder. > > If distillation is finished by DocumentLoadedInFrame(), onload() event > would also be delayed, so that the accessibility focus is more likely > to be on the web content. Otherwise, the focus is usually on the close > button of the CustomTab (CCT), or nowhere. > > Note that this CL doesn't guarantee the distilled title is announced > by TalkBack. If distillation finishes later than > DocumentLoadedInFrame(), or if for some reason the accessibility focus > is on the close button of the CCT, the title would go unannounced like > before. > > Bug: 811417, 803474 > Change-Id: Iaf2ff988b427ca9af582622597b505e7a8aca8e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791048 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697074} TBR=mdjones@chromium.org Bug: 811417, 803474, 1004663 Change-Id: Icbb871422ff3e173179d4250c26985081d9fa22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809967Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698409}
-
Eric Willigers authored
Test helper functions are introduced in web_app_browsertest_util.h BookmarkAppTest is renamed to WebAppEngagementBrowserTest. The test no longer references extensions. TBR=calamity@chromium.org Bug: 966290 Change-Id: I630fa2873766a5a2955fe96f91008fd3bb9bc84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787761Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#698408}
-
Austin Tankiang authored
The old logic for constructing these paths were taken from the legacy drive client code, and returned completely wrong paths for DriveFS. It turns out this doesn't matter because nothing uses these paths. In any case, change it to return relative drive paths for now. Bug: 1003238 Change-Id: I6ff75ca18c80acc7af976dc97801f7ac66bf70e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808981 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#698407}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/04ebb2a000ee..5327092bb28b git log 04ebb2a000ee..5327092bb28b --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ramakrishnan.nikhil@gmail.com [woff2] Fix memory leaks. Created with: gclient setdep -r src/third_party/freetype/src@5327092bb28b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I19b4f293d3599fbea68f1f218bf8f967252fcb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816179Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#698406}
-
Alex Danilo authored
Bug: 980452 Change-Id: I1676eb50d52df6976a12ec940a66a25ed3032ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814584 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ie3456782bf7055fbc1a2c6d07724fda50513bf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808311 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#698404}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I61b0a36ee57a983ccbdb68160cc0b11f13fbba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808172 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#698403}
-
rajendrant authored
This CL implements a heuristic to eagerly fetch the first K images in a document, which is needed to alleviate delays caused by intersection observer firing only after first render event. Bug: 996963 Change-Id: Ide96665ba836d423ba0c370cd4a075d1650c4b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769304 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#698402}
-
Fredrik Söderquist authored
* FindInstanceTime(kEnd, ...) will return "indefinite" for an empty, so always call that. * Sink the call to ResolveActiveEnd(...) since it can be shared between the two cases. * Drop the redundant "!end_times_.IsEmpty()" check. Bug: 998526 Change-Id: Idf6431e4313ee9ebec917759dba10c457443aa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813502Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#698401}
-
Etienne Bergeron authored
The call to GetFirstMatchingFont(...) may fail. The matched_font will be unset and can be null. As stated on the doc: https://docs.microsoft.com/en-us/windows/win32/api/dwrite/nf-dwrite-idwritefontfamily-getfirstmatchingfont The return value may be fail. Type: HRESULT If this method succeeds, it returns S_OK. Otherwise, it returns an HRESULT error code. StackFrame: content::FontFallback::GetCachedFont(std::__1::basic_string<wchar_t,std::__1::char_traits<wchar_t>,std::__1::allocator<wchar_t> > const &,wchar_t const *,wchar_t const *,DWRITE_FONT_WEIGHT,DWRITE_FONT_STYLE,DWRITE_FONT_STRETCH,IDWriteFont * *,unsigned int *) content::FontFallback::MapCharacters(IDWriteTextAnalysisSource *,unsigned int,unsigned int,IDWriteFontCollection *,wchar_t const *,DWRITE_FONT_WEIGHT,DWRITE_FONT_STYLE,DWRITE_FONT_STRETCH,unsigned int *,IDWriteFont * *,float *) SkFontMgr_DirectWrite::fallback(wchar_t const *,DWriteStyle,wchar_t const *,unsigned int) SkFontMgr_DirectWrite::onMatchFamilyStyleCharacter(char const * const,SkFontStyle const &,char const * * const,int,int) blink::FontCache::GetDWriteFallbackFamily(blink::FontDescription const &,int,blink::FontFallbackPriority) blink::FontCache::PlatformFallbackFontForCharacter(blink::FontDescription const &,int,blink::SimpleFontData const *,blink::FontFallbackPriority) blink::FontCache::FallbackFontForCharacter(blink::FontDescription const &,int,blink::S R=drott@chromium.org, fdoray@chromium.org CC=eae@chromium.org Bug: 997081 Change-Id: I3c007f3a7d9bba5dba78ae1a5e1eaaa7f8e8a7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814703Reviewed-by:
-
Rika Fujimaki authored
This reverts commit 6dfea7f4. This CL just adds Trace methods for ScriptValue and ScriptPromise, and it wouldn't cause regression. So we conclude that the test is flaky. Further discussion in crbug.com/1003130 Original change's description: > [Resolve Leak Error]Make ScriptValue Traceable > > We made ScriptValue Traceable to replace SharedPersistent > with TraceWrapperV8Reference in a follow-up CL. > > In this CL, most of the changes are just: > - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because > ScriptValue has a Trace method. > - Add a trace method for ScriptValue and ScriptPromise since > they have objects to Trace. > > We recommend you to mainly check > - script_value.h where I add VectorTraits. > - script_promise.h where I add VectorTraits. > - v8_callback_function.py where I add a code to generate HeapVector. > - v8_types.py > * Add ScriptValue and ScriptPromise to "is_traceable==True" > which is used to generate Trace method & HeapVector. > > + I removed code to detect leak around ScriptPromise because > ScriptPromise no longer has persistent which may cause memory leak. > > Bug: 998994 > Change-Id: I63fcbf01de099577fe14045785b3072c615d78c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792583 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Rika Fujimaki <rikaf@google.com> > Cr-Commit-Position: refs/heads/master@{#695505} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,keishi@chromium.org,kouhei@chromium.org,rikaf@google.com Bug: 1003130, 998994 Change-Id: I92abf0b0cfd6965c700b86009f03d1aed8f4c56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809204Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c12db81e7954..2051b8bf0523 git log c12db81e7954..2051b8bf0523 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a536fa4a..303c57cf (698214:698351) 2019-09-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fc1e948f..a536fa4a (698112:698214) 2019-09-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cf1a2beb..fc1e948f (697976:698112) Created with: gclient setdep -r src/third_party/webrtc@2051b8bf0523 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I23a913aab7d6bf819710681ab8360477186bc89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815879Reviewed-by:
-
Kunihiko Sakamoto authored
TBR=lazyboy@chromium.org Bug: 1006129 Change-Id: Ia78d4639cf07818a56fa212ca7414eec1e8cf7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815810Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#698397}
-
Boris Sazonov authored
The last usage of that method was removed by https://crrev.com/c/1724673. Bug: None Change-Id: I36d4f102368c001f6eeeccf6166ad6edc8641f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813354 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698396}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f51e1fd37d90..9a9841178078 git log f51e1fd37d90..9a9841178078 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bf4268a3963b..6c4ff5ddab07 (8 commits) 2019-09-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b8149cbe..3243c3b1 (453 commits) 2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e9b6f28fdd71..b6fa949c4539 (2 commits) Created with: gclient setdep -r src/third_party/skia@9a9841178078 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I3428c96581066df55b44a464fa4aa526291588be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816174Reviewed-by:
-
Miyoung Shin authored
This CL converts SpeechRecognitionSessionRequest in blink and content to the new Mojo type, and uses pending_receiver<SpeechRecognitionSession> in speech_recognizer.mojom. Bug: 955171, 978694 Change-Id: I279e20de018d77cd8247ccd489fa14b9e1bf11cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808941 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#698394}
-
Maksim Sisov authored
This reverts commit f477186c. Reason for revert: causes regression for show/hide/show actions Original change's description: > X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full > > Now, the DWTHPlatform just minimally responsible for setting > the window into fullscreen/maximized state or even restoring > its state. Most of the functionality has been moved from > DWTHX11 to X11Window instead. > > What is more, AdjustSize has been moved to X11Window > and is Linux/X11 specific now. > > Show/Hide methods have also been reworked and DWTHPlatform > determines inactivity now and is responsible for for > window state changes. > > Also, the WindowManagerTogglesFullscreen test has been changed in > such a way that it expects that Chromium reacts on fullscreen > changes made from a window manager side. This is what we have > already been doing in Wayland, btw. > > Last, SetBoundsInPixels method has been removed from the DWTHX11. > Instead, the WTHPlatform::SetBoundsInPixels is used. And, as > said previously, AdjustSize for that method is implemented > in the X11Window now. > > Bug: 990756 > Change-Id: Ia4a7d4859a4b42bd7de99eb7c4309ac55e34e9db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769450 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695066} TBR=sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 990756, 1005111 Change-Id: I9de50efd0d909e542cd4ccc1053bab04c8625a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815859 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#698393}
-
Miyoung Shin authored
This CL converts SensorClient{Ptr, Request} in device, services and blink to the new Mojo type, and uses pending_receiver<SensorClient> in sensor_provider.mojom. Bug: 955171, 978694 Change-Id: I6a231623f86c6ce258e71dd2fba281324ec0ca09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809127 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL adds a simple implementation for the controller of the Touch To Fill component and introduces Robolectric tests to test them. Most notable piece of logic: the controller will either call onDismiss or the selected credential callback but never both. Since there is no view yet, no Integration tests are possible. Bug: 957532 Change-Id: Ieb73b33edb07406cbc28f1de40e15f34e8f8bf62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803931Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#698391}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Firstly: Unified BookmarkApps vs WebApps API: Extract AppRegistryController out of AppRegistrar. AppRegistrar is read-only model (with getter methods only). AppRegistryController handles unified async Init and any updates (setter methods). Secondly: WebAppSyncBridge now uses WebAppRegistrar as a one-way dependency. Effectively, WebAppSyncBridge becomes the storage controller ("cloud" storage + local LevelDb). WebAppSyncBridge should handle and coordinate any changes. 1) WebAppRegistry becomes read-only model (M in MVC) for external subsystems other than WebAppSyncBridge. 2) The writeable batch updates API (RegisterApp/UnregisterApp and BeginUpdate/CommitUpdate ScopedRegistryUpdate/WebAppRegistryUpdate) moved out from WebAppRegistry to WebAppSyncBridge. WebAppSyncBridge is C in MVC. 3) WebAppSyncBridge uses WebAppRegistry (the model) in one way dependency: erase AbstractWebAppSyncBridge interface. Illustrational diagram is in progress. Bug: 860583 Change-Id: I09091b56bc08bbce0123c8ffd98f57a5dd4a9128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803037 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: -
Kunihiko Sakamoto authored
TBR=kenrb@chromium.org Bug: 1006122 Change-Id: I491900bbcc004a739bace61917fdadb8dfcb029d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816198Reviewed-by:
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I8ad1bd62ad92010eac8a6917d8c13455df8a8a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808069 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#698388}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b8a57b5c3bcd..b7485bb77fc6 git log b8a57b5c3bcd..b7485bb77fc6 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 saklein@chromium.org Build API: Add CHROME_ORIGIN env var when chrome root set. Created with: gclient setdep -r src/third_party/chromite@b7485bb77fc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I610bcd15a027e3e49a8c3232176e44b07cee691d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815822Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13bf57a9f28d..052b14753bfa Created with: gclient setdep -r src-internal@052b14753bfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia1d420e2140f6597666ae2defab55007bc76bdb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815821Reviewed-by:
-
Ken Rockot authored
This is a reland of a127c749 Fix for MSan failure in PS2 Original change's description: > [Mojo] Introduce async invitation client transport > > Normally clients accept invitations synchronously, as they must do > blocking IO to read out an OS handle for internal sync IPC (e.g. > brokered shm allocation). This is necessary in some sandboxed > environments where the sandboxed client cannot create its own sync IPC > channel to pass to the Mojo broker. > > On Android such restrictions don't apply, and it's critical to avoid > blocking the main thread where we want to synchronously initialize > Mojo. > > This CL introduces a new invitation transport type which supports > non-blocking invitation acceptance in clients. The only requirement to > use this is that the client must be allowed to allocate a Mojo > PlatformChannel (e.g. domain socket, named pipe, etc). Internally the > client then creates its own internal sync IPC channel and sends that > asynchronously over the main invitation transport. > > This allows Android clients to instantly accept Mojo invitations and > initialize Mojo IPC without blocking the calling thread. > > Bug: 1005432 > Change-Id: Id1dde38f209d57883a28bece050a4c0638bdec9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811759 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#698155} Bug: 1005432 Change-Id: If6b356d5a2d69ad7f4900e618bc4fea172e23bc3 TBR: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815663Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#698385}
-
Ricky Liang authored
This CL allows the caller to select the buffer pool type to be used with the video capture device clients. Design doc: go/cros-camera:dd:zero-copy Bug: 982201 Change-Id: I1228afa9fb9bbff9c718d6d4f90f2b35154ea84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692154 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#698384}
-
Clark DuVall authored
This is a reland of be5bd323 Original change's description: > [WebLayer] Load WebLayer from WebView > > This adds WebLayer to WebView, allowing us to load the WebLayer > implementation from a monochrome APK (or other APK which includes > WebView). > > Run the shell loading from MonochromePublic.apk with: > > $ autoninja -C out/Android run_weblayer_shell_monochrome > $ out/Android/bin/run_weblayer_shell_monochrome > > Run the shell loading from TrichromeWebView.apk with: > > $ autoninja -C out/Android run_weblayer_shell_trichrome > $ out/Android/bin/run_weblayer_shell_trichrome > > Change-Id: Ief31c2b79edae6b697ca2927fd6eccbf255515b3 > Binary-Size: Increase needed for implementing WebLayer, see go/weblayer-dev-intro > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810329 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698321} TBR=dtrainor@chromium.org,torne@chromium.org Change-Id: I3e76e41a9f808f8a85010bae2953a534e917ec75 Binary-Size: Increase needed for implementing WebLayer, see go/weblayer-dev-intro Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815605Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#698383}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad7ce9ad..debdeb70 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icdaeb0876e534b57020c0a00459eb3f906481727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815789Reviewed-by:
-
Eric Willigers authored
WebAppBrowserController no longer causes a crash when shortcut apps are used. The BookmarkAppTest tests can now be run with WebAppBrowserController. This relands the last part of the reverted CL https://chromium-review.googlesource.com/c/chromium/src/+/1787758 Bug: 966290 Change-Id: I1593fb83622a19b0c9db0273151d174dfb108a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809293 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Alan Cutter authored
During PWA installation we fetch the app's icons from the manifest to write into our backend model. After fetching the icons we copy them between synchronous functions then delete the original. This CL turns the copy into a move. Bug: 926083 Change-Id: I30d5d6f274933bac85c067f395bf80600dfcc7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811407 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#698380}
-
Hitoshi Yoshida authored
This CL intoduces a new grammar for async iterables[1] and also introduces "async" as a new keyword. In Blink, now we have no async iterables, and thus this CL does not change actual behavior of Chrome. [1] https://heycam.github.io/webidl/#idl-async-iterable Bug: 839389 Change-Id: Iea4a28cf3c655a74e7d3acbe46f1856116c09339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813118 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
