GitLab

Bug: 889940
Change-Id: I282344fe5efa03933c86bb0a4f9d763521aebf67
Reviewed-on: https://chromium-review.googlesource.com/1249394Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#594790}

A small customization: in tablet mode, it doesn't make sense to display
a message related to a keyboard shortcut.

Bug: 887984
Change-Id: Ife9dbd11a0077b3c8001124b0224d50eac683b9c
Reviewed-on: https://chromium-review.googlesource.com/1242079Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594789}

https://pdfium.googlesource.com/pdfium.git/+log/072d829e2cd1..2b4d11c0f133


git log 072d829e2cd1..2b4d11c0f133 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 thestig@chromium.org Shading functions should take const matrix pointers.


Created with:
  gclient setdep -r src/third_party/pdfium@2b4d11c0f133

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I251f92f5e74a433ad715727ca5552800c35b8a12
Reviewed-on: https://chromium-review.googlesource.com/1249327Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594788}

Switching to multi-window mode on Android and back is messing up the
Clear Browsing Data dialog on Android after the display order was changed
to move "Media Licenses" up from the bottom. Changing DialogOption to match
the order displayed.

BUG=888943
TEST=tested manually using steps in the bug

Change-Id: Iabae3c0bdaf3098a740b6709c8527b892be6aff3
Reviewed-on: https://chromium-review.googlesource.com/1246594Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594787}

Change-Id: I423a716e3716a552927676c3bc212141a10b6d20
Reviewed-on: https://chromium-review.googlesource.com/1247229Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594786}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a16c39ef89c4..74a2dc070e4e


Created with:
  gclient setdep -r src-internal@74a2dc070e4e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5f5b82bbc84b41dc9e8e77e73e8f887873af20bb
Reviewed-on: https://chromium-review.googlesource.com/1249328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594785}

https://memegen.googleplex.com/5329863038205952

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I040c5f5986884cad2ca2b194a06366e8fd12255f
Reviewed-on: https://chromium-review.googlesource.com/1246420Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594784}

This migrates password_manager::AffiliationFetchThrottler from
NetworkChangeManager to NetworkConnectionTracker, which works with the
network service enabled.

Bug: 887058
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I04c2529e24ea0bf85ebb0646127ded2b594306c2
Reviewed-on: https://chromium-review.googlesource.com/1239359Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594783}

ScopedBlockingCall serves as a precise annotation of the scope that may/will
block for the scheduler. This CL moves ScopedBlockingCall from the call site
to the implementation of FilePathWatcher::Watch, which is more accurate.

Bug: 874080
Change-Id: I03cf5d28a2c4763c0c358699aff9f32d686b46b6
Reviewed-on: https://chromium-review.googlesource.com/1243366
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594782}

This CL removes the last-version-... pref check/update that causes
deletion of disused data to be run at most once per major version.
Instead, it will be attempted at each startup.

Bug: 881443
Change-Id: Ie6fbae3a9c29d67af28d842f02014a1274d10540
Reviewed-on: https://chromium-review.googlesource.com/1211086
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594781}

Replace the HTS Incognito Button with a toggle.

Bug: 851166
Change-Id: I5c431abb508930ee1a9a24792f2299ea08d944cf
Reviewed-on: https://chromium-review.googlesource.com/1246453Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594780}

When screen relative coordinates are passed in, do not alter
them, they are already correct.

Note: compare with results in "Better failing test" patchset 3.

Bug: 889491
Change-Id: I7618aab997f01cca20d6c712385e19beff331647
Reviewed-on: https://chromium-review.googlesource.com/1246321Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594779}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d3738be3476f..ad0232dee5f5


git log d3738be3476f..ad0232dee5f5 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 33432579+alan-baker@users.noreply.github.com Unify memory instruction validation style (#1934)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@ad0232dee5f5

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I36a76977a0f6e2514f59c53d315d892313c7b454
Reviewed-on: https://chromium-review.googlesource.com/1249631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594778}

Bug: None
Change-Id: Idc21640edb5cce41094bf564ae9e3383e202dc91
Reviewed-on: https://chromium-review.googlesource.com/1244545
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594777}

Remove the module load address parameter unused by the ModuleDatabase

Change-Id: I80a41dba4c0f33c9acb0c4d4a03934ad3b19ca54
Reviewed-on: https://chromium-review.googlesource.com/1237215Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594776}

BUG=none

Change-Id: Ia943e5bda6e3f5d3cecf9eac39e2271801295a49
Reviewed-on: https://chromium-review.googlesource.com/1249392Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594775}

This reverts commit dc8f3c0a.

Reason for revert: Casing failures
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/2442

Original change's description:
> Android: Allow proguard to strip unused native methods.
> 
> This CL changes Monochrome APKs to allow proguard to strip out Java
> native methods that aren't used.
> 
> For APKs that use explicit JNI registration, this isn't possible since
> RegisterNatives ends up trying to load classes that are unused and
> removed by proguard.
> 
> Bug: 688465
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> Change-Id: I6816bd68ce47e59bfc9f75dace1b34ab3c200222
> Reviewed-on: https://chromium-review.googlesource.com/1244605
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594743}

TBR=pauljensen@chromium.org,agrieve@chromium.org,estevenson@chromium.org

Change-Id: Ic8e1f808a63c9c0fd119ee36efa1cc2b1e9a0616
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 688465
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/1249825Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594774}

Disabled due to flake:
  SyntheticKeyEventTest.KeyboardEventAck

Bug: 889878
Change-Id: I3ced9177ffbc1edbcbb0381714b92b66b02b5b07
Reviewed-on: https://chromium-review.googlesource.com/1249821Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594773}

Previously, MediaCodecVideoDecoder tests tried to flush the MCVD
instance on TearDown.  Unfortunately, it didn't handle the case
where not flush was needed.  ASAN got mad about this.

This CL fixes the teardown sequence to call Reset if the test still
has an MCVD insance, and to send an EOS output buffer only if MCVD
actually started the flush without completing it.

These changes don't affect MCVD, just the tests.

Bug: 889001
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id04afc7bbab4e0b1cde26df924573e0fed047947
Reviewed-on: https://chromium-review.googlesource.com/1244105
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594772}

Refactor this logic out of the InfobarDelegate so that it is easily
accessible in Android Java without the use of the Infobar.

This is needed so that the stale preview text can be displayed in the
page info dialog for the new Previews UI.

Also renames the related histogram pieces to generalize the naming.

Bug: 888029
Change-Id: Iaf4c8c8059c45d5ccfb408d8b831b6a322802a08
Reviewed-on: https://chromium-review.googlesource.com/1239214Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594771}

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/common/app_group.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=olivierrobin@chromium.org

Bug: 874080
Change-Id: I74ae6a8f94ea54ee9738a67493dc545921dc99e9
Reviewed-on: https://chromium-review.googlesource.com/1191420
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594770}

JS calls force layout when they require layout-dependent state. This
happens outside of the document lifecycle, and is not captured by our
existing metrics. Add a new ForcedLayout metric for UMA and UKM to
track the amount of time we spend doing layouts outside of the
document lifecycle.

R=eae@chromium.org,vpmstr@chromium.org

Bug: 869966
Change-Id: I3868e1483a32163666343453204c81b9c9bbd452
Reviewed-on: https://chromium-review.googlesource.com/1228855
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594769}

https://webrtc.googlesource.com/src.git/+log/efb94d57eb88..56db013e24cf


git log efb94d57eb88..56db013e24cf --date=short --no-merges --format='%ad %ae %s'
2018-09-27 buildbot@webrtc.org Roll chromium_revision 65b8a51a..f87ef787 (594582:594716)
2018-09-27 mbonadei@webrtc.org Remove usage of runtime_enabled_features in WebRTC.


Created with:
  gclient setdep -r src/third_party/webrtc@56db013e24cf

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2f9829d7eabba9d9bd556313f7b4f991d551ec8e
Reviewed-on: https://chromium-review.googlesource.com/1249629Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594768}

- replaced some pointer parameters with const reference
- replaced some non-const reference parameters with pointers
- replace unique_ptr<UpdateRequestsResult> with UpdateRequestsResult, and made
  UpdateRequestsResult move-only.
- fixed potential crash in UpdateRequestTask::ValidateReadResult
- use default copy constructor in SavePageRequest

Change-Id: Id2e2c103330a292e273a6889de359607deecc187
Reviewed-on: https://chromium-review.googlesource.com/1246281Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594767}

This should be purely renames with no functionality changes.

Bug: 545684
Change-Id: I6bffef6e07fdf6e787f60050447047854b961cc3
Reviewed-on: https://chromium-review.googlesource.com/1220709Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594766}

Bug: 888476
Change-Id: Iccb39603a10261d1bdf3fcb26b008bb02fc371e6
Reviewed-on: https://chromium-review.googlesource.com/1245465
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594765}

Add a new section in the chrome://management page to show force
installed extensions with powerful capabilities (like ability to read
and write all data on the page).

Bug: 879146
Change-Id: Ie45368caec53952a4c18efb07f3d80c21d5540b2
Reviewed-on: https://chromium-review.googlesource.com/1235674Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Stefan Teodorescu <fane@google.com>
Cr-Commit-Position: refs/heads/master@{#594764}

Replace content::FileChooserFileInfo usage with
blink::mojom::FileChooserFileInfo.

* Replace std::vector<content::FileChooserFileInfo> with
  std::vector<blink::mojom::FileChooserFileInfo*Ptr*> because it's the
  representation of array<fileChooserFileInfo> in mojom.

* Because FileChooserFileInfoPtr is not copyable, we use std::move() to
  pass it over functions.

* We temporarily transfer std::vector<blink::mojom::FileChooserFileInfoPtr>
  over legacy IPC. Add ParamTraits<blink::mojom::FileChooserFileInfoPtr>
  because FileChooserFileInfoPtr is not a simple struct for which we can
  use IPC_STRUCT_TRAITS_* macros.


FYI: All-in-one CL: https://chromium-review.googlesource.com/1170454

Bug: 869257
Change-Id: I73d54b70d3e24c917a783d3eafa1f29c292dc2bc
Reviewed-on: https://chromium-review.googlesource.com/1237798Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594763}

per Polymer 2 migration guide:
 - wrap <style is="custom-style"> with <custom-style>
 - move <custom-style> inside <body>

Bug: 739532
Change-Id: I089208681d14e19e71251a41e80bd024c02d1b3a
Reviewed-on: https://chromium-review.googlesource.com/1247530Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594762}

If there is no keyboard accessory, signaling that password generation is
unavailable doesn't constitute a state update. The keyboard accessory should
only be created and initialized if there is an action or data to display.

Bug: 888932
Change-Id: I9dbf8bd1ce4ae620f9b50e4e4aadb7c3c2335733
Reviewed-on: https://chromium-review.googlesource.com/1249084Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594761}

This patch changes force_subtree_update bool into "reasons" that fall
into one of two categories:
  - Isolation piercing, meaning that the update crosses and recurses
    into an isolation boundary.
  - Isolation blocking, meaning that the recursion may be blocked by
    isolation.

R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie5389a02b8cc529ca93bf0e50b225b0f343e2439
Reviewed-on: https://chromium-review.googlesource.com/1247201Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594760}

Some jumbo build configurations would not compile because of
the unused field. The are not allowed by the build system but
sometimes only jumbo builds notice such things since they
have access to more source code.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I079412fc98e5812f709b6566d02de9d91a5a8706
Reviewed-on: https://chromium-review.googlesource.com/1249485Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#594759}

https://android.googlesource.com/platform/external/perfetto.git/+log/0d9930ffe556..f7f0def7921b


git log 0d9930ffe556..f7f0def7921b --date=short --no-merges --format='%ad %ae %s'
2018-09-27 fmayer@google.com Move unix socket to base.
2018-09-27 fmayer@google.com profiling: Add missing pieces to heapprofd.


Created with:
  gclient setdep -r src/third_party/perfetto@f7f0def7921b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ide7d3b2ee71ae12939560cd7473f051537c5f610
Reviewed-on: https://chromium-review.googlesource.com/1249626Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594758}

Currently, the password dropdown only uses a two-line style when
disambiguation text (i.e., the subdomain on which the password was
saved) is available. For the experiment, when a user is in the Two-Line
group, we want to always use a two-line display, even when no such text
is present. This CL puts the obscured password (e.g., *****) on the
second line in such cases.

Bug: 870342
Change-Id: I77deba680277bdbe9ed8e435205e8fc7f18f0ef4
Reviewed-on: https://chromium-review.googlesource.com/1247029Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594757}

This is not used anywhere any more. Remove extension, entrypoints,
bindings and tests.

Bug: 889651
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If3e2c95f7531752f2690b1f3e4345620bf4efb2d
Reviewed-on: https://chromium-review.googlesource.com/1247191Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594756}

This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster.
This also adds memory accounting in SharedImageFactory/SharedImageStub.

TBR=boliu@chromium.org,sadrul@chromium.org

Bug: 870116
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7cb3837f2082c5a4d03a9bc71e91dc265cbd0e82
Reviewed-on: https://chromium-review.googlesource.com/1242080
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594755}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d8c6f4f9d8f..a16c39ef89c4


Created with:
  gclient setdep -r src-internal@a16c39ef89c4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I557eee8fcb096f692c4fbf797f02cf3a95c7c7c6
Reviewed-on: https://chromium-review.googlesource.com/1249624Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594754}

Adding cell to a sync error if it exists. This cell disappears when the error
is fixed. The asset is missing.

https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3e63bc1501_10_15

Screenshot (shared with chromium accounts):
https://drive.google.com/open?id=1S8kzlFmUwErOTn3BFC-2rR7KBeOX-V9i

Bug: 849754
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I69eeac598b5d1742528acb16d8c0cc672580b402
Reviewed-on: https://chromium-review.googlesource.com/1231333
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594753}

To avoid the previous regression (see analysis in bug), we force
layout in the case where we otherwise would get an outdated result.

Bug: 596743
Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756
Reviewed-on: https://chromium-review.googlesource.com/1246730
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594752}

In some situations, Start() would be called from both the constructor
and the observer notification method quickly, yielding to multiple
concurrent flows. Prevent those.

In addition, redo the tests so that they test both work from the
observer notification method and from an existing policy. Also add
a test that triggers the concurrency situation and verifies that
there is only one flow running in that situation.

BUG=chromium:887683
TEST=unit_tests --gtest_filter=*EnrollmentPolicyObserverTest*
CQ-DEPEND=CL:1234373

Change-Id: Ice6b46e19bf77a837b4c4908f332e9af6c5189f5
Reviewed-on: https://chromium-review.googlesource.com/1237242
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594751}