- 16 Nov, 2020 40 commits
-
-
Tanya Gupta authored
Added logic to call FDT in the tab service to capture the bitmap. Change-Id: I9c0e01641b6393ded8227e82fddd0b63c895e45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533327Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#827965}
-
Michael Checo authored
Screenshot: http://shortn/_5A4TAyrSyR Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I3413faa94c5c451596f4f37dce2d906b55fa35b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527821 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827964}
-
Dale Curtis authored
This is necessary to help debugging efforts. R=tguilbert Bug: 1148800 Change-Id: If638329d288701b1a95e7215935a4cf424dafcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542048 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#827963}
-
Jonathan Ross authored
We currently measure Histograms in perf benchmarks. This is done by emitting a trace of all histograms from startup. Then emitting another at the end of tracing. Then in Catapult we calculate differences in uma_metric.html However this has led to issues in the past with mis-calculating buckets of histograms. It also currently breaks down when histogram emitting changes occur near the startup. To help clear this, we want to not record the initial histograms. But instead calculate the differences. Thus emitting only one sample for Catapult to process. We will then reduce the complexity of uma_metric's processing in a follow up change in Catapult. Bug: 1145731 Change-Id: Ia6452984a16914aaf19e66c22d583592835f46df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521106Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#827962}
-
Shrek Shao authored
Proposal approved by privacy: go/client-rendering-api-drawn-to-ukm-review Add collections for Canvas/OffscreenCanvas context type: webgl, webgl2 that have draw calls issued. Tested locally with a list of draw call variants: drawArrays/Elements(Instanced) drawRangeElements MultiDraw variants BaseVertexBaseInstance variants Bug: 1147234 Change-Id: I3ae70f0585f9591a64bef2cb9d50afd72dd2aec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537090Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#827961}
-
James Forshaw authored
This CL removes the support for redirecting the OPM APIs when running under Win32K lockdown. These were added to allow Flash to enable HDCP and with Widevine moving to a utility process are no longer required. Bug: 1148912 Change-Id: Ia5ec0cd54d9ae6fec28b5603693ffde7c725f194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536847Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#827960}
-
Bo Liu authored
BaseInputConnection will keep a reference to the container view, which causes leaks after onDetachedFromWindow. Bug: 1149336 Change-Id: Iee7683092ea6f8878a09de78a09d044d8d29d246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536785 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827959}
-
Justin Donnelly authored
Bug: 1149562 Change-Id: Iaf0d7104fd0f90100e7c112d65baa602638163bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542044Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#827958}
-
Vladimir Levin authored
This patch renames a wpt, since the fact that the property is no longer animatable has been approved by csswg. R=chrishtr@chromium.org Change-Id: Ib6e937d6df223755f67c3698a0cb09aba7775fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542368 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#827957}
-
Joel Hockey authored
The current code in FileHelper assumes all windows are Arc. We now check the source and target aura::Window to detect and do the appropriate path translations and share files when necessary with crostini/pluginvm. For example, when crostini is the drag source, we will convert paths such as: <homedir>/file => /media/fuse/crostini_<hash>_termina_penguin/file And do the opposite translation when crostini is the drop target. We also convert paths and share files such as: <cryptohome>/MyFiles/file => /mnt/chromeos/MyFiles/file /media/removable/MyUSB => /mnt/chromeos/removable/MyUSB For PluginVM, the translation is <cryptohome>/MyFiles/file => //ChromeOS/MyFiles/file /media/removable/MyUSB => //ChromeOS/removable/MyUSB Bug: 1144138 Change-Id: I2bb38336537acf13c4797374d6dabe6e518d689e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517346 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827956}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/02736010cb17..afaca889d46b 2020-11-16 mbonadei@webrtc.org Trigger tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I30f12b8d82879b894ac6ff6aeec32f9b6d11fa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827955}
-
chrome://omniboxdpapad authored
The |flattenhtml| parameter, which the code previously relied to inline several icons, is not supported (purposefully) by generate_grd(). Addressed as follows: - icon_tabs.svg: Served from chrome://omnibox/, only used there. - cancel_red.svg and check_circle_green.svg: Exposed via chrome://resources/ URLs - ic_download.svg: Inlined in CSS directly, since this WebUI doesn't use <iron-icon> Bug: 1132403 Change-Id: Ib1738228cc90b193b8534ca9b27d1fb571503f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536152Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827954}
-
Roger McFarlane authored
Bug: 1110384 Change-Id: I4b0fa3a00beadc760bdb4a0c845d651e792fac39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542422Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827953}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dd6b36e8801e..2c5b040b5c2a 2020-11-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e5e961722054 to 4ad0019df0f0 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I9611a1ba0b085925c2f1ba7f74a203f437b96830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541918Reviewed-by:
-
dpapad authored
In this CL updating chrome://management and chrome://browser-switch. Launch Chrome with the following flags to experience dark scrollbars. --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ --force-dark-mode Bug: 1142291 Change-Id: Ib5abc4a5bca883b01a796890f18320db2349e1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536795Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827951}
-
Kartik Hegde authored
Since UDP connections do not guarantee a response from the other side, include a timeout to avoid infinitely waiting. BUG=BUG=b/172994051 TEST=unit_tests --gtest_filter=UdpProberWithFakeNetworkContextTest.* Change-Id: I09a33ef8d21516edfa30ebbe53cb0f6e336eedc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539766 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827950}
-
rbpotter authored
Enable the 5 zoom related tests that had been disabled with the update enabled in both flag states, as the underlying Blink issue has now been resolved. Make a few adjustments to the ZoomWithoutBubble test, as recent updates to the new UI had caused the test to fail with the update flag on. Bug: 1137905 Change-Id: Iead2dfb1f0dc3eab30553bc8b1e75a353049b5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538367Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827949}
-
Koji Ishii authored
Moving to |ComputedStyle| has following benefits: * Reduces the usage of |LayoutObject| in NG code. * Uses first-line style correctly when we have |NGPhysicalFragment|. This patch has no behavior changes. Bug: 1145048 Change-Id: If1298087754286e7a5ec1935fc1ba52d1298770f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536585Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827948}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, if a network APN list is empty or undefined a user is not able to manually enter a custom APN. This CL fixes this issue and allows a user to manually enter a new custom APN Bug: 1146524 Change-Id: I6ec01936cb32eefd2627e4447fe5055c99dd1401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537926 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#827947}
-
Andrew Grieve authored
This reverts commit 86befdda. Reason for reland: Bugs fixed in other CLs (see issue) Original change's description: > Revert "Android: Enable use_debug_fission for official builds" > > This reverts commit 9d3a4611. > > Reason for revert: Official builds failing crbug.com/1144538 > > Original change's description: > > Android: Enable use_debug_fission for official builds > > > > Bug: 1122182 > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822625} > > TBR=agrieve@chromium.org,benmason@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1122182,1144538 > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > Commit-Queue: Krishna Govind <govind@chromium.org> > Reviewed-by: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823080} Bug: 1122182 Bug: 1144538 Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#827946}
-
Jonathan Freed authored
Bug: 1149344, 1128269 Change-Id: I471ddf82d612de72085629ddaeb29c68b48d6f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542159 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
-
Miriam Zimmerman authored
The Platform.DailyUseTime metric is used to monitor system health on numerous dashboards, and as such it should not expire. BUG=chromium:1089270 TEST=CQ Change-Id: I28d8593a3cf935d4ba7c1b8f4d76d521f8f0b495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541784Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#827944}
-
Gabriel Charette authored
This allowance seems like an unintentional overlook of the fact that DidRunTask() runs microtasks. Microtasks should be treated the same as regular application tasks and not be allowed to implicitly nest application tasks. R=altimin@chromium.org Change-Id: Ie3f9d41d7525e465f813c7e2456cce3f4394ad57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537002 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827943}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e5da6b5b505..9e371caae2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1047896,chromium:897470 Tbr: tguilbert@google.com,lgrey@google.com Change-Id: I348d2e942e7c3b58d32fcb1c6216cd06e8cd1c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542306Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Ravjit Singh Uppal authored
Since Flash is deprecated we dont need the warning prompts about Flash deprecation anymore. Bug: 1134202 Change-Id: I52ba1a8bb6c87c280ede20ad2d7178da25a755c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536643Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#827941}
-
Collin Baker authored
Uses WinRT's Windows.Devices.Input.TouchCapabilities to check if the screen has touch input. If it does, registers the client in the WebUITabStripOnTablets synthetic field trial. Bug: 1044692 Change-Id: I62ea6c627805f3ae1b18479deffef3a7c638b574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536790 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#827940}
-
James Hawkins authored
Bug: 126802 Test: OSSettingsAboutPage* Test: DeviceNameHandlerTest.* Change-Id: I4c16cb932ecbbf03f66cdec32ff72b77ff5f30e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528637 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827939}
-
Noel Gordon authored
With CL:2536584 the SWA files app main.html is auto-generated from the files app main.html and provides its own CSS files. Thus, SWA main.css file is no longer used: remove it. Bug: 1113981 Change-Id: I88a7d0a02c10993f7c3113425466827f046939dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540146 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827938}
-
Robert Sesek authored
Bug: 1148931 Change-Id: Ic0cdded0c1c4821689486cacd5790fce82c40c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537057Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827937}
-
Zhaoyang Li authored
The tests can pass on device now, Reenable every test under the bug number and test utility. Bug: 1067821 Change-Id: I1fdbeed8bb42eb47705f883426def8e67287d1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523306Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#827936}
-
Shakti Sahu authored
This CL adds search capability to read later bookmarks. This enables read later items to be searchable from anywhere inside bookmarks. Bug: 1139072 Change-Id: I13329f066d300be1e1a70ddd51f42908b8454749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536813 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#827935}
-
Kevin McNee authored
Per the style guide, we should use proper test assertions to report failures gracefully. Bug: None Change-Id: Ice20b1f1dae1ca46db1b6471da62ff295a6c65ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538050Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Alex Turner authored
Currently, it is only defined on NavigationRequests. Defining it on the handles too will allow for easy determination of when a navigation has passed through ReadyToCommitNavigation(), i.e. via HasCommitted() || IsWaitingToCommit(). Note that some navigations can pass through ReadyToCommitNavigation() without eventually committing -- e.g. due to a doc.write. Adding this call will simplify handling of these edge cases. Bug: 1101584 Change-Id: I7c272ef2768a901b8988bfe8e28ae1a0c3ef2ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536389Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#827933}
-
Haiyang Pan authored
The crrev.com/c/2534602 which adds it as 50% does not seem to affect the build duration a lot: http://shortn/_lvbjprI51m. And there are still plenty of test devices: http://shortn/_ZtBguxAg9X Bug: 1111436 Change-Id: I0126df515488a5241e0a91aac8122bf21d66391f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541222Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#827932}
-
Dave Tapuska authored
In crrev.com/6e8f1f65 a SetMouseCapture call was missed. Causing the old issue to regress. Ensure the SetMouseCapture call is there so the targeting of mouse events is correct during drag. BUG=1149432 Change-Id: Ie61c25e45ac83d295111088bd8c1e25080c84a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541202 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827931}
-
Aga Wronska authored
This cl addresses a few easy to solve problems found in the code owned by Family Experiences team. More fixes will come in a followup. Bug: 1147260 Change-Id: I6b9766b18640f626fcd6aa063d3998d5d469b95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538515Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#827930}
-
Hiroshige Hayashizaki authored
Bug: 1129793, 1114601 Change-Id: Ifc26c2c9e75b25d4ff001395b4faf072c41974c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485411Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#827929}
-
Patrick Monette authored
This new member function allows the caller to modify an element in-place safely. The existing options to do this right now is either use const_cast<> then call Update() manually (was done by tests), or remove then reinsert the modified element afterwards. The issue with the later option is that you can't keep using the same HeapHandle pointer as it cleared during the removal. Bug: 971272 Change-Id: I202daa322f1160d601ffffa87ceb6a4dad0e291f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530370Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#827928}
-
Jimmy Gong authored
Previously only checked if the host phone is a PhoneHub host but did not verify whether if it was a BetterTogether host and has a valid Bluetooth address. This CL adds those checks. Bug: 1106937 Fixed: 1147290 Test: chromeos_components_unittest Change-Id: I8c2e7a596655a3a9904268873c8514f1332ae234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538694 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/54fc9abd737d..2228002b0f2d $ git log 54fc9abd7..2228002b0 --date=short --no-merges --format='%ad %ae %s' 2020-11-16 danzh Disable QuicUnackedPacketMapTest.DebugString() in chromium. 2020-11-13 nharper Remove unused QuicVersionManager::GetSupportedTransportVersions 2020-11-13 nharper Remove old TODO(nharper) that is out of date 2020-11-13 bnc Remove QUIC priority experiments. 2020-11-12 bnc Remove SpdyDeframerVisitor. 2020-11-12 dschinazi Removed unused variable 2020-11-12 danzh Pass PATH_CHALLENGE payload to QuicPacketCreator::SendPathChallenge() instead of getting it populated by this interface. 2020-11-12 wub Enhance the error message of QUIC_BUG in QUIC BandwidthSampler. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I3925f0a3efbd8c7eb30c52e878cec3e3c15572bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541807 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827926}
-
