- 19 Jun, 2018 40 commits
-
-
Olga Sharonova authored
[1] introduced AudioServiceLaunchOnStartup feature which we want to roll out with a new experiment group. Updating field trial to run the config on bots first. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1104681 Bug: 851611,853781 Change-Id: I3796a8ac205a6d37706a86e8647c933ee510f41a Reviewed-on: https://chromium-review.googlesource.com/1105957Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568485}
-
Xi Cheng authored
Bug: 851163 Change-Id: I651da22403ba5597667549970b29d7d47a62f73b Reviewed-on: https://chromium-review.googlesource.com/1105491Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#568484}
-
Ken Rockot authored
Adapts dynamic mojo_core library thunking to use base::ProtectedMemory for function table storage and exempts the calls from cfi-icall checks. Bug: 850464 Change-Id: I8e7d8dbcb4d312e089bdee830e89ed973ae5727e Reviewed-on: https://chromium-review.googlesource.com/1105301Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568483}
-
danakj authored
And remove an empty method and the caller on MicroBenchmark. R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9750cbcf1daebf365f8e5bd91022dedf32e49ec4 Reviewed-on: https://chromium-review.googlesource.com/1103137 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568482}
-
Becky Zhou authored
Bug: 851977 Change-Id: I99de0abe80ea536a23ecdca2401dd3fd6b816955 Reviewed-on: https://chromium-review.googlesource.com/1101699 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#568481}
-
Emircan Uysaler authored
This reverts commit e048eba0. Reason for revert: Speculative revert as a regression is detected in this range. https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ2ajFuAoM Original change's description: > Refactor VideoFrameBuffer::Type handling in MediaStreamRemoteVideoSource > > This CL cleans up this class in preparation for future types to be added. > > Bug: 853843 > Change-Id: Ibdf6f624cc01e776bd885fa785a1cdb37a19a150 > Reviewed-on: https://chromium-review.googlesource.com/1104965 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568165} TBR=emircan@chromium.org,chfremer@chromium.org Change-Id: Ic71cc3094e0e79572c2045a4c4464dd5b5bbd114 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853843 Reviewed-on: https://chromium-review.googlesource.com/1106397Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568480}
-
Kevin Bailey authored
Restores (dark) pressed color to tab switch button, which was unintentionally removed in prior CL. Also creates an ink drop mask for the tab switch button, due to discovering that ink drop was extending beyond border. (A more general solution is being worked on.) Bug: 780835 Change-Id: Id96f4c1695b0f0dceed1e122b55f0f029f813fa0 Reviewed-on: https://chromium-review.googlesource.com/1103140 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#568479}
-
Ilya Nikolaevskiy authored
Bug: 690537 Change-Id: Ie75bd4040aee327431b01c676a221a8eb70410ae Reviewed-on: https://chromium-review.googlesource.com/1106146Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#568478}
-
Hans Wennborg authored
The DIA SDK normally lives in the Visual Studio installation dir. Bug: none Change-Id: I38c17fdc6e26a49eb4205aceb34e56e7be9d3a65 Reviewed-on: https://chromium-review.googlesource.com/1106138Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#568477}
-
Rohit Rao authored
|reloadSessions| previously had code to trigger another sync refresh. The old sync sessions implementation would detect that nothing had changed and break the update cycle, but a new implementation notifies observers unconditionally. This was leading to an infinite loop of sync updates. BUG=854049 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I85dbf2810f5ff6e009812a33ad643fb54cfdc8c4 Reviewed-on: https://chromium-review.googlesource.com/1106001Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568476}
-
Mike Reed authored
See future Skia CL: https://skia-review.googlesource.com/c/skia/+/135566 Needs this to land first: https://skia-review.googlesource.com/c/skia/+/135622 Change-Id: I8f55332a74429750b89db4da5f9ce407df6bc222 Reviewed-on: https://chromium-review.googlesource.com/1105062Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#568475}
-
Mitsuru Oshima authored
ARC++ app may update the color programatically, which can result in noticable flashing. This will make the color change transition smooth by animating the color from currently used color". TBR=wutao@chromium.org BUG=b/88534690 TEST=manual. also covered by unit test Change-Id: Ia15976cb1ec425ddb4e23ec6a253667fa6f774d9 Reviewed-on: https://chromium-review.googlesource.com/1101504 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#568474}
-
Zhiqiang Zhang authored
- Added cast-framework and fido client for feature development. - Added auth-api-phone client, which is a missing dependency of auth - Updated BUILD.gn dependencies as they were out of date. Bug: 822826 Change-Id: I3076868f6607511ac911a26de482e4a645cedf56 Reviewed-on: https://chromium-review.googlesource.com/1105459Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568473}
-
Carlos Knippschild authored
The group was finally renamed in the experiment configuration so renaming it here again. Bug: 687364 Change-Id: I314b2993f27342054bbb423c80e16d2e7a8f886f Reviewed-on: https://chromium-review.googlesource.com/1105390Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568472}
-
Devlin Cronin authored
tabs.captureVisibleTab() is interesting. It used to work with every URL ever, and just checked for if activeTab or <all_urls> was present. However, this led to some issues where the extension could capture pages it shouldn't be able to, such as https://crbug.com/810220. Changing this to only allow access to pages that the extension had explicit access to also broke important use cases. For instance, taking screenshots of chrome:-scheme pages is important for filing bugs, tracking features, etc. This similarly broke use cases for other URLs that extensions don't have full access to, like other extensions' pages. An exception was added for chrome:-scheme pages, but this was insufficient for other cases. Adjust the permissions check to allow page capture of otherwise- restricted pages if the extension has activeTab granted. We require activeTab (rather than either <all_urls> or activeTab) because it gives a stronger guarantee that the user wants the extension to run on the given site. Note: this does not allow any other action on these restricted pages; only capturing the page is permitted. The new behavior enforces the following permission requirements for the host types: <arbitrary web page>: activeTab OR <all_urls> file:-scheme page: (activeTab OR <all_urls>) AND explicit file access from chrome://extensions. Pages restricted by enterprise policy: blocked Extension's own page: activeTab OR <all_urls> Another extension's page: activeTab chrome:-scheme page: activeTab Support for IPv6 pages and pseudo urls is dependent on these being properly supported with activeTab, which will be pursued in a followup. Bug: 839857 Change-Id: Ied3a71732cd5d41ad16f9b459f6fda9b1815edaf Reviewed-on: https://chromium-review.googlesource.com/1102902Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568471}
-
Justin Cohen authored
Previous CL was iPad only, but these tests are failing all over. TBR=olivierrobin@chromium.org Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I777f2677202564eb26a8b2735f3df55a1dfff3d9 Reviewed-on: https://chromium-review.googlesource.com/1106220Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568470}
-
Scott Violet authored
And updates the functions to better reflect what it is suppose to do. There was a race conditions with how the code was before. In particular, because access to content has to be on the io-thread care must be taken during destruction. Creation of the interfaces happens on the io thread, which means destruction of the object supplied to AddInterface() has to happen on the io-thread. I separated out the parts that happen on the io thread into a refcounted thread safe that is destroyed on the io thread. BUG=837686 TEST=covered by tests Change-Id: Ia3dce4894a3cf4b7a08cd5a9c4d1fae674d7e7c5 Reviewed-on: https://chromium-review.googlesource.com/1105611Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568469}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ee3e3a4f3cba..a1ea4276f87f git log ee3e3a4f3cba..a1ea4276f87f --date=short --no-merges --format='%ad %ae %s' 2018-06-19 tsepez@chromium.org fxcrt::{Byte,Wide}String missing move-assign operator Created with: gclient setdep -r src/third_party/pdfium@a1ea4276f87f The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifaa597fcb85a33cdd60f0cf0799170c1e7d76e4b Reviewed-on: https://chromium-review.googlesource.com/1106099Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568468}
-
Moe Ahmadi authored
After crrev.com/c/1078871 that updated FormSuggestionView and FormSuggestionLabel to use AutoLayout, autofill suggestions started showing in reverse order (i.e., the first suggestion was shown last and had to be scrolled to get to). This CL fixes that regression. Bug: 852910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6aebe579a8ec958ba9a12339396c2b0ddef45406 Reviewed-on: https://chromium-review.googlesource.com/1101482Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568467}
-
nednguyen authored
Bug: 849363 Change-Id: Ief8da1eda983c68c0db49f08cbca7d388c952741 Reviewed-on: https://chromium-review.googlesource.com/1102910Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568466}
-
rbpotter authored
Remove field trial configs for print scaling and print PDF as image, since these features have launched. Bug: None Change-Id: I667a797ebc4bdbe71fe37acf4a00ef0d34718223 Reviewed-on: https://chromium-review.googlesource.com/1103307Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568465}
-
Matt Menke authored
Also remove a couple that either no longer exist, have been disabled generally due to flakiness, or are now passing. BUG=844950, 844951, 844952, 853251, 844928, BUG=843205, 844949, 844925, 844939, 821021, BUG=853798, 844973, 844927, 844926, 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I094a012fe2076c7badf86a094140c7d74db183be Reviewed-on: https://chromium-review.googlesource.com/1104802 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568464}
-
Ken Rockot authored
Introduced by r567334. Oops. Bug: b/110332037 Change-Id: Ie1262a09d2fcb19ee166cb46184c9d01cecf2e06 Reviewed-on: https://chromium-review.googlesource.com/1105462Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568463}
-
Jeremy Roman authored
TimeTicks is less ambiguous and more consistent with the rest of Chromium. Change-Id: Ia3ba6053d65a4ae332a4c563bf89d9c85bfd493c Reviewed-on: https://chromium-review.googlesource.com/1105341Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568462}
-
lanwei authored
After we changed to use ui::TouchEvent to represent stylus input instead of ui::MouseEvent, we should not set its flag to left button or right button when we press or release the pen on the tablet or any button on the pen. Bug: 850011 Change-Id: I2c2dc11e2cc625691aee11c14f28e632e0c15df3 Reviewed-on: https://chromium-review.googlesource.com/1099876Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#568461}
-
Dominik Röttsches authored
After feedback in https://twitter.com/TiroTypeworks/status/1007383133061185536 ensure that the mentioned characters are segmented correctly. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If9013658c6309678556ba87f39c1c9923acb86d7 Reviewed-on: https://chromium-review.googlesource.com/1105047 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568460}
-
Dominik Röttsches authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8f1ed54877ff..7915fd51f123 $ git log 8f1ed5487..7915fd51f --date=short --no-merges --format='%ad %ae %s' 2018-06-19 wl Doh. Don't use CPAL or COLR data if tables are missing. 2018-06-18 wl Oops! 2018-06-18 ramakrishnan.nikhil Some more minor doc fixes. 2018-06-18 wl More minor doc fixes. 2018-06-18 wl Minor documentation fixes. 2018-06-18 wl Introduce `@example:' subsections. 2018-06-18 wl Add example for `FT_Get_Color_Glyph_Layer'. 2018-06-17 apodtele [base] Introduce `FT_New_Glyph'. 2018-06-18 ramakrishnan.nikhil Change documentation markup tags to lowercase. 2018-06-17 wl Typo. 2018-06-17 prince.cherusker [bdf] Fix underflow of an unsigned value. 2018-06-17 wl Fix documentation indentation; s/@const/@enum/; harmonize doc keywords. 2018-06-17 wl [base] Add tracing for `FT_Bitmap_Blend'. 2018-06-17 wl s/trace_bitmap/trace_checksum/. 2018-06-16 wl [sfnt] Fix color glyph layer loading. 2018-06-16 wl [sfnt] Fix color palette loading. 2018-06-16 wl Minor formatting. 2018-06-16 ramakrishnan.nikhil Minor formatting. 2018-06-16 wl * src/base/ftbitmap.c (FT_Bitmap_Blend): Avoid integer overflow. 2018-06-16 wl Add `FT_Bitmap_Blend' API. 2018-06-14 wl Replace `FT_Get_GlyphLayers' with `FT_Get_Color_Glyph_Layer'. 2018-06-14 wl Provide iterative API to access `COLR' data. 2018-06-14 wl Add glyph index and glyph load flags to glyph slot. 2018-06-14 wl [sfnt] Move `CPAL' stuff into separate files. 2018-06-13 wl [sfnt] Separate `CPAL' and `COLR' table handling. 2018-06-12 wl [sfnt] Fix `sizeof' thinko. 2018-06-12 wl Finish CPAL/COLR support (4/4). 2018-06-12 wl Finish CPAL/COLR support (3/4). 2018-06-12 wl Finish CPAL/COLR support (2/4). 2018-06-11 wl Finish CPAL/COLR support (1/4). 2018-06-12 wl [sfnt] Minor. 2018-06-12 apodtele Doc fixes and improvements. 2018-06-11 apodtele [raster] Clean up. 2018-06-11 wl Minor doc fixes. 2018-06-10 wl [sfnt] Fix compiler warnings. 2018-06-10 wl s/FT_Palette/FT_Palette_Data/, s/palette/palette_data/. 2018-06-10 madigens CMakeLists: also accept IOS_PLATFORM=SIMULATOR64 2018-06-10 wl Implement `FT_Palette_Get'. 2018-06-10 wl * src/sfnt/ttcolr.c (tt_face_load_colr): Improve overflow checks. 2018-06-09 apodtele [raster] Deal with pitch sign earlier. 2018-06-09 wl [sfnt] Read `CPAL' version 1 tables. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1115 Change-Id: I5efcaae92db23e377ce3a57d26bd833e31fef1f0 Reviewed-on: https://chromium-review.googlesource.com/1105958 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568459}
-
chrome://settings/languagesAnthony Vallee-Dubois authored
Bug: 818242 Change-Id: Ie5295fb0c2c1605cf15a340c965a56629c6c867c Reviewed-on: https://chromium-review.googlesource.com/1093022 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568458}
-
Uladzimir Miniailau authored
Remove unnecessary "Enable" from a password manager feature name. Bug: 785953 Change-Id: Ifafb1302ed5563dbeef00228cb90555515ecd1d7 Reviewed-on: https://chromium-review.googlesource.com/1105990 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568457}
-
kylechar authored
The tests disabled by these filters are disabled by DISABLE_ macro, don't exist or are disabled in a different filter file already. Bug: 807465, 854120 Change-Id: I6c7a854c266fa2099b55098857973e0e5640981d Reviewed-on: https://chromium-review.googlesource.com/1104967 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568456}
-
Mustaq Ahmed authored
Also fix window-postMessage-user-gesture.html expectation for UAv2. Bug: 805015 Change-Id: I669a5b01c3c0862a511978a9ec8d56a813ccfa77 Reviewed-on: https://chromium-review.googlesource.com/1104702 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#568455}
-
Annie Sullivan authored
Bug: 854203 Change-Id: Ib0d95f8cb95fed8f617ab6f8dee0d2e16e1d84f1 TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1106055Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568454}
-
Jeremy Roman authored
There are a handful more that do something subtle, but most are easily captured by the higher-level testing utility. Change-Id: Ie79ee46470384bee7addfea8bb40ccb0932ba8c1 Reviewed-on: https://chromium-review.googlesource.com/1105308Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568453}
-
John Budorick authored
TBR=dpranke@chromium.org Bug: 828031 Change-Id: I0c26116e0222a1d47ad5537a0b171f2fcfa022ef Reviewed-on: https://chromium-review.googlesource.com/1106049Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#568452}
-
Francois Doray authored
This will be used to periodically unfreeze LifecycleUnits, to allow them to update their state. Bug: 775644 Change-Id: I498930c8a555ddf3581099e61972aaeac6a36d91 Reviewed-on: https://chromium-review.googlesource.com/1099973 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#568451}
-
Mike Dougherty authored
The ContextMenu.DelayedElementDetails metric ensures that all awaiting requests are eventually processed by either the user cancelling or by the DOM element details being returned. The ContextMenu.CancelSystemTouches metric logs that the system touches were cancelled. This value should match the number of Context Menus shown, otherwise a user could continue to interact with the page after the Context Menu has been displayed. Bug: 817517 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4dc5d9d14eba12c06ca034b80c037bd673230878 Reviewed-on: https://chromium-review.googlesource.com/1102994 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#568450}
-
Oskar Sundbom authored
I stumbled on a couple of crashes where it looks like the audio thread is deadlocked on the event_.Wait() call. From what I can tell, there's no way to recover from a fail thread creation, so any thread that calls SimpleThread::Start() has a chance of freezing indefinitely. This was changed[1] from a CHECK to a DCHECK way back in 2011. There shouldn't be any valid cases where thread creation fails, so it's probably better to get a clean crash as soon as this happens, than possibly getting a crash dump much later, provided a watchdog kicks in. [1] https://codereview.chromium.org/8368009 Bug: 854154 Change-Id: I72f7318642a39b0e1b23964f0841423bc9e87496 Reviewed-on: https://chromium-review.googlesource.com/1104679Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568449}
-
clamy authored
These histograms were introduced to track the time between an intent reception or link click and the commit of the navigation and end of page load. We now have a more robust loading metrics architecture and they have not been used in a while. Bug: 708035, 691867 Change-Id: Ic9bcd7df968ba32e6148483abeccd074a502ddca Reviewed-on: https://chromium-review.googlesource.com/1099171Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568448}
-
jonross authored
Currently SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView is using a legacy method for waiting for hit test data. This change updates it to use the new HitTestRegionObserver. However there is a bug in the /2 variant of the test, there overlapping hit test regions are not submitted. Due to this I have it exit early in that config. TEST=SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView Bug: 846798 Change-Id: I410d493f1abc7334e4cc21c3c4edceb4e2edd8c9 Reviewed-on: https://chromium-review.googlesource.com/1102721Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#568447}
-
Ken Rockot authored
Removes the last vestiges of non-Mojo targets depending on Mojo internal types. Changes the //mojo/edk target to only expose the bare minimum API needed for embedders to initialize Mojo and IPC. Deletes some now unused types, PeerConnection and OutgoingBrokerClientInvitation. Cleans up a few scattered dependencies. TBR=dschuff@chromium.org Bug: 844763 Change-Id: I7f6ae2987b25fc2089608efea59bee52f15aec4b Reviewed-on: https://chromium-review.googlesource.com/1102120 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568446}
-