- 28 Feb, 2019 40 commits
-
-
Yusuf Ozuysal authored
This changes the logic for the thumbnail to properly reset while reusing old ViewHolders in the RecyclerView. It also adds tests using DummyUIActivity for the View/VIewBinder logic in the TabList component. BUG=935714 Change-Id: Iabf4defc977bfbc38c98f02ee9a9fcca999bf190 Reviewed-on: https://chromium-review.googlesource.com/c/1484735Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636586}
-
Christopher Cameron authored
Plumb the result of shortcut creation through to BookmarkAppReparentTab. On macOS, only allow reparenting tabs for which a shortcut was successfully created. Enforce this requirement only on macOS, as it is not a requirement on other platforms. Change-Id: Ibb639da5d58223eda728b0a828c84237b1a77c69 Reviewed-on: https://chromium-review.googlesource.com/c/1491140 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#636585}
-
Meilin Wang authored
This change introduced a new mode of libassistant called SIGNED_OUT to assistant service, where Assistant server allows requests to still be made with the absence of user credentials. This mode makes it possible to test assistant service functionalities without real gaia login. and then run: test_that -b board DUT_ip assistnt_Startup.feature_tests. Bug: b/124415316 Test: remove the gaia login dependency manually in assistant_Startup.feature_tests Change-Id: I5301396820cad57ba9a567e486ee6bdae44fa77a Reviewed-on: https://chromium-review.googlesource.com/c/1490402 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636584}
-
Chris Cunningham authored
The finch configuration underwent some name changes, so just making the names match here. Bug: 920473, 920476, 920472 Change-Id: I115b7874593473d2e14a031f068a0791a5e2baeb Reviewed-on: https://chromium-review.googlesource.com/c/1490739 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#636583}
-
Yusuf Ozuysal authored
Enable undo for the TabList UI module. Adds an API to insert at given index to the PropertyModel and uses that to undo at the right place. BUG=936925 Change-Id: Ida747684a31bea7fefd128ce156a18045d8bb6bb Reviewed-on: https://chromium-review.googlesource.com/c/1495453 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
Manu Cornet authored
I am not really sure what these expectations are supposed to test. SKColorTRANSPARENT is defined as R = G = B = A = 0. So GetBaseColor() of SkColorTRANSPARENT is black. So what these expectations are testing is basically that the shelf background target color always gets back to a hardcoded black, which doesn't seem desirable (that color can change and is defined as shelf "base color" in shelf_constants.h, this sounds like a "change detector" test that isn't helping much) and seems very different from what the test claims to be checking in the first place. This removes some expectations where they didn't really make sense. Change-Id: Ic346b0aade25790d3645bb987c8bc483e39ebb6b Reviewed-on: https://chromium-review.googlesource.com/c/1493084 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
The Chrome OS power daemon's create timers D-Bus API now implicitly deletes any old timers registered with a tag. Consequently, this change changes the ARC++ client's implementation to not call a delete timers call before calling the create D-Bus API. BUG=chromium:916044 TEST=Run unit tests. Change-Id: I2fb07b5d417d24f6518e369f5f82b18165962506 Reviewed-on: https://chromium-review.googlesource.com/c/1493819Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636580}
-
Tony de Luna authored
The kiosk button is visible if there are apps to show and the session state is LOGIN_PRIMARY. During OOBE enrollment we were not sending the list of apps and we were not updating session state to LOGIN_PRIMARY after enrollment. KioskAppMenuUpdater is responsible for updating the list of apps shown by the shelf Apps button. KioskAppMenuUpdater is always created on LoginDisplayHostMojo but was missing from LoginDisplayHostWebUI. Sessions that started with OOBE would not get an app list and the Apps button wouldn't be shown. Bug: 936641 Change-Id: I2fb4ad6df255d06c2e5e76a702b63bce0a43c395 Reviewed-on: https://chromium-review.googlesource.com/c/1493440 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#636579}
-
Ella Ge authored
TBR: majidvp@chromium.org No-Try: true Bug: 915352 Change-Id: I9e9ab79de26d2b7e335f8a334cd373064251fef6 Reviewed-on: https://chromium-review.googlesource.com/c/1495745Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#636578}
-
Josh Nohle authored
CryptAuth will only authorize Instance ID tokens that use the shared authorized entity (also known as sender ID) 16502139086. Bug: 899080 Change-Id: I8ba553f295d7ec5422d6aaa4f6e446aea19b9c27 Reviewed-on: https://chromium-review.googlesource.com/c/1495854Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#636577}
-
Ayu Ishii authored
Set net::LOAD_VALIDATE_CACHE flag instead when requesting service worker scripts with viaCache value Bug: 925249 Change-Id: I45578d8c0f61676b0958cfab9a7057796c0d2d0d Reviewed-on: https://chromium-review.googlesource.com/c/1474386 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636576}
-
David Quiroz Marin authored
There is a test for createImageBitmap that checks whether the source image can not be allocated (DstBufferSizeHasOverflow) and rejects the promise returning a null object when it should reject with kInvalidStateError Bug: 799025 Change-Id: I57b3afad681161e89c3cff746c3e433c31fe9895 Reviewed-on: https://chromium-review.googlesource.com/c/1495835 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636575}
-
Justin DeWitt authored
Bug: 935795 Change-Id: Ifab2596ca6bea3a72fc5a8b620d71604576f3833 Reviewed-on: https://chromium-review.googlesource.com/c/1487522Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636574}
-
Ella Ge authored
Tests: symbols-function-invalid.html system-additive-invalid.html system-fixed-invalid.html system-numeric-invalid.html system-symbolic-invalid.htm also flaky on Linux and Win flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcss%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fcounter-styles-3%2Fsystem No-Try: True TBR: eirage@chromioum.org Bug: 935689 Change-Id: Ib6724b44713a9a8cb7370adf781d948aa99615e2 Reviewed-on: https://chromium-review.googlesource.com/c/1495742 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
Patrick To authored
Rename two test classes that currently have "OpenVR" in its name. These classes do not have OpenVR specific implementations and can be generalized to support other runtimes. - OpenVRTestHook -> VRTestHook. The file is also moved from /device/vr/openvr/test to /device/vr/test. - MockOpenVRDeviceHookBase -> MockVRDeviceHookBase Change-Id: I7b8ecad096e7c787d39a59fd7308fc25fdc904db Reviewed-on: https://chromium-review.googlesource.com/c/1479813 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636572}
-
Ella Ge authored
This reverts commit f57001bc. Reason for revert: suspect causing media/controls-drag-timebar-rendering.html failing on multiple builder Original change's description: > Show controls and update time indicators during seeking > > This commit modifies the MediaControls to show the controls and update > the current time indicators (current time text + timeline thumb) > immediately during seek requests so the element behavior during rapid > seek requests (e.g. user is holding down the FF button on their BT > keyboard) look similar to when a user is scrubbing the timeline with > their mouse. > > Bug: 748749 > > TEST=MediaControlsImplTest, manual testing > out/Debug/bin/run_webkit_unit_tests -f *MediaControlsImplTest* > > Change-Id: I6588aded2a93e081a6ca638ee1da534ea00abf4d > Reviewed-on: https://chromium-review.googlesource.com/c/1274945 > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636493} TBR=mlamouri@chromium.org,steimel@chromium.org,agdoug@amazon.com Change-Id: I37ebe9e972218afb164eead7c7f1142993bbb311 No-Presubmit: true No-Try: true Bug: 937029 Reviewed-on: https://chromium-review.googlesource.com/c/1495803Reviewed-by:
-
Gabriel Marin authored
Conditionally compile the heap profiler code and its dependencies when enable_profiling is set to true. This removes 9 static initializers in memory_region_map.cc with the new tcmalloc in release builds. BUG=b:119055819 TEST=Unit tests pass Change-Id: I99adbf662d97f40304e698661506ad0d2c066d79 Reviewed-on: https://chromium-review.googlesource.com/c/1464324 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636570}
-
Josh Nohle authored
Add the prefix "DeviceSync" to all unit tests in the chromeos/service/device_sync directory so all tests can be run with --gtest-filter="DeviceSync*". Bug: 899080 Change-Id: I0ed1124daa853da2c4ebecd2ec229dbcf5fea7bf Reviewed-on: https://chromium-review.googlesource.com/c/1495796Reviewed-by:
-
Yoichi Osato authored
This patch is a preparation for Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports removal. Intent to Deprecate and Remove: http://bit.ly/2RGHe3x Though we soon make these APIs only available for test by turning the json5 feature flag from status: "stable" to status: "test", there is browser tests/chrome internal components that use them. ZipArchiver is a one of them and this patch reenable the APIs for it. We should migration it using new APIs. Bug: 766694 TEST: browser_tests --gtest_filter=*FilesAppBrowserTest*zipFile* on patch crrev.com/c/1481130 Change-Id: Ica140afb8c78b990af3fd7ecfd85ffffce8f4635 Reviewed-on: https://chromium-review.googlesource.com/c/1493986Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#636568}
-
Saman Sami authored
The renderer's surface should not be destroyed while it is still visible, because future CompositorFrames to that surface will be rejected. Bug: 933374 Change-Id: I46c34bad903f052bfd2ee43e6b673a8ef26fca30 Reviewed-on: https://chromium-review.googlesource.com/c/1495368 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#636567}
-
Marcin Wiącek authored
This patch is aligning various @IntDef to some standard used with many other CLs: 1. @IntDef is first, @Retention second and related @interface third 2. there is used @Retention(RetentionPolicy.SOURCE) 3. @IntDef entries are inside @interface BUG=919666 Change-Id: I2d9f057071bfa282809545a91d6917908e1594f5 Reviewed-on: https://chromium-review.googlesource.com/c/1480371Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#636566}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/201f136c9907..a1924739029e git log 201f136c9907..a1924739029e --date=short --no-merges --format='%ad %ae %s' 2019-02-28 bclayton@google.com SpirvShader: Fix variable construction of non input/output storage. 2019-02-28 hliatis@google.com Advertise support for VK_KHR_swapchain 2019-02-28 hliatis@google.com Add basic VkSurfaceKHR (Xlib only for now) 2019-02-28 chrisforbes@google.com Remove partial logic op support 2019-02-28 chrisforbes@google.com Use sample count from multisample state, not from attachment 0 2019-02-28 chrisforbes@google.com Fix Context::colorWriteActive to consider all rendertargets Created with: gclient setdep -r src/third_party/swiftshader@a1924739029e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124265819,chromium:b/124265819,chromium:b/126417154,chromium:b/126719156 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I7228d7a1b36268db5974e4f7a309993964bdf288 Reviewed-on: https://chromium-review.googlesource.com/c/1494832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636565}
-
Navid Zolghadr authored
Bug: 874948 Change-Id: I9027567fcdefef414b8d261a546be8c0b1b979dc Reviewed-on: https://chromium-review.googlesource.com/c/1491998Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636564}
-
Oystein Eftevaag authored
The four of us haven't been actively working with the code for a while now. R=fdoray@chromium.org Change-Id: Ide0dc0c0bbd3962e66bce123f567848b7dd2da78 Reviewed-on: https://chromium-review.googlesource.com/c/1495210Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#636563}
-
Steven Bennetts authored
This CL: * Introduces a NetworkIconState to cache state that the network icon code cares about in an intermediate format that will be compatable with Mojo network state. * Fixes a rather bad edge case (that I previously introduced) where ActiveNetworkIcon stores pointers to NetworkState that could possibly be accessed after being deleted. * Modifies the criteria for ActiveNetworksChanged() to include significant changes to signal strength. * Adds some verbose logging for continued debugging. Bug: 923444 Change-Id: I917b353c9da7a3c5e20dc8e69191a6a97f752aa9 Reviewed-on: https://chromium-review.googlesource.com/c/1469521Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Eric Stevenson authored
Was already done for native functions but missed when calling native instance methods. Bug: 934847 Change-Id: Ie4bfbe81c748d8f3c78de77cd759ff4d2c804791 Reviewed-on: https://chromium-review.googlesource.com/c/1495443 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#636561}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iaaf076b7c6e7fa6e473cd835d579e1d8f57a3fbd Reviewed-on: https://chromium-review.googlesource.com/c/1494828Reviewed-by:
-
Josh Nohle authored
Add a five-minute delay between immediate-retry attempts in the CryptAuth v2 Enrollment scheduler. It is probably a good idea to wait a short amount of time before retrying a failed enrollment attempt; otherwise, we might burn through all allotted "immediate" retry attempts specified by CryptAuth because of a transient failure. Also, CryptAuth throttles SyncKeys requests if more than one is sent within a five-minute window. Bug: 899080 Change-Id: Ie8d39b5e9d5af4464ac93200508b680e7039014c Reviewed-on: https://chromium-review.googlesource.com/c/1495739Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a0a1dcc95853..f6d776ff4a4a git log a0a1dcc95853..f6d776ff4a4a --date=short --no-merges --format='%ad %ae %s' 2019-02-28 dgarrett@google.com workspace_stages: Add test coverage for WorkspaceSyncChrome. Created with: gclient setdep -r src/third_party/chromite@f6d776ff4a4a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I9b6efa9c4116b2c6e40fb249c8ba2ccbe7bf628a Reviewed-on: https://chromium-review.googlesource.com/c/1494937Reviewed-by:
-
Brandon Jones authored
This requires all sessions that were previously setting an outputContext in the requestSession call to move that assignment to an updateRenderState call post-session-creation instead. Additionally, "inline" sessions can now be created without an outputContext but must still have one assigned to them before any requestAnimationFrame callbacks will be processed. Bug: 928417 Change-Id: I469fab8c3f641870387f2f92aee52182016efe37 Reviewed-on: https://chromium-review.googlesource.com/c/1476097 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#636557}
-
Avery Musbach authored
CanSnapInSplitview() checks stricter requirements than WindowState::CanSnap(), meaning that a window snapped in clamshell mode might not be appropriate to carry over to split view on entering tablet mode. Now the tablet mode window manager shall seek approval from CanSnapInSplitview() before attempting to carry over a snapped window to split view on entering tablet mode. TabletModeWindowState::TabletModeWindowState() shall no longer call TabletModeWindowState::GetSnappedWindowStateType(), because the whole purpose of that function is to check CanSnapInSplitview() which shall have already been checked in the tablet mode window manager. Test: ash_unittests TabletModeControllerTest.StartTablet*DesktopOnly* Bug: 936478 Change-Id: If4f732d7276d7cae438fe08a919a13f170986f7d Reviewed-on: https://chromium-review.googlesource.com/c/1492351 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
Daniel Libby authored
Currently, on both main and impl thread scrolling, if an in-progress scroll animation is updated in response to the GestureScrollUpdate, we do not get a TimeToScrollUpdateSwapBegin4 histogram value. This is due to the fact that we don't notify the LatencyInfoSwapPromiseMonitor while the input event is being handled, since only the scroll animation target is updated. This change adds calls that triggers the appropriate notifications so that the swap promises eventually trigger such that the LatencyInfo objects get shipped off with the CompositorFrame at a later point in time. Added to an existing layer_tree_host_impl unittest to verify we get the swap promise monitor notification when updating an animation. The main thread case was not as easily unit tested, so expanding and existing scroll wheel test in content_browsertests to perform multiple wheel-based scroll gestures and verify we see the appropriate histograms emitted. R=bokan@chromium.org, nzolghadr@chromium.org, tdresser@chromium.org Bug: 923498 Change-Id: Ia211800f96c304cdfebf2599e310e2bea8500d96 Reviewed-on: https://chromium-review.googlesource.com/c/1476208 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636555}
-
Tsuyoshi Horo authored
Bug: 910516 Change-Id: Iad6e51586678a3b391409d0f6526f62781d677a3 Reviewed-on: https://chromium-review.googlesource.com/c/1493688Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636554}
-
Rob Schonberger authored
This fixes a UI bug only visible when this flag is on. Bug: 911427 Change-Id: I31749509a5ba929fc484ae2812180bb2a5749fc1 Reviewed-on: https://chromium-review.googlesource.com/c/1491737 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636553}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe34723a55ec..fe83cfa6b43a git log fe34723a55ec..fe83cfa6b43a --date=short --no-merges --format='%ad %ae %s' 2019-02-28 hferreiro@igalia.com Add --current to rebase the current branch Created with: gclient setdep -r src/third_party/depot_tools@fe83cfa6b43a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7cde445615f55d5c2229f41695326da9421054f5 Reviewed-on: https://chromium-review.googlesource.com/c/1494833Reviewed-by:
-
Mike Wittman authored
Updates the field and accessor name to reflect its actual state, and to be consistent across platforms. Bug: 931418 Change-Id: I758a7bb8c8183174c42142563203e8e5acd20c37 Reviewed-on: https://chromium-review.googlesource.com/c/1478250 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#636551}
-
Antonio Gomes authored
... from t_p/blink/renderer/platform/. This is a first step to clean up how callbacks are handling in modules/filesystem. BUG=933878 R=jbroman@chromium.org CC=mek@chromium.org,blink-reviews-vendor@chromium.org Change-Id: I0d75062132af40e7e8038e1e90163d3b88d84caa Reviewed-on: https://chromium-review.googlesource.com/c/1494681Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#636550}
-
Nico Weber authored
It was only used by MSVC which we no longer use, and it required including sal.h (somewhat large) in compiler_specific.h (somewhat commonly included). clang-cl now no longer needs to process sal.h, which will help with build times a tiny bit. We still get the format string protection through the PRINTF_FORMAT macro. (WPRINTF_FORMAT on the other hand is a no-op and clang-cl seems to not check wprintf style format strings. So we do lose some coverage here for wide strings, but we lost that when we switched to clang-cl.) TBR=slangley Bug: none Change-Id: Iab02869cb06682500ab31e1810c070708347ad64 Reviewed-on: https://chromium-review.googlesource.com/c/1494679 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#636549}
-
David Bokan authored
In https://crrev.com/45236fd563e9df53dc45579be1f3d0b4784885a2 I did a heavy refactoring of how fragment anchors work and when they get invoked. This refactoring removed the layout call from LocalFrameView::ProcessUrlFragment. This is desirable since it should be layout that drives the fragment anchor, not the other way around. In general avoiding surprise layouts is good. I assumed this would be ok since we'll invoke the fragment anchor again in the next layout. However, there's a case where this isn't true. When a document finishes loading (Document::ImplicitClose) it will invoke the fragment anchor. The fragment anchor will then be removed since the document is already in the "load completed" state. If the iframe finishes loading without any layouts this call will be the only invocation and it'll happen on a dirty layout tree. The solution in this CL is to remove that invocation in ImplicitClose while layout is dirty potentially dirty. If layout is dirty it'll be invoked when we perform the layout. This leaves the only two ways for the anchor to be invoked as: - Right after a layout - When the fragment is first set and layout is already clean Change-Id: I3f038a4e35038a0cd9e4a17593b9b6b3d810068f Bug: 934405 Reviewed-on: https://chromium-review.googlesource.com/c/1481054 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#636548}
-
John Lee authored
This makes available an endpoint chrome://welcome/preview-background.jpg that takes in a parameter of a number, referring to the index in the whitelist of NTP backgrounds for Onboarding to fetch. Change-Id: I99ec3cc83852b88f56bc0bc58c2d1ef6dfbb2202 Reviewed-on: https://chromium-review.googlesource.com/c/1481890 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636547}
-
