GitLab

The ViewportControl.scrollItemIntoView mistakenly operates in terms of
first and last active elements; instead, it should rely on first and
last visible elements.

The patch also changes firstVisibleElements and lastVisibleElements
to always rely on cumulative heights.

BUG=none
R=einbinder

Review-Url: https://codereview.chromium.org/2359563003
Cr-Commit-Position: refs/heads/master@{#420010}

Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker.

Required to enable per thread heap on DedicatedWorker.

BUG=591606

Review-Url: https://codereview.chromium.org/2354903004
Cr-Commit-Position: refs/heads/master@{#420009}

This reverts commit 2d6fa4fd.

Compilation failed on the Google Chrome Win bot.
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/11064

R=dbeam@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review URL: https://codereview.chromium.org/2355233002 .

Cr-Commit-Position: refs/heads/master@{#420008}

.. and, sadly, remove gabadie@

BUG=none

Review-Url: https://codereview.chromium.org/2317663002
Cr-Commit-Position: refs/heads/master@{#420007}

Restoration of a last closed window is done by TabRestoreService.
However if that window is going to be the first window for a profile,
SessionService will perform restoration and there will be conflict
between services. It leads to tabs duplication.

BUG=500083

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2345763002
Cr-Commit-Position: refs/heads/master@{#420006}

Review-Url: https://codereview.chromium.org/2344143002
Cr-Commit-Position: refs/heads/master@{#420005}

https://chromium.googlesource.com/chromium/src/+/9a66a83a2

BUG=634285
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/2358763002 .

Cr-Commit-Position: refs/heads/master@{#420004}

BUG=464234

Review-Url: https://codereview.chromium.org/2354923004
Cr-Commit-Position: refs/heads/master@{#420003}

BUG=555865

Review-Url: https://codereview.chromium.org/2352703003
Cr-Commit-Position: refs/heads/master@{#420002}

[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb image to single-sampled srgb image.

Per our discussion with @piman and @kbr at https://codereview.chromium.org/2286593002/,
The current code is correct, no further work to be done. Simply remove this TODO is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2356813002
Cr-Commit-Position: refs/heads/master@{#420001}

This test is no longer flaky after being deflaked in
https://codereview.chromium.org/2346163003.

Flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Fanimations%2Fopacity-responsive-neutral-keyframe.html

BUG=647776
TBR=ielelland@chromium.org

Review-Url: https://codereview.chromium.org/2350303006
Cr-Commit-Position: refs/heads/master@{#420000}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b476a27e48e383179a1461eb6f52f484d31ec5c0 Revert of Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py (patchset #6 id:100001 of https://codereview.chromium.org/2332283002/ ) (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=621828

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2359683002
Cr-Commit-Position: refs/heads/master@{#419999}

BUG=577685

Review-Url: https://codereview.chromium.org/2048503002
Cr-Commit-Position: refs/heads/master@{#419998}

This class is used only for passing bunch of parameters to the
ResourceDispatcher from the WebURLLoaderImpl. Inside ResourceDispatcher,
almost all of the members are just copied to a ResourceRequest created
in it and converted into an IPC message. It's useless and is bothering
developers with extra click when exploring and coding of trivial lines.
Let's remove it.

Comments in request_info.h are copied to resource_request.h and
resource_dispatcher.h if needed.

ResourceRequest creation logic in unit tests are adjusted so that
variables for which the default value of RequestInfo is different from
one of ResourceRequest are set to one of RequestInfo as before.

Bonus: Typo fix visiblity -> visibility

R=jam@chromium.org,tsepez@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2345253002
Cr-Commit-Position: refs/heads/master@{#419997}

Show this tooltip the first time a user goes into narrow mode with the new
history page.

R=tsergeant@chromium.org
BUG=598017
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2280513002
Cr-Commit-Position: refs/heads/master@{#419996}

When "cancel on defer is on", the multibuffer reader can sometimes get
delete before it is allowed to deliver a pending read callback. This basically
hangs the multibuffer data source as it waits for the read callback forever.

BUG=648395, 647867, 646434

Review-Url: https://codereview.chromium.org/2357773003
Cr-Commit-Position: refs/heads/master@{#419995}

1. The mime sniffer buffers some body data. This is a very confusing
   behavior for streaming usecases.
2. The fetch spec uses the MIME type with parameters which
   WebURLResponse::mimeType doesn't provide. We need to parse
   Content-Type header in any case and mime sniffing may introduce
   inconsistency here.
3. We don't see any benefit of mime sniffing for fetch() initiated
   requests.

From the above reasons we don't want the mime sniffer to run for fetch()
initiated requests.

BUG=2016

Review-Url: https://codereview.chromium.org/2323623002
Cr-Commit-Position: refs/heads/master@{#419994}

In a case of mouseup, we refer to event.target and mouse-related events
are never dispatched on disabled OPTIONs. In a case of touch, we need
to check disabled state manually because we don't use event.target.

BUG=624302

Review-Url: https://codereview.chromium.org/2360483002
Cr-Commit-Position: refs/heads/master@{#419993}

Cr-Commit-Position: refs/heads/master@{#419992}

|stringValue| may be empty.

BUG=629029

Review-Url: https://codereview.chromium.org/2350303005
Cr-Commit-Position: refs/heads/master@{#419991}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/b204faa4ed43b92a19079a9f675c7c1bcbe65128 Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=621828

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2355223002
Cr-Commit-Position: refs/heads/master@{#419990}

Correctly propagate minimum font size settings to page popups.

BUG=634285

Review-Url: https://codereview.chromium.org/2359663003
Cr-Commit-Position: refs/heads/master@{#419989}

* Existing support for 2x scale wasn't actually working.  Now it is.
* Uses chrome://theme/ URLs instead of direct references to image files on disk
  (will make mucking with that imagery in a separate patch easier, among other
  things).
* Uses transforms to flip folder images for RTL instead of dedicated resources.

For now there's still some ugliness since Mac is using a different set of
resources (file locations, resource IDs) than other platforms.  That will all be
cleaned up later.

BUG=564112
TEST=Run chrome with --force-device-scale-factor=2, open bookmark manager, check that folder icons in right-hand pane are high-res
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2350473003
Cr-Commit-Position: refs/heads/master@{#419988}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e979fa345e7e..7cddce097e8a

$ git log e979fa345..7cddce097 --date=short --no-merges --format='%ad %ae %s'
2016-09-20 charliea Fix bug where "start bisect" button was getting pushed off screen

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2355213002
Cr-Commit-Position: refs/heads/master@{#419987}

This adds:
  Q_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
to CLs in ui/file_manager.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2357733003
Cr-Commit-Position: refs/heads/master@{#419986}

This CL changes a BytesConsumer::endRead expectation. It can return
Result::Done and a caller needs to handle the return value.

BUG=610195

Review-Url: https://codereview.chromium.org/2351643004
Cr-Commit-Position: refs/heads/master@{#419985}

When clicking a link that can either be handled by the browser, or by an
external app, in incognito mode we now automatically choose the browser,
to keep the user within incognito mode as much as possible. Links that
can only be handled externally (e.g., intent:// and other system
schemes) are unchanged (prompt the user, then send an external intent).

Added a test that an intent:// URL in incognito mode will still prompt.

BUG=587306

Review-Url: https://codereview.chromium.org/2350933005
Cr-Commit-Position: refs/heads/master@{#419984}

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil.

BUG=610195

Review-Url: https://codereview.chromium.org/2356693002
Cr-Commit-Position: refs/heads/master@{#419983}

1) Ignore zero-height fragments during margin collapsing step.
See https://www.w3.org/TR/CSS2/box.html#collapsing-margins
2) Change the order of expected/actual for all EXPECT_EQ in ng_block_layout_algorithm_test
3) Add more test expectations for the collapsing margin logic.

BUG=635619

Review-Url: https://codereview.chromium.org/2350603002
Cr-Commit-Position: refs/heads/master@{#419982}

draft-ietf-tokbind-protocol-10:
- The TokenBinding.signature now closes over the token binding type.
- Public key serialization is length prefixed to support parsing unknown key types.
draft-ietf-tokbind-negotiation-05:
- Require Renegotiation Indication
draft-ietf-tokbind-https-06:
- Sec-Token-Binding header base64 shouldn't include pad characters.
- Include-Referred-Token-Binding-ID header's value is case insensitive.

This also updates the tls and quic code to indicate support for draft version 10.

BUG=467312

Review-Url: https://codereview.chromium.org/2337253004
Cr-Commit-Position: refs/heads/master@{#419981}

We are about to launch ImeThread (targeting M54), and in case we fail to
launch, we should be able to disable the feature safely.

BUG=648482

Review-Url: https://codereview.chromium.org/2349973008
Cr-Commit-Position: refs/heads/master@{#419980}

This makes the code much more readable and complies with the Chromium
style guide.

Review-Url: https://codereview.chromium.org/2357793002
Cr-Commit-Position: refs/heads/master@{#419979}

TEST=paint/invalidation/caret-color.html
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2354023002
Cr-Commit-Position: refs/heads/master@{#419978}

Currently, the Yank command on Mac and the selection clipboard on Linux can
reveal the text of an obscured/password Views::Textfield. This CL modifies
Textfield::UpdateSelectionClipboard() to ensure that the selection clipboard is
not modified for a password textfield. Textfield::ExecuteTextEditCommand(..) is
also modified to only update the yank kill buffer for a non-password textfield.
Unit tests which demonstrate the problem are also added.

BUG=648511, 648509

Review-Url: https://codereview.chromium.org/2358463002
Cr-Commit-Position: refs/heads/master@{#419977}

BUG=644649

Review-Url: https://codereview.chromium.org/2348843002
Cr-Commit-Position: refs/heads/master@{#419976}

BUG=None
TEST=try

Review-Url: https://codereview.chromium.org/2356953003
Cr-Commit-Position: refs/heads/master@{#419975}

This is a fix after r419951

BUG=610176
TBR=dcheng@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2357833002
Cr-Commit-Position: refs/heads/master@{#419974}

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.

Review-Url: https://codereview.chromium.org/2345013003
Cr-Commit-Position: refs/heads/master@{#419973}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2c1c32b86fc93210cff0450d29df4b47055643af Add goma_dir getter to recipe_module goma (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=621828

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2353083004
Cr-Commit-Position: refs/heads/master@{#419972}

WebMediaPlayerAndroid (WMPA) used the EstablishSurfacePeer construct and
the BrowserMediaPlayerManager to send a SurfaceTexture from the GPU
process to a MediaPlayer in the BrowserProcess.

MediaPlayerRender does not use a BrowserMediaPlayerManager, but needs a
way to receive surface textures from the GPU. This change introduces the
ScopedSurfaceRequestManager and the ScopedSurfaceRequestConduit.

The Manager allows the registration of a callback in the Browser
process, which can receive a ScopedJavaSurface. Upon registration,
the manager creates a token that can be used at a later time to
fulfill the request.
The Conduit forwards surface texture to the Manager, using the
issued token to route the ScopedJavaSurface to the right request.
From the GPU process, surfaces are sent via the ChildProcessServices
and the IChildProcessCallback, the same way that EstablishSurfacePeer
currently does. In single process mode, the Manager directly implements
the Conduit interface.

Security recommended 128 bits as the token size. It is represented by
base::Nonce class, which supports serialization accross IPC and Mojo,
and is easy to send as two uint64_t through JNI and AIDL.

The CL that covers the integration within StreamTexture and
MediaPlayerRenderer is tracked by the same bug, and can be
found at https://codereview.chromium.org/2282633002/.

Adding palmer@ as TBR, since he is the only owner for aidl files, but
is unavailable ATM.

TBR=palmer
BUG=627658
TEST=Added UTs, manually verified that it worked in the prototype.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2285593002
Cr-Commit-Position: refs/heads/master@{#419971}