- 26 Feb, 2019 40 commits
-
-
Jérôme Lebel authored
Don't show encryption error when sync is disabled. Bug: 914059 Change-Id: I719bf76ea87d670c8deda34532ed185a4d4d4685 Reviewed-on: https://chromium-review.googlesource.com/c/1487814Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635472}
-
Alex Ilin authored
SharedPersistentMemoryAllocator is based on obsolete shared memory classes and is being replaced by {Writable,ReadOnly}SharedMemoryAllocator. SharedPersistentMemoryAllocator is still used in base/debug/activity_tracker.h and base/debug/activity_analyzer.h. This CL converts these last clients of the SharedPersistentMemoryAllocator to the new allocators and removes SharedPersistentMemoryAllocator. Bug: 920183 Change-Id: Ic789dc79a5798135a43bd59bbaaa4d2977c96cbf Reviewed-on: https://chromium-review.googlesource.com/c/1481297Reviewed-by:Brian White <bcwhite@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635471}
-
Gauthier Ambard authored
This CL adds the logic to clear the browsing data from the web implementation of the BrowsingDataRemover. Bug: 619783 Change-Id: Ia4771a61a8482adf296816eed54dafb5498de932 Reviewed-on: https://chromium-review.googlesource.com/c/1477831 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#635470}
-
Nate Fischer authored
No change to docs information, this just utilizes Gitiles' feature for adding a site logo (https://github.com/google/gitiles/blob/master/Documentation/markdown.md#site-logo). This uploads a 45px tall Android System WebView logo (borrowed from internal CL http://cl/235462348, for consistency). Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I66dc613f0e1f681dc09b0a8c9d861ecdd5b0e904 Reviewed-on: https://chromium-review.googlesource.com/c/1488065 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#635469}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7180cebfd347..83af02a24a8e git log 7180cebfd347..83af02a24a8e --date=short --no-merges --format='%ad %ae %s' 2019-02-26 perezju@chromium.org [Telemetry] Remove clear_sytem_cache_for_browser_and_profile_on_start Created with: gclient setdep -r src/third_party/catapult@83af02a24a8e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244,chromium:902268 TBR=sullivan@chromium.org Change-Id: Id4787cb2f03cfd5630a5f08d2c358cf20aba4720 Reviewed-on: https://chromium-review.googlesource.com/c/1488502Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635468}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9b8d2b0bbfad..d56f8d2e0501 git log 9b8d2b0bbfad..d56f8d2e0501 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 cwallez@chromium.org Remove Chrome-specific configs for GLFW and GLM Created with: gclient setdep -r src/third_party/dawn@d56f8d2e0501 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935641,chromium:935704 TBR=cwallez@chromium.org Change-Id: I74e3cf161943daca3161d0b176069b2a64a82974 Reviewed-on: https://chromium-review.googlesource.com/c/1488503Reviewed-by:
-
Colin Blundell authored
As part of the effort to eliminate this class, this CL eliminates its last public API. We port the callers to either use identity_test_utils.h or directly use SigninManager::OnExternalSigninCompleted() as appropriate given the context of the test. Bug: 796544 Change-Id: I3f32b3fbb2285925a65d35d0041750281cfc67c5 Reviewed-on: https://chromium-review.googlesource.com/c/1486531Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635466}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ba9f084228f..de280d758ae2 Created with: gclient setdep -r src-internal@de280d758ae2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I97237198ba9e1b711d8fba82cf31b66814058235 Reviewed-on: https://chromium-review.googlesource.com/c/1488501Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635465}
-
Gauthier Ambard authored
The file was used for downstream compatibility. Bug: none Change-Id: Idd6baf6fd2542c3e67b49f1bec169d021922d79d Reviewed-on: https://chromium-review.googlesource.com/c/1475407 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#635464}
-
Joel Hockey authored
Added https://github.com/webcomponents/html-imports/blob/master/src/html-imports.js Many polymer files are using html imports of URLs such as chrome://resources/html/polymer.html. When running in UI test mode, none of the chrome://resources URLs will load. Previously it was fine for these requests to fail, since polymer and other libraries were being loaded explicitly from //third_party/polymer/ sources in the main document. But with this polyfill, a failure to load is causing the whole page to fail. We will follow up to patch the html-imports.js polyfill to translate chrome://resource URLs to the correct location of the related script within //ui/webui/ or //third_party/polymer/ Bug: 924873 Change-Id: I289aa1448b06a1ced131c9a3c5faf8a6fb53898e Reviewed-on: https://chromium-review.googlesource.com/c/1488482Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635463}
-
Jordan Demeulenaere authored
This CL replaces the cross button by a Cancel/Close button as shown in go/autobot-gallery-m74. We introduce back the hairline style as the Chrome ButtonCompat does not handle setting a custom background (e.g. the rounded border of hairline style). Ideally, we should add this functionality in ButtonCompat to inherit the button behavior (like ripple effect). When shown, the chips are now split into 2 carousels: - the suggestions carousel shows assistive chips. - the actions carousel shows (filled or hairline) buttons. The carousel now supports the CENTER alignment (valid only when it has a single chip/button to show) to center its child within the carousel. The "Go back" button on the details confirmation screen has been temporarily removed until the details screen is refactored to use the prompt action and that we can flag prompt choices as being a "Cancel" button. Animated transition of buttons will be added in a future CL. Screenshots: - https://screenshot.googleplex.com/q9M8Qx5yNZk.png - https://screenshot.googleplex.com/p54uTuZMmEh.png - https://screenshot.googleplex.com/HfgBqeOsMY5.png Bug: b/125283126 Change-Id: I4df01d97d2ef0b6682e9de9b225077043d15252f Reviewed-on: https://chromium-review.googlesource.com/c/1482896 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#635462}
-
Gauthier Ambard authored
This CL changes the height of the cells, making sure that they have 48pt when they only have one line of text, 58 when they have two lines. It also unifies the different font for the subtitles to Footnote. Reland of:https://chromium-review.googlesource.com/c/1474755 Bug: 922511 Change-Id: I4396927bc73ef6ef90abd4f5a9d059082b4ea068 Reviewed-on: https://chromium-review.googlesource.com/c/1479959 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635461}
-
Olya Kalitova authored
Adds images to the PluginVm launcher dialog: * Add logo image * Add FPO image * Add error image Renames a few of the images so the naming is consistent. Also replaces title with a big message label as logo image is supposed to be above it. Proper layout would be added in further CLs. Test: browser_tests --gtest_filter="PluginVm*" Bug: 931700 Change-Id: I6fb5e60909a6da50913d5cca96b725a4351748a1 Reviewed-on: https://chromium-review.googlesource.com/c/1477690Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#635460}
-
Fredrik Söderquist authored
Like in LocalFrameView::UpdateStyleAndLayoutIfNeededRecursive, explicitly update style (and attach the layout tree) before proceeding to layout. This ensures that the style update/layout tree attachment of the child document does not mark its frame owner as dirty after layout has already been performed for the top-level document. Bug: 933409 Change-Id: I6b2c864aededed7429c63cbd068ec45c58972ae0 Reviewed-on: https://chromium-review.googlesource.com/c/1481331Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#635459}
-
Andrew Moylan authored
This function is called by both TfNative and MlService codepaths, and ML Service code path was already logging success. Moved the logging out of the common function and made it explicit in each codepath. Bug: 935838 Test: no Change-Id: I8a9a5882f339866ffd309e7ffa87945adf455c7a Reviewed-on: https://chromium-review.googlesource.com/c/1488391 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635458}
-
Marc Treib authored
If local Sync is enabled, then ProfileSyncService::OnEngineInitialized() used to call TryStart(). TryStart() kicks off the engine initialization, which is obviously redundant at this point. So this CL removes the unnecessary call. Bug: none Change-Id: Iac2a01ff013e8034db446ed6200131829299b2bf Reviewed-on: https://chromium-review.googlesource.com/c/1486355 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#635457}
-
Nico Weber authored
Bug: 926235 Change-Id: I22f037731caaf8bcd693f2937195e8d5ddf8da91 Reviewed-on: https://chromium-review.googlesource.com/c/1487352Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635456}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I5c1a0002afd82cfbcfc2e6fcc72576e266b9791d Reviewed-on: https://chromium-review.googlesource.com/c/1488472Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635455}
-
Ivan Sandrk authored
This is a purely refactoring CL which doesn't modify any behaviour. Currently ArcSessionManager::RequestDisable also calls ArcSessionManager::RequestArcDataRemoval - there are use cases where we want to disable ARC and preserve user data, so decouple the two. This CL is a preparation for disabling of ARC inside of locked fullscreen mode. More details can be found on the design doc go/disabling-arc-locked-fullscreen Bug: 888611 Change-Id: Ifd2aad309c0300416aae3124d3f526ec7cf30a44 Reviewed-on: https://chromium-review.googlesource.com/c/1363202Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635454}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0bd66935e1028ca587363e5b045ac210344de291 Reviewed-on: https://chromium-review.googlesource.com/c/1488499Reviewed-by:
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=blundell@chromium.org Bug: 714018 Change-Id: I4268e80cb016b4a8958ea4803656396f66854f11 Reviewed-on: https://chromium-review.googlesource.com/c/1486611 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635452}
-
Ricky Liang authored
BUG=b:124281296 TEST=Take picture on people page and make sure the user-facing camera is opened if present. Change-Id: I80e1ab45289a1be924e06941a26364a3db784001 Reviewed-on: https://chromium-review.googlesource.com/c/1475017Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Auto-Submit: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635451}
-
Sriram authored
These tests are using "white" videos and the rendering is not actually "white" (the CSS color) used in ref test. Also the ref test has the font property (sans-serif) applied to the inner span, so we get a different font for the other span - that font has slightly different metrics (even though it's still 9px), so over the whole line this ends up yielding an "extra pixel" in height. Fixed the ref tests to use the actual <video> element instead of white background <div>, and also fixed the font size issue by applying font family to parent <span> element. BUG=930608, 626703 Change-Id: I44c33a8cda08aff2e8b84f2542cc504866bd4c10 Reviewed-on: https://chromium-review.googlesource.com/c/1485628Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#635450}
-
Adam Rice authored
Wrap v8.createPromise() in a createPromise() function which always sets the isSettled flag to false. Make resolvePromise() and rejectPromise() ignore promises that don't have the isSettled flag present. Replace Promise_resolve() and Promise_reject() with createResolvedPromise() and createRejectedPromise() functions that also set the isSettled flag. Strictly speaking, the createR*Promise() functions only need to be used when a promise is stored and might be resolved or rejected later. But to avoid confusion about where they are needed, always use them in place of Promise_resolve() and Promise_reject(). BUG=931640 Change-Id: I5472cb4a78f7b970ab256084b819ae28ffda6a33 Reviewed-on: https://chromium-review.googlesource.com/c/1481178Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#635449}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/478c5c145fc9..0ba9f084228f Created with: gclient setdep -r src-internal@0ba9f084228f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iecff5c34214da0974210d5faee58564e60b08ef8 Reviewed-on: https://chromium-review.googlesource.com/c/1488500Reviewed-by:
-
Luciano Pacheco authored
Fix closure errors Bug: 778674 Change-Id: I00f239f14f906e0489f038f24d90ccf343bcaf63 Reviewed-on: https://chromium-review.googlesource.com/c/1488480 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635447}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/202077e2810d..346e10e8ae1a git log 202077e2810d..346e10e8ae1a --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 377d493a0847..9a16248dedf3 (2 commits) Created with: gclient setdep -r src/third_party/skia@346e10e8ae1a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icaee3879cf477efeee763caaa1f64a4b2e64592d Reviewed-on: https://chromium-review.googlesource.com/c/1488498Reviewed-by:
-
Rakina Zata Amni authored
Currently when looking for locked ancestors of a node we are using the ParentOrShadowHostNode instead of doing a flat-tree traversal. Slotted nodes that are inside a display-locked subtree might behave incorrectly due to this. Example, affecting focus: <div id=shadowHost> #shadowRoot <div id='locked'> // locked div <slot> <input> // originally shadowHost's child Flat-tree: <div id=shadowHost> #shadowRoot <div id='locked'> // locked div <slot> <input> // slotted The slotted input shouldn't be focusable since it's actually inside a locked subtree, however ParentOrShadowHost will return the node tree parent - the shadowHost - because the slot is not the parent of the slotted input. Bug: 882663 Change-Id: Ic455aaec00554b0fb5a878a2d80636a3e902648e Reviewed-on: https://chromium-review.googlesource.com/c/1466547 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:vmpstr <vmpstr@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#635445}
-
Adam Rice authored
Expose methods and accessors that are used between the WritableStream C++ implementation classes publicly so that they don't have to be friends of each other. The order of the methods in the C++ files will be updated to match the headers in a follow-up CL. Bug: 902633 Change-Id: I26787cf13a1e4dcba63686d090dd5f36142cd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/1481144Reviewed-by:
-
Camille Lamy authored
This CL is part of a series of CLs that removes members from NavigationHandleImpl and queries them from NavigationRequest instead. This CL removes parameters passed to NavigationHandleImpl::WillProcessResponse. Bug: 916537 Change-Id: If35835e7034238fabe8dc4b9a4d933093b1249e1 Reviewed-on: https://chromium-review.googlesource.com/c/1450193Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#635443}
-
Oleg Davydov authored
Years ago there was a variable |not_updated| in handle successfully/unsuccessfully downloaded extension manifests. Now it is handled more elegant via ExtensionDownloader::DetermineUpdates method, so we may remove it and replace its only usage with actual data. ExtensionDownloader: :HandleManifestResults method, and it was used to Change-Id: I188b588c061dd6595c2bb5d6030afe5200b28130 Reviewed-on: https://chromium-review.googlesource.com/c/1486271Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635442}
-
Sergio Villar Senin authored
As part of the Onion Soup effort, the base::time primitives should replace any usage of platform/wtf ones in Blink. In this first step we're replacing the following 2 calls: * TimeTicksInSeconds() -> base::TimeTicks::since_origin()::InSecondsF() * TimeTicksFromSeconds() -> base::TimeTicks() + base::TimeDelta::FromSecondsD() Bug: 919383 Change-Id: I3bb3b4fe76c11ca3c6c5b1bfb8ebffce51f03bf7 Reviewed-on: https://chromium-review.googlesource.com/c/1472625Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I059fc47bbabf89deb753d14944694a5bab2382b5 Reviewed-on: https://chromium-review.googlesource.com/c/1487435 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/storage have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of StorageAreaMap and StorageController classes, they make sense to use USING_FAST_MALLOC because they have been created by smart pointers. Bug: 919389 Change-Id: Ic440735af3bb0e2e87fce36b41564ade69a6ebfb Reviewed-on: https://chromium-review.googlesource.com/c/1488398Reviewed-by:
-
Leon Han authored
Make ServiceWorkerNetworkProviderForFrame::Create() be called only in case of creation for a valid instance. Have those callsites intending to create an empty instance just call ServiceWorkerNetworkProviderForFrame::CreateInvalidInstance() directly. BUG=931092 Change-Id: Icec8a537b96bc420c8dbc0b79a09d6ff3bd51598 Reviewed-on: https://chromium-review.googlesource.com/c/1477513Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#635438}
-
Tim Song authored
BUG=934608 Change-Id: Id673d62c802072036a8b6b63161104b26f9768bd Reviewed-on: https://chromium-review.googlesource.com/c/1482115 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635437}
-
Yutaka Hirano authored
SinkPeer is designed to read all the response body in order to let the network stack store the contents to the HTTP cache. We need to read the response body rather than discarding it. Bug: 894819 Change-Id: I9ba34d3b765c7d3f1127ad18f5aac17c3eddd6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1481137Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b2ef4ac9fd6..478c5c145fc9 Created with: gclient setdep -r src-internal@478c5c145fc9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38b49fce033267045a7848c41f08bba34a5db9c4 Reviewed-on: https://chromium-review.googlesource.com/c/1488497Reviewed-by:
-
Nate Fischer authored
net-debugging.md was accidentally omitted from navbar.md, making it less discoverable. This adds it in, so this page can be discovered from the grey-ish top bar of the other docs pages. Details on navbar can be found: https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/markdown.md#Navigation-bar R=ctzsm@chromium.org Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia3e870833a3e86c8703301e296effce7139e66dd Reviewed-on: https://chromium-review.googlesource.com/c/1488533 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#635434}
-
Yutaka Hirano authored
This is a reland of https://crrev.com/5432359239b23e0810aea8c78adcd37f637936f4. The original CL caused crashes due to handle reset in a two-phase read, so this CL delays the reset operation a bit. Original description: WebURLLoaderImpl is not destructed when the request is cancelled, so it's better to destruct the response body handle in WebURLLoaderImpl::Context::Cancel manually. Bug: 894819, 927184, 929793 Change-Id: Ie3822049bb796ba180ad428f97bd873cec3a17f0 Reviewed-on: https://chromium-review.googlesource.com/c/1481143 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
