GitLab

We'd like to investigation how many pages will be affected by the feature [1].
This CL also adds counters for <input type=submit>, which is a typical
affected element.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QpEoCwU0Ttg

BUG=141169

Review URL: https://codereview.chromium.org/706503002

git-svn-id: svn://svn.chromium.org/blink/trunk@184882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test depends on the exact output of zlib, which may vary depending
on which CPU optimizations it's able to use.

BUG=430557
TBR=vsevik@chromium.org

Review URL: https://codereview.chromium.org/702183002

git-svn-id: svn://svn.chromium.org/blink/trunk@184881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Prevent inherited style from propagating into a plugin placeholder. (patchset #3 id:40001 of https://codereview.chromium.org/669883003/)

Reason for revert:
Causing layout test fast/plugins/plugin-placeholder-inherit.html to fail.

Original issue's description:
> Prevent inherited style from propagating into a plugin placeholder.
> 
> Without setting 'all: initial', it's possible for text colours and such to be
> inherited by the placeholder, which is unexpected.
> 
> TEST=fast/plugins/plugin-placeholder-inherit.html
> BUG=364716
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184878

TBR=esprehn@chromium.org,mkwst@chromium.org,jbroman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364716

Review URL: https://codereview.chromium.org/706623003

git-svn-id: svn://svn.chromium.org/blink/trunk@184880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/702603003

git-svn-id: svn://svn.chromium.org/blink/trunk@184879 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Without setting 'all: initial', it's possible for text colours and such to be
inherited by the placeholder, which is unexpected.

TEST=fast/plugins/plugin-placeholder-inherit.html
BUG=364716

Review URL: https://codereview.chromium.org/669883003

git-svn-id: svn://svn.chromium.org/blink/trunk@184878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<select multiple>, <select size=2-or-greater>, and <input
type=date/datetime-local/month/time/week> had a bug that they prevented
sequential focus navigation even if they were not focusabble.

Change nextNodeWithGreaterTabIndex() so that it uses adjustedTabIndex().

BUG=425937
TEST=automated

Review URL: https://codereview.chromium.org/681103003

git-svn-id: svn://svn.chromium.org/blink/trunk@184877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test float-paginate-complex adds nothing over the other float-* tests,
except the case with a big line box. That case has been split out into
a new reftest: float-big-line.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/699593003

git-svn-id: svn://svn.chromium.org/blink/trunk@184876 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch is a first step towards cleaning up StylesSidebarPane and
introduction of structured object instead of styleRule objects.

This patch removes styleRule.section property, and kills unneeded
section.uniqueProperties list.

R=vsevik, pfeldman

Review URL: https://codereview.chromium.org/699873002

git-svn-id: svn://svn.chromium.org/blink/trunk@184875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They are duplication of WebURLRequest::FetchRequestMode and WebURLRequest::FetchCredentialsMode.

BUG=N/A

Review URL: https://codereview.chromium.org/706543002

git-svn-id: svn://svn.chromium.org/blink/trunk@184873 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new WebSocket implementation doesn't support the extension.

R=yhirano
BUG=339373

Review URL: https://codereview.chromium.org/706573003

git-svn-id: svn://svn.chromium.org/blink/trunk@184871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This turns out to be the wrong way to solve the problem. We'll have to
think harder about the best way to support this (uncommon) use case.

BUG=429244
TBR=jww@chromium.org

Review URL: https://codereview.chromium.org/704723003

git-svn-id: svn://svn.chromium.org/blink/trunk@184870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The style rules of tree elements became outdated after the rule was
edited. This patch adds synchronization for them as well.

BUG=430133
R=vsevik

Review URL: https://codereview.chromium.org/692073003

git-svn-id: svn://svn.chromium.org/blink/trunk@184869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added an explicit column-gap, used column-count rather than column-width,
and removed some lines to make the test fit better in content_shell.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/695283002

git-svn-id: svn://svn.chromium.org/blink/trunk@184868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Ctrl+/Ctrl- shortcuts are already supported in hosted mode on linux
for some time. This patch adds the same supoprt for Cmd+/Cmd- shortcuts
on mac in hosted mode.

TBR=pfeldman

Review URL: https://codereview.chromium.org/702583003

git-svn-id: svn://svn.chromium.org/blink/trunk@184867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dcheng
NOTRY=true

Review URL: https://codereview.chromium.org/702003003

git-svn-id: svn://svn.chromium.org/blink/trunk@184866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/673163004

git-svn-id: svn://svn.chromium.org/blink/trunk@184865 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The revalidation headers ("if-modified-since", "if-none-match") should not be exposed to the ServiceWorker.

BUG=429570
TEST=http/tests/serviceworker/resources/fetch-request-no-freshness-headers-iframe.html

Review URL: https://codereview.chromium.org/703813002

git-svn-id: svn://svn.chromium.org/blink/trunk@184864 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings

This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings
(Ref: binding-methods changed:
static v8::Handle<v8::Object> associateObjectWithWrapperNonTemplate(ScriptWrappable*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*)
static v8::Handle<v8::Object> associateObjectWithWrapperNonTemplate(Node*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*)
static v8::Handle<v8::Object> associateObjectWithWrapper(PassRefPtr<T>, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8:Isolate*)
static v8::Handle<v8::Object> associateObjectWithWrapper(T*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*))

BUG=424446

Review URL: https://codereview.chromium.org/695773002

git-svn-id: svn://svn.chromium.org/blink/trunk@184863 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=429176
R=apavlov

Review URL: https://codereview.chromium.org/706523003

git-svn-id: svn://svn.chromium.org/blink/trunk@184862 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is a bug due to which source ranges in inherited styles sections
and pseudo elements style sections are not updated on the front-end
as the editing happens. This patch fixes it.

BUG=430129
R=vsevik

Review URL: https://codereview.chromium.org/698113006

git-svn-id: svn://svn.chromium.org/blink/trunk@184861 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Window has custom toV8 function, and Window inherits from EventTarget.
So, EventTarget also has custom toV8 because an EventTarget can be a
Window.

crrev.com/646523004 made Node to call EventTarget-version of
v8SetReturnValueForMainWorld because Node inherits from EventTarget,
and it calls toV8 function every time. It caused a perf regression.

This CL adds a new version of v8SetReturnValueForMainWorld for Node
and its subclasses so that they can use the fastest path.

class hierarchy:
    ScriptWrappable <-- EventTarget <--+-- Node <-- ...
                                       +-- Window
overloads:
    v8SetReturnValueForMainWorld(ScriptWrappable*)
        Optimized and very fast.
    v8SetReturnValueForMainWorld(EventTarget*)
        Uses custom toV8 function and slow.
    v8SetReturnValueForMainWorld(Node*)  <----------- NEW!!
        Optimized and very fast.
    v8SetReturnValueForMainWorld(Window*)
        Uses custom toV8 function and slow.

Before this CL:
Element matches EventTarget version of
v8SetReturnValueForMainWorld, and it's very slow.

After this CL:
Element matches Node version of
v8SetReturnValueForMainWorld, and it's very fast.

BUG=428707,235436

Review URL: https://codereview.chromium.org/684763004

git-svn-id: svn://svn.chromium.org/blink/trunk@184860 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Pesky overrun issues.

BUG=430351

Review URL: https://codereview.chromium.org/705663003

git-svn-id: svn://svn.chromium.org/blink/trunk@184859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the grid and flexbox specs:
"the ::first-line and ::first-letter pseudo-elements do not apply to
grid/flex containers".
http://dev.w3.org/csswg/css-grid/#grid-containers
http://dev.w3.org/csswg/css-flexbox/#flex-containers

This was almost working right, except in the case that an ancestor was
setting the ::first-letter pseudo-element.

Modified RenderBlock::updateFirstLetter() in order to stop looking for
the first text child when you reach a grid or flexbox.
Added a few more cases to the current tests in order to check this
behavior.

TEST=css3/flexbox/flexbox-ignore-container-firstLetter.html
TEST=fast/css-grid-layout/grid-container-ignore-first-letter.html

BUG=430099

Review URL: https://codereview.chromium.org/686173006

git-svn-id: svn://svn.chromium.org/blink/trunk@184858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch fixes CSS.getMatchedStylesForNode protocol method so that
it starts to report matched selectors for pseudo style matches.

R=vsevik, apavlov

Review URL: https://codereview.chromium.org/697773004

git-svn-id: svn://svn.chromium.org/blink/trunk@184857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools shows "there are unsaved changes" dialog if there's at least one
dirty uiSourceCode. However, saving a network-originated javascript file will
not prevent you from loosing changes as the devtools will close.

This patch changes the behavior so that the alerting message pops up only
if there are file system uiSourceCodes with unsaved changes.

R=vsevik
BUG=426783

Review URL: https://codereview.chromium.org/698053003

git-svn-id: svn://svn.chromium.org/blink/trunk@184856 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Layout test not needed.

Review URL: https://codereview.chromium.org/691493005

git-svn-id: svn://svn.chromium.org/blink/trunk@184855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this series of patches, registration succeeds even if the worker script
has a syntax error because the installing sequence does not check the result of
the script evaluation.

To enable the installing sequence to wait for the script evaluation, this adds
WorkerReportingProxy::didEvaluteWorkerScript() to be called when the
evaluation is completed and to propagate the result up to the Chromium-side.

Patch dependency:
[1] Blink: THIS PATCH
[2] Chromium: https://codereview.chromium.org/697593002/
[3] Blink: https://codereview.chromium.org/697833004/

BUG=426344
TEST=compile (test will be added by [3])

Review URL: https://codereview.chromium.org/692003002

git-svn-id: svn://svn.chromium.org/blink/trunk@184854 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A previous CL allowed word spacing to be added around inline-blocks.
However the line width calculation wasn't consistent with children placement,
and contents will overflow on the right side of the line if there was
inline-block induced word spacing.

This CL makes RenderBlockFlow::computeInlineDirectionPositionsForSegment to be
consistent with InlineFlowBox::placeBoxRangeInInlineDirection.

BUG=429655

Review URL: https://codereview.chromium.org/704693003

git-svn-id: svn://svn.chromium.org/blink/trunk@184853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is based on the current heuristic in
plugins::PluginPlaceholder::HidePlugin
(components/plugins/renderer/plugin_placeholder.cc).

Tests are added to ensure that the placeholder closing code works as
expected, and to verify that the newly-added WebPluginPlaceholder method
is respected.

A crude UI is currently used; showing the X graphics currently used is blocked
on deciding how to load image resources in this environment.

BUG=364716

Review URL: https://codereview.chromium.org/698533003

git-svn-id: svn://svn.chromium.org/blink/trunk@184852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Run-time flag enableImageColorProfiles defaults to off. Add a window
InternalSettings method to enable the flag during layout tests.

BUG=369787

Review URL: https://codereview.chromium.org/643713006

git-svn-id: svn://svn.chromium.org/blink/trunk@184851 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hide isSpecialElement since it is only used in
htmlediting.cpp. And since the two callers pass
a non-null node, turn the null check into an ASSERT.

Review URL: https://codereview.chromium.org/694893003

git-svn-id: svn://svn.chromium.org/blink/trunk@184850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=425651
R=eroman@chromium.org

Review URL: https://codereview.chromium.org/692763002

git-svn-id: svn://svn.chromium.org/blink/trunk@184849 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Widen GPU trigger condition (patchset #3 id:40001 of https://codereview.chromium.org/660133005/)

Reason for revert:
There's content that depends on the existing trigger in order to
opt-out of GPU rasterization. Since we're close to the branch point,
let's revert this and then try to expand again in M41.

Original issue's description:
> Widen GPU trigger condition
> 
> GPU rasterization will be triggered when viewports meet either of the 
> following conditions:
> 1) width=device-width, minimum-scale=X, where X >= 1.0
> 2) width=device-width, user-scalable=no
> 
> BUG=424469
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184566

BUG=424469

Review URL: https://codereview.chromium.org/685003008

git-svn-id: svn://svn.chromium.org/blink/trunk@184848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some specs use union type attributes. For example, TrackEvent[1]
has 'track' attribute, of which type is
(VideoTrack or AudioTrack or TextTrack). Let's support union type
attributes so that we can reduce custom bindings. Follow-up CLs
will replace custom bindings if possible.

BUG=240176

Review URL: https://codereview.chromium.org/704503002

git-svn-id: svn://svn.chromium.org/blink/trunk@184847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184840

BUG=428189
TBR=bokan@chromium.org

Review URL: https://codereview.chromium.org/701783006

git-svn-id: svn://svn.chromium.org/blink/trunk@184846 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch devirtualizes animatedLocalTransform and renames it
calculateAnimatedLocalTransform to emphasize that it is not cheap.

SVGGraphicsElement::animatedLocalTransform was virtual to support
SVGTextElement's special transform code. The text-specific
transform code is only in an infrequently-taken codepath
(style && style->hasTransform()) so we can actually improve performance
by devirtalizing and combining the two transform codepaths. The real
benefit is code simplification though.

Secondly, I've renamed this function to make it clear that it is not
a simple lookup.

BUG=429551

Review URL: https://codereview.chromium.org/693423002

git-svn-id: svn://svn.chromium.org/blink/trunk@184845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/695563008

git-svn-id: svn://svn.chromium.org/blink/trunk@184844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code just is the hasOneTextChild logic, so
to avoid confusion use that instead.

Review URL: https://codereview.chromium.org/692153002

git-svn-id: svn://svn.chromium.org/blink/trunk@184843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184838

BUG=416535
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/703473005

git-svn-id: svn://svn.chromium.org/blink/trunk@184842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=184836

BUG=425872
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/685243003

git-svn-id: svn://svn.chromium.org/blink/trunk@184841 bbb929c8-8fbe-4397-9dbb-9b2b20218538