- 20 Feb, 2020 40 commits
-
-
Marc Treib authored
...instead of manually watching for relevant changes. This is a small cleanup/simplification; no behavior changes expected. Bug: 1024332 Change-Id: Ie5671ebc278c890ca0f7ce082b1ec0df3c98b107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065001Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#743089}
-
Finnur Thorarinsson authored
When troubleshooting why no media files appear in the PhotoPicker it is important to know what query was issued so that the file system can be inspected (to see if any files should have matched). This is only logged once (when a PhotoPicker dialog is opened). Bug: 656015 Change-Id: I833665827f598bb1c40cbfeec2cc44f6c8c4b7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066537 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#743088}
-
Mohamed Amir Yosef authored
Bug: 1044365 Change-Id: I9fd23b258c86f68e01be02f17c49d0adcbe7a1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064940 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743087}
-
Sergey Poromov authored
This reverts commit 68d4bec3. Reason for revert: Build failures: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/35129 https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/67071 Original change's description: > Introduce Mojo interface for accessibility, adding a SetMode() method > > Based on crrev.com/c/1847304, by Colin Blundell <blundell@chromium.org> > > This CL starts the process of converting accessibility IPC to Mojo. We > start off by converting the message FrameMsg_SetAccessibilityMode > which, while not strictly a message from accessibility_messages.h, > it's very important in that it's responsible of getting accessibility > enabled in the renderer side, when the ui::AXMode::kWebContent is > specified. > > Also, it's important to migrate this message first and doing it using > an associated channel for the new mojom::RenderAccessibility interface > since we need to make sure that this new RenderAccessibility::SetMode() > method gets processed in the expected order relative to other messages > already being sent using Mojo between the browser and renderer process, > such as those for mojom::NavigationClient, for instance. Not doing it > in this way would lead to race conditions during the migration period, > since the ordering of some messages from accessibility_messages.h being > migrated to Mojo could not be processed in the expected order compared > to this new RenderAccessibility::SetMode() method, which is required to > happen first to get the RenderAccessibilityImpl object created in the > renderer. > > Specifically, this CL does the following: > - Adds render_accessibility.mojom with the RenderAccessibility > interface. > - Adds a new class RenderAccessibilityManager implementing the new > mojom::RenderAccessibility interface, which will also manage the > lifecycle of the object that will be handling accessibility in the > renderer (i.e. the RenderAccessibilityImpl object). > - Sets up the plumbing for RenderFrameHostImpl to be able to connect to > the mojom::RenderAccessibility implementation via RenderFrameImpl, > using an associated channel to connect to the receiver side, > implemented by RenderAccessibilityManager. > - Changes how RenderAccessibilityImpl gets created, so that its > existence is now manager by RenderAccessibilityManager, which is > permanently connected to the browser process for the entire lifetime > of the RenderFrameImpl object. > - Uses this infrastructure to replace the sending and handling of > FrameMsg_SetAccessibilityMode. > - Updates RenderFrameImpl::SetAccessibilityModeForTest() to rely on > RenderAccessibilityManager::SetMode() from now on. > - Updates tests as needed. > > Future work will incrementally convert the rest of the accessibility > messages, including introduction of the Mojo interface for methods > that go from the renderer to the browser. > > Bug: 1010831 > Change-Id: I919177bcf7cfa0af6ae4b921341f239674606d52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991446 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#743081} TBR=dmazzoni@chromium.org,dcheng@chromium.org,aboxhall@chromium.org,rockot@google.com,haraken@chromium.org,dtapuska@chromium.org,chrishall@chromium.org,arthursonzogni@chromium.org,mario@igalia.com,meredithl@chromium.org Change-Id: I97660f4d0c88a8eed6d9014e9d4ea4b4006842ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065671Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#743086}
-
Ali Juma authored
This adds a feature flag for Safe Browsing, and disables WKWebView's version of Safe Browsing when this flag is enabled. Bug: 1028755, 1050174 Change-Id: I213a3fb1aeaeaa4b497e7ba56be2c61046a5b688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065550Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#743085}
-
Tim Volodine authored
Remove cross origin sensor metrics, due to RAPPOR framework being turned down. Cross origin metrics measure the Device Motion/Orientation API usage across frames. These metrics will be added using the new UKM framework as a follow-up if necessary. BUG=1025720 Change-Id: Ie9506fcdc9d0b04088e49af91f7a5a7b093a881b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062332Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#743084}
-
Deepankar Tyagi authored
R=sdoerner@google.com Bug: 1043748 Change-Id: Ib0ad2f166fd644922a8202c3cbb0e798d5853e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064308Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Deepankar Tyagi <dpnkar@google.com> Cr-Commit-Position: refs/heads/master@{#743083}
-
Boris Sazonov authored
Adds a getAndroidAccount, getId, getEmail, getGaiaId static helpers to CoreAccountInfo. These helpers all do the same task - they return Account/CoreAccountId/Email/GaiaId from the argument if it's not null, and return null otherwise. IdentityManager.getPrimaryAccountId will be replaced by this in subsequent CLs. Bug: 1051000 Change-Id: Id0cc2bb5049f5464cbfc06a4866c7a9bf2074724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061813 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743082}
-
Mario Sanchez Prada authored
Based on crrev.com/c/1847304, by Colin Blundell <blundell@chromium.org> This CL starts the process of converting accessibility IPC to Mojo. We start off by converting the message FrameMsg_SetAccessibilityMode which, while not strictly a message from accessibility_messages.h, it's very important in that it's responsible of getting accessibility enabled in the renderer side, when the ui::AXMode::kWebContent is specified. Also, it's important to migrate this message first and doing it using an associated channel for the new mojom::RenderAccessibility interface since we need to make sure that this new RenderAccessibility::SetMode() method gets processed in the expected order relative to other messages already being sent using Mojo between the browser and renderer process, such as those for mojom::NavigationClient, for instance. Not doing it in this way would lead to race conditions during the migration period, since the ordering of some messages from accessibility_messages.h being migrated to Mojo could not be processed in the expected order compared to this new RenderAccessibility::SetMode() method, which is required to happen first to get the RenderAccessibilityImpl object created in the renderer. Specifically, this CL does the following: - Adds render_accessibility.mojom with the RenderAccessibility interface. - Adds a new class RenderAccessibilityManager implementing the new mojom::RenderAccessibility interface, which will also manage the lifecycle of the object that will be handling accessibility in the renderer (i.e. the RenderAccessibilityImpl object). - Sets up the plumbing for RenderFrameHostImpl to be able to connect to the mojom::RenderAccessibility implementation via RenderFrameImpl, using an associated channel to connect to the receiver side, implemented by RenderAccessibilityManager. - Changes how RenderAccessibilityImpl gets created, so that its existence is now manager by RenderAccessibilityManager, which is permanently connected to the browser process for the entire lifetime of the RenderFrameImpl object. - Uses this infrastructure to replace the sending and handling of FrameMsg_SetAccessibilityMode. - Updates RenderFrameImpl::SetAccessibilityModeForTest() to rely on RenderAccessibilityManager::SetMode() from now on. - Updates tests as needed. Future work will incrementally convert the rest of the accessibility messages, including introduction of the Mojo interface for methods that go from the renderer to the browser. Bug: 1010831 Change-Id: I919177bcf7cfa0af6ae4b921341f239674606d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991446 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#743081}
-
Antonio Gomes authored
This function is used only in local_frame.cc past [1]. This CL moves it out of the Blink API, down to the aforemented file. [1] https://crrev.com/c/2028708 BUG=919392, 1041083 R=haraken@chromium.org Change-Id: I5f3a5167751f3e37142967d584ec4cf7c824af39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056460 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Antonio Gomes authored
This is a follow up of [1]. [1] https://crrev.com/c/2028708/13/content/browser/frame_host/render_frame_host_impl.cc#3272 BUG=2028708 R=arthursonzogni@chromium.org Change-Id: I39bc2d9ed53d920eb857a4429796e6a42772f460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057183 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/189bea09d5ac..71d0f777fcf6 Created with: gclient setdep -r src-internal@71d0f777fcf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I58a3e325c8ca1876bd879fe1b9ba769d10bd0cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065896Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743078}
-
Alex Newcomer authored
Change-Id: I41431331a7aca745ee58edd116fbc9328ca3a178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065335 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#743077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e4d24728146d..69ac3898ce66 git log e4d24728146d..69ac3898ce66 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 tvanderlippe@chromium.org Reland "Fix TS + Ninja integration" Created with: gclient setdep -r src/third_party/devtools-frontend/src@69ac3898ce66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02e620928e0b1d5948793b60808506b28135dd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743076}
-
Jan Wilken Dörrie authored
This change modifies CompromisedCredentialProvider to make use of the SavedPasswordsPresenter to be able to merge compromised credentials with passwords present in the password store. Bug: 1044726 Change-Id: I8dd6dd52306efb7ecc81f11061ad4793e54fe7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063019 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743075}
-
Sergey Poromov authored
[Sheriff] Mark virtual/web-components-v0-disabled/external/wpt/dom/ranges/Range-mutations-dataChange.html timeout Test flaky on Mac and Linux debug bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/86971 TBR=masonfreed@chromium.org No-Try: true Bug: 1016457 Change-Id: I61295e3c4e55c675a1c0c8831f05576178a0102b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066544Reviewed-by:
-
Jamie Madill authored
This reverts commit 648288e2. Reason for revert: Suspected for flaky crash hitting WebGL tests. See bug. Bug: 1054357 Original change's description: > [Sampling profiler] Apply metadata to samples before first contentful paint > > Requests that the sampling profiler apply metadata to samples between > navigation start and first contentful paint, at the time when first > contentful paint is sent to the browser process. This metadata will > support analysis of execution during page load. > > This change introduces monotonic time interfaces for the required metrics > because the existing interfaces are limited to 1ms resolution. If used > they would result in up to 2% of samples being misidentified as occurring > during loading when they weren't, or vice versa. > > Bug: 1034756 > Change-Id: Ibb39877ecfc52a1e5327204c39c3b0ce0f1b8ccd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042324 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742717} TBR=sullivan@chromium.org,wittman@chromium.org,bmcquade@chromium.org,npm@chromium.org,schenney@chromium.org Change-Id: I83e655350d8537934b7715efdd3a576266c80e72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066061Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#743073}
-
Vasilii Sukhanov authored
Bug: 1050659,1053093 Change-Id: Ia39d8f37ece8ba9c3a7f89830a20819c4eec3c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064550 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743072}
-
Dominique Fauteux-Chapleau authored
Bug: 1042319 Change-Id: Ic242cb0528b111612cbe22de7ed24f55bc026522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062616Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#743071}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2801bf43716e..b0e9cd6645e1 git log 2801bf43716e..b0e9cd6645e1 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 39e685ccd37e..c357af84c7cb (1 commits) Created with: gclient setdep -r src/third_party/angle@b0e9cd6645e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I5e0806928ee5b2236a9ec8b6b79132a2cb8e5e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066305Reviewed-by:
-
Artur Kochowski authored
Calculation was using only the height part of preferred size while ignoring the width. Depending on situation this might have caused method to return size that was either too small or too big. There is no visible bug in Chromium because this method is called multiple times and width returned from CalculatePreferredSize is later set to be the same value. Change-Id: I573ea709bb2f3fdadaa36cf71e8bddbe80ec3f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056823Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#743069}
-
Sergey Poromov authored
This reverts commit e0723ae5. Reason for revert: "capture_unittests" failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17155 Original change's description: > Skip 3A for still capture if ZSL is enabled > > This CL skips the wait for 3A-convergence (AE, AF, AWB) when > Zero-Shutter Lag (ZSL) is enabled. When configuring streams, camera HAL > adapter would add a private usage flag to the configured still capture > streams. Video Capture Device (VCD) would then use this private usage > flag to determine if ZSL is enabled. If ZSL is enabled, we skip 3A when > trying to construct a capture request. > > BUG=b:130851309 > TEST=Tested on kukui and verified VCD is able to get ZSL availability > through the private usage flag. > > Change-Id: I751a432b099fb1e012fbd65e54f57901d508225c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919530 > Commit-Queue: Jasmine Chen <lnishan@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743048} TBR=dcheng@chromium.org,shik@chromium.org,hywu@chromium.org,lnishan@google.com,wtlee@chromium.org Change-Id: I5386db19de0e1a4e93828c2ab81a53f51ee7a08d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:130851309 Bug: 1054385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066618Reviewed-by:
-
Sergey Poromov authored
The tests are flaky. Sample run: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/2669 TBR=eugenebut@chromium.org Bug: 1054372 Change-Id: I017acc96b29650cc944f26f3c5a538a89432ac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064946Reviewed-by:
-
Wez authored
New //base primitives are being added under //base/util, which has its own unit-tests suite, so we should be running that. Bug: 1020698 Change-Id: I5126381cf2fc1fdf3a5b6e466cd994d23167f926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062420 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#743066}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07a0ee92..b86395aa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaefa7f1b4d9ba267c76bccb41d9e54912145be6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064949Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743065}
-
Maksim Moskvitin authored
This CL is a part of ObjectId -> Topic API migration. It's a pure refactoring and there should be no behavioral changes. Bug: 1029698 Change-Id: Ieab9c5a76c009a3ec93dd2a8737b9f9b6119a101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059376Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#743064}
-
Jose Lopes authored
This callback is meant to be called every time a new key is registered, thus it must be a repeating callback, as documented in: https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=502d7a8bc634c4248b7cc2f43e2305eee7213d94&l=51 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib852f03ab2f862d02d0e09be95626090cee60d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035960 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743063}
-
Kai Ninomiya authored
This reverts commit 51f4efc9. Reason for revert: rmtree fix was reverted Original change's description: > Roll CTS and fix extract_expectation_names.py > > https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..02b62c256590b040d514ec15c0f12041be8d1575 > > Change-Id: I6db0043cf844a81d1ccdecb4e7c0a51de5430fb4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036 > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743007} TBR=kainino@chromium.org,robertma@chromium.org,enga@chromium.org,rmhasan@google.com Change-Id: I2fee3ed2df610c3fc0e385725e3ae0e86718f745 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066464Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743062}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b1e6dfe. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 9431619c "Clipboard Tests: Update DOCTYPE to lowercase." 76ee218c "Split html/.../query-encoding/ tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I3be8ea0796671ac0c3d75dbff05e05b403fbfc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066204Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743061}
-
Andrey Zaytsev authored
Also removed the version updater callback argument as it does not need to be created outside of CheckUpdates(). Bug: 1015841 Change-Id: I4a2bb4a23ce1c24e1a8358c641b797be0a79a21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049982 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#743060}
-
Mugdha Lakhani authored
Design Doc: https://docs.google.com/document/d/166h__sHZGVD7eTBKkBMF7beLGOmT6mwTVe8dtsTCU7A/edit?usp=sharing Before screenshot here: After screenshot here: https: //drive.google.com/open?id=0B486O0P6jAtRZ0ptUEJXemUwczNjTjlGejFPZ1ZaZS02RXFr https: //drive.google.com/a/google.com/file/d/15sHXrBgFOUAT5p2gccLHfIyP5ELYRsXV/view?usp=sharing Bug: b/64863368 Change-Id: I05b8cc3c878f930d0c18b69a4f84ac43a10b2592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873631 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#743059}
-
Marc Treib authored
If Sync-the-feature is enabled, there is only a single, combined storage for passwords. So we should not offer the account storage in this case, and if the opt-in already exists it should be ignored. This CL adds the necessary "!IsSyncFeatureEnabled()" checks plus corresponding tests. Bug: 1024332 Change-Id: I496ecb902297983d51526a74211ff1b754376e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062981Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#743058}
-
Rayan Kanso authored
This is needed for the stale manifest use case. Bug: 1045588 Change-Id: I7deb018afa062f829cc13247ab7faaa86da8a129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050274Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#743057}
-
Benoît Lizé authored
The global memory dump is fetched once per memory metrics recording, and never re-used. However the global dump is never reset, wasting memory. Bug: 1054360 Change-Id: I04f65427194068e579cd87938d4cf65af9bd0962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056820 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#743056}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/631436b3c1f2..e4d24728146d git log 631436b3c1f2..e4d24728146d --date=short --first-parent --format='%ad %ae %s' 2020-02-20 wolfi@chromium.org Use 1000 not 1024 for kB and MB calculations 2020-02-20 rajasekar89be@gmail.com DevTools: fix Reveal in Network panel does not work if filter was set before Created with: gclient setdep -r src/third_party/devtools-frontend/src@e4d24728146d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035309,chromium:1044651 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16768ffe4e11ce0765d328c2fc64718de3f76e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065653Reviewed-by:
-
Antonio Gomes authored
BUG=704136, 919392 Change-Id: Id91b5c49e96ecae45b1c10f96d99b74e7c64a75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064748Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#743054}
-
sandromaggi authored
Bug: 1053606 Change-Id: I5051770b0ecb8c1b6d2a91ed31f9b533277c13de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062287Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#743053}
-
Sergey Poromov authored
chromeos-eve-chrome consistently fails: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3756 Bug: 1054340 Bug: 1000351 Change-Id: I51d89786926f48f7bdab4884bf27bf6b495d4947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065003 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#743052}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/adeb0b9fdd32..189bea09d5ac Created with: gclient setdep -r src-internal@189bea09d5ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99835ef74504f6366491dc97b73b897b54147bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066056Reviewed-by:
-
Jan Wilken Dörrie authored
While base::Value switched to checked iterators in its list API, base::ListValue still used unchecked std::vector<Value>::iterators. This change fixes this oversight and slightly improves the checked iterator interface by making the comparison operators non-members, thus allowing implicit conversions on both arguments. Bug: 990059 Change-Id: I7b3bb4573300fe7f391c6b911817448f8aee7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060672 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
