- 16 Oct, 2019 40 commits
-
-
Sylvain Defresne authored
The tests ProgrammaticTabModelTest/TabModelTest.* tried to clean up the session file using NSFileManager but this step was flaky due to a race condition (it sometimes fails with a permission error). TestChromeBrowserState already delete the state directory if no explicit path is passed to the builder, thus the step to clean up was unnecessary and can be removed. Bug: none Change-Id: If0ece62ee5cee726e4135952f3d50efae35dabb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865211 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#706450}
-
Etienne Pierre-doray authored
By default, the NetworkService bootstraps a leaking SystemDnsConfigChangeNotifier singleton object in NetworkChangeNotifier::NetworkChangeNotifier(). This SystemDnsConfigChangeNotifier observes the DNS configuration (via FilePathWatchers on /etc/resolv.conf and /etc/hosts on POSIX and via ObjectWatchers on the registry on Windows). These watchers outlive the BrowserTaskEnvironment of the RenderViewHostTestHarness, including it's message queues. If the trybots experience network changes (e.g. due to expiring DHCP leases or other problems), it is possible that the watchers post messages to a message queue that has been destroyed already, see crbug.com/1011275#c3. This CL cause NetworkService to use a mock NetworkChangeNotifier which does not observe network changes. Bug: 1011275 Change-Id: I426999899cadf4732a93d4040871f56332422d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856803Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#706449}
-
Nicolás Peña Moreno authored
We do not intend to ship this feature, so remove the flag and some of the associated code. A followup CL will remove SubTaskAttributions and code used to compute them. Bug: 738493 Change-Id: I6b036e5d308bf8e555f5d5c76874e12458a028c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853124Reviewed-by:
Tom McKee <tommckee@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706448}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/083a75d6762c..59e72b71b5cf git log 083a75d6762c..59e72b71b5cf --date=short --no-merges --format='%ad %ae %s' 2019-10-16 fmalita@chromium.org [skottie] Luma matte support Created with: gclient setdep -r src/third_party/skia@59e72b71b5cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Iaa5b859db39d7f55e92dd7b4c4387dd32880748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706447}
-
Javier Ernesto Flores Robles authored
Change-Id: Ifc0899f198c9dad30c55e17efa6cf24bb2444b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864680 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Andy Paicu authored
Bug: 1014026 Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706445}
-
danakj authored
The UpdateVisualProperties IPC is going to a RenderWidget to set state on it, so move it back to RenderWidget. We are no longer attempting to build some global state in the Renderer, as each local root is an atomic unit of state, even including the "global" properties such as screen info, so that each RenderWidget sees the updates to itself as a single change. VisualPropertiesManager is no longer needed in the browser as each RenderWidgetHostImpl will just Send() the IPC to its RenderWidget directly. Tests updated to look for the IPCs again. R=avi@chromium.org TBR=dcheng Bug: 419087 Change-Id: I656864ea7f1a379c06b013b4aa6d88698838a4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857182 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706444}
-
ckitagawa authored
Renderer side paint preview implementation. This CL creates a mojo service on a RenderFrameObserver that facilitates most of the paint preview capture management. Flow: - Browser calls this service to request paint preview capture of current frame (future CL 1) - PaintPreviewServiceImpl sets up for capture in Blink (this CL) - Blink handles the capture via a flow similar to printing (future CL 2) - This will include invoking a request to the browser to forward requests to OOP subframes. - PaintPreviewServiceImpl does post-processing and marshals a response (this CL) - Two artifacts are produced: - A SkPicture is written to the file handle provided by the browser - A proto containing metadata for the frame is sent via shared memory to the browser. - Browser does some minor modifications to the proto then either stores the proto to disk or forwards the proto and SkPicture files to a utility process for playback. The browser will retain the links from the proto for hit testing. (future CLs) Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Internal Doc: go/fdt-design Bug: 994833 Change-Id: I88ffb89d92dfcb78b61a91a21df2b842c713f8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824669Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#706443}
-
Roman Sorokin authored
This is a first step to implement new Help App dialog specs (see the bug for details) Bug: 1008073 Test: run on a device with a long content Change-Id: Id1abdb069ecc52aa35590f10cb5d21ab2e7eff70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864674Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706442}
-
Dominique Fauteux-Chapleau authored
Bug: 944625 Change-Id: Ifa032c85938406b87d24edf4c06ec738905a7978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783400 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706441}
-
Parastoo Geranmayeh authored
This reverts commit ba4c901f. Reason for revert: suspect for test failure. Please see bug. Bug: 1014930 Original change's description: > Fix for flaky test (scrollbar-button-gesture-target.html). > > The test fails because it tries to dereference a raw pointer which > points to layer that was destroyed. The fix is to set the pointer > to null and add checks in scrollbar_controller.cc > > Bug: 1002828, 987115 > Change-Id: I46efc7e35ee62bb36020a42aafbd75998728017c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854534 > Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706170} TBR=bokan@chromium.org,arakeri@microsoft.com Change-Id: I83735cb53a08929a532a917748278cfdabb98d64 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002828, 987115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864711Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706440}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the viz::mojom::FrameSinkManager interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I8a7ea0d64ec447de26e52a2b65f7620009be44ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860028Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#706439}
-
Laís Minchillo authored
This CL fixes a crash when a null VisualStateCallback is passed to postVisualStateCallback. Since there is no action to do if the callback is null, just return early. Bug: 1014924 Change-Id: I891eda56bd884af5b2d7e1cb909895cb5fdd6a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865155Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706438}
-
Jonah Ryan-Davis authored
These tests were all caused by bugs in Mesa which were fixed, but the tests were still suppressed until the bots were updated to a later Mesa version. All the bots are now updated and the tests pass. Bug: 666384 Bug: 680675 Bug: 844349 Bug: 905011 Change-Id: Ic371d2fdaf36a6ebd184ee36b78b90dacd6dfcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863375Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#706437}
-
Roman Aleksandrov authored
Change ResolveLanguageListInThreadPool so that it uses AppLocale instead of default locale if exists. Bug: 955397 Change-Id: I6947dd89e297adea3fd019e38d083e45419ea282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704098Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#706436}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_sudden_termination_disabler_type.h file was moved to third_party/blink/public/common. Since the file is no longer in the public/platform/ directory we are also renaming it sudden_termination_disabler_type.h (and the type defined in that file to SuddenTerminationDisablerType). Bug: 1008303 Change-Id: Ia97a4bbc329b222b4bdc7ee92ff73c507963aa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845002Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nick Harper authored
This fixes a bug in QuicTestPacketMaker which was blocking this flag from being fixed. Change-Id: I76ffbbe1c87c35dfe94119e694eb787fb6cbf720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864301 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706434}
-
Mikel Astiz authored
Prior to this patch, if OnTrustedVaultKeyRequired() got called during the sync engine's initialization, the keys would be successfully fetched from the client, but there was no known engine to feed them to, so they got dropped and IsTrustedVaultKeyRequired() never became true. As fixed alternative, the patch proposes to defer the reading of the keys until SetSyncEngine() gets called. Bug: 1000146 Change-Id: I058407b157c66e72a3d62354108c5ee151197125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865149 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#706433}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/14dd70757eb0..bedeb781e8ca git log 14dd70757eb0..bedeb781e8ca --date=short --no-merges --format='%ad %ae %s' 2019-10-16 tobine@google.com Vulkan: Define VK_USE_PLATFORM_XLIB_KHR Created with: gclient setdep -r src/third_party/angle@bedeb781e8ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:1011068 Change-Id: Id65c6d366d421ac8aa743dace21e9e161e17b84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864557Reviewed-by:
-
Ganggui Tang authored
This reverts commit c40a0262. Reason for revert: The crash looks unrelated to this CL, crbug.com/1013943 Original change's description: > Revert "[StartSurface] Add long press behavior for the fake box" > > This reverts commit 14f7eff8. > > Reason for revert: Crashes on Canary with voice input > > Original change's description: > > [StartSurface] Add long press behavior for the fake box > > > > This CL is based on > > https://chromium-review.googlesource.com/c/chromium/src/+/1824554/3 > > > > It is the fourth patch of splitting the bigger one > > https://chromium-review.googlesource.com/c/chromium/src/+/1797069 > > > > It also unifies the record of the 'Android.OmniboxFocusReason' metrics. > > > > Screenshot: > > https://drive.google.com/file/d/1YlxcF40SYtGVj9K0YgviQtnt5tdGFm-m/view?usp=sharing > > > > Bug: 982018, 1012275 > > Change-Id: I16d045777164d49d72356af474e5c186c8318370 > > Binary-Size: crbug.com/998206 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824126 > > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#705264} > > TBR=yusufo@chromium.org,gogerald@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 982018, 1012275, 1013943 > Change-Id: I4a48866d15dc65e8f939fe1c86867754eea87604 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860598 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705727} TBR=yusufo@chromium.org,gogerald@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=yusufo@chromium.org Bug: 982018, 1012275, 1013943 Change-Id: I2af5453e12de134bb6c75b1c9229bd4644007d40 Binary-Size: crbug.com/998206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864005 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#706431}
-
Elly Fong-Jones authored
This CL removes overrides from: * AppUninstallDialogView, which uses text that is computed during the constructor (and used redundant cancel text) * DataRemovalConfirmationDialog, which uses static text * DownloadInProgressDialogView, which uses static text * Various NativeFileSystem dialogs, which use static text or text computed during the constructor & then never changed This change also makes NativeFileSystemRestrictedDirectoryDialogView::is_directory_ const to make the code easier to reason about. Bug: 1011446 Change-Id: Ib345c6f742b860a9041a9df21e003f802fe5648d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863632Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706430}
-
Findit authored
This reverts commit 8716ddc2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 706414 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg3MTZkZGMyNzQ2MmE5OGIxZWYwNDliZTY5N2M1YzBlNWJjZjYzNmMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-archive-dbg/4735 Sample Failed Step: compile Original change's description: > Roll src/third_party/dawn/ 1093c4de2..cc071e45b (6 commits) > > https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..cc071e45bb9c > > $ git log 1093c4de2..cc071e45b --date=short --no-merges --format='%ad %ae %s' > 2019-10-16 enga Split generation of dawncpp headers from libdawncpp > 2019-10-16 natlee D3D12 replace ASSERT_SUCCESS with better error handling > 2019-10-16 hao.x.li Prioritize discrete GPU in end2end tests > 2019-10-15 senorblanco clang-win compile files for skia-dawn. > 2019-10-15 cwallez Add dawnGetProcAddress. > 2019-10-15 cwallez Split the libdawn target in components with a single purpose. > > Created with: > roll-dep src/third_party/dawn > > TBR=kbr@chromium.org > BUG=dawn:22 > > Change-Id: Ib61611e5455abf1b66f33b1b68c311a428c3bf9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864683 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706414} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=dawn:22 Change-Id: I0a9279b00ded522a578ec0957a0ae528fd09aa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864410 Cr-Commit-Position: refs/heads/master@{#706429}
-
Friedrich Horschig authored
This CL makes the header (title, subtitle, illustration) part of the recyclerview that previously only displayed credentials. This makes the entire sheet contents (apart from the handlebar) scrollable. Bug: 1012219 Change-Id: I81d5191cf007f4d6516a4700f983b81b17434c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859654 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706428}
-
Thomas Tangl authored
- Remove big bordered box - Move sync info into bordered box when a blue button is shown - Refactor spacing Screenshot: https://drive.google.com/open?id=1CmKpM_rEA92NO-dP_V71q7TghYAALV_S Bug: 995720 Change-Id: I1e47024c57330a69c77632ac8020d11d6e983b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864786Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706427}
-
Peter Wen authored
Apart from the build/tooling/test/third-party directories listed in suppressions.xml, every usage of System#exit must be explicit and have the @SuppressWarnings annotation, preferably with a short explanation of why it is necessary. Added @SuppressWarnings for all existing usages. Removed the System#exit call in ChromeApplication since we have no visibility into how often the application replacing bug is hit. Throwing an exception with a custom message will help us see its current impact. Bug: 1000651 Change-Id: Ia48598b32e339efccb0ca1b55ef03068da505410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851770 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706426}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be181e24..ad531032 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I162813eb82348c00ad2c88319c349eda7f687ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864872Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706425}
-
Mikel Astiz authored
This affects the experimental codepath used to retrieve and store encryption keys. The keys are associated to a user as determined by identity servers, and using CoreAccountId for such IDs does not work well on all platforms (namely, ChromeOS). Bug: 1000146 Change-Id: Iaaab6f1867ac99c026e3474822e86ca5e80f5404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863803 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3ba68b08. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I42c32bb0765bbccd8e5628e006cb64752cdb6ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864871Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706423}
-
Lukasz Anforowicz authored
There are 2 NavigationThrottle that try to cancel and restart an existing navigation via OpenURL call: - NewTabPageNavigationThrottle - PDFIFrameNavigationThrottle Before this CL, these throttles tried to create OpenURLParams out of NavigationHandle in an ad-hoc way - taking some navigation properties into account and ignoring others. This CL tries to fix this, by introducing OpenURLParams::FromNavigationHandle that 1) should cover all relevant navigation properties and 2) can be used from all throttles that need this functionality. It also turns out that by fixing how |source_site_instance| is propagated we can fix some crashes happening in the wild - https://crbug.com/1014483. Bug: 1003957, 1007041, 1014483 Change-Id: I5acf27201c3a7a40ce7b239102a5075f26f4c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838381Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#706422}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the XREnvironmentIntegrationProvider interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I261bdae8d49490a58a098545ef692fbf84b6d256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836416 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
Dominic Battre authored
Bug: 1014475 Change-Id: I18f0192e1c1edb893177705e60687ddf022f1f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862691Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#706420}
-
Fergal Daly authored
Cascade order is ::part !important > !important > ::part Bug: 1014400 Change-Id: If73f8280d0370e93f633f2460b744b073798090a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863059 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#706419}
-
Antonio Gomes authored
.. by calling PeerConnectionDependencyFactory::GetWebRtcSignalingThread() directly. This is now possible, after [1], where peer_connection_dependency_factory.cc|h is moved to Blink. [1] https://crrev.com/c/1805159 Note that to match the actual return type (base::SingleThreadTaskRunner) the PCDF method is renamed to GetWebRtcSignalingTaskRuner(). BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ia7d564ce94db4d8009d680f78925560681f98b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806845 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#706418}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/67bce690decd..ab12219ba56a $ git log 67bce690d..ab12219ba --date=short --no-merges --format='%ad %ae %s' 2019-10-13 junyer Fix the regexp_benchmark build with GNU make. 2019-10-11 junyer Oops, wrap a couple of lines. 2019-10-11 junyer Read flags using the GetFlag() style. 2019-10-11 junyer Make flags use the DEFINE_FLAG() style. 2019-10-11 junyer Remove a condition from exhaustive1_test.cc that is no longer needed. 2019-10-11 junyer Move util/flags.h into the testing target. 2019-10-11 junyer Don't declare testing::TempDir() in dump.cc itself. 2019-10-11 junyer Split out the fake testing::MallocCounter into its own file. 2019-10-11 junyer Remove the fake test_tmpdir flag in favour of testing::TempDir(). 2019-10-10 junyer Remove the comment on NumCPUs(). 2019-10-10 junyer Call .range(0) explicitly rather than just .range(). 2019-10-10 junyer Move NumCPUs() into regexp_benchmark.cc. 2019-10-10 junyer Migrate to the new benchmark API. 2019-10-10 junyer Implement the new benchmark API as a layer over the old benchmark API. 2019-10-09 junyer Tidy up the ersatz benchmark library. 2019-10-07 junyer Move pod_array.h and sparse_{array,set}.h from util/ to re2/. 2019-08-26 junyer Partial revert of commit 7a10064. 2019-08-26 junyer Adjust a thread annotation. 2019-08-13 milkovic.marek Improvements in install target generated by CMake 2019-08-26 junyer Simplify the plumbing for re2.pc. 2019-08-19 junyer Add Clang 9 to the Travis CI matrix. 2019-08-19 junyer Don't assume that iterators are just pointers. 2019-08-18 junyer No, it was right before. Try the /cygdrive form. 2019-08-18 junyer Try under 'C:\Program Files (x86)' instead. Sigh. 2019-08-18 junyer Ensure that CMake is in the path on Windows. 2019-08-18 junyer Comment on why we pin to Visual Studio 2015. 2019-08-18 junyer Attempt to avoid VCVARSALL.BAT breakage entirely. 2019-08-18 junyer Attempt to address VCVARSALL.BAT breakage. Sigh. 2019-08-18 junyer Argh. Try a different flag. 2019-08-18 junyer Try to upgrade Bazel harder on Windows. 2019-08-18 junyer Upgrade Bazel before trying to build with it. 2019-08-18 junyer Switch to Starlark for C++ rules. 2019-08-15 junyer Configure Kokoro to run CMake builds on Ubuntu. 2019-08-15 junyer Configure CMake to require version 3.5.1, which is what Xenial has. 2019-08-15 junyer Upgrade Travis CI from Trusty to Xenial. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I2ecc4256aae4bb5ea7766857e2ed53bd5f624b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861714 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7274850f96f2..083a75d6762c git log 7274850f96f2..083a75d6762c --date=short --no-merges --format='%ad %ae %s' 2019-10-16 csmartdalton@google.com Revert "Reland "ccpr: Unblacklist Qualcomm with msaa"" Created with: gclient setdep -r src/third_party/skia@083a75d6762c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Ief90067b1b30106bb0305628e70aa221019cb0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864452Reviewed-by:
-
Daniel McArdle authored
This CL adds net_base_address_tracker_linux_fuzzer. Change-Id: I89c7c087f7c9c85deabcaf7d265bdc88564c312d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863151Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#706415}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..cc071e45bb9c $ git log 1093c4de2..cc071e45b --date=short --no-merges --format='%ad %ae %s' 2019-10-16 enga Split generation of dawncpp headers from libdawncpp 2019-10-16 natlee D3D12 replace ASSERT_SUCCESS with better error handling 2019-10-16 hao.x.li Prioritize discrete GPU in end2end tests 2019-10-15 senorblanco clang-win compile files for skia-dawn. 2019-10-15 cwallez Add dawnGetProcAddress. 2019-10-15 cwallez Split the libdawn target in components with a single purpose. Created with: roll-dep src/third_party/dawn TBR=kbr@chromium.org BUG=dawn:22 Change-Id: Ib61611e5455abf1b66f33b1b68c311a428c3bf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864683Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#706414}
-
arthursonzogni authored
The tests aren't failing locally. TBR=altimin@chromium.org Bug=976218 Change-Id: Ic5e8c3984584f7388c80bee64da40ce4e88deebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864780Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706413}
-
Miyoung Shin authored
This CL converts MdnsListenClientPtr and Binding<MdnsListenClient> in chrome and services to the new Mojo type, and uses pending_remote<T> in host_resolver.mojom. Bug: 955171 Change-Id: Ie1821bd2d5edbbbcfc14ce8380053ce9cfaa2be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860535 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706412}
-
Parastoo Geranmayeh authored
This reverts commit 50b0289b. Reason for revert: UDPSocketTest.TestUnexpectedSequences fails. Bug: 1014916 Original change's description: > Roll Fuchsia SDK from 889950275648 to 889947586298 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > TBR=cr-fuchsia+bot@chromium.org > > Change-Id: I654114143b038a86cc813bd5ce57508260abed5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864551 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#706330} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I1b5fbffa51bb3ecef38f2d370c89902ff33c911f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864710Reviewed-by:
-
