- 24 Sep, 2014 26 commits
-
-
reveman authored
content: Fix OOM error handling in GpuMemoryBufferImplSharedMemory::AllocateSharedMemoryForChildProcess. We need to run the callback with an empty handle after failing to allocated shared memory. BUG= TBR=piman@chromium.org Review URL: https://codereview.chromium.org/595063004 Cr-Commit-Position: refs/heads/master@{#296333}
-
jackhou authored
BUG=415422 Review URL: https://codereview.chromium.org/602483002 Cr-Commit-Position: refs/heads/master@{#296332}
-
scottmg authored
(Split off of https://codereview.chromium.org/588813002) The main change here is to restructure the ParseNode tree to include comments. Comments are not included in the tree as normal nodes, but instead attached subordinate to other |ParseNode|s. This is useful for two reasons: - it means neither the evaluator nor the main code of the parser need to get more complicated, as they do not need to constantly consider comments. - it confers additional information about the relative location of of the comments to their surrounding code when (in the future) outputting the formatted code. Comments are added in relation to the node they're attached to as before, after, or suffix. This is so that formatting can keep them attached to the correct thing when things are reflowed. Timing data (Windows, Release): Before: Done. Wrote 1618 targets from 530 files in 2613ms Done. Wrote 1618 targets from 530 files in 2952ms Done. Wrote 1618 targets from 530 files in 3093ms After: Done. Wrote 1618 targets from 530 files in 2767ms Done. Wrote 1618 targets from 530 files in 3120ms Done. Wrote 1618 targets from 530 files in 2872ms So, it seems within the noise at this point. R=brettw@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/588893006 Cr-Commit-Position: refs/heads/master@{#296331}
-
vivek.vg authored
Although passing SkBitmap by value doesn't copy the underlying pixels, it indeed involves memcpy (~64 bytes to be precise) to replicate the settings from the other bitmap in the copy constructor. This overhead, albeit minor, can be avoided by passing SkBitmap as reference. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/597553002 Cr-Commit-Position: refs/heads/master@{#296330}
-
thestig authored
BUG=417093,417119 NOTRY=true TBR=groby@chromium.org Review URL: https://codereview.chromium.org/600663003 Cr-Commit-Position: refs/heads/master@{#296329}
-
sungmann.cho authored
Review URL: https://codereview.chromium.org/598453004 Cr-Commit-Position: refs/heads/master@{#296328}
-
avi authored
BUG=407376 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/589403004 Cr-Commit-Position: refs/heads/master@{#296327}
-
dbeam authored
Also reverses "OK" + "Cancel" buttons to match other overlays. R=estade@chromium.org BUG=407498 Review URL: https://codereview.chromium.org/591353002 Cr-Commit-Position: refs/heads/master@{#296326}
-
thestig authored
BUG=336556 Review URL: https://codereview.chromium.org/577893003 Cr-Commit-Position: refs/heads/master@{#296325}
-
tonyg authored
This broke the android scripts. BUG=388885 TBR=dtu@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/599743002 Cr-Commit-Position: refs/heads/master@{#296324}
-
mseaborn authored
ppapi/ no longer has any references to NaCl's "Gio" code. This cleanup will allow the Gyp file to be removed from the NaCl side. BUG=none TEST=build Review URL: https://codereview.chromium.org/593243003 Cr-Commit-Position: refs/heads/master@{#296323}
-
vivek.vg authored
The method WebImageLayer::setBitmap(SkBitmap) is no longer available and should be removed from the WebImageLayerImpl as well. R=jamesr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/593083002 Cr-Commit-Position: refs/heads/master@{#296322}
-
zmo authored
This is for adding "analyze" to the GPU recipe BUG=411991 TEST= R=sky@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/597763002 Cr-Commit-Position: refs/heads/master@{#296321}
-
rsleevi authored
This includes the following changes: https://chromium.googlesource.com/chromium/deps/nss/+/b37fb0be291ca6b0238476fcebe54bae77baf2aa Export CERT_VerifySignedDataWithPublicKeyInfo from NSS on Windows BUG=401365 R=davidben@chromium.org Review URL: https://codereview.chromium.org/590413004 Cr-Commit-Position: refs/heads/master@{#296320}
-
cjhopman authored
This fixes configuration of various targets (mostly adding some missing files for is_android builds). Adds a target setting up the content_shell_apk assets directory. Uncomments the previously non-working dependencies from libcontent_shell_content_view. Adds forwarding of testonly in all of the android templates. TBR=mark@ BUG=359249 Review URL: https://codereview.chromium.org/569923003 Cr-Commit-Position: refs/heads/master@{#296319}
-
tonyg authored
The args were messed up. BUG=388885 NOTRY=True Review URL: https://codereview.chromium.org/596983002 Cr-Commit-Position: refs/heads/master@{#296318}
-
Scott Graham authored
This reverts commit ba1e1e3f. <jiayl_> It broken component_unittests: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1)/builds/49443/steps/components_unittests/logs/RecordMissingViaHeaderBytes BUG= TBR=jiayl@chromium.org Review URL: https://codereview.chromium.org/596163002 Cr-Commit-Position: refs/heads/master@{#296317}
-
reveman authored
GpuMemoryBufferImplOzoneNativeBuffer should not be calling platform specific GpuMemoryBufferImpl::CreateFromHandle. BUG=416873 TBR=piman Review URL: https://codereview.chromium.org/596833002 Cr-Commit-Position: refs/heads/master@{#296316}
-
vmpstr authored
This patch partially fixes checkerboard on rapid tab switch problem. When we become invisible we mark the active tree as requiring high res content to draw, and manage tiles to evict resources. However, manage tiles will end up scheduling an activation with rasterize on demand since we couldn't schedule anything. This will end up activating and clearing the require high res flag. This fixes it by not activating or scheduling activation when we have no memory. R=reveman BUG=415760 Review URL: https://codereview.chromium.org/594703002 Cr-Commit-Position: refs/heads/master@{#296315}
-
jrummell authored
BUG=none TEST=cq Review URL: https://codereview.chromium.org/591783002 Cr-Commit-Position: refs/heads/master@{#296314}
-
brettw authored
TBR=scottmg Review URL: https://codereview.chromium.org/593333002 Cr-Commit-Position: refs/heads/master@{#296313}
-
qyearsley authored
BUG=394990 Review URL: https://codereview.chromium.org/593253002 Cr-Commit-Position: refs/heads/master@{#296312}
-
dmichael authored
Blocking renderer->plugin messages can be interrupted by any message from the plugin->renderer (even async ones). So while handline a blocking message, such as HandleInputEvent or HandleBlockingMessage, it's currently possible to re-enter JavaScript. This patch makes that impossible by queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage while any renderer->plugin sync message is on the stack. BUG=384528 Review URL: https://codereview.chromium.org/589213003 Cr-Commit-Position: refs/heads/master@{#296311}
-
nednguyen authored
Previously, creation of platforms is done in browser_finder classes. This patch aims to detach the coupling between creating browsers from platform by moving such methods to platform. Also modify android_platform_backend so it owns the adb instance. SHERRIFS: reverting this patch will require reverting https://codereview.chromium.org/541693004/ first. BUG=413637 Review URL: https://codereview.chromium.org/522553002 Cr-Commit-Position: refs/heads/master@{#296310}
-
hclam authored
Stats generated by cast streaming API contains some redundancy stuff like "bucket" and "count". Also remove 0 buckets in the stats to reduce size. Review URL: https://codereview.chromium.org/582253002 Cr-Commit-Position: refs/heads/master@{#296309}
-
John Abd-El-Malek authored
BUG=414808 TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/593333003 Cr-Commit-Position: refs/heads/master@{#296308}
-
- 23 Sep, 2014 14 commits
-
-
jonross authored
Change the shelf visibility animation so that the status area is visible before animating any properties. This way it is rendering for the full animation. TEST=ShelfLayoutManagerTest.SetAutoHideBehavior BUG=416618 Review URL: https://codereview.chromium.org/596863003 Cr-Commit-Position: refs/heads/master@{#296307}
-
gunsch authored
R=lcwu@chromium.org BUG=None Review URL: https://codereview.chromium.org/600573003 Cr-Commit-Position: refs/heads/master@{#296306}
-
thestig authored
BUG=17540,385396,411235,416957,417048 NOTRY=true TBR=groby@chromium.org Review URL: https://codereview.chromium.org/602453002 Cr-Commit-Position: refs/heads/master@{#296305}
-
dalecurtis authored
Several AudioParameters fields are irrelevant when converting from one type to another via AudioRendererMixer. Not ignoring these values results in expensive extra renderer side resampling load and extra physical stream creation. Physical stream creation has a long tail of additional overhead (multiple threads, shared memory, etc). AudioRendererMixerManager will now ignore these irrelevant params when determining whether it should reuse an existing mixer. BUG=none TEST=new unittest. Review URL: https://codereview.chromium.org/596073002 Cr-Commit-Position: refs/heads/master@{#296304}
-
boliu authored
StreamTextureFactorySynchronousImpl::CreateProxy did not check if context_provider already exists in which case it does not need to re-add the observer. BUG=416981 Review URL: https://codereview.chromium.org/594273003 Cr-Commit-Position: refs/heads/master@{#296303}
-
Brett Wilson authored
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b246733..66b8c06 TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org Review URL: https://codereview.chromium.org/601553003 Cr-Commit-Position: refs/heads/master@{#296301}
-
estade authored
See [1] for network_menu.js/css deletion See [2] for sim_unlock_ui.cc change [1] https://codereview.chromium.org/6693032 [2] https://codereview.chromium.org/399303003/diff/100001/chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc#oldcode298 BUG=122753 Review URL: https://codereview.chromium.org/588363002 Cr-Commit-Position: refs/heads/master@{#296300}
-
vitalyp authored
BUG=393873 R=dbeam@chromium.org,mtomasz@chromium.org Review URL: https://codereview.chromium.org/575313004 Cr-Commit-Position: refs/heads/master@{#296299}
-
rdevlin.cronin authored
BUG=416691 Review URL: https://codereview.chromium.org/595683002 Cr-Commit-Position: refs/heads/master@{#296298}
-
sclittle authored
Keep track of the situations when Chrome expects the data reduction proxy via header to be present in a response, but the data reduction proxy via header is missing. BUG=412888 Review URL: https://codereview.chromium.org/577343002 Cr-Commit-Position: refs/heads/master@{#296297}
-
vitalyp authored
R=bshe@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . ui/keyboard/resources/compiled_resources.gyp && ninja -C out/Default | grep WARNING Review URL: https://codereview.chromium.org/594603002 Cr-Commit-Position: refs/heads/master@{#296296}
-
lazyboy authored
This will make some zoom functionality work in pdf viewer as they rely on tabs.setZoomSettings/tabs.setZoom. BUG=416332 Test=Load chrome with --enable-mime-handler-view and --out-of-process-pdf Navigate to a pdf file, see ctrl+/- or zooming through browser menu work. Ctrl + wheel still doesn't work, will fix that in a follow up CL. Review URL: https://codereview.chromium.org/597653002 Cr-Commit-Position: refs/heads/master@{#296295}
-
Brett Wilson authored
This application downloads a URL to a temp file, unzips it, and then cleans everything up. IN a future pass, we'll extract a manifest and contents of the module. BUG= R=ben@chromium.org Review URL: https://codereview.chromium.org/596913002 Cr-Commit-Position: refs/heads/master@{#296294}
-