- 17 Aug, 2018 40 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/54ff302cdc5a..ff6a73cc08af git log 54ff302cdc5a..ff6a73cc08af --date=short --no-merges --format='%ad %ae %s' 2018-08-17 mtklein@google.com add rec2020 configs to DM 2018-08-17 robertphillips@google.com Pull non-substantive changes out of GrShape mask drawing CL 2018-08-17 reed@google.com try to help res-scaling in perspective 2018-08-17 robertphillips@google.com Reland "Make directFilterMaskGPU & directFilterRRectMaskGPU no longer require canFilterMaskGPU's permission" 2018-08-17 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). 2018-08-17 kjlubick@google.com [PathKit] Add conic tests and re-create expectations. 2018-08-17 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 3394a73db973..43a2762db19a (1 commits) 2018-08-17 kjlubick@google.com [PathKit] Rework API to avoid extra copies unless explicitly called for. 2018-08-17 caryclark@skia.org update doc index Created with: gclient setdep -r src/third_party/skia@ff6a73cc08af The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Iadc4ac9d71bd79276fc8da58cfd5bdb58263ec39 Reviewed-on: https://chromium-review.googlesource.com/1180321Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584223}
-
Toni Barzic authored
Device getting enterprise enrolled, and then used should be a good signal that demo mode resources are no longer needed. An exception is made for demo mode implemented through public sessions (as it's the case today) - in that case retailer might attempt to swich to the revamped demo mode sessions, so might need the resources after all. BUG=827368 Change-Id: Ia5645b059050f9d7858ba34acd84201969b88b71 Reviewed-on: https://chromium-review.googlesource.com/1176652 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584222}
-
Devlin authored
This reverts commit f41f215c. Reason for revert: Checking to see if this was the cause of flakiness in a test. Original change's description: > [Extensions] Introduce common client initialization > > In order to extract apps-specific code from extensions, we'll need to > be able to add extra information to the extensions client from outside > extensions code. This will require having a centralized initialization > for the extensions client. > > Introduce a single method, EnsureExtensionsClientInitialized(), which > constructs and sets the ChromeExtensionsClient. Remove the old way of > constructing the client, ChromeExtensionsClient::GetInstance(). Update > all callers to construct the client via the new method. > > While we're at it, update the client to use base::NoDestructor instead > of LazyInstance. > > Bug: 873937 > Change-Id: I47147cd5f33ea44079c0a319626c57f3c5813af8 > Reviewed-on: https://chromium-review.googlesource.com/1175459 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583217} TBR=thestig@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 873937 Change-Id: I750a4cde4d76054fc82f91bac8e63413f9599b9e Reviewed-on: https://chromium-review.googlesource.com/1179347Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584221}
-
Dan Sanders authored
When playing silence, many samples are small enough that squaring them results in a denormal float. On some AMD CPUs this results in significantly reduced performance. This patch configures the SSE floating point environment to flush denormals and to treat denormals as zero. Bug: 531026 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3842a22f6dc9bef76d87b0a6db069c3f9234d19 Reviewed-on: https://chromium-review.googlesource.com/1179361 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584220}
-
Alex Newcomer authored
UX requests we disable context menus on the back button and overflow buttons in the shelf. Removed tests for these cases and added new ones for not showing the menus. Bug: 875334 Change-Id: I45c320a148e8f7ad39abd0e8181e59e3c4b663fe Reviewed-on: https://chromium-review.googlesource.com/1180073Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584219}
-
Fredrik Söderquist authored
There's no real reason to give 'tabindex' preferential treatment (not anymore at least.) Just let it be handled by the common fall-through code-path and flatten the structure of the code a bit. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I96e6c265aeb384fe1acc0b61378078bb3d06051c Reviewed-on: https://chromium-review.googlesource.com/1179886 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584218}
-
Charles Zhao authored
(1) TabLifecycleObserver is added for TabActivityWatcher to track OnDiscardedStateChange event. (2) In DidReplace(replaced_tab), the ukm_source_id and is_discarded state is copied to new_tab so that we can track discarded state after reload or closing. (3) A browser test is added. Change-Id: I9777b515d28d215f3409525b0201dc5916d35941 Bug: 872139 Change-Id: I9777b515d28d215f3409525b0201dc5916d35941 Reviewed-on: https://chromium-review.googlesource.com/1166763Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584217}
-
Becca Hughes authored
Add a list of media sessions and their state to a new audio focus tab on media internals. BUG=870418 Change-Id: I654b9444c1abc3f5ae12c29d070627e137f5e137 Reviewed-on: https://chromium-review.googlesource.com/1161500 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#584216}
-
David Roger authored
This CL moves the token-related specific code from signin_client to other files. Device-id code is moved to device_id_helper (code shared by desktop and mobile) and chrome_device_id_helper (code shared by desktop and ChromeOS), and called from the token service for all platforms. The SigninClient is simplified, which allows in particular simplifying the iOS implementation. Unittests for the Device ID code are added. TBR=bartfab Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I781456d437830689294ec459d75e5fd19259f6af Reviewed-on: https://chromium-review.googlesource.com/1122867 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#584215}
-
Dale Curtis authored
Vivo has confirmed these devices should work with float audio and has asked us to re-enable support. BUG=737188, b/112714561 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7286d65f47bb56a8ff2750dec58d9c783519b65f Reviewed-on: https://chromium-review.googlesource.com/1180064Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584214}
-
Balazs Engedy authored
Most notably, `security key` is no longer capitalized. Bug: 849323 Change-Id: I5f9693cd95c21d770dbac7d2eeba081b2bf34f1a Reviewed-on: https://chromium-review.googlesource.com/1179900 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584213}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6cef7cac8d71..f62079a0f9e5 git log 6cef7cac8d71..f62079a0f9e5 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 chiniforooshan@chromium.org Telemetry: queueing_durations in TBMv2 Created with: gclient setdep -r src/third_party/catapult@f62079a0f9e5 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553 TBR=sullivan@chromium.org Change-Id: I575568b7cb1ec5dbf3d61a8b2427a055eb40dc0c Reviewed-on: https://chromium-review.googlesource.com/1180002Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584212}
-
Matthew Jones authored
This reverts commit be62a5ba. Reason for revert: Causes compile failure on many bots: ../../components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java:625: error: cannot find symbol new BenchmarkTask().execute(); https://ci.chromium.org/buildbot/chromium.android/Android%20Cronet%20Marshmallow%2064bit%20Perf/24049 Original change's description: > Android: removing default execute() on AsyncTask > > execute() is a confusing function, with a hidden implicit meaning that > changed in API 11. It would be better if everyone had to use the more > explicit executeOnExecutor() so their preference (serial or thread pool) > is called out. > > Bug: 869907 > Change-Id: I79be6d2b3114cb0520df1104ec5849f7c070c99e > Reviewed-on: https://chromium-review.googlesource.com/1172446 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584189} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I9184afddb3028649c88f9fdf80ea46c4f7cc7806 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869907 Reviewed-on: https://chromium-review.googlesource.com/1179352Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584211}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3394a73db973..d731ff82e5a8 git log 3394a73db973..d731ff82e5a8 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 fjhenigman@chromium.org Vulkan: support depth offset. 2018-08-17 tobine@google.com Refactoring EGL validation Created with: gclient setdep -r src/third_party/angle@d731ff82e5a8 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I40e756d43a596483d6237843ad1f7968ef144efa Reviewed-on: https://chromium-review.googlesource.com/1180188Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584210}
-
Jennifer Apacible authored
TBR=davidben@chromium.org NOTRY=true (disabling tests) Bug: 875404 Change-Id: I68f0c612342043a91d7d4feef3d91f4353232299 Reviewed-on: https://chromium-review.googlesource.com/1180370Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584209}
-
Meilin Wang authored
Fix the assistant title bar controls icon spacing and size. Test: local compile and manually test. Bug: b:112312676 Change-Id: I095ad7f7ec4814c4247c75c0e5501e656f7acb18 Reviewed-on: https://chromium-review.googlesource.com/1179249 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584208}
-
Pavel Yatsuk authored
Current server infrastructure doesn't have dedicated staging endpoint. All traffic should be sent to prod endpoint. BUG=811909 R=wylieb@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I028f9b0f5fcf80dc313c534347800d8bdcae185d Reviewed-on: https://chromium-review.googlesource.com/1174958 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#584207}
-
Sarah Hu authored
Fingerprint.UnlockEnabled should map to whether there's finger enrolled for screen unlock, instead of tracking a feature flag. Remove the recording in chrome and keep the definition for biod to use. Bug: 862295 Change-Id: Ibb706d0ac8ae05240446a3758c5b2e6d5c2e6224 Reviewed-on: https://chromium-review.googlesource.com/1180343Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584206}
-
Takumi Fujimoto authored
The Cast toolbar icon has been in the same section as extension icons. This CL puts the icon in the trusted area of the toolbar if the ViewsCastDialog flag is enabled. CastToolbarButton, the main icon object, is owned by ToolbarView, just like AvatarToolbarButton. CastToolbarButton observes MediaRouterActionController (to be renamed in a later patch, because "Action" is specific to the old icon) and sets its visibility and pressed state accordingly. When the ViewsCastDialog flag is disabled, the old icon is used. Screencap: https://drive.google.com/open?id=1IMxDzKSiR8AJ89muOy1-_NDLp0RNYAau Bug: 859216 Change-Id: I0ec14e6d20dd58b0356166520c8511e3f9027b83 Reviewed-on: https://chromium-review.googlesource.com/1158794Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#584205}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1f867bb6e2c7..1b2b76d634ba git log 1f867bb6e2c7..1b2b76d634ba --date=short --no-merges --format='%ad %ae %s' 2018-08-17 npm@chromium.org Add FPDFText_GetFontInfo 2018-08-17 thestig@chromium.org Remove CFPF_SkiaBufferFont and CFPF_SkiaFileFont. 2018-08-17 tsepez@chromium.org Rename CJS_Return to CJS_Result. 2018-08-17 hnakashima@chromium.org Optimize rendering of 2D barcodes: create Rect only on black regions. Created with: gclient setdep -r src/third_party/pdfium@1b2b76d634ba The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:872907 TBR=dsinclair@chromium.org Change-Id: If97634d9c5aefb8b3eb86eef4073e9aa314514d5 Reviewed-on: https://chromium-review.googlesource.com/1180278Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584204}
-
Sadrul Habib Chowdhury authored
This is a reland of 0cdc1458 Original change's description: > metrics: Initialize persistent metric allocator early. > > The PersistentMemoryAllocator in the gpu (and other) process is created > asynchronously. If any uma-histogram is reported before that time, then > those Histograms are not stored in the shared memory. This has some > implications: > . If the process crashes (which is common for the gpu process on > android), then these metrics are lost. > . If the process stays alive, then the metrics are reported > periodically, but because it is buffered, it doesn't match up > correctly with the other metrics that are reported in the shared > memory. > > The allocator is created in response to a message from the browser, > which includes the handle for the shared memory to use for the allocator. > The browser waits until the process has been launched and connected. > So this happens much later, compared to other messages which are sent > from browser over mojo without waiting for the connection to have > been established first. Therefore, change this so that the browser > immediately shares the shared-memory segment with the gpu process. mojo > takes care of waiting for the process-launch etc. > > BUG=865179, 778749 > > Change-Id: Iccd3d4422de3e22ead4bc6510afc5ea207bf6b6e > Reviewed-on: https://chromium-review.googlesource.com/1174709 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583673} TBR=avi,sadrul Bug: 865179, 778749 Change-Id: I205221ed82b073464e1c4d52593ba727ebc211a5 Reviewed-on: https://chromium-review.googlesource.com/1179346Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584203}
-
Devlin authored
This reverts commit cb6c4c2d. Reason for revert: Reverted suspected culprit; checking to see if still flaky. Original change's description: > Disable TabManagerTest.ProactiveFastShutdownWithBeforeunloadHandler > > TBR=wjmaclean@chromium.org > NOTRY=true > > Bug: 874915 > Change-Id: Id0fae86ef2e130185d92ad28383c74036dcd96f3 > Reviewed-on: https://chromium-review.googlesource.com/1177881 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583660} TBR=xidachen@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874915 Change-Id: Ie5e977ce5893b35b7510e19c330b668ee6ff52f0 Reviewed-on: https://chromium-review.googlesource.com/1179348Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584202}
-
Prashant Malani authored
Add the histogram entries for remaining LE Credential operations (Check, Remove, Reset, ResetTree, Sync, SyncOutcome) and their actions (if applicable). The CL that introduced the code that generates this data is http://crrev.com/c/1093957 Bug: chromium:809749 Test: None Change-Id: I3959e1696fa3df963f16d834c5d2fdbe8966633f Reviewed-on: https://chromium-review.googlesource.com/1178473 Commit-Queue: Prashant Malani <pmalani@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#584201}
-
kereliuk authored
Went through the docs and issues and made some updates Change-Id: I7f628c45fc9a992c7a70f864e027a3525ea9054b Reviewed-on: https://chromium-review.googlesource.com/1178101 Commit-Queue: Jonathon Kereliuk <kereliuk@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584200}
-
Lindsay Pasricha authored
Uses the same compile config as gpu_tests_release_trybot. Bug: 855301 Change-Id: I70947b3bd21cbbe0519dcb37cb8c6bf844a3e274 Reviewed-on: https://chromium-review.googlesource.com/1179988Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584199}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: I6aeb3571f6e72dd3599a4a6055189a227312d5c4 Reviewed-on: https://chromium-review.googlesource.com/1154527Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#584198}
-
Maja Kabus authored
New class TrustedScript added as a C++ implementation of JS TrustedScript. Bug: 739170 Change-Id: Ife70f8838aefa6bb4aac45f09639464c19de6e1b Reviewed-on: https://chromium-review.googlesource.com/1168494 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#584197}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/1c78a7ba9366..9a87d6b9de35 git log 1c78a7ba9366..9a87d6b9de35 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 dschuff@chromium.org Don't run the performance tests in the emulator Created with: gclient setdep -r src/native_client@9a87d6b9de35 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: I26c25267ac7a2f43446d968c2a9cee6f4fe9c4df Reviewed-on: https://chromium-review.googlesource.com/1180187Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584196}
-
Christopher Grant authored
This allows future UI library module to have one less needless dependency. There's no reason the UI needs to look up the icon for a given omnibox suggestion. BUG= R=acondor Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6fd8152ed64dd2201a4d1ad1fef139ce309965b0 Reviewed-on: https://chromium-review.googlesource.com/1180162 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#584195}
-
Robbie McElrath authored
GoogleURLTracker needs to be migrated from NetworkChangeNotifier to NetworkConnectionTracker to unblock enabling the network service. NetworkConnectionTracker currently needs a network::mojom::NetworkService* in order to to be constructed, but GoogleURLTracker is used in ios, which doesn't have a NetworkService instance to give it. NetworkConnectionTracker only actually uses the NetworkChangeManager interface, so this change makes it depend only on that, not on the entire NetworkService. Bug: 868018 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia2d422686eaf2473c25698f6aa3e6bd66dd04ad4 Reviewed-on: https://chromium-review.googlesource.com/1177186 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584194}
-
Moe Ahmadi authored
Splits Autofill settings page into two separate pages, one for addresses and the other for credit cards. TBR=rohitrao@ Bug: 860526,875313 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b579976f44b413d24d71e04bfb6ef8642e5c78f Reviewed-on: https://chromium-review.googlesource.com/1180266Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584193}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/6b0d82229b2c4ce85b1c3f6d55bda661e07bead2..01e8e625ad83cc9a07288bd4dc285bd8b0ccd550 BUG=none Change-Id: Ia06d532d0a15b3b898396594e1f118818b408437 Reviewed-on: https://chromium-review.googlesource.com/1177906Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#584192}
-
Jennifer Apacible authored
TBR=pkasting@chromium.org NOTRY=true (disabling tests) Bug: 875444 Change-Id: I25183c656dab7f8ef061d2261dbfe517369f68ba Reviewed-on: https://chromium-review.googlesource.com/1179257Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584191}
-
Daniel Erat authored
Update chromeos::CrosDBusService::Start to call ServiceProviderInterface::Start methods (which export methods) before calling dbus::Bus::RequestOwnership. Otherwise, there's a brief window of time where other D-Bus clients may attempt to call methods before they're available. Bug: 874978 Change-Id: I69bc36e465e8086921b67122514f2607399ea33d Reviewed-on: https://chromium-review.googlesource.com/1178757Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584190}
-
Sam Maier authored
execute() is a confusing function, with a hidden implicit meaning that changed in API 11. It would be better if everyone had to use the more explicit executeOnExecutor() so their preference (serial or thread pool) is called out. Bug: 869907 Change-Id: I79be6d2b3114cb0520df1104ec5849f7c070c99e Reviewed-on: https://chromium-review.googlesource.com/1172446Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#584189}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/adc48799090c..c8993d8b01c9 git log adc48799090c..c8993d8b01c9 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 buildbot@webrtc.org Roll chromium_revision 409b9c00..77bf1926 (583992:584099) 2018-08-17 nisse@webrtc.org Delete webrtc::PacketTime and backwards compatibility. 2018-08-17 saza@webrtc.org Toggle AECs via AudioProcessing::Config 2018-08-17 titovartem@webrtc.org Switch webrtc users from deprecated ctors. 2018-08-17 sprang@webrtc.org Don't drop keyframes even if TemporalLayers says so. Created with: gclient setdep -r src/third_party/webrtc@c8993d8b01c9 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ided700bf4eb02c9e1f3cfb9cc5e9eaff4f7eb8b0 Reviewed-on: https://chromium-review.googlesource.com/1180246Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584188}
-
Eric Orth authored
Slight behavior change to never return any address results when the flag is set (to prevent misuse). Affects even the old API usage, but should be safe since a quick check showed that all current usage of the flag never reads the resulting addresses. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2579521d181022a8b0c425f959bcc0808f7ed7fa Reviewed-on: https://chromium-review.googlesource.com/1177913 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#584187}
-
Xiangjun Zhang authored
This CL setup a sandboxed utility service for mirroring. The service encodes the captured audio/video streams and sends them to the remote Cast receiver. The sandbox type is set to "renderer" since the service does media encoding and cast control messages parsing, which has similar requirements as a renderer in term of sandbox policy. Bug: 734672 Change-Id: Ieeb1e373241266c15535f6d4d8fa54337ca59941 Reviewed-on: https://chromium-review.googlesource.com/1162932Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#584186}
-
Jacob Dufault authored
Change-Id: I923d4987dcfaa7788451f28005998417521589ce Reviewed-on: https://chromium-review.googlesource.com/1179245Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#584185}
-
Mitsuru Oshima authored
We now uses dsf for display zooming. Notable changes: * removed ui_scale_, effective_ui_scale parameters. * ZoomInternalDisplay/ResetInternalDisplayZoom is now used only for UnifiedDesktop (we probably want to change this crbug.com/873828) * ModeList for internal display now contains just one mode. I simplied the code for this cases. I also left methods in ScreenManagerOzoneInternal because it's deprecated. Bug: 823922 Test: Removed tests that are no longer necesary. Adjusted tests when they still make sense. Change-Id: Ifca7d45bba15346bb1d0ae78faa150a57e1cb6e6 Reviewed-on: https://chromium-review.googlesource.com/1173726Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#584184}
-