- 05 Oct, 2018 40 commits
-
-
Jian Li authored
Also make EoS url fetcher support immediate or background fetch with different backoff policy. Bug: 867488 Change-Id: If41abed1f85781cf84b9038f600e0a94c6c1524c Reviewed-on: https://chromium-review.googlesource.com/c/1263053 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#597231}
-
Matt Menke authored
Since NetLog is moving to the network service, we will no longer need ChromeNetLog. This is a step towards removing the class, while maintaining all functionality. This is the only member of ChromeNetLog that was used on iOS, so this CL also updates iOS to use NetLog directly instead. Bug: 767450 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0ef4674b564f4575e256d40795bac051242ccf2a Reviewed-on: https://chromium-review.googlesource.com/c/1264915 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597230}
-
Scott Violet authored
This argument ended up setting the field twist on PointerDetails. The TouchEvent constructor *also* takes a PointerDetails. So, having TouchEvent reset the twist was mildly confusing, especially when it has a default value. This patch removes the angle argument to PointerDetails. BUG=none TEST=covered by tests Change-Id: I5edf042df2e6e61c73a406bf2f15f45079991cb9 Reviewed-on: https://chromium-review.googlesource.com/c/1264975Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597229}
-
Lan Wei authored
In the test "hover-during-scroll.html", we tried to test that new hover effects should not be invoked during scroll if the mouse cursor is not visible, so we set |internals.setIsCursorVisible| to false. However, when we run the test, we set the mouse cursor visible to true when we run smoothScroll function, and a mouse move will also set the mouse cursor to be true. Therefore, we should remove the related code from this test. Bug: 877132 Change-Id: I860b778dacc62c20dbd541d607a2b4ee83bb84b1 Reviewed-on: https://chromium-review.googlesource.com/c/1250082Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#597228}
-
Steven Bennetts authored
This also includes some cleanup of default values, renames 'override' -> 'behavior', and documents the KeyboardOverscrollBehavior enum. Bug: 843332 Change-Id: I5149d41701ff44606f2ce4dec3f74d263ed411d2 Reviewed-on: https://chromium-review.googlesource.com/c/1262958Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597227}
-
Donn Denman authored
Introduced recently in CL https://chromium-review.googlesource.com/c/chromium/src/+/1262090. BUG=892669 Change-Id: I9b69ba69c0a950c11de218a622bce041b4b6a98f Reviewed-on: https://chromium-review.googlesource.com/c/1265156Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#597226}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/497958d899c3..03cbf33a695e git log 497958d899c3..03cbf33a695e --date=short --no-merges --format='%ad %ae %s' 2018-10-05 jaebaek@google.com Validator: FPRoundingMode decoration (#1482) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@03cbf33a695e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I43af696c49d7bbcd206ec534629ad1568bbdbfb2 Reviewed-on: https://chromium-review.googlesource.com/c/1265067Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597225}
-
danakj authored
Currently the URL is acquired through a few jumps between RenderWidget and RenderViewImpl. RenderFrameImpl asks RenderView for the URL, but it is actually asking the RenderWidget. RenderWidget goes to the owner delegate if present, so back to the RenderView, to get the main frame in order to get the URL. With pepper, the RenderWidgetFullscreenPepper overrides the RenderWidget method, so when it tries to get the URL it ends up going to the pepper object instead. This makes 2 different ways that the GetURLForGraphicsContext3D() method gets redirected. Then also the UpdateURLForCompositorUKM() finds the main frame and gets the URL itself, if the RenderWidget is attached to the main frame. Notably, popups do not provide a way to redirect GetURLForGraphicsContext3D(), so they do not get a URL at all for the gpu channel ever. Instead of these many methods, we add a GetURLForDebugTrace() method on WebWidget, that RenderWidget can query. When the RenderWidget is for a frame, the WebFrameWidget will acquire the URL. When the RenderWidget is for a popup, the WebPagePopupImpl will do likewise, from the frame tree that spawned the popup. And when the RenderWidget is for fullscreen pepper, the PepperWidget can know the URL and return it (in this case RenderFrameImpl continues to grab the URL and give it to the RenderWidgetFullscreenPepper in order for it to provide it. Then UKM can also use this method, and but just only use the URL if the RenderWidget is itself attached to the main frame, which can be queried without involving the RenderView. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: Iad18c5f7ea902eaa02f58645ede61a5b4609b561 Reviewed-on: https://chromium-review.googlesource.com/c/1237177 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597224}
-
rbpotter authored
Fixing and enabling: CrSettingsInternetDetailPageTest.InternetDetailPage CrSettingsInternetPageTest.InternetPage Bug: 875454 Change-Id: I2a1f31c623d67e178ab99d3558aa9e7e06a8c8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1262934Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597223}
-
Mark Pearson authored
and re-enable it Call the scoped feature list earlier in test setup instead of in the middle of a test. Calling scoped feature list in the middle of a test will clobber existing features, which could result in problems as behavior changes mid-run. (I am not ready to review this feature flag yet. This feature has caused problems in the past, so I'd like to keep the flag around for longer. It has little overhead in the code.) Bug: 891959 Change-Id: I2cee38ff6ff2cc7de16ba1d260f831cee5a68349 Reviewed-on: https://chromium-review.googlesource.com/c/1263562Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#597222}
-
Charlie Harrison authored
It is easy to misuse this class and either: 1. Ignore the return value for |Initialize| 2. Forget to check |IsValid| after initialization This CL makes it impossible to ignore initialize, so callers must handler mmap failures. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idc39565ccd80234ed54aafdd6174d37fff259e9f Reviewed-on: https://chromium-review.googlesource.com/c/1262758Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#597221}
-
Xi Han authored
Add an additional check before calling GetPreemptedSequenceToScheduleLockRequired(). Bug: 892633 Change-Id: I7ee9bcf1e05a96dbabb9378fc6ea99118e0810fe Reviewed-on: https://chromium-review.googlesource.com/c/1263894Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597220}
-
Scott Little authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1166600, as a temporary workaround to the bug listed below, which is caused by a bug in the network stack that affects partial range cache revalidations. This CL only bypasses the cache when reloading placeholders for LoFi, and not when reloading placeholders for lazily loaded images, because bypassing the cache when lazily loading images can potentially waste a lot of network data, plus lazy image loading isn't launched yet, so keeping the behavior as-is will make it easier to debug and fix the underlying problem. Bug: 892461 Change-Id: I96ed023431fc4e7e346497820da1de14940aca64 Reviewed-on: https://chromium-review.googlesource.com/c/1263565Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#597219}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/949f77f4..da3dfedf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0860759a870f581047fe28eb4e5e2427e41b5b2a Reviewed-on: https://chromium-review.googlesource.com/c/1265076Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597218}
-
Dmitry Titov authored
It should compute and report monthly visited host count approximatley every week. It also only runs once per Chrome session and after a delay to avoid slowing down startup. The average cost of computation is less than 10ms and most of it is on background thread, however this is still enough to implement 'sparse' way of querying. Bug: 867488 Change-Id: I000ef4224f87d4d98c0a73519ce9648feb158df7 Reviewed-on: https://chromium-review.googlesource.com/c/1260494 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#597217}
-
Kurt Horimoto authored
This CL updates the |-hitTest:withEvent:| implementation for the toolbar container view such that touches are ignored when they occur within the container, but not on an actual toolbar. This allows touches to reach the web content area when the toolbars are collapsed and the content is laid out behind the container. Bug: 889884 Change-Id: Ifbb6aff819784c692da9fdd649febfe51688e9f7 Reviewed-on: https://chromium-review.googlesource.com/c/1259882Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597216}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fb631023730..0c3bd49069d4 git log 2fb631023730..0c3bd49069d4 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ehmaldonado@chromium.org bot_update: Don't use apply_patch_on_gclient. Created with: gclient setdep -r src/third_party/depot_tools@0c3bd49069d4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891917 TBR=agable@chromium.org Change-Id: I5d9d64b7c5d3f22b4958d8e4629f54246d1d7799 Reviewed-on: https://chromium-review.googlesource.com/c/1265061Reviewed-by:
-
Becca Hughes authored
Add an about://flags flag to enable unified audio focus on ARC++. BUG=883958 Change-Id: Idd0738a116d9eeaf225fab79de5945f73299dca7 Reviewed-on: https://chromium-review.googlesource.com/c/1237406 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597214}
-
Ryan Hansberry authored
Delay showing the 'Chromebook added' notification until the MultiDeviceSetupDialog has been closed. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 883069 Change-Id: If8ae079f77de89cede94ea840e5335445fb7a0ad Reviewed-on: https://chromium-review.googlesource.com/c/1260304Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#597213}
-
Robbie McElrath authored
Bug: 881976 Change-Id: I39b93d0db822c341c7834ee100be957eaecbd15d Reviewed-on: https://chromium-review.googlesource.com/c/1263046Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#597212}
-
Ned Nguyen authored
Bug:792928 Change-Id: Ie383f3a5f499eee5e118668b6570800fa78fbdbe NOTRY=true # doesn't affect CQ Change-Id: Ie383f3a5f499eee5e118668b6570800fa78fbdbe Reviewed-on: https://chromium-review.googlesource.com/c/1263336 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#597211}
-
Stephane Zermatten authored
runnable scripts. Before this patch, the controller only run an autostart script if it was the single runnable script. This means that the presence of non-autostart, but runnable script prevents autostart from triggering. This was a misunderstanding. As long as there is exactly one autostart script, it must be started, and other runnable scripts can be ignored. After this patch, as long as there is exactly one autostart script, it is run. Bug: 806868 Change-Id: Id60223064bc3ed8fc364f7f9a8ae1a4ed4ef921b Reviewed-on: https://chromium-review.googlesource.com/c/1264658Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#597210}
-
Mugdha Lakhani authored
"background-fetch" permission was added to the Permissions API with this commit: https://github.com/w3c/permissions/pull/183/commits/096436eb59caaa5b244b0514d84f287392cb069b Chrome uses Automatic Downloads for this permission, so as not to add yet another user facing permission to the UI. This CL: 1. Adds a background_fetch content setting, because that's needed by PermissionContext and allows us to decouple from Automatic Downloads content setting. 2. Adds a BackgroundFetch PermissionContext mapped to this content setting. 3. Makes this PermissionContext decide whether background fetch() is permitted, which we do by: a. Querying DownloadRequestLimiter when there' a top level frame. b. Querying the Automatic Downloads content setting in other cases. For context and details, please see this document: https://docs.google.com/document/d/1rPYSlbzScw_6PLUJ3m96ZLIkxXVAWyBSL75-VDJEMso/edit?usp=sharing Bug: 886896 Change-Id: Id0fcc64d4242290f3782c61ef11babe5717b409f Reviewed-on: https://chromium-review.googlesource.com/c/1233714 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597209}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I67564c434bcf88639d7703d207f5a8f874549c9b Reviewed-on: https://chromium-review.googlesource.com/c/1265068Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/39cf6a765ae3..9934cc2f2f1a git log 39cf6a765ae3..9934cc2f2f1a --date=short --no-merges --format='%ad %ae %s' 2018-10-05 tsepez@chromium.org Tidy PWL_FLOATRANGE Created with: gclient setdep -r src/third_party/pdfium@9934cc2f2f1a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib220b512ee0b339c7f7a0ffc41c945182817ceac Reviewed-on: https://chromium-review.googlesource.com/c/1265063Reviewed-by:
-
Kyle Milka authored
This reverts commit 5d112920. Reason for revert: Broke old UI and we probably won't be able to completely remove the old UI in M71. Original change's description: > [NTP] Remove UI MD flag > > Remove flag for ntp md ui. Change the new styling to be the > default and remove the md class, this mainly affects the fakebox > as the icons are styled via md-icons. > > Bug: 864673 > Change-Id: I7eb5da522a657417c527e3aa666bab14f8485bef > Reviewed-on: https://chromium-review.googlesource.com/1255600 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595953} TBR=isherman@chromium.org,kristipark@chromium.org,kmilka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864673 Change-Id: I5ef13705787953e96b7e4b0ead21e1e8aeb558d1 Reviewed-on: https://chromium-review.googlesource.com/c/1265024Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597206}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org,eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3836a9f162723371650e239918cc43412ab6c6c4 Reviewed-on: https://chromium-review.googlesource.com/c/1265066Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#597205}
-
Rayan Kanso authored
Paused fetch notifications were not displayed on browser start-up. This means that the fetch could not be resumed and is forever paused. The state of the entry needs to be exposed on DS initialization, so that paused items can notify the OfflineContentAggregator and display a notification. Bug: 889423 Change-Id: Ia61c903f6234264821aad20b7bb93d6a3fdeb447 Reviewed-on: https://chromium-review.googlesource.com/c/1251630Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#597204}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/39be1c969580..64626344db73 git log 39be1c969580..64626344db73 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 bhthompson@google.com Make grunt-paladin and grunt pfqs important Created with: gclient setdep -r src/third_party/chromite@64626344db73 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ide9ce8f3e1cb48798be6d653ce3a277a2fd171b5 Reviewed-on: https://chromium-review.googlesource.com/c/1265038Reviewed-by:
-
manuk authored
[Omnibox] When in keyword mode, don't allow shortcut matches of different keywords to be the default match. Prior to this cl, when the user has searched for `searchProvder searchTerm` (not in keyword mode) then typing in `searchProvider `, entering keyword mode, and typing `s` could result in the shortcut match for the earlier search becoming the default match and causing him to leave keyword mode. Bug: 632215 Change-Id: I19ee38e3e5c9ee68f8f7703afccef1276027b521 Reviewed-on: https://chromium-review.googlesource.com/c/1182295 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#597202}
-
Tatiana Buldina authored
bug: chromedriver:1945 Change-Id: I3148ef524714e06766db15cf63812bf2ca0d75eb Reviewed-on: https://chromium-review.googlesource.com/c/1265256Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#597201}
-
Wei Li authored
UI Devtools use overlay model to support element highlight. However, in remote debugging configuration, the highlight is handled by screencast module which is not supported in current UI Devtools. This CL fixes this by using local debugging on local sessions. BUG=749778 Change-Id: Idc81ff27e05d5b95e72748873b933b1ecdb80ad2 Reviewed-on: https://chromium-review.googlesource.com/c/1262960Reviewed-by:
-
Majid Valipour authored
Worklet animation supports invalidation of its compositing state. This patch makes this invalidation process a no-op for animations that are running on main (i.e., |compositor_animation_| is null). This means we no longer try to read/modify the non-existent |compositor_animation_| which was causing the crash. Note that in some situations, even for currently main thread animaiton, we may actually want to create and start the |compositor_animation_| but this is a separate issue that can be fixed as a follow up. The added DCHECK uncovered a bug where we were attaching the worklet animation to early even if play was failing. This is also fixed. Bug: 887659, 889330 Change-Id: I4a89de6632e053f68beafb810355c25e4bfba0e3 Reviewed-on: https://chromium-review.googlesource.com/c/1249387 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597199}
-
Robert Ogden authored
This way it can also be used by the new Previews UI Bug: 871839 Change-Id: Iecba63729da87fc6f30cc0f0cceaebf85adc4729 Reviewed-on: https://chromium-review.googlesource.com/c/1265062 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#597198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/263549ba0d66..4e9584b32dfe Created with: gclient setdep -r src-internal@4e9584b32dfe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I85fee9a3d742f47597ade47e850eb1d993769238 Reviewed-on: https://chromium-review.googlesource.com/c/1265037Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597197}
-
Tommy C. Li authored
This CL takes a section of code used to show the full URL for Steady State Elisions and moves it from the Views UI code to the OmniboxEditModel. This is in preparation for it to be used for Query in Omnibox. It also adds a little bit of specific test coverage for this code. Bug: 874592 Change-Id: I354c17a91751f930bd94d0ce9e02ef3f2846d15f Reviewed-on: https://chromium-review.googlesource.com/c/1262655 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a1134509c91d..96a0f6191781 git log a1134509c91d..96a0f6191781 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 oprypin@webrtc.org Revert "[cleanup] Remove useless includes." 2018-10-05 sprang@webrtc.org Turning off a stream should results in target bitrate 0 signal 2018-10-05 yvesg@webrtc.org [cleanup] Remove useless includes. Created with: gclient setdep -r src/third_party/webrtc@96a0f6191781 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib706f62da1f7169d1aea11c1617c76ea2278fe12 Reviewed-on: https://chromium-review.googlesource.com/c/1264629Reviewed-by:
-
Brian White authored
Crash reports indicate that checksums are valid even though the bucket boundary values are tested to be incorrect. Try to determine if it is memory corruption or bad calculations. Bug: 836238 Change-Id: Ie89df5fef5093e9dd8c45fe9ff26a0430838769e Reviewed-on: https://chromium-review.googlesource.com/c/1264036Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#597194}
-
Kevin Marshall authored
Net tests broke because test process' /data directories are now isolated and can't be used for sharing data out-of-process. The net test launcher depends on the old behavior for deploying configuration files to test code. This CL designates a special path "/data/shared" into which shared files will be placed. The shared directory will be mounted at "/test-shared" in the test process' namespace. The net test launcher & test code are modified to use the new paths. TBR=mmenke@chromium.org Bug: 891732 Change-Id: Id94bffe05a3b140ed60e42507cdc8d238677f202 Reviewed-on: https://chromium-review.googlesource.com/c/1259829 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Previously, when the user has a disabled PDF plugin (or no PDF plugin) and the website has an IFRAMEed PDF, when Click to Open PDF was enabled, we would inject a fake <object> tag into the IFRAME to force a PDF plugin placeholder to appear. This approach is problematic with CSP, as CSP may forbid OBJECT tags from loading in IFRAMEs. This CL instead injects the placeholder HTML directly into the IFRAME. In the IFRAME case, the button is now a plain link, which should allow the user to click it and download the PDF even if CSP forbids <object> tags or JavaScript. It still may trigger a CSP warning if IFRAME is prohibited from running JavaScript, but that only hurts keyboard-accessibility, and doesn't prevent the mainstream use case from working. This CL also prevents the <object> tag from auto-opening the PDF after download, which was probably a mistake, since that overrides the user configurable "Always open with system viewer" option. Bug: 887752, 879149, 878871 Change-Id: I900c08331d2cfc96ea7cd1cd46ea594445b0920b Reviewed-on: https://chromium-review.googlesource.com/c/1246956Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#597192}
-
