GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/0e1901c5709f..c827dc29b351


git log 0e1901c5709f..c827dc29b351 --date=short --no-merges --format='%ad %ae %s'
2019-05-10 treehugger-gerrit@google.com Merge "Do not grab spinlock for reading."
2019-05-10 fmayer@google.com Fix typos in heapprofd doc.
2019-05-10 fmayer@google.com Merge "Document [DEDUPED] methods."


Created with:
  gclient setdep -r src/third_party/perfetto@c827dc29b351

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I956d3ac108378bd39da74bc7fb34bcf691e9f2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606075Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658700}

https://webrtc.googlesource.com/src.git/+log/2a1f020dd9e6..efe931463c18


git log 2a1f020dd9e6..efe931463c18 --date=short --no-merges --format='%ad %ae %s'
2019-05-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision def6b1e7..b149f494 (658489:658619)
2019-05-10 srte@webrtc.org Renaming inferred route change events.


Created with:
  gclient setdep -r src/third_party/webrtc@efe931463c18

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4bf0f6a22b653266d5e85d0b8143baa0cf31b4ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606105Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658699}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/06ce59b0b076..2947e88f7938


git log 06ce59b0b076..2947e88f7938 --date=short --no-merges --format='%ad %ae %s'
2019-05-10 33432579+alan-baker@users.noreply.github.com Update instrumentation passes to handle 1.4 interfaces (#2573)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@2947e88f7938

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com,jonahr@google.com

Change-Id: If302dd1c041dcc160e90eb2c3b1e2b8d40c906d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605479Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658698}

Fork the search_page so it can be customized for OS settings. Remove
manage search engines. When SplitSettings is enabled:
* Show "Assistant" section in OS settings
* Hide "Assistant" section in browser settings
* Use "Search engine" as the section title in browser settings

Later we may change the "Search engine used in the address bar" label
to make it clear that it also affects the app launcher, but that needs
to go through UX review first.

Bug: 960937
Change-Id: I4b1233c6e0cad2b6bea678eed420d9004434335c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599928
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658697}

Change downloads to use the same approach as settings, extensions, and
print preview:
(1) Use an individual grd file instead of browser_resources.grd
(2) Create unpak folder

Bug: 715296
Change-Id: Ieff03ab94d867871d62d29e217fc189434e8b03d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605478Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658696}

This change is part of the Android Password Manager UI.

This CL adds a button to the accessory sheet, meant to allow users
to manually trigger password generation. The change is flag guarded
by #manual-password-generation-android.

Bug: 835234
Change-Id: Ie651d51c53ee28a943fd06f6f93396a495720354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479996
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658695}

This change restrictes the SMS Receiver API to only be used from top level
frames to prevent malicious sites from accessing the one time passcodes
for signup. Restriction in the browser process will be added in a
following CL.

Bug: 955765
Change-Id: Ie11e3b1fc6c9bf4597bde880d5083fec7255b79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594211Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658694}

This change removes:
1) The enable-offline-auto-reload flag
2) The enable-offline-auto-reload-visible-only flag
3) The {en,dis}able-offline-auto-reload-visible-only switches
4) All code paths for handling those switches

The {en,dis}able-offline-auto-reload switches are retained because they
are used to control offline-auto-reload in browser tests, which often
do not expect error pages to be reloaded out from under them.

Bug: None
Change-Id: I05a6b481775200ac187df837bbf1e03db833a6e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604219
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658693}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/c4f8f65792d4..30ebd2f19c8d


git log c4f8f65792d4..30ebd2f19c8d --date=short --no-merges --format='%ad %ae %s'
2019-05-10 johnkslang@users.noreply.github.com Merge pull request #103 from amdrexu/bugfix


Created with:
  gclient setdep -r src/third_party/spirv-headers/src@30ebd2f19c8d

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com,jonahr@google.com

Change-Id: I2d3ce1aa203cb0a6b3fbfed323401ba20b3f9da7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606073Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658692}

WebAppBrowserController is now defined in chrome/browser/ui/web_applications/
and renamed to AppBrowserController.

It is the abstract superclass for the controllers for two types of apps:
- HostedAppBrowserController for extension based apps
- ManifestWebAppBrowserController for web apps (e.g. PWAs)

Change-Id: Iec4cf2e73f53873ef274fdc51f25375361efb698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600920Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658691}

When toggling the 'elide cells' checkbox, it would be applied. But upon
making a new query, the option would not be reapplied to the newly
rendered DOM elements.

Bug: 961747
Change-Id: Ia7e8a877383c1367464fe5dd3ba00141511d9c45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604492
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658690}

This CL is re-enabling the layout unittest on windows.

Fonts size have been adjusted on MAC. They are now about
1 pixel larger than other platform, which make more sense
than the previous values. I cannot explain the choice of
the previous values.

These tests were flaky because some code in chrome tests were
modifying a system-wide flag that change the way fonts are
rendered.

We are assuming the default configuration: Anti-Aliasing is on.

Other unittests should not turn on/off the system-wide flag.
Modifying that flag may leave the developer computer or the
build bot in a bad state. Tests are likely to crash and may
not restore correctly the state; they may run in parallel and
have incorrect behavior.

This change needs to be landed after fixing flakiness:
  1) https://chromium-review.googlesource.com/c/chromium/src/+/1570527/
  2) https://chromium-review.googlesource.com/c/chromium/src/+/1569969

NOTE TO SHERRIFS:
 If any Layout test are flaky, please disable the test
 and assign the bug to me. I think I've found any cause of flakiness. If not,
 I'll dig more.

BUG=759870, 701241
R=tapted@chromium.org
CC=​​​​​​​​​robliao@chromium.org,asvitkine@chromium.org

Change-Id: Iab8f4adb58e565600bedecb1365e05bfdf931079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570653
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658689}

TBR=vasilii@chromium.org

Bug: 961196
Change-Id: I358bb7ee3c0355f3e00e93e2824db727ca37ebca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604281
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658688}

This is the client change to allow scripters to override the text of the Autofill-Assistant payment request button.

Bug: b/131363578
Change-Id: I23990038b6636507fd8df3654aacddd9f5d43901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603348
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658687}

This reverts commit 4942308a.

Reason for revert: This change appears to be generating a lot of crashes. See http://crbug.com/961599 for examples.

Original change's description:
> Adding CanAccessDataForOrigin() checks to AppCache.
>
> Adding security checks to verify that the process is allowed to
> access the manifest and document URLs the renderer sent to the AppCache.
>
> Bug: 946260
> Change-Id: Idd42305c42d61c88ef5b76f26d231bb9a9a2c75a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582310
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Commit-Queue: Aaron Colwell <acolwell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657921}

TBR=acolwell@chromium.org,mek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 946260, 961599
Change-Id: Iab9a7870e39a723453ad860ec80f672ed678d654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604336Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658686}

Add/remove selected state to tiles on click.

Screencast: http://go/scrcast/NTQ1NTA3NzAxNTgxNDE0NHw1MDVkNDQ5ZC1lMQ

Bug: 937570
Change-Id: Ie5c29edd3aa978e158324e687288c8fc1107728c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604422
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658685}

Bug: 941690
Change-Id: I6ca379bbbeef1d6ab48fcafb72d5469fd25e1890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602451Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658684}

Currently, the notification bar abruptly disappears after the second to last
notification is dismissed, which is quite jarring.

This same animation will also be used when the clear all animation is updated to
spec.

Video:
https://screencast.googleplex.com/cast/NDg3MjczMzQ3MzExMjA2NHw3ZmNmNGY5OC01Yw

TEST=manually verified, updated unit test
BUG=958276

Change-Id: I55bfeb4b23c1c2bda47ccd21dbef5a5955a62675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592701
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658683}

LayoutNG is a new layout engine for Blink designed to support modern web
applications with predictable performance characteristics and extensible
behavior. Fixes a large number of interoperability and correctness bugs.

The goal of this field configuration and the finch trial is to allow for
early metrics gathering in preparation for enabling LayoutNG by default.

Bug: 591099
Change-Id: I566824fadbc8f022cb013db1566deb5b23f91537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590608
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Auto-Submit: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658682}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c693cce42dc..f185df0cfd8c


Created with:
  gclient setdep -r src-internal@f185df0cfd8c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com

Change-Id: Ia64cb3a64dc001302fa3059e43ed17af3af3d669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606104Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658681}

Without these changes, rolling Googletest results in compilation
errors: https://crrev.com/c/1597689/1.

TBR=ajwong, avi, morlovich, piman, rdevlin.cronin, xhwang

Change-Id: Ic9c2c9c2b328ad1e501745dffd196a2386e99e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605840Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Staphany Park <staphany@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658680}

- Creates InfobarContainer protocol so the ChildCoordinators can
communicate with the ContainerCoordinator. Uses this to inform it they've
stopped.
- Nils the InfobarDelegate on stop.

Bug: 911864
Change-Id: I108fbaa3e7a4b0ee73c4cf2e57ee3d969eba473d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605148Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658679}

Bug: 961725
Change-Id: I0b993083c4f222014675bbb3c7e4f7c9750a755b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603267Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658678}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cb549d80..ee8d4aca

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I7ab0cac5f951a4b203233519d0871c9b72ce3f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604325Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658677}

Select the blink::WebThemeEngine at run-time. Delete references to
long-deleted files.

Bug: 961342
Change-Id: I3eecfb24b0fc31da4e7b90634ba7ccc1079b1f10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602857Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658676}

This reverts commit 956715c7.

Reason for revert: precautionary measure for canary releases over the
weekend, to prevent the directory being deleted for users that
haven't yet migrated to prefs.

Original change's description:
> Fix sync protocol violation about birthday requirements
> 
> The sync (store) birthday can only be empty during the very initial
> interactions with the server, when control datatypes are downloaded,
> after enabling sync (or the user signing in, for sync-the-transport
> mode).
> 
> If, during startup, the birthday is empty, we should throw away all
> sync metadata and redownload everything. One way to do so is to
> regenerate the cache GUID, which datatypes detect as mismatch and
> leads to all sync metadata being cleared.
> 
> As can seen in newly added tests, the scenario seems hard to
> reproduce, but we have server-side evidence that some users run into
> this issue (and would even DCHECK-fail for DCHECK-enabled builds).
> 
> Bug: 923285
> Change-Id: If9e4807a086001931fd65f3e12a1ab53c4a33c9d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599456
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658540}

TBR=treib@chromium.org,mastiz@chromium.org

Change-Id: I4e65fcfa02d9e0cefe753839b0d56ecad8de0170
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 923285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606161Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658675}

This patch determines boundary shaping criteria more
correctly.

This change includes "must" criteria in the current spec:
https://drafts.csswg.org/css-text-3/#boundary-shaping
and also honor what HarfBuzz requires.

6 tests turn to pass. 3 tests need rebaseline because
borders around "A" prevents kerning between space+A.

Bug: 636993
Change-Id: I65f6cdb3cb32bccffa225641383abe25fce6abb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599062
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658674}

Moves distance info into InspectorHighlight, which can be
tested over protocol.

Bug: 946873
Change-Id: Ica3cde18b2e993df843e1ff4491a8e8ca2358f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590453
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658673}

Missed a typo and a comment on the original CL.

Bug: 951907
Change-Id: If7ccecae4d23255e2dfc4f38779e20b3c0123dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605155
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658672}

Bug: 961776
Change-Id: I3d6d22599657bbcdef61370410d3deb002783fef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605509
Auto-Submit: sebsg <sebsg@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658671}

The policy indicator icon was not correctly shown and this cl fixes it.

Bug: b/132281249
Test: Local build
Change-Id: I28d31b3bf1b8e4876ecceb76d80f7f6186d3f4c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601386Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658670}

In order to run the web-platform-tests automatically, we will use
testdriver Action API in all the wpt to simulate inputs.

pointerevent_support.js keeps many commonly used functions in the
pointer event tests. There are click function for all input types,
touch, mouse and pen. So I make the current touch tap function to a
general "clickInTarget" function for all inputs.

Bug: 606367
Change-Id: I8da3e8910c6ec0128a40d38ce6ac21bf24c449a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604328Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658669}

PreviousLinePosition() and NextLinePosition() are subroutines of
SelectionModifier and only used there. Hence, this patch moves the two
functions, together with their helper functions, to
selection_modifier_line.cc for better code structure.

This is also preparation for implementing hit test based up and down
caret movements.

Note: One VisibleUnitLineTest tests an exposed subroutine of
PreviousLinePosition, which is inappropriate. This patch changes it
to test up caret movement instead.

Bug: 950728
Change-Id: Ia8a59e8de4bef53c5b4708c59e6995c9d6021687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603211
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658668}

This patch also removes the logic for the unused variations
of the experiment and adds some basic unit tests for the
feature.

Bug: 894211,956095
Change-Id: I189c542e54d12db430a701b2c6feb62e59a978c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597693Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658667}

Disable in-connection version negotiation in QUIC and change P2PQuicTransport to use a single supported version

BUG=961472

Change-Id: I9db2ed94b6de916e6834c7169575f2f46aa3ebc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603824Reviewed-by: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658666}

The contains_address bool previously determined which type of icon to
add to a suggestion in the autofill-use-improved-label-disambiguation
experiment. Ultimately, one icon was chosen, so contains_address is
unused.

This CL changes the boolean to store whether a LabelFormatter in the
experiment was successfully created. If so, an icon is added.

This change is necessary because unexpected forms, such as those
without name fields, add an icon to suggestions that are not made with
a LabelFormatter. However, in these cases it is preferred to not show
the icons.

Screenshot:
https://screenshot.googleplex.com/7gsK2RE8Wu9

Bug: 951174
Change-Id: I8aa1434506d2639cf59677f53cf1540eeffd37b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602733
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658665}

In normal browser cases, when the user backs out of the page info
dialog, in some cases focus needs to be returned to the security chip/
location bar. In PWA/focus mode, since the page/app info dialog is
launched from the three-dot app menu, focus needs to instead return to
the web contents pane. (See attached bug for example.)

This is a more general fix to a spot fix introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1362499
to solve issue 910067.

We create a general system because the behavior is (a) substantively
different depending on the calling context, and (b) often relies on
code/access to views specific to the caller.

Bug: 949066
Change-Id: Ideb8fdcb8ec09c580845b3c83c44eb3ab6c76ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600081
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658664}

Script is almost working, but uploading .ndjson to the wrong directory.

Bug: 873714
Change-Id: If75f693be6cbeafc4dbe4995208bbe76feaf4313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605153Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658663}

Put the setup of the broken image and placeholder elements in a helper
class to make it easier to decipher what is being done, and also what
depends on the ComputedStyle object and not.

Bug: 953707
Change-Id: I675539611e5160e4e31523a1dbcea830fe5c7f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604267
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658662}

This reverts commit 24cade5c.

Reason for revert: Breakage fixed before this CL took effect

NOTRY=true
TBR=sullivan@chromium.org
CC=​​tdresser@chromium.org,mythria@chromium.org,ulan@chromium.org
Bug: 961434

Original change's description:
> Disable browse:shopping:lazada and amazon where failing on Android Go
> 
> NOTRY=true
> TBR=sullivan@chromium.org
> CC=​​tdresser@chromium.org,mythria@chromium.org,ulan@chromium.org
> 
> Bug: 96434
> Change-Id: Ic34d4f6221eecd7907273526a11021d57556a3a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603544
> Commit-Queue: Charlie Andrews <charliea@chromium.org>
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658269}

TBR=sullivan@chromium.org,charliea@chromium.org

Change-Id: Iec64491f99aab830af0d1ab136182b7ea16e9485
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 96434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605156Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658661}