GitLab

r1385: Linux: Call memset() in a couple places in ExceptionHandler.

BUG=332335

Review URL: https://codereview.chromium.org/590403003

Cr-Commit-Position: refs/heads/master@{#296446}

This is to help diagnose an issue where the perf bots seem to be running without
flash.

BUG=416849

Review URL: https://codereview.chromium.org/597213002

Cr-Commit-Position: refs/heads/master@{#296445}

Add filenames support. DO_NOT_CONVERT_FILENAMES policy is not
supported because writing NSFilenamesPboardType to NSPasteboard always
populates the URL types.

Modify SetURL so that it doesn't overwrite previous SetString.

The following tests now passes:
OSExchangeDataTest.URLAndString
OSExchangeDataTest.TestFileToURLConversion

BUG=378134

Review URL: https://codereview.chromium.org/542203004

Cr-Commit-Position: refs/heads/master@{#296444}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4d5ca33..440c1ed

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/602733003

Cr-Commit-Position: refs/heads/master@{#296443}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cd523eb..34a9895

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/601813002

Cr-Commit-Position: refs/heads/master@{#296442}

Updated wording as well.

BUG=413337
TEST=manual

Review URL: https://codereview.chromium.org/597673003

Cr-Commit-Position: refs/heads/master@{#296441}

The original usage of the method was added to fix a rendering issue
with the YouTube plugin: see http://crrev.com/2862031 .
Setting an appropriate viewport seems to work as well
and removes usage of a method I'm trying to remove.

BUG=417221

Review URL: https://codereview.chromium.org/596253002

Cr-Commit-Position: refs/heads/master@{#296440}

BUG=78512, 407376
TEST=no change

Review URL: https://codereview.chromium.org/596543002

Cr-Commit-Position: refs/heads/master@{#296439}

Revert of Swarm tests on Linux release tester. (patchset #2 id:20001 of https://codereview.chromium.org/598053002/)

Reason for revert:
since I disabled the recipe side

Original issue's description:
> Swarm tests on Linux release tester.
>
> BUG=414808
> TBR=maruel@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/01b2eb0b5e291faa238d6a21def3e62056bc1fdd

TBR=maruel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414808

Review URL: https://codereview.chromium.org/602603004

Cr-Commit-Position: refs/heads/master@{#296438}

On CrOS, app windows can already be minimized by clicking their icon in the
taskbar. This just makes them show a minimize button as well.

On Windows, we prevent minimize if the window can't maximize, which
doesn't really make sense. They will now be able to minimize and show a
minimize button.

On Mac and Linux they could always minimize.

BUG=351179

Review URL: https://codereview.chromium.org/603523002

Cr-Commit-Position: refs/heads/master@{#296437}

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/600003002

Cr-Commit-Position: refs/heads/master@{#296436}

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/603453003

Cr-Commit-Position: refs/heads/master@{#296435}

Revert of Another attempt to fix debug info stripping for ASan on OSX (patchset #5 id:80001 of https://codereview.chromium.org/560323004/)

Reason for revert:
Broke mac asan content_browsertests:
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%281%29/builds/4311/steps/content_browsertests/logs/stdio

Original issue's description:
> Another attempt to fix debug info stripping for ASan on OSX
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions in each
> executable. However __asan_default_options still must be preserved to be accessible
> from the ASan runtime.
>
> This CL removes all ASan symbols except for __asan_default_options from the .saves files
> and makes Chromium.app and Chromium Helper.app correctly use app_asan.saves.
> It also turns mac_strip_release on for ASan builds.
>
> BUG=148383,242503,170739,166857
> R=mark@chromium.org
> TBR=cpu@chromium.org
>
> Committed: https://crrev.com/d051b21c75afc414190db331fd608cc61e3056dc
> Cr-Commit-Position: refs/heads/master@{#296413}

TBR=mark@chromium.org,cpu@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148383,242503,170739,166857

Review URL: https://codereview.chromium.org/597873004

Cr-Commit-Position: refs/heads/master@{#296434}

Revert of Adding split view divider widget. (patchset #15 id:280001 of https://codereview.chromium.org/545393002/)

Reason for revert:
DragHandleTest.ScrollTest is failing on the bots: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36880

Original issue's description:
> Adding split view divider widget.
>
> Adding split view divider widget which could be dragged to exit the split view.
>
> BUG=403207,408691
>
> Committed: https://crrev.com/b47c16517f0882cbabf8c9aa9ce66711f026fd5b
> Cr-Commit-Position: refs/heads/master@{#296351}

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,tdanderson@chromium.org,pkotwicz@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403207,408691

Review URL: https://codereview.chromium.org/602603003

Cr-Commit-Position: refs/heads/master@{#296433}

Since we use an embedder provided thread everywhere, we should also let
the embedder do the yielding.

BUG=301514
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/596243002

Cr-Commit-Position: refs/heads/master@{#296432}

Change this ManagePasswordsBubbleCocoaTest to use the tab strip model API
active_index() to determine if tab content is active.

TBR=rohitrao
BUG=417253

Review URL: https://codereview.chromium.org/592353005

Cr-Commit-Position: refs/heads/master@{#296431}

BUG=414808
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/598053002

Cr-Commit-Position: refs/heads/master@{#296430}

BUG=none
R=inferno@chromium.org

Review URL: https://codereview.chromium.org/598063002

Cr-Commit-Position: refs/heads/master@{#296429}

This is a reland of http://crrev.com/3882aae7 since
http://crrev.com/40d8624d should have fixed the problem leading to
diff update failures.

BUG=340387
TEST=N/A

Review URL: https://codereview.chromium.org/596353002

Cr-Commit-Position: refs/heads/master@{#296428}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5fa19f3..4d5ca33

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/603573003

Cr-Commit-Position: refs/heads/master@{#296427}

Revert of Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/601803002/)

Reason for revert:
Wrong revert. I misread the buildbot failure email.

Original issue's description:
> Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/595313002/)
>
> Reason for revert:
> Break build:
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/19333
>
> Original issue's description:
> > Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594)
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3
> >
> > TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org
> >
> > Committed: https://crrev.com/0ae73de143b645c376ac0e503e9627d33bb3c4f1
> > Cr-Commit-Position: refs/heads/master@{#296414}
>
> TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/677a9222f8fbf4e581ba4461ae700c8c380bc78c
> Cr-Commit-Position: refs/heads/master@{#296418}

TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/595353002

Cr-Commit-Position: refs/heads/master@{#296426}

This function can return NULL if it fails to attach a stencil buffer,
or if it fails to allocate a GrGLTexture object.

R=enne@chromium.org
BUG=416795

Review URL: https://codereview.chromium.org/596343002

Cr-Commit-Position: refs/heads/master@{#296425}

Instead of a cryptic Unicode code point, this makes characters that are not
defined by the current braille table show up as dot 8, which should be
a rarely used cell in most or all braille tables.

While it might be nice to give users more information than a single 'unknown
character' dot, this is the only feasable alternative to the hexadecimal
number (\xHHHH).

BUG=321715

Review URL: https://codereview.chromium.org/589133002

Cr-Commit-Position: refs/heads/master@{#296424}

It doesn't make sense for 1-copy rasterizer where we can
control the exact amount of memory used to be affected
by the transfer buffer limit.

This sets the upper bound to 32 resources, which is reduced
to 0 when invisible. A simple constant like this is likely
what we want long term.

BUG=406404

Review URL: https://codereview.chromium.org/597833002

Cr-Commit-Position: refs/heads/master@{#296423}

This makes it so that the plugin can not use blocking completion callbacks while servicing HandleBlockingMessage. This is to discourage leaving JavaScript hung while doing long-running things (e.g. file IO).

(Of course, the plugin can get around this by bouncing to another thread; but I think this adds a useful guideline/deterrent.)

BUG=415351

Review URL: https://codereview.chromium.org/600553002

Cr-Commit-Position: refs/heads/master@{#296422}

BUG=412841

Review URL: https://codereview.chromium.org/584533002

Cr-Commit-Position: refs/heads/master@{#296421}

Since we on ChromeOS don't (always) need to enumerate devices at all.

BUG=345296
NOTRY=true

Review URL: https://codereview.chromium.org/596233003

Cr-Commit-Position: refs/heads/master@{#296420}

https://codereview.chromium.org/554733002 added support to 24K as sample rate, we need to update the uma stat correspondingly.

BUG=411241

Review URL: https://codereview.chromium.org/602503003

Cr-Commit-Position: refs/heads/master@{#296419}

Revert of Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594) (patchset #1 id:1 of https://codereview.chromium.org/595313002/)

Reason for revert:
Break build:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/19333

Original issue's description:
> Roll src/third_party/WebKit f2b7b089:5fa19f3 (svn 182592:182594)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3
>
> TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org
>
> Committed: https://crrev.com/0ae73de143b645c376ac0e503e9627d33bb3c4f1
> Cr-Commit-Position: refs/heads/master@{#296414}

TBR=ager@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/601803002

Cr-Commit-Position: refs/heads/master@{#296418}

Review URL: https://codereview.chromium.org/584313003

Cr-Commit-Position: refs/heads/master@{#296417}

Cr-Commit-Position: refs/heads/master@{#296416}

Enumeration and iteration were passing around void**. With this CL, we
instead use an Iterator object.

TBR=jkarlin@chromium.org,rvargas@chromium.org,clamy@chromium.org,piman@chromium.org
BUG=413644,416059
TEST=None

Review URL: https://codereview.chromium.org/588243002

Cr-Commit-Position: refs/heads/master@{#296415}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2b7b089..5fa19f3

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/595313002

Cr-Commit-Position: refs/heads/master@{#296414}

Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.

Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).

Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions in each
executable. However __asan_default_options still must be preserved to be accessible
from the ASan runtime.

This CL removes all ASan symbols except for __asan_default_options from the .saves files
and makes Chromium.app and Chromium Helper.app correctly use app_asan.saves.
It also turns mac_strip_release on for ASan builds.

BUG=148383,242503,170739,166857
R=mark@chromium.org
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/560323004

Cr-Commit-Position: refs/heads/master@{#296413}

For now, this is used in the SupervisedUserInterstitial instead of listening to pref changes manually.
More clients will follow in later CLs.

BUG=

Review URL: https://codereview.chromium.org/597573002

Cr-Commit-Position: refs/heads/master@{#296412}

Use an internal callback instead of requiring the client to
pass a scoped_ptr<> to a "Delete" function.

BUG=416873

Review URL: https://codereview.chromium.org/600693002

Cr-Commit-Position: refs/heads/master@{#296411}

Enable using a JS dictionary to initialize a the fields in a Mojo struct. For example, to initialize a URLRequest:

  var urlRequest = new loader.URLRequest({
    url: "http://www.cnn.com",
    method: "GET",
    auto_follow_redirects: true
  });

The value of unspecified fields is the Mojo default for the field's type. Values for fields that were not specified in the Mojom struct definition are ignored.

BUG=416163

Review URL: https://codereview.chromium.org/595063002

Cr-Commit-Position: refs/heads/master@{#296410}

Try swarming base_unittests, browser_tests, content_browsertests, interactive_ui_tests, sync_integration_tests and unit_tests on debug Linux bots.

BUG=414808
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/598463004

Cr-Commit-Position: refs/heads/master@{#296409}

"Add New User" screen should have enabled all hardware
keyboards, owner and system input methods.

BUG=365299
TEST=manual

Committed: https://crrev.com/a5a81ef618a26e513a4ae0f2b4b0e77f8224e946
Cr-Commit-Position: refs/heads/master@{#296199}

Review URL: https://codereview.chromium.org/484353005

Cr-Commit-Position: refs/heads/master@{#296408}

Images over 32M pixels exceed IPC message limit size.  In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message.

BUG=366825
TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug

Review URL: https://codereview.chromium.org/482163002

Cr-Commit-Position: refs/heads/master@{#296407}