GitLab

BUG=836871

Change-Id: If259500c8f226ff198586f56a3d711565791b488
Reviewed-on: https://chromium-review.googlesource.com/1140433
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575695}

The worker's onmessage handled needs to be wrapped in a step_func()

Change-Id: Icfbad1936d9c9bd7fbd5522ce64f667f2699ef0d
Reviewed-on: https://chromium-review.googlesource.com/1139179
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575694}

Bug: 680407,621126
Change-Id: I4be6aeb3cdce35c89abaea8ce756aba456aa36b9
Reviewed-on: https://chromium-review.googlesource.com/1138794Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575693}

Some Chrome OS services actually rely on this being OK since they don't
have the PID of the target process available. Presumably they would fail
if DCHECKs were enabled.

This removes an unnecessary DCHECK so that such code can be exercised in
chromium tests.

Bug: None
Change-Id: Id546644aae7222eaf76b9a279f0c99af0764573c
Reviewed-on: https://chromium-review.googlesource.com/1140280Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575692}

Bug: 857533
Change-Id: I9a62b52edad78b30cc25dc15f7f098ce3a82bc46
Reviewed-on: https://chromium-review.googlesource.com/1140374
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575691}

In fullscreen, when the mouse moves to the upper border of the screen, a
slide-down menu will show. When the user enables showing toolbar in
fullscreen, a native title bar will also appear. In such case, our tab
strip and toolbar should show underneath the title bar.

This CL reuses the Cocoa browser's menu and mouse tracking classes, and
implements a Views based FullscreenToolbarController to track the mouse
activities and menu progress so the top UI would show in appropriate
position.

BUG=831219

Change-Id: Ia30c9cb74819a866ae39cc3e696affb94350efbf
Reviewed-on: https://chromium-review.googlesource.com/1130001Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575690}

We decided to skip the finch trial for adding these new UMA metrics,
so remove the flag kPresentationFeedbackEveryFrame added earlier.

Bug:851088

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I63eacff9d616594d340b983a0fe373c24e790032
Reviewed-on: https://chromium-review.googlesource.com/1136069Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575689}

When the flag is on, Polymer 2 is used everywhere. When off, Polymer 1 is used.

Bug: 862472
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iefdbf6448c0c69b6f22df1a3db57db29e29607da
Reviewed-on: https://chromium-review.googlesource.com/1137706
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575688}

This is a partial reland of b035cfda

Original change's description:
> Disallow QuitCurrent*Deprecated() on RunLoops with Quit*Closure()s.
>
> Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky,
> potentially causing unexpected early-exits if run under a different
> RunLoop to the one intended.
>
> If a caller has taken a Quit*Closure() from the RunLoop then we now
> assume that they intend to use it to quit the loop, and therefore use
> of QuitCurrent*Deprecated() with it must be unintentional.
>
> Bug: 844016
> Change-Id: Ib181d0cb34cdba2af29f557646cbe631101bc6b0
> Reviewed-on: https://chromium-review.googlesource.com/1082980
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571499}

Bug: 844016
Change-Id: I0666631fa736244c18f8848b317b41762881c748
Reviewed-on: https://chromium-review.googlesource.com/1121296Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575687}

Don't allow Explore on Content to re-show itself in response to a tap on
the toolbar button until any previously set content is fully removed
from the sheet.

Also, go directly to the hidden state when tapping on the scrim when the
peek state is disabled.

BUG=863568

Change-Id: I5f6fea7fe637b4f346542321de6716899b6bf8fc
Reviewed-on: https://chromium-review.googlesource.com/1139112Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575686}

This type was introduced for server LoFi before Previews had
blacklisting support. It did 3 things: bypassed cache, loaded original
request, and disabled previews.

Previews are disabled by the 5 minute rule after an opt out, so that
functionality is covered (if users have disabled their blacklist, they
will not be served the preview because of a new 5 second rule, but this
scenario is not supported by default).

Bypass cache is not important, as LoFi images, litepage, etc are using
vary to control resources based on added headers, so not setting the
various previews headers handles this (in the case of client LoFi,
range requests are used instead of vary).

Since we are using a reload type that gets the original requested URL,
we handle that case as well.

This also adds dependency injected Clock for testing the ignored
blacklist functionality.

Bug: 863569
Change-Id: Ia1f05f6242522f883903742301025fb6d3c71044
Reviewed-on: https://chromium-review.googlesource.com/1137022Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575685}

BUG=b:110439301

Change-Id: I3ab1081653fbca1c1f427f2621d181f2fe0c1bc3
Reviewed-on: https://chromium-review.googlesource.com/1128326Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575684}

https://android.googlesource.com/platform/external/perfetto.git/+log/3d33483bb985..debca810f01d


git log 3d33483bb985..debca810f01d --date=short --no-merges --format='%ad %ae %s'
2018-07-17 hjd@google.com Merge "perfetto-ui: Add dingus test double library"
2018-07-17 hjd@google.com perfetto-ui: Add dingus test double library


Created with:
  gclient setdep -r src/third_party/perfetto@debca810f01d

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iebad06e41a79ae03969ec5cce0c197b699b2ee80
Reviewed-on: https://chromium-review.googlesource.com/1140414
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575683}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9e945c84d2be..004af3cf8045


git log 9e945c84d2be..004af3cf8045 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 dgarrett@chromium.org Revert "chrome_committer: Hardcode GCE service account."


Created with:
  gclient setdep -r src/third_party/chromite@004af3cf8045

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Iab1c07aab14afff52078df885670fa522cb8c8f9
Reviewed-on: https://chromium-review.googlesource.com/1140258Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575682}

Makes fling speed feel more natural.

Bug: none
Test: flashed, flinged
Change-Id: I8b181dbe0e9dec00f1e7a91799bbd83e86bea48b
Reviewed-on: https://chromium-review.googlesource.com/1140503
Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575681}

The previous DCHECK meant that we can't introduce a new type in the
future without breaking old clients. Instead, just ignore types we
don't know about.

Bug: 864428
Change-Id: Iaa31e2b0e6d501e14fcc1fa840110fc22f5c100a
Reviewed-on: https://chromium-review.googlesource.com/1140058Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575680}

Bug: 826367
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6f3659b846ecf118e1c5710a77ba020ba6eb2d25
Reviewed-on: https://chromium-review.googlesource.com/1123692Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575679}

This is a reland of 4714a9fc (PS1 is the original CL)

Reverted @ https://chromium-review.googlesource.com/c/chromium/src/+/1137893
for a perf regression.
Suspected cause : |IncomingTaskQueue::message_loop_scheduled_| wasn't
equivalent to |was_empty| after all since |incoming_queue_| being empty
doesn't mean |outgoing_queue_| is empty (hence setting a bit to false
when both |outgoing_queue_| and |incoming_queue_| are empty is important
to avoid scheduling more than necessary.

Original change's description:
> [MessageLoop] Refactor ScheduleWork and TaskAnnotator logic out of IncomingTaskQueue
>
> This was extracted from
> https://chromium-review.googlesource.com/c/chromium/src/+/1088762/17
> in an attempt to simplify it (and is now a precursor to it).
> (MessageLoop::Controller was IncomingTaskQueue::MessageLoopController
> there but after grokking the resulting CL it's simpler under MessageLoop
> as done in this CL)
>
> This CL splits the logic in IncomingTaskQueue which took care of
> scheduling the MessageLoop into a dedicated class. In that follow-up CL:
> MessageLoopTaskRunner will interact directly with the task Observer and
> take IncomingTaskQueue completely out of the picture (merely a data
> structure holding various task queues at that point).
>
> IncomingTaskQueue also took care of detaching on MessageLoop shutdown
> which was moved to the new Controller class as well.
>
> message_loop.cc is the best place for this extracted logic as it all
> pertains precisely to MessageLoop's implementation detail (how
> ScheduleWork should be invoked).
>
> This CL simplifies locking as well by having a clear separation between
> the two locks instead of two locks in the same class used
> interchangibly. |incoming_queue_lock_| is now strictly for incoming
> tasks. |message_loop_lock_| is now strictly for
> ScheduleWork()/DisconnectFromParent().
>
> Note: |message_loop_scheduled_| was dropped as it was redundant (always
> equal to |!was_empty|).

This last statement was incorrect. The equivalent of
|message_loop_scheduled_| was incorporated into |was_empty| in PS2 of this
reland.

>
> Performance wise, the perf tests show that this change is a noop :
>  * While BasicPostTaskPerfTest became simpler (executed less code) with
>    this CL :
>      The new BasicPostTaskPerfTest w/ MockObserverSimulatingOverhead
>      reintroduces that overhead to show that it's still the same (or
>      slightly in favor of this CL).
>  * And the IntegratedPostTaskPerfTest are the same.
>  * Augmented perf tests to 30 seconds which yields more reliable results.
>    (and ran old ones under 30s mode too when comparing)
>  * Results :
>      https://docs.google.com/spreadsheets/d/100wYvbCI_dJ7gRnQiSsYaTb5OJnbF_muL6LyQWJLXSU/edit
>
> Bug: 860252
> Change-Id: I22de2409d52414524cc125b0e2fe08e2c516fcbe
> Reviewed-on: https://chromium-review.googlesource.com/1127262
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574048}

Bug: 860252
Change-Id: Ibe52413366e9b3ff38c9cb51616f9b8938ca68ad
Reviewed-on: https://chromium-review.googlesource.com/1137894Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575678}

Creates the provider that will contain the buttons to bring up manual
fallbacks for autofill. Gated behind the manual fill flag.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia36af25fc1e45f92e892b72a058b92d00c135b9c
Bug: 845472
Reviewed-on: https://chromium-review.googlesource.com/1135323
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575677}

They are replaced by
- Memory.Experimental.Renderer2.V8
- Memory.Experimental.Renderer2.V8.AllocatedObjects

The corresponding CL in V8 that removes recording:
https://chromium-review.googlesource.com/c/v8/v8/+/1101197

Bug: 852415
Change-Id: I1357ced8536386d7083666edc66862661e073e84
Reviewed-on: https://chromium-review.googlesource.com/1101033
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575676}

In the touch layouts, LOCATION_BAR_ICON_SIZE is 20, but kFaviconSize is 16, leading to different location bar icon image sizes depending on what icon is displayed and causing the omnibox text to jump when the icon size changes. For example, when typing a url, the 20px globe icon is displayed; wheras when typing a search url, the default search provider's favicon is displayed if available, which for Google is the 16px G icon. To avoid this, we set the location bar icon's size as LOCATION_BAR_ICON_SIZE, which is large enough to contain all icons. This is not an issue in other layouts, where both constants are 16.

Bug: 860295
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie9bc7a1b0b6b5a1f3dc6f4d2239d8fc2305c5063
Reviewed-on: https://chromium-review.googlesource.com/1135700
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575675}

Null ptr checks were missing on context_provider_wrapper, resulting
in crashes after a GPU context loss.

BUG=863752

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4b6f1fc394deb3f5567fee1da6f74b66aa7db79d
Reviewed-on: https://chromium-review.googlesource.com/1140282Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575674}

Bug: 864585
Change-Id: Id88cbb9f2d0cb487bf1285988d015b356633916c
NoTry: True
Tbr: robliao@chromium.org, ellyjones@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1140533Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575673}

Vertically center custom background images. kCSSBackgroundPositionTopCover
was previously added to align custom backgrounds, change this to
kCSSBackgroundPositionCenterCover.

Bug: 862789
Change-Id: I7905f21bcb8f54fd2710784b4dc16da8820ec1dd
Reviewed-on: https://chromium-review.googlesource.com/1140364Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575672}

Rather than VRDisplayHost calling into a specific device to request
a session, this change allows VRDisplayHost to choose the correct
device to match the options.

VRDisplayHost is no-longer tied to a single device, and there is now
only one VRDisplayHost per VRServiceImpl.

VRDisplayInfo and VRMagicWindowProvider should be returned as part of
session creation, which will be addressed in followups.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic305b3f1243f91b512da34ac936fe14bfb4a8d76
Reviewed-on: https://chromium-review.googlesource.com/1107484
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575671}

Creating SigninEarlGreyUI class to contain all the EarlGrey helpers
for sign-in.

-[SigninEarlGreyUI signinWithIdentity:] is created to be used everywhere
sign-in is needed in EarlGrey tests.

The following methods are being moved into SigninEarlGreyUI class
-[SigninEarlGreyUtils checkSigninPromoVisibleWithMode:]
-[SigninEarlGreyUtils checkSigninPromoVisibleWithMode:closeButton:]
-[SigninEarlGreyUtils checkSigninPromoNotVisible]
-[ChromeEarlGreyUI signInToIdentityByEmail:]
-[ChromeEarlGreyUI confirmSigninConfirmationDialog]

|signInToIdentityByEmail:| is renamed by |selectIdentityWithEmail:|, to
match its behaviour.

This patch will help future work to migrate to the unified user consent
UI.

-[SigninEarlGreyUI confirmSigninConfirmationDialog] cannot be removed
until crrev.com/i/652748 is landed.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I537679ec7673ec75100e122d5903d9454bd5a21a
Reviewed-on: https://chromium-review.googlesource.com/1138621
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575670}

Bug: 833878
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If087700c9d318711c81bd5a0e50d929e960bd61d
Reviewed-on: https://chromium-review.googlesource.com/1138399Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575669}

In the previous implementation, there was a bug where the ARC remote user
command wasn't being run if it was issued while the user wasn't logged in.
The command would be received upon log-in and immediately executed, while the
ARC instance wasn't ready yet.  Fixed this by waiting for ARC to be ready in
case it wasn't already.

Bug: chromium:860587
Change-Id: Ie14c5e9ac8c7437e149c84f56cc70ad63cb0b1e8
Reviewed-on: https://chromium-review.googlesource.com/1138249Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575668}

no video format

Devices like Pinnacle Dazzle are listed in DirectShow with their video
formats while listed in MediaFoundation with no available video format
at all.

This makes the capture factory fallback to DirectShow implementation
when it contains at least one video format and its MediaFoundation
counterpart has none.

Bug: 862395
Change-Id: I5d02f97971d4cf98372e12bb96c0b7ad9cc6d9c3
Reviewed-on: https://chromium-review.googlesource.com/1137817
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575667}

This makes some test output more readable. I've added the implementations
to the test_support library so we don't accidentally link these
functions into Chrome. The definitions are included alongside the types
being printed, opposed to a test support header file, to avoid ODR violations

Change-Id: Ica0aa9629f9cf745b0a4e42b3536d9537b34bfc7
Reviewed-on: https://chromium-review.googlesource.com/1101472
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575666}

Bug: 853728
Change-Id: I0d46d3004852fbbd0cb4a0793bbb899e43f38b2c
Reviewed-on: https://chromium-review.googlesource.com/1130526
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575665}

During a side swipe to change tabs, we remove the content area from the
view hierarchy.  This was causing issues with the downloads UI, as we
were attempting to set up constraints before the view hierarchy was
reassembled.  This CL swaps the order of calls to
sideSwipeViewDismissAnimationDidEnd and setCurrentTab, to ensure that
the view hierarchy is fully reassembled before any of the tab change
machinery is invoked.

BUG=849827

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iba2642f949a10d1a31ed32ae3763fed244022fdf
Reviewed-on: https://chromium-review.googlesource.com/1138351Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575664}

Prior to this CL, there was a separate observer class for
SetLocalDescription() and SetRemoteDescription().

In this CL, the WebRtcSetRemoteDescriptionObserver is renamed to
WebRtcSetDescriptionObserver (to reflect it is used both for local and
remote descriptions) and the WebRtcSetDescriptionObserverHandler is
split up in a "Local" and "Remote" handler version.

WebRtcSetDescriptionObserverHandler is updated to use the
TransceiverStateSurfacer. In Plan B this is a refactoring that
shouldn't make any functional changes, but in Unified Plan this setup
will allow the creation of transceivers as well.

The RTCPeerConnectionHandler is updated to wire both local and remote
descriptions to use the same observer.
The WebRtcSetDescriptionObserverImpl takes care of adding and removing
receivers. Prior to this CL this is something we did for remote
descriptions but not local ones. Because SetLocalDescription() does not
change the set of receivers in Plan B, this should not make a
difference. But in Unified Plan, the same codepath needs to run in both
local and remote cases because in Unified Plan both
SetLocalDescription() and SetRemoteDescription() modifies the state of
transcievers. In an upcoming CL the "...ObserverImpl" will not just add
and remove receivers but also take care of updating transceivers if
Unified Plan is used.

This CL also:
- Removes RTCPeerConnectionHandler::SetLocalDescriptionRequest because
  it is not used anymore.
- Removes SessionDescriptionRequestTracker, because it doesn't do much
  and the only remaining use was in CreateSessionDescriptionRequest
  which is updated to do the equivalent of its use of the tracker.

Bug: 777617
Change-Id: I8a5726f25764c1e57ec18e7eb96decf083fc8333
Reviewed-on: https://chromium-review.googlesource.com/1136441Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575663}

Remove incognito member variable from CustomFrameHeader and make the
text color part of the AppearanceProvider (in Mash, this relies on
window properties).

Also move some functionality from CustomFrameViewAsh to HeaderView so
that when BrowserNonClientFrameViewAsh uses HeaderView, it will benefit
from it as well.

Bug: 837705
Change-Id: I7cb4aa654b37a6a9f8f73864c745f15245a15fc3
Reviewed-on: https://chromium-review.googlesource.com/1117883
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575662}

Bug: 857431
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1c8ae739deab88470f40e5b3c2e241406ecb233e
Reviewed-on: https://chromium-review.googlesource.com/1138797
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575661}

Bug: 860129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6dec83e03cc51b5ce8239aebd8a5e22639a1996d
Reviewed-on: https://chromium-review.googlesource.com/1139633Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575660}

Manual revert of
  47b8c934

Change-Id: I1ae7917e2e458c36f8e6f7dce19cbef34437d411
Reviewed-on: https://chromium-review.googlesource.com/1140297Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575659}

This patch adds the data saver promo to the top of the overflow menu
when Chrome Duet is enabled. The top divider for the promo has been
removed and promo now scrolls off when the menu is scrolled (only in
Duet).

Supporting this patch is a change in how the header view is provided
to the menu. Instead of passing the view directly, its layout ID is
passed instead, bringing it more in line with the footer version.
To get access to the inflated view, this patch also added
AppMenuPropertiesDelegate#onHeaderViewInflated.

Bug: 847632
Change-Id: I1c332199f6760d1ba1f30262e122bf30ab4c835e
Reviewed-on: https://chromium-review.googlesource.com/1136714Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575658}

https://chromium.googlesource.com/angle/angle.git/+log/6fb8ba4e8660..d691aeeb956f


git log 6fb8ba4e8660..d691aeeb956f --date=short --no-merges --format='%ad %ae %s'
2018-07-17 geofflang@chromium.org Vulkan: Implement GL_CHROMIUM_copy_texture with CPU copies.


Created with:
  gclient setdep -r src/third_party/angle@d691aeeb956f

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I6652dc3c69e45f5eb685a4c38d827f9d98610c4a
Reviewed-on: https://chromium-review.googlesource.com/1140255Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575657}

BUG=862255
TEST=On iPhoneX, rotate into landscape and open the Bookmarks.  The bubble should not overlap with the notch, in both LTR and RTL languages.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I07c2215e7b3b6e01ee8e39cae6d03054199cb205
Reviewed-on: https://chromium-review.googlesource.com/1140195Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575656}