- 21 Aug, 2014 40 commits
-
-
mmenke@chromium.org authored
This allows embedders to send a chunk when they do not yet know if it is the final chunk or not. BUG=405678 Review URL: https://codereview.chromium.org/492063002 Cr-Commit-Position: refs/heads/master@{#291222} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291222 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
Functionality: The |AppRegistry| has for each running application an |AppActivityRegistry|. The |AppActivityRegistry| knows all activities associated with the application it represents. It can furthermore shut the app entirely down upon resource manager request. It will then create an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This placeholder can then ask the |AppActivityRegistry| to restart the application again. A shutdown request for the application is only performed when all activities were marked for UNLOAD. If there were multiple activities upon shutdown for one app, the app has to take care of re-creating all windows and thus re-creating all activities. Since an activity match cannot be performed, the |AppActivityProxy| will only be shown once and it will show in the location of the most recently used activity of that app. If we later on find an app which really uses multiple windows and it is imperative to keep the history for all of them tact & the app is recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and try to address it in a cleaner way, but at this time that seems rather un-useful since it is not known if required. BUG=388085 TEST=AppActivityTest.* Review URL: https://codereview.chromium.org/477523002 Cr-Commit-Position: refs/heads/master@{#291221} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291221 0039d316-1c4b-4281-b951-d872f2087c98
-
dyen@chromium.org authored
Some extension files are compiled on android when enable_plugins is set to 1. These files need to have the parts that references extension files compiled out of the code. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032 TEST= trybots Review URL: https://codereview.chromium.org/468913006 Cr-Commit-Position: refs/heads/master@{#291219} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291219 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
* AppListViewDelegate was accessing deleted search_provider. * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted * Explicitly delete FilePathWatcher. This was causing recursive callback to FilePathWatcherImpl::Cancel from FilePathWatcherImpl::CancelOnMessageLoopThread, which caused crash. Clean ups * change OnIO to OnFILE as they run on FILE thread. * removed unused singleton related code. BUG=None TEST=Run athena_main on desktop and close window. Review URL: https://codereview.chromium.org/490033003 Cr-Commit-Position: refs/heads/master@{#291214} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291214 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@chromium.org authored
BUG=403618 Review URL: https://codereview.chromium.org/475263002 Cr-Commit-Position: refs/heads/master@{#291213} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291213 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
Original: https://codereview.chromium.org/487913004/ Reverted because of a conflict with a patch that landed after it. Only change is to use the new location for id_util (crx_file). Original Description: Only show the checkbox for all urls when the switch is on BUG=402958 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/490793003 Cr-Commit-Position: refs/heads/master@{#291212} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291212 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
Update existing configs and add a bunch more. BUG=396139,357253,361300 Review URL: https://codereview.chromium.org/491113002 Cr-Commit-Position: refs/heads/master@{#291211} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291211 0039d316-1c4b-4281-b951-d872f2087c98
-
mvanouwerkerk@chromium.org authored
* No need to pass manager in callback * No need to keep pointer to manager in provider * Rename test methods Foo to FooForTesting Review URL: https://codereview.chromium.org/486203004 Cr-Commit-Position: refs/heads/master@{#291209} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291209 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
Design Doc (Googlers Only): https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit BUG=384011 TBR=timsteele@chromium.org Review URL: https://codereview.chromium.org/379283002 Cr-Commit-Position: refs/heads/master@{#291207} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291206} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291206 0039d316-1c4b-4281-b951-d872f2087c98
-
johannkoenig@chromium.org authored
See https://codereview.chromium.org/484923003 R=tomfinegan@chromium.org Review URL: https://codereview.chromium.org/497513002 Cr-Commit-Position: refs/heads/master@{#291204} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291204 0039d316-1c4b-4281-b951-d872f2087c98
-
timvolodine@chromium.org authored
This patch contains a test page used for manually checking the functionality of the Battery Status API. It is currently also available at http://jsbin.com/battery-status-test. BUG= Review URL: https://codereview.chromium.org/464073003 Cr-Commit-Position: refs/heads/master@{#291203} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291203 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=403007 TBR=yurys@chromium.org Review URL: https://codereview.chromium.org/493203003 Cr-Commit-Position: refs/heads/master@{#291202} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291202 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
(vs always opening on the first screen like it's happening now) BUG=405602 TEST=Start Chrome with --enable-new-avatar-menu (if it's not own by default). If you've got to screens, when you press "Switch users" the User Manager should show up on whatever screen you triggered it from. Review URL: https://codereview.chromium.org/489953002 Cr-Commit-Position: refs/heads/master@{#291201} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291201 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
BUG=405747 Review URL: https://codereview.chromium.org/493973002 Cr-Commit-Position: refs/heads/master@{#291200} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291200 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
This adds the ui/keyboard:keyboard_unittests target to the GN build and adds the rest of ui/keyboard/webui/ to the build. Since the webui bits are the only parts that need mojo the mojo deps are restricted to that source set. R=sky@chromium.org Review URL: https://codereview.chromium.org/493833002 Cr-Commit-Position: refs/heads/master@{#291199} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291199 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
The DataTypeManager is now in charge of reenabling previously failed types. BUG=368834 R=maniscalco@chromium.org Review URL: https://codereview.chromium.org/439903002 Cr-Commit-Position: refs/heads/master@{#291198} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291198 0039d316-1c4b-4281-b951-d872f2087c98
-
primiano@chromium.org authored
heap_profiler_unittests was previously a native executable target. It turns out that we don't have the harness in place to run native executable tests reliably on all Android versions due to the PIE vs non-PIE issue (L vs ICS, see crbug.com/373219). This caused a revert in crrev.com/416003005. This change is making heap_profiler_unittests an apk target, following the same pattern of the other tests we have in the codebase. This change is also re-adding the tests to the the bot list. BUG=393964 Review URL: https://codereview.chromium.org/465223005 Cr-Commit-Position: refs/heads/master@{#291197} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291197 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
A context factory is specific to a particular native viewport so we shouldn't leak it between different WindowTreeHostImpl instances. This fixes some crashes in mojo_view_manager_unittests. R=sky@chromium.org Review URL: https://codereview.chromium.org/494883002 Cr-Commit-Position: refs/heads/master@{#291196} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291196 0039d316-1c4b-4281-b951-d872f2087c98
-
dtrainor@chromium.org authored
- Some OEMs don't let us change the background, so the padding is incorrect. - Also including sizing the menu too large causes clipping. BUG=398837 Review URL: https://codereview.chromium.org/469673006 Cr-Commit-Position: refs/heads/master@{#291193} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291193 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
only when needed, and deleted as soon as they are no longer necessary. Add methods to SSLClientSocketPool that are passed to the SSLConnectJob and SSLConnectJobMessenger as callbacks. These allow the SSLConnectJob to tell the SSLClientSocketPool to create a messenger for the job when appropriate, and the SSLConnectJobMessenger to tell the SSLCLientSocketPool to remove a messenger when appropriate. An SSLConnectJob will now only create an SSLConnectJobMessenger if its socket's session is not already in the session cache. The messenger will then ask to be removed when there are no remaining pending or connecting sockets in the messenger. Written by Mackenzie Shelley <mshelley@chromium.org> Original review URL: https://codereview.chromium.org/384873002/ R=rsleevi@chromium.org TBR=mek@chromium.org BUG=398967 Review URL: https://codereview.chromium.org/476313004 Cr-Commit-Position: refs/heads/master@{#291192} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291192 0039d316-1c4b-4281-b951-d872f2087c98
-
pvalenzuela@chromium.org authored
This CL enables usage of the Sync FakeServer in Android tests. This is done by creating a new ChromeShell-based APK, ChromeSyncShell, and a test APK that instruments it (ChromeSyncShellTest). As part of this CL, previously-disabled tests (SyncTest.java) are re-enabled. However, these tests will not run as part of the Chromium waterfall/trybots as they are not configured to run ChromeSyncShellTest. How to run the tests: 1) Build these targets: chrome_sync_shell_apk chrome_sync_shell_test_apk 2) Run test script build/android/adb_install_apk.py \ --apk=ChromeSyncShell.apk && \ build/android/test_runner.py instrumentation \ --test-apk ChromeSyncShellTest BUG=323265,348951,348117 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/457883002 Cr-Commit-Position: refs/heads/master@{#291190} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291190 0039d316-1c4b-4281-b951-d872f2087c98
-
msarda@chromium.org authored
Shared Authentication is the only supported scheme starting with M39. This CL removes the dependency on MutableProfileOAuth2TokenService on iOS. BUG=233117 Review URL: https://codereview.chromium.org/489113003 Cr-Commit-Position: refs/heads/master@{#291189} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291189 0039d316-1c4b-4281-b951-d872f2087c98
-
erikchen@chromium.org authored
The code made assumptions about whether the window's root view was layer backed. The CL that introduced the bug: https://codereview.chromium.org/390503003/ BUG=NONE Review URL: https://codereview.chromium.org/481273002 Cr-Commit-Position: refs/heads/master@{#291188} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291188 0039d316-1c4b-4281-b951-d872f2087c98
-
kcwu@chromium.org authored
Some of the VDAs, like DXVA and AVDA, don't distinguish between visible size and coded size. And given GVD is always been used with container, we should keep using size from config in GVD. BUG=390048 TEST=Manually tested: flash player using youtube. html5 player with resolution 1280x720 and 1216x684, h264 and vp8. apprtc with resolution 640x480 and 636x476. All tests are performed on both daisy and link. R=hshi@chromium.org, posciak@chromium.org Review URL: https://codereview.chromium.org/426873004 Cr-Commit-Position: refs/heads/master@{#291187} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291187 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
Trackers for empty-title files were not handled in AddToPathIndexes() and UpdateInPathIndexes(), while they are handled in RemoveFromPathIndexes(). So an entry in multi-backing lists could be inconsistent. This CL fixes those two methods' behavior. BUG=405448 TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDisk*" Review URL: https://codereview.chromium.org/493643002 Cr-Commit-Position: refs/heads/master@{#291186} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291186 0039d316-1c4b-4281-b951-d872f2087c98
-
eakuefner@chromium.org authored
This patch implements Chart JSON for Telemetry, which represents a JSON format specifically for conveying data to Buildbot to be sent to the perf dashboard in charted/summarized form. Consult go/telemetry-json for further specs on this format. This is an 0.1 since the overall metadata and description portions of the format are still in flux. BUG=399970 Review URL: https://codereview.chromium.org/439613003 Cr-Commit-Position: refs/heads/master@{#291185} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291185 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
Galaxy S4 requires a surface texture in order for the media player to report correct video size. So bind a texture to MediaPlayer whenever the video is HLS BUG=400145 Review URL: https://codereview.chromium.org/478403002 Cr-Commit-Position: refs/heads/master@{#291184} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291184 0039d316-1c4b-4281-b951-d872f2087c98
-
dhnishi@chromium.org authored
permission and resource manager. BUG=372607 Review URL: https://codereview.chromium.org/475193002 Cr-Commit-Position: refs/heads/master@{#291183} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291183 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
This test was flaking on ChromeOS ASAN bots. See bug for details. TBR=miu@chromium.org NOTRY=true BUG=406051 Review URL: https://codereview.chromium.org/496093002 Cr-Commit-Position: refs/heads/master@{#291182} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291182 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/496473003/rlarocque@chromium.org authored
Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/2322 Original issue's description: > Add ui_unittests to GN build. > > Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file. > > Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these. > > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291154 TBR=sky@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/496843002 Cr-Commit-Position: refs/heads/master@{#291181} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291181 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
Revert of Multiprofile security: Show a warning messagebox when desktop casting/sharing is turned on upon user (patchset #3 of https://codereview.chromium.org/496563002/) Reason for revert: Broke Linux ChromiumOS Tests on waterfall: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/47585 Original issue's description: > Multiprofile security: Show a warning messagebox when desktop > casting/sharing is turned on upon user switch > > Purpose of this change: > > Asks the user with a system modal dialog box if he wants to > turn off screen sharing/screen casting and then switch users > or abort switching users. > > BUG=353170 > TEST=TrySwitchingUserTest.* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291152 TBR=jennyz@chromium.org,jamescook@chromium.org,skuhne@chromium.org NOTREECHECKS=true NOTRY=true BUG=353170 Review URL: https://codereview.chromium.org/473953004 Cr-Commit-Position: refs/heads/master@{#291180} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291180 0039d316-1c4b-4281-b951-d872f2087c98
-
yfriedman@chromium.org authored
It's bouncing emails if you send mail directly (instead of from reitveld) NOTRY=true Review URL: https://codereview.chromium.org/492913003 Cr-Commit-Position: refs/heads/master@{#291178} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291178 0039d316-1c4b-4281-b951-d872f2087c98
-
wiltzius@chromium.org authored
BUG=402882 Review URL: https://codereview.chromium.org/467043003 Cr-Commit-Position: refs/heads/master@{#291177} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291177 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
When converting those bots to recipes in r287833, "unit" was replaced with "unit_tests". In fact, "unit" is a composite step that includes 5 other targets besides "unit_tests". This CL adds those targets back. This CL also adds accessibility_unittests and gfx_unittests, which presently run on the linux_asan trybot and on other waterfalls, but not on chromium.memory. The same should be done to cast_unittests and google_apis_unittests, once they are green under ASan. BUG=none R=glider@chromium.org TBR=phajdan.jr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/498443002 Cr-Commit-Position: refs/heads/master@{#291176} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291176 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
With the --extension-action-redesign switch, hiding an extension action should cause it to go to the overflow menu (rather than disappearing completely). Enable this functionality. BUG=403824 Review URL: https://codereview.chromium.org/476873002 Cr-Commit-Position: refs/heads/master@{#291174} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291174 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Previously, if you specified an empty resource ID file in the grit template in the GN build, it would send "-f" with no argument to grit, and this would cause the command line parsing to get messed up and it wouldn't generate any files. This patch just omits the "-f" argument in this case. R=jam@chromium.org Review URL: https://codereview.chromium.org/495183002 Cr-Commit-Position: refs/heads/master@{#291173} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291173 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291172} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291172 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/470403005 Cr-Commit-Position: refs/heads/master@{#291171} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291171 0039d316-1c4b-4281-b951-d872f2087c98
-
dtseng@chromium.org authored
BUG=404766 TEST=Using a sample extension, "commands": { "foo": { "suggested_key": { "chromeos": "Search+Shift+L" ... and adding a listener to onCommand, pressing Search+Shift+L results in triggering of the callback. (on linux, this is lwindows+shift+l). Review URL: https://codereview.chromium.org/392313003 Cr-Commit-Position: refs/heads/master@{#291170} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291170 0039d316-1c4b-4281-b951-d872f2087c98
-