- 19 Apr, 2020 13 commits
-
-
Julie Jeongeun Kim authored
This CL migrates grid-dynamic-updates-relayout.html to external/wpt/css/css-grid/grid-definition, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-template-columns-rows-changes-001.html. Bug: 1063749 Change-Id: I077502f4b40d0c0744d775c9a0382097b8a31672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154360Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#760349}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1070293 Change-Id: Ib70026f3e74e50b81642866f098c1834eab1588b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146226 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#760348}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 84-4099.3-1586167754-benchmark-84.0.4111.0-r1 to 84-4103.6-1586771664-benchmark-84.0.4114.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3f565f3d4a2754d051b91c9cf4ad1277ae0834bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760347}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae28b321d07d..62687b1ec3c8 git log ae28b321d07d..62687b1ec3c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@62687b1ec3c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: I562cc6167c5e3c95ed227a6bee9eead15eeecbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154930Reviewed-by:
-
Haiyang Pan authored
This reverts commit f16f501c. Reason for revert: The test keeps failing. See https://ci.chromium.org/p/chromium/builders/ci/android-10-arm64-rel/4353 and https://ci.chromium.org/p/chromium/builders/ci/android-10-arm64-rel/4344 Original change's description: > android: Add AR test to android-10-arm64-rel builder > > Bug: 1070264 > Change-Id: Ib741b6123633cf58a6b45f44a8154b8dae97f2f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155410 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#760306} TBR=martiniss@chromium.org,hypan@google.com Bug: 1070264 Change-Id: I10410791d0ed8d490eee57198d27befcdf7bd297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155887Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#760345}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Icd38648625bf6c083af598623ed14ccbd661fe67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155221Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760344}
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: Ifee67f9d96e320f6c4d0c09c1ec5a0cb2c8d0871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146058 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#760343}
-
Eric Willigers authored
The header with default web app ids was previously in chrome/browser/chromeos/extensions/ With BMO, web applications no longer rely on Extensions: TBR=alemate@chromium.org TBR=pastarmovj@chromium.org Bug: 877898 Change-Id: I9c7e5e003bc97b47ec473fda7c2f7880a43bb7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149740Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#760342}
-
Fergus Dall authored
Bug: None Change-Id: Id65a21f3e6f3bfe585eabc4e87e3bf92b0761ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147974Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#760341}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e838d8d0fbc..3ce055109dd8 Created with: gclient setdep -r src-internal@3ce055109dd8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071247 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: I7af5a392ef986f47b3ebbdccb97f07025d83cc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154927Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760340}
-
Wei-Yin Chen (陳威尹) authored
Bug: 982018 Change-Id: Ied383279878bcf66eb80343eae34942c06d875b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155805Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#760339}
-
Anton Bikineev authored
This also adjusts the tests. Original change's description: > clang plugins: default no-members-in-stack-allocated to on > > Artifacts can be removed after the clang prebuilt is updated. > > Change-Id: I473c22843445745a39d1fc648a7bbcc336631b8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152329 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Cr-Commit-Position: refs/heads/master@{#759880} Change-Id: I16e07fe68e308005350c37cf50d0fe5c1e2611e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154788 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760338}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ic1e9a56fb5806a89ac56f0facf37b88c4cd7c361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155809Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760337}
-
- 18 Apr, 2020 27 commits
-
-
Anders Hartvoll Ruud authored
This enables support for the 'revert' keyword once again, now that issue 1071454 is fixed. This reverts commit e5912ac3. Bug: 579788, 1071454 Change-Id: I5ca25177567e80f85e05584dcfee12c5398e1084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153121Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760336}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a59affb2a75..ae28b321d07d git log 6a59affb2a75..ae28b321d07d --date=short --first-parent --format='%ad %ae %s' 2020-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 49ad8eaae192..33b58ebb7ea8 (24 commits) Created with: gclient setdep -r src/third_party/skia@ae28b321d07d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I42f6a77cb9a0d2886cb758c9e253898b0c28538b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155674Reviewed-by:
-
Kramer Ge authored
OzoneDrmMojo is at 100% in M81 and M83 branch cut has passed, feature is by default on in M83. Legacy IPC code should be removed. Bug: 620927,806092 Change-Id: I40346e50df69515163a7b6e1df92b3a50a101bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142332Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#760334}
-
Nico Weber authored
This reverts commit 2883cd18. Reason for revert: broke tests; we also need to update 2 baselines: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8882703558916297872/+/steps/package_clang/0/stdout Original change's description: > clang plugins: default no-members-in-stack-allocated to on > > Artifacts can be removed after the clang prebuilt is updated. > > Change-Id: I473c22843445745a39d1fc648a7bbcc336631b8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152329 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Cr-Commit-Position: refs/heads/master@{#759880} TBR=thakis@chromium.org,kouhei@chromium.org,johannkoenig@google.com,bikineev@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idd66b71f7b71f7ae64ffc8cb4d24160a86cc80f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155363Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ebc69c9ef34..6a59affb2a75 git log 0ebc69c9ef34..6a59affb2a75 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 reed@google.com flutter is ready for m44 Created with: gclient setdep -r src/third_party/skia@6a59affb2a75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Iab553aef43bb5f8cb3a87620d6f36c1824e219ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155672Reviewed-by:
-
Jacobo Aragunde Pérez authored
According to the standard, the figcaption that corresponds to a certain figure element can only be its first or last child. Existing code was searching among all of its descendants, which might include captions belonging to a different figure and caused the reported bug. Bug: 1060810 Change-Id: I0fc7f2dc52fb211f640913b64e449259ae55d146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144273Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#760331}
-
Gavin Williams authored
- Accepts a printer id, kicks off a printer status request, then once complete broadcasts the status to "printer-status-update". Bug: 1059607 Change-Id: I91b30632a6682a4705616d714038a7826483753c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128236 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#760330}
-
Yuki Shiino authored
This fix is not perfect, but solves partial build breakage with dllimport/dllexport specifiers. Bug: 839389 Change-Id: I1d31d341ff1ab0f29797d48b97df45e2815e866a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154430Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#760329}
-
Nnamdi Theodore Johnson-Kanu authored
This CL is in preparation for enabling Polymer3 in ChromeOS settings pages. It uncomments polymer_modulizer build target and makes sure Polymer3 modules can be generated from js files. Bug: 1045266 Change-Id: I8570053b3aa043b180078dd69286f4db51acd898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153305 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#760328}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9283cf0354c5..3e838d8d0fbc Created with: gclient setdep -r src-internal@3e838d8d0fbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Ibc9d7604f0e8f1f3a3f91f3fd269ef04e584efbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155669Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb490911a952..0ebc69c9ef34 git log fb490911a952..0ebc69c9ef34 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 johnstiles@google.com Fix modulo-by-zero crash during SPIR-V conversion. Created with: gclient setdep -r src/third_party/skia@0ebc69c9ef34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ie3515c173a1fd8eaa10585b9377f4a99f07f814c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155668Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I53ad6739e0ee384aa3bd13aaaf700dc11a4609a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155617Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I587b28b49d6fe4da269a8eb160586048081a8fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155360Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760324}
-
Philip Rogers authored
This reverts commit 0410b740. Reason for revert: Causing MediaFeedsWebUIBrowserTest.All failures, see https://crbug.com/1072145. Original change's description: > Add live details, images, duration fields for episodes. > > Bug: 1065986 > Change-Id: I4d3339006bbea2aaf1a6c9566e34a6faa506b04c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148247 > Commit-Queue: Sam Bowen <sgbowen@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760284} TBR=dcheng@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I77600047ed412095a253d955770a74e613b4dbb4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065986, 1072145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155621Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760323}
-
Philip Rogers authored
This reverts commit 1f585617. Reason for revert: This is causing flakes, see: https://crbug.com/1072143. Original change's description: > [Extensions Metrics] Add metrics for action invocation source > > Add a new histogram to track the invocation source for extension > toolbar actions. This can include: > - The main toolbar > - The new extensions menu > - The old overflow menu (in the 3-dot menu) > - A programmatic API call (currently limited to allowlisted > extensions). > > Bug: 1064111 > Change-Id: I373768ba97c67d4b80bdc56585fd5a8e6c5163cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147685 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Caroline Rising <corising@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760154} TBR=rdevlin.cronin@chromium.org,bcwhite@chromium.org,corising@chromium.org Change-Id: I191039916b5f3626bf06196a41eb896c7ed02bc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064111, 1072143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1943cb1302d..30b6825fa7b1 git log b1943cb1302d..30b6825fa7b1 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@30b6825fa7b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7fb2bbc51e22600fb322a40d05eeb9809ebbaa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155615Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f09ddec3..171cc405 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2691dd630e5d27e2722a67dadfcebecd92e7baa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155236Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760320}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 92a97b99. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 4de68d38 "fixup! [css-grid] Migrate flex-sizing-columns-min-max-width.html to WPT" f511fde8 "[css-grid] Migrate grid-gutters-and-flex-content.html to WPT" a236d77b "[css-grid] Migrate grid-gutters-and-tracks.html to WPT" d51ce450 "Add a WPT for image being lazy loaded multiple times" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia10512f1942f27b732a085c5b24a73efc343225c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155234Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760319}
-
Istiaque Ahmed authored
ScriptFinishedCallback can/should be a OnceCallback as it would only run (at most) once. This makes internal class Handler take OnceCallbacks too, simplifying the code a bit. Bug: None Change-Id: Id74e83ba255c9507ea778a7ad9fef08f8d7b9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133659 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760318}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c8fb8b1..f09ddec3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia5ffe3aeb886e21d1ab41afc1e4f6408d9c6b34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155228Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ifd2156c012a7203e4bdb8c9d7bd1fe3c994d142d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155052 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#760316}
-
Mugdha Lakhani authored
Remove CookieControlsBridge dependency from PageInfoController. CookieControlsBridge enables improved Cookie Controls UI. (Context: https://bugs.chromium.org/p/chromium/issues/detail?id=1040091) WebLayer will likely support it in the future and TODOs have been added to componentize it. Bug: 1052375 Change-Id: I3d92e1af94a41cd0e4407cc9d0771a23542f743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151455 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760315}
-
Anders Hartvoll Ruud authored
CSSBitset is the same as a std::bitset, except it uses CSSPropertyID in its API, and has substantially (~10x) better performance when traversing the set bits for cases where few bits are set. Previous experiments has shown that the typical number of applied declarations per element is in the 10-20 range (out of a 500+ bitset), which makes this optimization relevant. There are two reasons for adding this. First, there is a need (in the near future) to interact with a CSSPropertyID-based bitset outside of the StyleCascade. Therefore it's nice to have an API which actually accepts/yields CSSPropertyIDs, to avoid noisy casting at every call- site. Second, there will be a need to traverse the bits efficiently in a situation where the common case has very few bits set. This CL replaces std::bitset with CSSBitset in CascadeMap, without using any of the capabilities which make CSSBitset special, but those capabilities will be used in the near future. Change-Id: I7080c97f784f01c4f560e9fb570443dd927b7a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152370Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c632aa633792..fb490911a952 git log c632aa633792..fb490911a952 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@fb490911a952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ibee7a69ed991824c39cb8f3cf9da4f6cafef4349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155552Reviewed-by:
-
Lei Zhang authored
Change-Id: I2a594c53509a303a95aaf3268dfae914b2fff30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154734Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760312}
-
Greg Thompson authored
Include the contents of directories that unexpectedly exist. This may shed some light into failures on ToTWin64(dbg). BUG=1013720 R=zmin@chromium.org Change-Id: I466528a73e8aee93e70c7af11ccfa2c82b9e1198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152832 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760311}
-
Anders Hartvoll Ruud authored
The 'initial', 'inherit' and 'unset' keywords were handled, but 'revert' was not. This caused crashes when trying to represent certain declaration block serializations using shorthands. Change to use IsCSSWideKeyword instead, which includes 'revert'. (It should also avoid the same problem the next time a new CSS-wide keyword is added). Bug: 1071454 Change-Id: I968a32a5ad5b2a1a1958f60ec19679c6a642df14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152817Reviewed-by:
-
