- 22 Sep, 2017 26 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/33d54da00a77..703485470a88 $ git log 33d54da00..703485470 --date=short --no-merges --format='%ad %ae %s' 2017-09-21 jbudorick [devil] Explicitly start the adb server in recovery after killing it. Created with: roll-dep src/third_party/catapult BUG=753685 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia5697160374e954b19638c381c115c4ac2fc66e8 Reviewed-on: https://chromium-review.googlesource.com/677861 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503643}
-
dpapad authored
Left/right sliding of subpages needs to be reversed in RTL. Bug: 715509 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I58a79b4fc5fa2514b2ea030cff69eaf3256833e2 Reviewed-on: https://chromium-review.googlesource.com/677413 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#503642}
-
Ryan Landay authored
This CL introduces a builder pattern for constructor, to make it easier to read call sites where we construct or add SuggestionMarkers. TBR=skobes@chromium.org DocumentMarkerController: :AddSuggestionMarker() and SuggestionMarker's Change-Id: I46d4d891b9cb28e672562259a25e40731cd1febf Reviewed-on: https://chromium-review.googlesource.com/666327 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#503641}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/cfbbcbe52624..a83b903b601a $ git log cfbbcbe52..a83b903b6 --date=short --no-merges --format='%ad %ae %s' 2017-09-21 angle-deps-roller Roll skia/third_party/externals/angle2/ d48261595..f32cd0b78 (1 commit) 2017-09-21 mtklein ok, add via_skp 2017-09-21 angle-deps-roller Roll skia/third_party/externals/angle2/ 1f9d68437..d48261595 (1 commit) 2017-09-21 herb Remove unsafe align4 call Created with: roll-dep src/third_party/skia BUG=763972 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I68df7307985eac3dd532e134701f0ef14ab3b63f Reviewed-on: https://chromium-review.googlesource.com/677856Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503640}
-
Tetsui Ohkubo authored
When an image is downloaded, download notification should show minimized thumbnail on the right when collapsed, just like screenshot notification. For the explanation with a screenshot, see the bug. TEST=manual BUG=766900 Change-Id: Id9ab63cb5c77fede9a9fb9502232c300c22a94a9 Reviewed-on: https://chromium-review.googlesource.com/674464Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#503639}
-
lgcheng authored
arc optin: Change to oobe style. oobe arc optin: Fix agree button end margin to 18px. oobe button: Change the radius of light blue outside border to 4px according to UI feedback. Bug: 767664 Test: Manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I59c03f5c29bda7e6fa0f8d0366068d1c0ee277e3 Reviewed-on: https://chromium-review.googlesource.com/677637Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#503638}
-
Jennifer Apacible authored
Bug: 604586 Change-Id: I7bf1ea23b30552cd93b77ff80c5e34a36abfe097 Reviewed-on: https://chromium-review.googlesource.com/669309Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#503637}
-
Ryan Landay authored
There are several places in InputMethodController where we use an EphemeralRange to create a PlainTextRange relative to the root editable element. This CL adds a helper method that takes an EphemeralRange and returns an std::pair of the root editable element and the resulting PlainTextRange, to allow us to reduce code duplication. Change-Id: I67a6c6cdad71c66426b73d3b151ab15cc0eece3e Reviewed-on: https://chromium-review.googlesource.com/677496Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#503636}
-
Steven Bennetts authored
Bug: 619295 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I598f3f1fa39e93c5b252f831d7d59c189e91feee Reviewed-on: https://chromium-review.googlesource.com/677886Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#503635}
-
Tetsui Ohkubo authored
This CL removes ripple effect from notification header for the sake of consistency with Android notifications. Originally, this feature was added in * http://crrev.com/2959363002 * http://crrev.com/c/603033 TEST=manual BUG=767246 Change-Id: I80e7772fb535f3050263d57f4d11f8d6d81eec27 Reviewed-on: https://chromium-review.googlesource.com/676963Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#503634}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b6d73eb8. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2121 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I3e6f4c313810035dac9e45d15d5ee5b5160507f6 Reviewed-on: https://chromium-review.googlesource.com/677815 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503633}
-
Walter Korman authored
Use 'override' and nullptr. TBR=pdr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I74df17c8a055ea613f116e05f6dd0fa6bb7fa533 Reviewed-on: https://chromium-review.googlesource.com/675811 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#503632}
-
spqchan authored
When the active tab changes, the page might not be get reloaded. As such, we'll have to invalidate the touch bar when that happens. Bug: 766969 Change-Id: I6cd9288966d7cd618a38709eb5e2dadcebb1a3c2 Reviewed-on: https://chromium-review.googlesource.com/677481Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503631}
-
Philip Rogers authored
DragControllerTest is complex and duplicates logic in RenderingTest. This patch switches the test to use RenderingTest. This lets us remove redundant logic, remove unused variables such as performance_, and will make it possible to create iframe tests in the future (which require SingleChildLocalFrameClient). This is just a cleanup and should have no change in behavior. Bug: 766355 Change-Id: I313a9cc4a33aa1afdba5f89be52630762930b3ae Reviewed-on: https://chromium-review.googlesource.com/671164 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#503630}
-
Raymond Toy authored
When posting a task from the ScriptProcessorHandler::Process to fire a process event, we need to keep the handler alive in case the ScriptProcessorNode goes away (because it has no onaudioprocess handler) and removes the its handler. Bug: 765495 Test: Change-Id: Ib4fa39d7b112c7051897700a1eff9f59a4a7a054 Reviewed-on: https://chromium-review.googlesource.com/677137Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#503629}
-
Dan Beam authored
* Use align="$i18n{textdirection}" instead of JS. * Add directionality to extensions. * Delete a bunch of settings code. R=dpapad@chromium.org BUG=None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib85bfd34c5ea57ef6ee0b6fc5509a1bb0a38ac6b Reviewed-on: https://chromium-review.googlesource.com/676482 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#503628}
-
Vladislav Kaznacheev authored
This is a temporary fix for b/66168241. A cleaner fix requires multiple changes in ash/highlighter and ash/system/palette/tools which are planned in crbug/761120. Bug: b/66168241 Test: manual Change-Id: I4311d24bd4e1899088f3c2d857fdf84f2ad5af95 Reviewed-on: https://chromium-review.googlesource.com/676225Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#503627}
-
Kyle Horimoto authored
Now, when RegisterAdvertisement() or Unregister() fail, the operation is retried until it succeeds. This fixes several related issues which result from getting stuck thinking that an advertisement is registered or unregistered when it actually is not. Bug: 767500, 672263 Change-Id: I73886e104dc64fbc3f307e3c834de873ddf85914 Reviewed-on: https://chromium-review.googlesource.com/677715Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#503626}
-
Luke Halliwell authored
Bug: 767080 Bug: internal b/65844132 Change-Id: Id0d1280e7ff202b2541a54077ee4df459a5dc62a Reviewed-on: https://chromium-review.googlesource.com/676464Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#503625}
-
David Valleau authored
The actual error messages displayed to the user have not been finalized and are open for discussion. R=michaelpg@chromium.org, skau@chromium.org, xdai@chromium.org Bug: 670068 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I49ca57a14eef09b2eff5b8434c4242fec0b6db75 Reviewed-on: https://chromium-review.googlesource.com/667961Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#503624}
-
David Tseng authored
Bug: 618099 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I194d9e2ccea2641f7d4685db7d68273e850df53a Reviewed-on: https://chromium-review.googlesource.com/675587 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#503623}
-
Devlin Cronin authored
Add some basic documentation on extension API schemas. Bug: 734198 Change-Id: I4a29787ff489929d5051ca06fca27bbe6dc7111c Reviewed-on: https://chromium-review.googlesource.com/677130 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#503622}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I8a525930611c03c04860d59c9a9e9e5c8f9d1ab3 Reviewed-on: https://chromium-review.googlesource.com/678335Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#503621}
-
Victor Costan authored
Bug: 718360 Change-Id: If0a8b84bf4eb6252f2b64c070f305a9c2685542b Reviewed-on: https://chromium-review.googlesource.com/677738Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#503620}
-
Andrew Moylan authored
This CL removes GeolocationDelegate::UseNetworkLocationProviders. Its responsibility (of optionally disabling network geolocation) is explicitly moved to GeolocationDelegate::CreateAccessTokenStore. Today GeolocationDelegate has UseNetworkLocationProviders (default true) and CreateAccessTokenStore (default nullptr), and these are effectively &&'d together by LocationArbitrator to decide whether to try to use network geolocation. Since AccessTokenStore has other uses, UseNetworkLocationProviders is essentially redundant. I surveyed embedders internal and external to Chromium repo and found no cases of contradictory use of these two signals (i.e. no cases of setting UseNetworkLocationProviders to false but still overriding CreateAccessTokenStore to return a non-nullptr). I also spruced up the LocationArbitrator unit tests with some comments and made them a bit more "injecty" to simplify understanding them. Bug: 748921 Change-Id: I528f6f0a81263df868795be81201141c260aa836 Reviewed-on: https://chromium-review.googlesource.com/670964Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503619}
-
Robert Liao authored
There are no more references to ReadWriteLock in the Chromium codebase. BUG=758721 Change-Id: I2b83afb9c1682fe349f2e389eb75fc0c368497b6 Reviewed-on: https://chromium-review.googlesource.com/676626Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#503618}
-
- 21 Sep, 2017 14 commits
-
-
Adrienne Walker authored
Currently, at raster images are decoded lazily from the PlaybackImageProvider when they are encountered during the raster process. The lock on the raster image is held only for the duration of the op itself. To simplify code and to help with oop serialization, this patch now holds the lock for these images across the entire task. This will potentially increase the memory high watermark for cases where there are a lot of images. In practice, there are very few at raster images, and so this should not be too impactful. A followup to this patch is to assert that no image is encountered that has not been predecoded (either via task or via this at raster synchronous decode) and also to modify PlaybackImageProvider to not do any decoding or uploading. However, these are more risky changes and so have been deferred. Bug: 762732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifec303c16b4d35c789f313445614d7cd59955a61 Reviewed-on: https://chromium-review.googlesource.com/676276Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#503617}
-
Istiaque Ahmed authored
This is a reland of 350845d8 The fix is in Patch set #1 -> #2, by removing dependency on ipc/ipc_message.h from e/c/constants.cc. The include fails on "win_x64_archive" bot but doesn't reproduce on local win 64 build. Since we're using MSG_ROUTING_NONE from ipc_messages.h in event_bindings.cc anyway, move the usage there. Original change's description: > Extension SW: Add filtered event listener support. > > The primary change is to send worker information to > EventRouter::Add/RemoveFilteredEventListener. EventRouter creates > worker specific event listeners when worker information is present > (identified by a base::Optional param). > > The other changes are: > - Added the ability to call MakeLazy() on service worker specific > event listeners. > - Since routing id matching is not done deliberately on service > worker filtered events, added routing id retrieving function > GetRoutingIDForFilteredEvents() to ScriptContext. > > An end-to-end browsertest with webNavigation API to exercise event > filters was also added. > > IPC changes: > This CL adds an optional param to Add/RemoveFilteredListener. The > presence of this param denotes that the listener being added/removed > belongs to an extension service worker. And the value of the param > (ExtensionHostMsg_ServiceWorkerIdentifier) contains the identifying > bits of a service worker. The absence of this param indicates that > the message is for vanilla (non service worker) extension event > listeners. > > Bug: 721147 > Change-Id: I2ff3c26db54ae1e1fd7d10b8afcb277d382e83c2 > Reviewed-on: https://chromium-review.googlesource.com/666222 > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503298} TBR=tsepez@chromium.org Bug: 721147 Change-Id: I53e0ef921eaf3fe318fa3f01c2bdf5dfe2d32994 Reviewed-on: https://chromium-review.googlesource.com/677587 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#503616}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/8e9e3d8975ee..09b5ce623fc4 $ git log 8e9e3d897..09b5ce623 --date=short --no-merges --format='%ad %ae %s' 2017-09-22 art-snake Rename CPDF_SyntaxParser::GetObject to GetObjectBody 2017-09-21 dsinclair Move CFX_WeakPtr to WeakPtr 2017-09-21 dsinclair Move CFX_UnownedPtr to UnownedPtr Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Id11a43c4b8a1763ad079a9f477895cc2cd1d433c Reviewed-on: https://chromium-review.googlesource.com/677791 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503615}
-
Evan Stade authored
class. It seems confusing to let Notification become cluttered by extra fields that are type specific. Bug: 763426 Change-Id: I202f10cca7b2637fd696897616cadf1f0c44e93f Reviewed-on: https://chromium-review.googlesource.com/669687 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#503614}
-
Lucas Garron authored
This CL also adds unit tests for .foo preloading and updates two tests that were using http://foo as a test URL. There are still other places in the code that use http[s]://foo as a test domain. If this change causes issues for them down the line, they should be changed to use foo.test or another domain under a test TLD: https://tools.ietf.org/html/rfc2606#section-2 BUG=b/65158868 (Google-internal) Reviewed-on: https://chromium-review.googlesource.com/669396Reviewed-by:
Chris Bentzel <cbentzel@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502948} Change-Id: I506ff6fa7477501bddb4712576cc225a4debfaeb Reviewed-on: https://chromium-review.googlesource.com/673709 Cr-Commit-Position: refs/heads/master@{#503613}
-
Piotr Swigon authored
This change has been behind a flag for some time, there is no server side component as this flag controls only a UI treatment. Bug: 471623,767297 Change-Id: I216eabddcb017cd4b1bf794d1bdfe5c13f0fe71d Reviewed-on: https://chromium-review.googlesource.com/676690Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#503612}
-
Nate Chapin authored
Bug: Change-Id: I92558b0137e7fc1159f5f7ed3648312645c283f5 Reviewed-on: https://chromium-review.googlesource.com/677493Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#503611}
-
Jiaquan He authored
Enabling answer cards will add a SearchResultContainerView to SearchResultPageView. This will intefere the relevance sorting with SearchResultTileItemListView and SearchResultListView, which then breaks some unit tests. Bug: 766784 Change-Id: I513f006a5d552eb91b20b834b123d2233d5048c2 Reviewed-on: https://chromium-review.googlesource.com/673850 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#503610}
-
Scott Graham authored
Adds some deps/data_deps that weren't being included on Fuchsia. Bug: 761182 Change-Id: I5d36d5c6cf7b7cc0527b8e95264d7feb016f6648 Reviewed-on: https://chromium-review.googlesource.com/673805Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#503609}
-
Yuri Wiitala authored
Re-wires the API and internals of GLHelperScaling (and GLHelper::ScalerInterface and GLHelper::YUVReadbackInterface) to allow client code to create fixed-ratio scaling pipelines. Callers can then request scaling of any subset of the output space. This is just like the skia::ImageOperations::Resize() API. This is a prerequisite need for the referenced crbugs (below). Rationale: In the old API, callers had to specify exact source and destination sizes upfront; and fully reconstruct pipelines whenever either changed. In addition, the old API required whole-number source rect coordinates; but this prevented using many scaling ratios (e.g., 3:1) that require sampling from non-whole-numbered source rect coordinates. Much of this change is simply plumbing-throught the API changes everywhere. However, the following were mostly rewritten: 1. [gl_helper_scaling.cc] ScalerImpl now back-computes the source sampling rect based on the requested result rect. It also works backwards through the "ScalerImpl chain" to ensure minimaly-sized intermediate textures are produced. 2. [gl_helper.cc ] YUVReadbackImpl and YUVReadback_MRT were simplified and able to be merged into one class. Bug: 760348, 754872 Change-Id: Iba3ed5cf504eeed69eb115b4c38d031db47bebcc Reviewed-on: https://chromium-review.googlesource.com/669918 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#503608}
-
Eric Stevenson authored
Bug: 765428 Change-Id: Ia3234093b48cc94f2b51fc889063bec62fbb8a85 Reviewed-on: https://chromium-review.googlesource.com/677649 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#503607}
-
Yuke Liao authored
There is a TODO in the help message to make the test file identifiers configurable, however, this doesn't help users in any way, so move it closer to where the variable is defined. Bug: Change-Id: Id6f3fed4b121e115cfa71f6dc89d576529e0acd0 Reviewed-on: https://chromium-review.googlesource.com/677054Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#503606}
-
Matt Wolenetz authored
Modifies PITB::StartPipelineWithMediaSource() to let any PITB::OnEnded() or PITB()::OnError() stop the run loop and let the method return. In cases where OnError (like that triggered if EME is indicated in init segment -> PITB::FailTest()) or OnEnded occur prior to pipeline completing start-up, this avoids one kind of fuzzer timeout. Also includes addition of PITB helpers to assist common "RunUntilIdle" scenarios and refactoring of PITB to use those helpers. Also changes the SRC= PITB::StartInternal() to similarly allow early fuzzer EME callback to quit the run-loop early, possibly mitigating any similar timeouts in SRC= media_pipeline_integration_fuzzer. BUG=766472,766669 Change-Id: I8307db26828eaf04ae92dc1dbee4fa6969c5dd37 Reviewed-on: https://chromium-review.googlesource.com/677774Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#503605}
-
smut authored
Bug: 756270 Change-Id: Ica1ab2cf9c8e57dadfb1693b9beae96f3e2240ae Reviewed-on: https://chromium-review.googlesource.com/677857Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#503604}
-