- 25 Jun, 2018 40 commits
-
-
James Wallace-Lee authored
When a node's CSS transform changes, the accessibility tree should perform a layout so that focus appears in the correct location. R=dmazzoni@chromium.org, ikilpatrick@chromium.org Bug: 610840 Test: DumpAccessibilityTreeTest.AccessibilityTransform Change-Id: I2517358ea8f8b8a2b24c2daf358dca2058fe1c37 Reviewed-on: https://chromium-review.googlesource.com/1108393 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570135}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07c24bb0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20248 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=robertma No-Export: true Change-Id: I3c47d84ce9d69eaf50c9cf479bed37a35c0396fa Reviewed-on: https://chromium-review.googlesource.com/1113907 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570134}
-
Ryan Landay authored
This is to fix builds that are running into this error: java.lang.ArrayIndexOutOfBoundsException: 2 at org.pantsbuild.jmake.ClassInfo.getDeclaredMethodPos(ClassInfo.java... at org.pantsbuild.jmake.RefClassFinder.findConcreteSubclassesNotOverr... at org.pantsbuild.jmake.CompatibilityChecker.checkMethodModifiers(Com... at org.pantsbuild.jmake.CompatibilityChecker.checkMethodsAndConstruct... at org.pantsbuild.jmake.CompatibilityChecker.compareClassVersions(Com... at org.pantsbuild.jmake.PCDManager.checkUpdatedClasses(PCDManager.jav... at org.pantsbuild.jmake.PCDManager.run(PCDManager.java:340) at org.pantsbuild.jmake.Main.mainProgrammatic(Main.java:347) at org.pantsbuild.jmake.Main.mainExternal(Main.java:409) at org.pantsbuild.jmake.Main.main(Main.java:681) jmake: internal Java exception: java.lang.ArrayIndexOutOfBoundsException: 2 jmake: Consult the following stack trace for more info: Change-Id: I7045c41e5208c1bc87aaee303e4be2f7c07768e5 Reviewed-on: https://chromium-review.googlesource.com/1114005Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#570133}
-
Xiaocheng Hu authored
If an inline element contains an atomic inline child, the height of the child is often different from its parent, in which case the parent's rect is no longer a simple union of its child rects. Currently, LayoutNG fails to handle this. This patch ensures box fragment creation in this case so that we can get correct rects for the parent. Tests: - A lot of tests have wrong baselines, where inline elements are dumped with wrong sizes. This patch corrects them - 4 relevant hit test failures are fixed - Unfortunately, this patch reveals some existing bugs or unimplemented features. As a result, 7 tests regressed... Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4bf26ac35542d03a8bf01de1ffb9d4b2cdbac96b Reviewed-on: https://chromium-review.googlesource.com/1108509 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#570132}
-
Bailey Berro authored
This change adds comments to make it clear which functions are used for reporting metrics and moves them to the bottom of the class. Bug: chromium:757625 Change-Id: I07f82bb50df9ac77afc4d235d802c576aa326bbc Reviewed-on: https://chromium-review.googlesource.com/1102088Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#570131}
-
Xiaocheng Hu authored
Spec (https://drafts.csswg.org/css-text-3/#line-break-transform) says that, during whitespace collapsing, segment break between Hangul characters should be converted into a space instead of removed. This patch implements that. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie61a223ea400a20166ea3ecd779904d4ae57d67a Reviewed-on: https://chromium-review.googlesource.com/1112756Reviewed-by:
-
Zach Helfinstein authored
BUG=None TEST=None Change-Id: Ie9702139a651b118c91264cb930816720a2bf178 Reviewed-on: https://chromium-review.googlesource.com/1112644 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#570129}
-
Aleks Totic authored
Main fix is to fix painting of self-painting AtomicInlines. self-painting AtomicInlines must paint their background in background phase. This also fixed several other tests. Rebaselined their txt expectations. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibaff3c6a681fec81101cb4b8d67877302d74ddff Reviewed-on: https://chromium-review.googlesource.com/1112673Reviewed-by:
-
Peng Huang authored
Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If3d967a2b90f8910fd696ddd8bddc741d4f9ecc5 Reviewed-on: https://chromium-review.googlesource.com/1110020Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570127}
-
Kurt Horimoto authored
This is used for both the collection view and table view implementaitons of the Reading List UI, so needs to be moved to a shared location. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia01403e6d318b4ea331ed85ba622c4ce8ce041cf Reviewed-on: https://chromium-review.googlesource.com/1102119Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570126}
-
Lei Zhang authored
It is not used for anything. (anymore) Change-Id: I9bb1d203e12f750065f250072e9c7a3a305535cc Reviewed-on: https://chromium-review.googlesource.com/1112900 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570125}
-
bsheedy authored
Rolls the WebXR samples repo DEPS revision to the most recent commit, which should have all the fixes necessary to get the XR perf tests running again. Bug: 853400 Change-Id: I2327ca1c83cee3f242a0b9cdfb72b14fca09751c Reviewed-on: https://chromium-review.googlesource.com/1113912Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570124}
-
Jacob Dufault authored
Bug: 855742 Change-Id: If5e8e6f55f1854a2f8063d1e2fb044bac7f997ed Reviewed-on: https://chromium-review.googlesource.com/1112623Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#570123}
-
Erik Luo authored
Originally, payloads with 'contentDocument' created a new SDK.DOMDocument on the frontend. When we prepared DevTools to render iframes inline [1], we switched it to use SDK.DOMNode, which lacks - isInShadowTree reset - documentURL, baseURL 'contentDocument' differs from 'templates' and 'importedDocuments' in that the latter two do not affect shadow tree/documentURL/baseURL. [1] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b Bug: 836849 Change-Id: I9c242720c3d0c37bf8170b1b87d8b31a2f52d2ff Reviewed-on: https://chromium-review.googlesource.com/1102156 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570122}
-
Donn Denman authored
When using a layout with ellipsize=start on old versions of Android a crash can result. This is a speculative fix that changes the way we ellipsize to "middle" to workaround this crash. BUG=834959 Change-Id: I0330d9eee82400983e4407bb8a558e322cbf4482 Reviewed-on: https://chromium-review.googlesource.com/1107169 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#570121}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a24509ac99f7cf6cac7a86c30979d9553f79795 Reviewed-on: https://chromium-review.googlesource.com/1112839Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570120}
-
manuk authored
This issue was most noticeable when quickly alt-tabbing away and back to chrome, or blurring and re-focusing the omnibox. The omnibox schedules a repaint for the location bar when it blurs, but not when it focuses. This caused the region of the location bar that is not overlapped by the omnibox to be stale when the omnibox gains focus quickly after losing focus; the omnibox would be painted with its focus-color (white) while the location bar would retain its blur-color (light gray). This was not an issue prior to material refresh because the omnibox and location bar did not change color on focus and blur. Bug: 853370 Change-Id: I7c6035a09e76cf9fff019234e769ffc312b0a9bd Reviewed-on: https://chromium-review.googlesource.com/1112494 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#570119}
-
Stephan Stross authored
Bug: 839491 Change-Id: I9682eef59b6d1ec2157108a72976dc1b868575f9 Reviewed-on: https://chromium-review.googlesource.com/1110853 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570118}
-
Becca Hughes authored
This is a reland of 981a543f This adds a bugfix that adds a DetachFromParent method that we call in StyleEngine. This stops the global environment variables instance holding a reference to the document one after the document has been disposed. Original change's description: > [CSS Env Vars] Add some WPT tests > > Adds some WPT tests to test env() with @supports as well > as fallback values. > > BUG=825890 > > Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d > Reviewed-on: https://chromium-review.googlesource.com/1111023 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569852} Bug: 825890 Change-Id: If828b977d62145fb1ea9bb710a48d76307a054d5 Reviewed-on: https://chromium-review.googlesource.com/1113877Reviewed-by:
-
Fady Samuel authored
Mac was calling RequestRepaintForTesting() in production code on Show. This is just wrong. The reason this code existed is no longer relevant as far as I can tell. Delete it. Bug: 840545 Change-Id: I17ebbcbd430860e568223a39d865ed14710ac503 Reviewed-on: https://chromium-review.googlesource.com/1112497Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570116}
-
Aga Wronska authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I43d9aea4fa423681080f672ec3d455587e80cd86 Reviewed-on: https://chromium-review.googlesource.com/1112389Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#570115}
-
Taylor Brandstetter authored
Fixes a buffer overflow bug (see bug link below). https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/159d060dceec..7a8bc9a90ca9 $ git log 159d060dc..7a8bc9a90 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 deadbeef Switching from localtime to localtime_r on non-Windows platforms. 2018-06-14 tuexen Ensure that the ip6_plen is provided in network byte order. 2018-06-06 tuexen Improve compliance with RFC 4895 and RFC 6458. 2018-06-02 tuexen Don't overflow a buffer if we receive an INIT or INIT-ACK chunk without a RANDOM parameter but with a CHUNKS or HMAC-ALGO parameter. Please note that sending this combination violates the specification. 2018-05-29 tuexen Try to please the Windows compiler. 2018-05-29 tuexen Plug memory leak recently introduced. 2018-05-28 weinrank Suppress 'type-limits' warning for GCC 2018-05-28 tuexen Fix mask. 2018-05-26 tuexen Allow sys tunables to be set before calling usrsctp_init(). 2018-05-26 tuexen Add range check for sysctl set functions. 2018-05-21 tuexen Fix typo. 2018-05-21 tuexen Cleanup and sync with FreeBSD sources. 2018-05-21 tuexen Backport https://svnweb.freebsd.org/changeset/base/333813. 2018-05-21 tuexen Whitespace change. 2018-05-14 tuexen Sync FreeBSD ID and minor cleanups. 2018-05-14 tuexen Ensure MTUs are a multiple of 4. 2018-05-14 ruengeler m_last is not needed 2018-05-09 ruengeler Build clusters 2018-05-09 ruengeler Set DF Flag correctly 2018-05-08 tuexen Remove stray =. 2018-05-08 tuexen Don't invalidate the sockets, since even they are closed, the value is used to join the corresponding threads. 2018-05-08 tuexen Fix typos. 2018-05-08 tuexen When reporting ERROR or ABORT chunks, don't use more data that is guaranteed to be contigous. Thanks to Felix Weinrank for finding and reporting this bug by fuzzing the usrsctp stack. 2018-05-08 tuexen sctp_get_mbuf_for_msg() should return NULL if mbuf is too small. 2018-05-06 tuexen Don't dereference a NULL pointer. 2018-05-06 tuexen Handle the case of m == NULL in m_copym(). 2018-04-26 justin.kim recv_thread: Invalidate socket after closing 2018-04-08 tuexen Fix logical inversion bug. 2018-04-08 tuexen Small cleanup, no functional change. 2018-04-08 tuexen Fix a signed/unsiged warning. 2018-03-27 deadbeef Fix increment in sctp_connectx_helper_add 2018-03-27 deadbeef Fix cast in sctp_findassociation_ep_addr 2018-03-23 weinrank Fix warnings for "atomic_init" 2018-03-23 weinrank Check for "-Wstrict-prototypes" 2018-03-21 tuexen Use HTTP/SCTP PPID. Created with: roll-dep src/third_party/usrsctp/usrsctplib Bug: chromium:854883, chromium:811477 Change-Id: Ib3db2407c2e591b4162c675596346d8be00955a6 Reviewed-on: https://chromium-review.googlesource.com/1112590Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#570114}
-
Yue Li authored
- migrate many methods into the handler - update loading/error screen specs Bug: b/78190629 Test: Manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7a590f547cc85309f982c58421f0984721a4f04b Reviewed-on: https://chromium-review.googlesource.com/1112716Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#570113}
-
Matthew Jones authored
This patch prevents the location bar from attempting to show the scrim before the view it is supposed to appear behind is inflated (thus making the params null). Bug: 856225 Change-Id: I7fabcd421251602cc25132db71fbb0482312458f Reviewed-on: https://chromium-review.googlesource.com/1113953Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#570112}
-
Kyle Horimoto authored
This class serves as the source of truth for which device is the host for the logged-in account; additionally, it provides the ability to set the host on the back-end. If an attempt fails, it is retried every 5 minutes until it either succeeds or until AttemptToSetMultiDeviceHostOnBackend() is called with a new device. Bug: 824568 Change-Id: I61239ac85b84d57a53b259bc05209aee751f7cee Reviewed-on: https://chromium-review.googlesource.com/1112838 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570111}
-
Ryan Hansberry authored
Grab the global SecureChannelClient instance in EasyUnlockServiceFactory, and inject it into EasyUnlockServiceRegular and EasyUnlockServiceSignin. This change has allowed me to manually verify that Smart Lock works with the new SecureChannel API, in the regular, lock-screen case. Additional work still needs to be done to fully integrate the sign-in case, which will come in subsequent CLs. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 824568, 752273 Change-Id: I77952966eace55dabb6895569c8b18ac03cd1189 Reviewed-on: https://chromium-review.googlesource.com/1108880 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570110}
-
Peng Huang authored
This reverts commit d37409a1. Reason for revert: external/wpt/css/css-sizing/min-content-soft-hyphen-001.html failed on Windows 10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36928 Original change's description: > Move a test for min-content for a soft-hyphen to wpt > > This tests when the inline-size is [min-content]: > * A `­` produces a break opportunity when computing the > min-content inline size. > * The hyphen character generated by `­` is included into > the min-content inline size. > > Originally developed in [CL:1111895]. > > [min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content > [CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895 > > Bug: 636993 > Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Reviewed-on: https://chromium-review.googlesource.com/1113085 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570066} TBR=cbiesinger@chromium.org,kojii@chromium.org Change-Id: I3fb91c7c2d66e775a12994734a14afc566d05a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1113667Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570109}
-
Henrique Nakashima authored
When clicking on a link in a PDF to another page/position in the same document, open in a new window (if shift was pressed) or a new tab (if ctrl was pressed or if the click was on the middle button). Use PDF open params to do so, specifying page and y position. Bug: 720180 Change-Id: I535b707d592056a020033cbbd00a689f3de8e821 Reviewed-on: https://chromium-review.googlesource.com/1112479 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570108}
-
Xing Liu authored
The CL that causes the flakiness has been reverted. See: https://chromium-review.googlesource.com/c/chromium/src/+/1112777 Landed as e4144ed1. This CL enables flaky tests in DownloadActivityTest. TBR=dtrainor@chromium.org Bug: 855389,855219,855168,855167 Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5 Reviewed-on: https://chromium-review.googlesource.com/1113910Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570107}
-
Zach Helfinstein authored
Change-Id: Iaf5ca9c7787b9ce22a217943ce412ccdca137dcf Reviewed-on: https://chromium-review.googlesource.com/1093989Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#570106}
-
Jacob Dufault authored
Sometimes the dialog should not be dismissed, such as when there are no users. Bug: 839583 Change-Id: Iee275fb636e5842ba2e99b799b8c04539ea1c3bd Reviewed-on: https://chromium-review.googlesource.com/1093882 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
In preparation for detecting a mismatch between the running sync client cache guid, and the one persisted in the metadata, a new field is introduced in model_type_state.proto such that the cache_guid is persisted togethter with other model type state fields. Mismatch detection will be used to prevent leak of sync data between different accounts syncing on the same device. Bug: 820049 Change-Id: If537753f0e3011148692c27bd3b63a0742872a28 Reviewed-on: https://chromium-review.googlesource.com/1113338 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570104}
-
Xiaoqian Dai authored
This reverts commit a0c1584a. Reason for revert: It broken Chrome PFQ, see crbug.com/856142 for more details. Original change's description: > Reland "Reland "Update fontconfig to 6cc99d6a"" > > This reverts commit 812edd08. > > Reason for revert: libuuid1:i386 should now be installed on the bots (bug 853048) > > Original change's description: > > Revert "Reland "Update fontconfig to 6cc99d6a"" > > > > This reverts commit 0c91664f. > > > > Reason for revert: Broke Linux Builder (dbg)(32) > > > > Still missing libuuid: > > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697 > > > > [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86) > > FAILED: v8_context_snapshot.bin > > python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin > > ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory > > ./v8_context_snapshot_generator failed with exit code 127 > > > > Original change's description: > > > Reland "Update fontconfig to 6cc99d6a" > > > > > > This is a reland of e6db40d9 > > > > > > Reason for reland: All bots should now have libuuid1 installed (bug 853048). > > > > > > Original change's description: > > > > Update fontconfig to 6cc99d6a > > > > > > > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > > > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > > > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > > > > fix a use-after-free. > > > > > > > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > > > > dependency since we statically link fontconfig. > > > > > > > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > > > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > > > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > > > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > > > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > > > > > > > BUG=831146,822737,787020,829890,847323 > > > > TBR=thestig,dnicoara > > > > > > > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > > > > Reviewed-on: https://chromium-review.googlesource.com/1095538 > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#567445} > > > > > > TBR=thestig,dnicoara > > > > > > Bug: 831146, 822737, 787020, 829890, 847323, 853048 > > > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869 > > > Reviewed-on: https://chromium-review.googlesource.com/1104759 > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#568221} > > > > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org > > > > Change-Id: Icd39638df79083776546d4283675c3e172bbefe4 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 831146, 822737, 787020, 829890, 847323, 853048 > > Reviewed-on: https://chromium-review.googlesource.com/1105539 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568346} > > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 831146, 822737, 787020, 829890, 847323, 853048 > Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be > Reviewed-on: https://chromium-review.googlesource.com/1112179 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Elliott Friedman <friedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569800} TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,friedman@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831146, 822737, 787020, 829890, 847323, 853048 Change-Id: Ic4c518680efb4480a9568829996f5ceebaf459e7 Reviewed-on: https://chromium-review.googlesource.com/1113840Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#570103}
-
Ryan Landay authored
The Android horizontal tab switcher currently feels very "slippery." This is largely because we currently have a bug in the logic that gives flings a "boost" to the next tab where, if you start dragging a tab over so that it's already the centered tab, we apply the boost anyway, so you actually end up scrolling by two tabs. The minimum scroll distance to move over by one tab is also currently fairly large, which makes it easier to run into the bugging fling boost behavior. This CL fixes these two issues. I'm also introducing some non-linearity into the scroll distance function. After this CL, the velocity range to scroll by one tab is fairly large, then the velocity range to scroll by two tabs is somewhat smaller, and then the ranges to scroll by 3 through 11 tabs are fairly small, and then the range to scroll by 12 tabs is fairly large again. Bug: 849417 Change-Id: I9f3d442a191091a126410526c9097c445eb9fe40 Reviewed-on: https://chromium-review.googlesource.com/1109212 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c050a1a185bf..ed55419d859b git log c050a1a185bf..ed55419d859b --date=short --no-merges --format='%ad %ae %s' 2018-06-25 herb@google.com Use indices into the vectors shared by runs 2018-06-25 caryclark@skia.org fix path measure fuzzes 2018-06-25 brucewang@google.com Implement onMakeClone(const SkFontArguments& args) in classes: SkTypeface_Empty, SkTypeface_Stream, SkTypeface_File 2018-06-25 robertphillips@google.com Add bullet proofing for preAbandonContext 2018-06-25 egdaniel@google.com Make GrVkBackendContext no longer derive from SkRefCnt. Created with: gclient setdep -r src/third_party/skia@ed55419d859b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I93b01085a5d5cb6814bb2b040761af55aae4eec1 Reviewed-on: https://chromium-review.googlesource.com/1113819Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570101}
-
Mitsuru Oshima authored
The capture window will not receive events while locked because there is an extra mechanism to block events in locked state, but having capture window in locked state will make lock UI unusable by mouse/touch. Explicitly release capture so that mouse/touch event works when locked. BUG=788782 TEST=covered by unittest Change-Id: I01849f71ec0f059a21b433295fbdf816962d44d4 Reviewed-on: https://chromium-review.googlesource.com/1112938Reviewed-by:
-
Jialiu Lin authored
Since now we need to prepare password hash for both sync, other gaia and enterprise passwords, we should rename the function as PasswordStore::PreparePasswordHashData(..) and don't gate on empty sync username. Also fix minor UMA logging issue in PasswordStore::SaveProtectedPasswordHashImpl Bug: 830998 Change-Id: I26cb613babcdd0268785e61b52c021aa9f343cb5 Reviewed-on: https://chromium-review.googlesource.com/1112586Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570099}
-
Ryan Sturm authored
Because other features (capping heavy pages in particular) wish to us incredibly similar functionality as the previews opt out blacklist, this should be moved to a component. components/blacklist will be a component for consumable blacklists and opt_out_blacklist is a sub directory of one such blacklist. TBR=pwnall@chromium.org Bug: 852593 Change-Id: I1b0b041eac6a715c70eaa3cf24542f63977caa50 Reviewed-on: https://chromium-review.googlesource.com/1109035 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570098}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic7258e4b4e03988344412e2e15893ea30f68ae38 Reviewed-on: https://chromium-review.googlesource.com/1112939Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570097}
-
Chris Mumford authored
The extensions network throttle (ExtensionThrottleManager) used to use the net::NetLog to log throttling activity. Logging was only done if ExtensionThrottleManager::set_net_log was called, but that was removed nearly four years ago in refs/heads/master@{#298862} (https://codereview.chromium.org/631203003). This change removes the logging implementation as these classes will soon be moving to the render process. Bug: 784576 Change-Id: I1025dd6f3134d438e549165f5b7045b3ecf2dc61 Reviewed-on: https://chromium-review.googlesource.com/1113899 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570096}
-
