- 03 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9c51142bd01..38cf390f9cf2 git log d9c51142bd01..38cf390f9cf2 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9dce00d2..22aaaa25 (756252:756379) Created with: gclient setdep -r src/third_party/webrtc@38cf390f9cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a7fb73f28877c5c470d32d73737633400a8244f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756471}
-
Mustafa Emre Acer authored
The delayed warnings experiment should only handle phishing pages. It doesn't make sense to run it for other threat types, as the goal is to understand the effect of different URL display modes to phishing threats. This CL also fixes a DCHECK when there are multiple unsafe resources in the current WebContents. The old code assumed that the method to create the user interaction observer could only be called once per WebContents. In reality, it's called for each unsafe resource, so this CL ignores subsequent calls. Bug: 1057157 Change-Id: Ifb87dae060c2a08c37aeef55835c318ba7bcdfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130626 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756470}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b6e7ef1092b7..36e67aa86981 git log b6e7ef1092b7..36e67aa86981 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 bungeman@google.com Mark dawn and shaderc as third_party. 2020-04-03 bsalomon@google.com Make copy proxy in GM budgeted when texgen policy is kDraw. 2020-04-03 mtklein@google.com every label has a use 2020-04-03 csmartdalton@google.com ccpr: Don't use half float vertex attribs 2020-04-03 reed@google.com plumb camera info down to devices 2020-04-03 jvanverth@google.com Set gn output_dir variable for test apps. 2020-04-03 jvanverth@google.com Add GrD3DBuffer. 2020-04-03 kjlubick@google.com [canvaskit] Add gm helper functions to tests. Created with: gclient setdep -r src/third_party/skia@36e67aa86981 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: Idabcbb6fe0f2e40d72b668a2f7407ee9f5ffe46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136063Reviewed-by:
-
Pavel Yatsuk authored
When test scenario involves tab switching, the toolbar is animated into view. ChromeTabModalPresenter has a logic that prevents it from running enter animation when toolbar animation is not finished (browser controls are not fully visible). Because of this logic modal dialog view is not added to container view immediately in ModalDialogManager.showDialog call. On the other hand Espresso's onView(...).check() call verifies condition immediately and asserts if the condition is not met (descendant with a particular text is not present in container view). This causes occasional test failures. Semantically test should verify that a dialog with particular text is shown at some point. Container view visibility it closest approximation to a condition that modal dialog view is added to the container. In this CL I add helper that polls UI thread waiting for dialog container to become visible. BUG=1030683,1030903,1031092 R=twellington@chromium.org Change-Id: Id1a42aefa45ee50d26171ecbff662c44226ad056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134401Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#756468}
-
Yuly Novikov authored
Don't specify ssd dimension. TBR=kbr Bug: 1064477 Change-Id: Idd00b8601bbfd072bf4043ee27c9beebeb56c915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136270Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756467}
-
Peter Kotwicz authored
This CL deprecates: - WebApk.Permission.ChromeWithoutPermission - WebApk.Permission.ChromePermissionDenied2 I am deprecating the metrics because we did the analysis we were planning on with the metrics and no longer need them. BUG=1064849 Change-Id: I068372555566daa03859e1cd1afc490a0c961d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121430 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#756466}
-
Peng Huang authored
Tested with AMD GPU on WIndows 10. Bug: 1067709 Change-Id: I0c7147ef6e2cb9338304f5692f66f6e0715986c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135980Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756465}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/390ef29999bc..96c26c681bc7 git log 390ef29999bc..96c26c681bc7 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 m.maiya@samsung.com Add support for NV_shader_noperspective_interpolation 2020-04-03 jmadill@chromium.org Pass layer count to robust 2D array texure init. Created with: gclient setdep -r src/third_party/angle@96c26c681bc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I635422d4989ea65e96e2a0d750ed36724bab9e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136050Reviewed-by:
-
Matthew Jones authored
Bug: 1067737 Change-Id: I698b88bcdc00f8ffc59eaada119f0c92bd54f929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134518 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I10ae4609d00c1ad2c23c04226e2ac930149fe1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136086 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756462}
-
Maggie Chen authored
It is for the debugging purpose only and it wil have a performance impact. The code will be removed immediately once valid crash dumps are collected. Bug: 885066,885066 Change-Id: Ie8761ed4e6050a07e76af0a030b67dab5bb011e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129028 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756461}
-
John Budorick authored
Bug: 922145 Change-Id: Ic21bfc796baa5d8b8f55a5dedef7b9eaa35aa5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135340Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756460}
-
Tao Bai authored
Bug: 1067334 Change-Id: Ibf64b31d7ad6289a9a1ab5f4aab1fcf4dcbd14eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134611 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#756459}
-
chrome://signin-errordpapad authored
Fixed: 1012533 Change-Id: Id45159fb7fcf33ac14b954cc05d6139dd4abbbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132941Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756458}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e06125cb520f..ad6d1b30e0f1 git log e06125cb520f..ad6d1b30e0f1 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 amaiorano@google.com Really fix Android build Created with: gclient setdep -r src/third_party/swiftshader@ad6d1b30e0f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idb24445b6d1b20980267cb21a085b1b46b9a10ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136137Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. In addition, this test uses <html class="reftest-wait"> as described in [1] to replace the code that was depending on testRunner in order to make sure that the screenshot is taking at the right time. Last, the original test relied on a green-256x256.jpg image that is exactly equivalent to the PNG version already in WPT, so this test has been migrated to use that one instead. [1] https://web-platform-tests.org/writing-tests/reftests.html?highlight=reftests#controlling-when-comparison-occurs Bug: 1063749 Change-Id: Idcd76fcf3b1e82fe14be602c120d8c105f5c658a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134258Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#756456}
-
Lukasz Anforowicz authored
This CL adds the FromBackgroundServiceWorker_NoSniffXml test. The new test complements the old FromRegisteredServiceWorker_NoSniffXml test, but the new test registers the service worker in a more typical way - via the following entry in the extension manifest: "background": {"service_worker": "sw.js"} Additionally, the new test covers not only a target URL that is covered by extension permissions, but also other-without-permission.com. The old test is still relevant for testing how a 'fetch' event handler of a service worker behaves. One aspect where this is important is where the 'fetch' event handler doesn't handle the fetch - I vaguely remember that I heard that the fallback might use a different URLLoaderFactory from the one normally used from within the service worker. Bug: 1051594 Change-Id: Ic9df888cd0799ce57131e6df93d9c6f39501aedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132938Reviewed-by:Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#756455}
-
John Delaney authored
Currently, ConversionStorageSql is instantiated and owned by a ConversionManager instance. ConversionStorageSql is solely accessed through a SequencedTaskRunner, and is deleted on the same sequence that it is accessed. ConversionStorageSql also holds a pointer to the manager which implements the ConversionStorage::Delegate. Because of this setup, it is possible for the ConversionManager to be destroyed when there are still storage tasks in the queue that require a StorageDelegate. Because the storage instance is deleted on the sequence, the pointer to the ConversionManager is no longer valid and it will still be accessed. This change fixes this potential behavior by moving the Delegate implementation off ConversionManager, and into a separate class that is only accessed on the storage sequence and owned by ConversionStorageSql. Because ConversionPolicy cannot be shared, storage related methods are pulled onto the DelegateImpl. Bug: 1059840 Change-Id: Ie0fdf7a07d3dbe75359bb29b0dfea8a973ca3db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095435 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#756454}
-
James Vecore authored
This flag can be used to enable or disable Nearby Sharing Change-Id: I7eb984f164affb98a4d8f9e3cfb1f462f981ed87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133053Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#756453}
-
Brandon Wylie authored
Bug: 1067716 Change-Id: I717bc16a22492dec3238bffc9e943c6be29f57ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134205 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#756452}
-
Sergey Ulanov authored
Updated PlayAudio test in web_engine_integration_tests to enable FuchsiaAudioConsumer and verify that the audio played as expected. It uses a fake implementation of fuchsia.media.AudioConsumer interface that's injected to the web context. Also updated the tests to play two files with different sample rate to verify that the audio renderer handles mid-stream config changes. Bug: 1027048 Change-Id: I14b0b63d9dc7444c749ee0da348b39df93c1242b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940726Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756451}
-
Sammie Quon authored
This is a regression from my previous cl crrev.com/c/2099291. I don't have access to a win7 but this speculative fix readds the MessageView specific HighlightPathGenerator which insets the ring a bit. On my cros-linux you can see the ring is now within the notification bounds. Test: manual Bug: 1067594 Change-Id: Iddaf378dc864f2a438d5a64174592faa4bf66c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136054Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#756450}
-
Michael Tang authored
- Ported Omaha 3's ExtraArgsParser into chrome/updater. - (At Sorin's request) Renamed ExtraArgs to something else (currently TagArgs, but I'm open to renaming it or any other item) - Ported the Omaha 3 ExtraArgsParser tests Change-Id: Ief76020716ae35fff26bacd19357847651acad5a Bug: 1050738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081332 Commit-Queue: Michael Tang <tangm@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#756449}
-
Leonard Grey authored
Bug: 1066116 Change-Id: I4c77eb55d4288ab1ecf327875d37a1b8fe90d292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134778 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#756448}
-
John Lee authored
This CLs replaces all usage of the cr-section class with a new cr-row class. It also removes uses of the class where there isn't much benefit to using them and cleans up some of the HTML and CSS that were used to override the class. Bug: 973674 Change-Id: I1c33ca05626bde382bd7fbd0b54b4ab3b86089dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134197 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756447}
-
Charlene Yan authored
Updating the context menu for Tab Groups to show a submenu with the entry "Add to Group" if another group exists and the submenu to had "New group" as the first item followed by a separator and then the other existing groups. If there are no other groups, a submenu will not appear and the menu item will simply be "Add to new group". Bug: 1064674 Change-Id: I88b470171d4f44e6969201fea7e991d5cd2905c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133269 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#756446}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d6db0b9fdd5..7ff61c6fba28 git log 2d6db0b9fdd5..7ff61c6fba28 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 brcui@microsoft.com Add alt text to Screencast canvas element Created with: gclient setdep -r src/third_party/devtools-frontend/src@7ff61c6fba28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067074 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf41d49a66c51a3a461b7e8f2583e4ef16fe0441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136136Reviewed-by:
-
Saurabh Nijhara authored
The test was based on the assumption that the wizard controller is recreated in the login display host and hence, had the expectations according to that. If instead the wizard controller object is reused, this test fails the expectations set in the test class at the start. Hence, calling AdvanceToScreen(...) directly instead of going through login display host. Bug: 1064271 Change-Id: I12b11f0a08269d91d776ae0e438b7b0b8ce7262d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132382Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#756444}
-
rbpotter authored
This UI is shown on the main people page landing page, so to avoid flicker on load, it should be in the main rather than the lazy module. Size changes: vulcanized.html: 240k -> 247k (+2.9%) crisper.js: 313k -> 321k (+2.6%) lazy_load.vulcanized.html: 257k -> 249k (-3.1%) lazy_load.crisper.js: 304k -> 297k (-2.3%) Bug: 1026064 Change-Id: I809b8701ab3859561911980064bd84a4ded4a83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134779 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Jeff Yoon authored
- chromium_trybot recipe set in ci.star for both bots - mb configs set in mb_config.pyl for both bots, exactly the same as the builders Bug: 1055164,912681 Change-Id: Ib2235e9803ddafddbd7fc44be493ab06fcb74c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121429 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#756442}
-
Dale Curtis authored
This reverts commit 6db10514. This did not work well so it's being reverted. R=tguilbert Bug: 1012063 Change-Id: Ia5faf1026921dab735ead8acaa8f4fdd80dc6fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135894 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#756441}
-
Garrett Beaty authored
Consoles defined using ci.console_view instead of luci.console_view can specify a dictionary that controls how entries in that console are sorted. Calls to ci.builder can then specify the console_view_entry attribute with the category and/or short name for the builder and an entry for the builder will be added to the console corresponding to the builder's mastername. Bug: 1067057 Change-Id: Icbbb310bbf4434aeb2434ab930e8fb64fff85a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136107 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756440}
-
Alexander Cooper authored
Moves chrome/browser/vr/service and corresponding dependent metrics code into content. Also moves not-yet published statics into content/public. As a result of the move a few changes had to be made: * VRService needed to switch to PermissionControllerImpl * Swapped two "NULL"s to "nullptr" * Renamed usages of XRRuntimeManagerStatics to XRRuntimeManager * Deleted WebVRServiceProvider and directly hooked up VRServiceImpl in browser_interface_binders * Switched ChromeXrIntegrationClient::GetInstance usages to use ContentBrowserClient->GetXrIntegrationClient (and removed ChromeXrIntegrationClient::GetInstance) * Created GetXrDeviceServiceForTesting to manage dependencies for tests * ukm::GetSourceIdForWebContentsDocument replaced with WebContents::GetLastCommittedSourceId * XrRuntiemManagerUnitTest needed some singlethreaded task environments added due to changes in tests (requirements from using mojom) It seems like linking //device/vr into a source_set causes one of the static initializers from gvr_shim to get counted now (perhaps being optimized out when in a static library?) Bug: 1031622 Change-Id: Id856e6cb68471a9960f54c663ece417461067541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125016 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#756439}
-
Clark DuVall authored
This can now be shared between //chrome, //headless, and //weblayer. Bug: 1050722, 1049317 Change-Id: I3fdc6979926b7ba8d27a8543cace8909b5c3f75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134691 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#756438}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/52ecbf88d69c..14215fbea0c8 git log 52ecbf88d69c..14215fbea0c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 jophba@chromium.org Add recipe engine servers to buildbucket cfg Created with: gclient setdep -r src/third_party/openscreen/src@14215fbea0c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I609f25078b3928b034c3e1e2dd54cc67368a3bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136052Reviewed-by:
-
Tom Anderson authored
The bot's config will be moved into linux-ozone-rel, so this temporary bot can be removed. BUG=1029240 R=agable Change-Id: Iff366bf66bbf8d4a04e3d88970199908e8e0f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134692 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Peng Huang authored
glImportMemoryWin32HandleEXTFn and glImportSemaphoreWin32HandleEXTFn are added. It will be used for implementing Vulkan GL interop on Windows. Bug: 1067709 Change-Id: Ic6fa3e44ea5da64bd4f56491c97daee184e0f362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135420Reviewed-by:
-
Arthur Eubanks authored
This reverts commit fd6e6ffb. Reason for revert: https://crbug.com/1067752 Original change's description: > Use urllib instead of curl > > Now that https://crbug.com/965937 is fixed. > Partial revert of https://crrev.com/c/1624331. > > Change-Id: I9e73fdff99984601182ec142723a9d3521a9eb6e > Bug: 897796 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134702 > Commit-Queue: Arthur Eubanks <aeubanks@google.com> > Auto-Submit: Arthur Eubanks <aeubanks@google.com> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756285} TBR=hans@chromium.org,aeubanks@google.com Change-Id: Ia53d6e84a8e09d13d7935cfde3b9310d7bc06e93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136138Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756434}
-
Orin Jaworski authored
This CL takes another step toward having selection change logic consider full selection instead of updating line and state separately with assumed NORMAL state default. The API is preserved for now but behavior changes slightly in a way that should, long term, be more efficient than doing event handling in duplicate. In particular, the goal is to have result views only update on selection change once instead of once on line change and then again on state change. Bug: 1046523 Change-Id: I6c94db73d4997241275e4a1b62b75272611c166a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134917Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756433}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7803f6a504e3..d49a958f8fdf git log 7803f6a504e3..d49a958f8fdf --date=short --first-parent --format='%ad %ae %s' 2020-04-03 rsavitski@google.com Merge "perfetto_cmd: if unique session is given, set comm to "p-session_name"" Created with: gclient setdep -r src/third_party/perfetto@d49a958f8fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id38cce4b2db2e6f76aab5656dc51a97b18121ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136133Reviewed-by:
-
