- 17 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a822f4b3c64..e1b777717bc9 git log 4a822f4b3c64..e1b777717bc9 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 srte@webrtc.org Removing deprecated min_pacing_rate alias in StreamsConfig. Created with: gclient setdep -r src/third_party/webrtc@e1b777717bc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I87564a2436bdf1b03fd396d8d9c309f373949819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697221}
-
Aaron Krajeski authored
We recently removed logic that used CPU resources for small canvases and instead are using GPU-accelerated canvases, regardless of size. It looks as though this change is causing some crashes in webview, temporarily re-add that logic for webview while a more robust fix is in the works. Bug: 994310 Change-Id: I5efbbd9ae783e2c41c9c2c6246234ba3d513e24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800346Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697220}
-
Miyoung Shin authored
This CL converts MtpManager{Ptr, Request} in services and components to the new Mojo type. Bug: 955171 Change-Id: Iac8e22b1b2b40b3c8417fe3b66628626b349b287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806167Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697219}
-
Manu Cornet authored
The crash happens when the display width is less than about 210 pixels, and one clicks on the overflow button. Add a test to prevent future regressions. Bug: 977043 Change-Id: I8d1fa02eee829bf4ca0d45000b66842dcd2e65a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808378Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697218}
-
Lei Zhang authored
- Mark parameters const for SetAccessibilityViewportInfo() and SetAccessibilityDocInfo(). - Fix lint errors. Change-Id: I2d54ac4e4b04acb20b7b86767534b30bfba8541e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794502 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#697217}
-
Niels Möller authored
Intended to enable landing of https://webrtc-review.googlesource.com/c/src/+/153180 Bug: webrtc:8733 Change-Id: If4eccd18aca2ad76d35beb6f8a492797bb1dc5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808841Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#697216}
-
Javier Ernesto Flores Robles authored
Bug: 1001409 Change-Id: I2c97c64a9fded5935dda6142d0be18b00bef230f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803444Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#697215}
-
Nazerke authored
Link for settings in the 'turn on sync' page is wrong blue. This CL sets the kBlueColor dynamic color as a link color, according to the dark mode theme. Bug: 1004685 Change-Id: I6be3e299055dda213a8854cf03f6a6d119d59acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809297Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#697214}
-
Mikel Astiz authored
BUG=1004762 TBR=finnur@chromium.org Change-Id: If7a436a68552104df92e77803c7326b695023929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808844Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697213}
-
Xida Chen authored
This test is an interpolation test, and that should be reflected in the name. This CL change the name of the file. Bug: 900581 Change-Id: Icb9585dfc8454576a4659d52dbbb08268fc2719b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805503Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697212}
-
Jasper Chapman-Black authored
Replace the two-column view for milestone vs canary builds with a one-column view with a toggle for selecting milestone vs canary comparisons. Also enforce certain conditions (mainly: diff-against version must precede original version) Bug: 1001775 Change-Id: Ie2f9b61b93e839898968d586b364883cbfa6c116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807070Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697211}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d545bfbb94ca..747b3409bc2d git log d545bfbb94ca..747b3409bc2d --date=short --no-merges --format='%ad %ae %s' 2019-09-17 bsalomon@google.com Fix bug where coverage on interior of stroked rects is applied twice Created with: gclient setdep -r src/third_party/skia@747b3409bc2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I8d7e52296f5bf73de70e4b6607dcb809557750e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808550Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6ca32387e704..263def0ec958 git log 6ca32387e704..263def0ec958 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Fix colspan. 2019-09-17 fmayer@google.com Merge "Reland "Add x86 ASAN to CI builds."" 2019-09-17 fmayer@google.com Merge "Add -S to curl to print errors." 2019-09-17 tneda@google.com Merge "perfetto-ui: Making heap dump marker clickable" Created with: gclient setdep -r src/third_party/perfetto@263def0ec958 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1f167c406ca83b4b55861cb4dd9edf004c2f194b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808549Reviewed-by:
-
Alex Turner authored
This DCHECK was added to validate the hypothesized cause of a bug. The change is no longer necessary and shouldn't be included in the release. Bug: 959194 Bug: 1004429 Change-Id: I48ddf24dfef0372f57d3705600918fe43e6744df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803670Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697208}
-
Javier Ernesto Flores Robles authored
Bug: 1001409 Change-Id: Iabd639d6064bd68127d085b2a29db1ce5267abd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803442Reviewed-by:
-
Benedikt Meurer authored
This adds a bunch of missing values to the "DevToolsPanel" enum, as otherwise all these drawers get logged with the code 0 instead, which makes it impossible to distinguish. Bug: chromium:993562 Change-Id: Icdb11f6c35fe8f521e141c487c6a0b483fa4ee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805663 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697206}
-
Javier Ernesto Flores Robles authored
Bug: 1004749 Change-Id: I3c6560e27d38e9880d7bdd2b09235db38ecc336a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809164 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL reenables the ManualFillingControllerTest that was previously disabled because the SetUp failed when initializing the initial navigation for the RenderViewHostTestHarness. This cannot happen anymore since the Test doesn't use any navigations anymore but instead calls the controller interface directly. Therefore, it also isn't a subclass of RenderViewHostTestHarness anymore but uses TestProfile and TestWebContents directly. Bug: 1004585 Change-Id: I6c48c651447645453fc080a35efa90c7d7b60c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807224 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697204}
-
Mikel Astiz authored
This introduces basic functionality related to this passphrase type, which behaves similarly to KEYSTORE_PASSPHRASE but is designed to receive the encryption key by means other than the sync protocol. Bug: 1000146 Change-Id: I0a3f093ae47a8efcb79794572c6e7ac30b335d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806874Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697203}
-
Lowell Manners authored
The word 'flush' is a slightly ambiguous but 'destroy' describes exactly what this method does, so "DestroyEvictedFrames" is a clearer name. Change-Id: I22654a1c10e6c5a0c2a94c7d04a75c1cbf8e913b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803436Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#697202}
-
Alex Clarke authored
This is helpful whern diagnosing test failures resulting from scheduler policy changes. Bug: 971191 Change-Id: I835db83e62895e45ef7400d231db8b6e30f14ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806464Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#697201}
-
Mathias Bynens authored
Previously, there was a property order mismatch between the DevTools Console Preview and the expanded view. For example: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {a: 1, b: 1, c: 1, __proto__: Object} This patch removes the confusing mismatch as follows: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {c: 1, b: 1, a: 1, __proto__: Object} The core change happens in ObjectPropertiesSection.js. The test expectations are updated accordingly (note that for each test, only the order in which properties/values are printed changes). The patch also includes a drive-by change across files unifying the way U+00A0 is escaped in string literals. Screenshot: https://goo.gle/devtools-property-order-mismatch BUG=989514 Change-Id: I102afcbd107100a52e0932401429a3fa8db99eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806457Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e25bd5bbc4f..56bc26904935 Created with: gclient setdep -r src-internal@56bc26904935 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id090e3578adb369b0d19d77a9e305f9decea1b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808515Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697199}
-
Ivan Sandrk authored
Bug: 891222 Change-Id: I6675c208550affd8f8bb1316d4935c02f0e07a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783439Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697198}
-
Dominik Röttsches authored
Implement the CSS fonts property font-optical-sizing [1]. Typographic optical sizing means that a font has slight variations in glyph contrast to better optimize for legibility at different font sizes: The glyph shapes vary between for example a headline font size and a body text font size. The CSS font-optical-sizing property with its default value of auto exists to automatically apply the current font size value to a variable font's 'opsz' axis. This means, if a variable font supports the 'opsz' axis and optical sizing, the right value is automatically applied without the need for an explicit font-variation-settings styling. Intend to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Y3lhEykjfV0 Chromestatus entry: https://www.chromestatus.com/feature/5685958032752640 [1] https://drafts.csswg.org/css-fonts-4/#font-optical-sizing-def Bug: 773697 Change-Id: Ifa4b6e042204a3fbf172b8cfe232821d8691283b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795244 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cc17f852d575..99f23d6ff220 git log cc17f852d575..99f23d6ff220 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 wl@gnu.org * src/sfnt/sfwoff2.c (woff2_open_font): Check table index. Created with: gclient setdep -r src/third_party/freetype/src@99f23d6ff220 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Ibcb85facaaf5583378c111554fe542c746d4c339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809241Reviewed-by:
-
Vikas Soni authored
A recent change - https://chromium-review.googlesource.com/c/chromium/src/+/1783526 requires |context_state| to be passed to SharedImageRepresentationSkiaGL::Create(). This started causing nullptr deref crashes since it was passed as nullptr before in SharedImageVideo. Change-Id: Ia060262be9c0a28b7b62ef318cd83fe5d22880f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807603 Auto-Submit: vikas soni <vikassoni@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697195}
-
Dominic Battre authored
Autofill's form parsing can abort due to a number of reasons (wrong scheme, not enough fields, form target url matching some suspicious patterns, ...). This CL introduces logging for these aborts to chrome://autofill-internals to speed up the understanding why autofill is disabled for a certain form. Bug: 928595 Change-Id: I754b56bb6b30ab3b2809c8bf508b74f6bbd380c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804298 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/69dd79c4f0ca..6ca32387e704 git log 69dd79c4f0ca..6ca32387e704 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Merge "Revert "Add x86 ASAN to CI builds."" Created with: gclient setdep -r src/third_party/perfetto@6ca32387e704 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie75794a2fe63e762ff0f266651f63a080ba1e46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808514Reviewed-by:
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I2806b40040f96fde571fb725dc1a3ed885a4629d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808840Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697192}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1c6284cd11f..4a822f4b3c64 git log c1c6284cd11f..4a822f4b3c64 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2e4ccff8..dbd15694 (696956:697157) 2019-09-17 danilchap@webrtc.org In TaskQueueTest::PostDelayedAfterDesctruct increase timeout Created with: gclient setdep -r src/third_party/webrtc@4a822f4b3c64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1000531 Change-Id: I8734d8e8efbb8ef949237b8ac94c1bff0bfdff27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809240Reviewed-by:
-
Denis Solonkov authored
We can't expect that the test array would be put in the same place in memory between test runs and since [l, r) is being rounded to the page size. Due to that we can't make any assumptions about the elements inside of the final range and can't calculate the resulting sum, since all elements inside of the range are zeroed. The tests were modified the following way: 1) All zeroes in the test array were replaced by one to be able to locate all zeroed elements in it. 2) GetSum method was replaced by GetZeroes method which is expected to return 4096. 3) The size of the array was set to 2*4096 - 1 to prevent unlikely case of array aligning perfectly on memory and having 2 pages cut out of it. Bug: 998082 Change-Id: Idde87569decd3a52ecd1a0c034ab638833d8e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795791 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697190}
-
Jan Wilken Dörrie authored
The checked iterators model the RandomAccessIterator concept, however they did not implement operator>, operator>= and operator[], which are part of the concept requirements [1]. This change adds implementations of these operators and adds appropriate tests. [1] https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator#Requirements Bug: 817982, 828324 Change-Id: I14d80a412a9071c5ba50c57114ffec794cde9f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807195Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1vuvx8gWWX-f2Tb01QmorWg3EGJpP9VU6/view?usp=sharing Screenshot after: https://drive.google.com/file/d/12i0Dw3h82IjPTU4VP-LmCsHobZE38pU4/view?usp=sharing Bug: 995720 Change-Id: I86ddfd04ad59e16abc546fa97fcebbdd715616bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807314Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#697188}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41079d70e469..65a5036eb041 git log 41079d70e469..65a5036eb041 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 1e146e8a3485..99793fa67d78 (2 commits) Created with: gclient setdep -r src/third_party/angle@65a5036eb041 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I6c0ecf18ef577f28e32c47009c53beec06137e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809237Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df432d5efb70..d545bfbb94ca git log df432d5efb70..d545bfbb94ca --date=short --no-merges --format='%ad %ae %s' 2019-09-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@d545bfbb94ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I9dec96d1d33ad47325b049d342d106fc1e81f054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809239Reviewed-by:
-
Robbie Gibson authored
The root cause looks like the BVC view will show up momentarily when closing the last tab. I assume that all the actual tab views are removed, which lets the BVC shine through. Bug: 1003485 Change-Id: I4760cd2031abdcb5d04572efd5c1fbb637dae6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807221Reviewed-by:
-
Nikita Podguzov authored
This is required to clean several expired print jobs at once. Bug: 992889 Change-Id: Iecfedcd1282fe610c6bcc60c7f42746916dc9497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804486 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#697184}
-
Robbie Gibson authored
Here, the root case is that the accessibleElements array keeps growing and eventually has many many copies of self.trailingButton (once on each page load). This causes voice control to think there are many buttons named share, so it asks which one to choose. This also seems to fix a bug where you can't swipe past the share button when using voiceover. I assume it's a similar issue coming from -indexOfAccessibilityElement:. Bug: 1004331 Change-Id: Iaed748b8488451704d8d338c50b5d12cfce61986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807114Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#697183}
-
Tanmoy Mollik authored
To enable the feature flag that will make android manual start it is necessary to change the tests that assume android is auto start. This signIn method is used by some sync autofill and bookmark tests that needs to manually set setFirstSetUpComplete to start the sync process. Bug: 1004264 Change-Id: Ie33ae3b69478794b32530dd5596af66d813ee84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798323 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
