GitLab

Some of the code from a previous prototype [1] pulled out into a smaller patch that can be committed.

[1] https://chromiumcodereview.appspot.com/274773002/


BUG=362293

Review URL: https://codereview.chromium.org/311193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275633 0039d316-1c4b-4281-b951-d872f2087c98

This change is a simple cleanup: It removes some Channel API
that is only used only in POSIX specific tests. These
funtions still live in ChannelPosix. POSIX speicific tests
now touch ChannelPosix instead of its superclass Channel.

TEST=none
R=darin@chromium.org, jam@chromium.org
BUG=377980

Review URL: https://codereview.chromium.org/320433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376486

Review URL: https://codereview.chromium.org/324503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275631 0039d316-1c4b-4281-b951-d872f2087c98

This code path was broken sometime within a year, and we don't think
it's worth to support this more.

BUG=366154

Review URL: https://codereview.chromium.org/317083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275395 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/319943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275630 0039d316-1c4b-4281-b951-d872f2087c98

* Sidenav subnav has a grey bg. 
* Only the article page ToC is sticky when scrolling (not entire sidenav area)
* In ToC, can now click through on h2 headings when there are child h3 headings (previously it would only expand the menu and not go to the anchor link)
* Fixed bug where sidebar overlapped with article body
* Removed misleading mouse pointer cursor on fatnav for non-clickable items.
* Removed -webkit and other prefixes for box shadows and linear gradients
* Added .video-container class so YouTube video will be responsive

BUG=

Review URL: https://codereview.chromium.org/291663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275629 0039d316-1c4b-4281-b951-d872f2087c98

PERF SHERIFFS: This will change all benchmarks that use the typical_25 page set.

BUG=381694
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/314303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381827

Review URL: https://codereview.chromium.org/321613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275624 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug wherein we'd release a scoped_ptr and dereference it in the same line of code.  That worked by luck on some compilers, but failed on OSX, in a way only revealed by tryjobs on a subsequent blink change.

BUG=108012

Review URL: https://codereview.chromium.org/320103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372495
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/317333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275622 0039d316-1c4b-4281-b951-d872f2087c98

This moves the single method CanDecodeOnIOThread on
VideoDecodeAcceleratorImpl to VideoDecodeAccelerator. The
implementations that were subclasses of VideoDecodeAcceleratorImpl now
get an override for CanDecodeOnIOThread that returns false.

TEST=linux desktop build
BUG=380884

Review URL: https://codereview.chromium.org/317083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275621 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, if the browser is still writing the DevToolsActivePort
file when Telemetry attempts to open it, Python will raise an IOError.
Make the Telemetry-side code more robust when reading the file
containing the port.

BUG=372560

Review URL: https://codereview.chromium.org/317163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366154

Review URL: https://codereview.chromium.org/314103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275619 0039d316-1c4b-4281-b951-d872f2087c98

The InMemoryContentStore currently only supports lookup by entry ID, but this
CL adds support for also looking up articles by URLs. This will make the class
more usable for when users manually distill web pages.

BUG=379642

Review URL: https://codereview.chromium.org/314573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275614 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175623:175702&mode=html

TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/319253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275613 0039d316-1c4b-4281-b951-d872f2087c98

"Client" rather than "Delegate" is the canonical name for embedder delegate
interfaces.

Also renames TabAutofillManagerDelegate to ChromeAutofillClient.

BUG=none
TEST=compiles
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/306053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275612 0039d316-1c4b-4281-b951-d872f2087c98

Passing strings rather than arraybuffers to the tty node is still
the only supported way to go, so don't warn about this method
being depreceated just yet :)

R=binji@chromium.org, binji

Review URL: https://codereview.chromium.org/318153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275611 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381703

Review URL: https://codereview.chromium.org/317393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275610 0039d316-1c4b-4281-b951-d872f2087c98

Add an example that nests embedded app, so we have two levels of nesting (and thus two connections).

I realized an error in understanding of ServiceConnection et al and have corrected this with this CL. ViewManager is now instantiated by the synchronizer. For a given app instance there may be N instances of ViewManager, one per unique connection. Code utilizing ViewManager needs to be more careful about which instance they pass.

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/311373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275609 0039d316-1c4b-4281-b951-d872f2087c98

This is just temporary to get the bots green.

TBR=dtu@chromium.org
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/313403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275608 0039d316-1c4b-4281-b951-d872f2087c98

Test plan:

Debug:

$ gn gen out/Debug_gn
$ ninja -C out/Debug_gn aura

Release:

$ gn gen out/Release_gn --args='is_debug=false'
$ ninja -C out/Release_gn aura

Android:

$ gn gen out/Debug_gn --args='os="android" cpu_arch="arm"'
$ ninja -C out/Debug_gn aura

BUG=None
TEST=see above.
R=brettw@chromium.org,scottmg@chromium.org
TBR=ben
NOTRY=true

Review URL: https://codereview.chromium.org/305293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275607 0039d316-1c4b-4281-b951-d872f2087c98

A unit test added.

TBR=vrk@chromium.org

BUG=381873

Review URL: https://codereview.chromium.org/322603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275606 0039d316-1c4b-4281-b951-d872f2087c98

Typo fix; since both instances of the parameter were typoed, this actually did what we wanted it to, because of C++'s variable name shadowing rules.  But it looked really bad.

BUG=381791

Review URL: https://codereview.chromium.org/312093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275605 0039d316-1c4b-4281-b951-d872f2087c98

selection. 
This change adds a check before trying to select 
the window with the enter key that verifies that the 
selection is active. If it is not, pressing it has no 
effect.

BUG=381811
TEST=WindowSelectorTest.SelectWindowWithReturnKey

Review URL: https://codereview.chromium.org/324493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372843

Review URL: https://codereview.chromium.org/323563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275603 0039d316-1c4b-4281-b951-d872f2087c98

Use the frame number from the active tree rather than LTH, since LTH is
on a different thread.

R=danakj@chromium.org
BUG=380895

Review URL: https://codereview.chromium.org/317013008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275602 0039d316-1c4b-4281-b951-d872f2087c98

The new video-decoding PPAPI accepts NALU's for H264 streams.

BUG=281689
TEST=Example in the pending CL for the new PPAPI

Review URL: https://codereview.chromium.org/301243008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275601 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Invert DSF to map from delegated frame to layer space (https://codereview.chromium.org/311253004/)

Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=381982

Original issue's description:
> Invert DSF to map from delegated frame to layer space
> 
> The size of the frame data from a delegated source will not in general match up
> exactly with the delegated layer's bounds. Frame sizes and layer bounds are both
> expressed as integers, but frame sizes are in physical pixels and layer bounds
> are in device-independent pixels. If the device scale is not an integer, there
> may not be an exact mapping between the two spaces. For instance, if the layer
> size is 105 x 211 and the device scale is 1.5, the delegated content is
> responsible for filling 157.5 x 316.5 physical pixels in the final output. This
> isn't really possible so what actually happens is the delegated renderer
> produces a frame with a physical size of 158 x 317 pixels and sends that up to
> the DRLI. To map this frame into physical space, the DRLI should apply the
> inverse of the device scale factor to reflect that the frame covers 105.333 x
> 211.3333 logical pixels.
> 
> Before this patch, DRLI would attempt to scale the frame by (105/158, 211/317)
> resulting in the frame being scaled down non-uniformly to try to make 158 x 317
> pixels fit into a 157.5 x 316.6 space. This scaling looks bad and ends up
> mapping pixels partially outside of the layer's logical bounds into the layer's
> logical bounds.
> 
> BUG=370074
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275544

TBR=enne@chromium.org,danakj@chromium.org,jamesr@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370074,381982

Review URL: https://codereview.chromium.org/313403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275600 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements GATT characteristic properties for
BluetoothRemoteGattCharacteristicChromeOS. Also, a typo in the "Writable
Auxiliaries" property declaration has been fixed.

BUG=362799
TEST=device_unittests, browser_tests

Review URL: https://codereview.chromium.org/307453007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275599 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381990
NOTRY=True
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/318223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275591 0039d316-1c4b-4281-b951-d872f2087c98

It needs the input method system initialized. Use a test input method since app_shell on Linux is just a convenience for developers.

BUG=381852
TEST=app_shell_browsertests

Review URL: https://codereview.chromium.org/314423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275590 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Telemetry] Disable DCHECK crashes in release builds. (https://codereview.chromium.org/322593004/)

Reason for revert:
Did not have the desired effect.

Original issue's description:
> [Telemetry] Disable DCHECK crashes in release builds.
> 
> Telemetry is designed for performance, not functional testing and it is
> currently bearing more of the weight of these failures than the infra can
> handle.
> 
> NOTRY=True
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275580

TBR=dtu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/323643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275588 0039d316-1c4b-4281-b951-d872f2087c98

This change updates the multi-account handling code to make sure the
options parameter object is present before dereferencing it to find
the "account" field. A new browser test calls getAuthToken without
options.

BUG=381637

Review URL: https://codereview.chromium.org/323563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374209

Review URL: https://codereview.chromium.org/318993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275586 0039d316-1c4b-4281-b951-d872f2087c98

See the bug for more details.  Fixes potential stuck playback.

- Separates error callback registration from mixer input addition.
- Removes |mixer_inputs_| in favor of letting AudioConverter manage.
- Adds a new unittest to verify paused inputs receive errors.

This fixes the problem implicitly because AudioRendererImpl will
deliver a decode error which shuts down the pipeline.

BUG=379374
TEST=new unittest.

Review URL: https://codereview.chromium.org/301223012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104711

Review URL: https://codereview.chromium.org/321443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275584 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275583 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Breaks rendering on Android Chrome.

Original issue's description:
> Blink roll r175622:175677
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175623:175677&mode=html
> 
> TBR=peter@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275538

TBR=peter@chromium.org
BUG=381982
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/319183009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275582 0039d316-1c4b-4281-b951-d872f2087c98

We were previously linking in this .obj file which patched the broken
ftol that was causing floating point stack overflows. This is fixed
in VS2013 Update2 and so is no longer required.

https://connect.microsoft.com/VisualStudio/feedback/details/808199

R=cpu@chromium.org
BUG=348525

Review URL: https://codereview.chromium.org/318153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275581 0039d316-1c4b-4281-b951-d872f2087c98