GitLab

Bug: 938836
Change-Id: I389403bd798e1712441acdba149d1941f4881da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506079Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638187}

By default, all commands are accessible. However, once user specifies
session in W3C mode, all JWP commands will return as "Unknown Command".
Other commands such as "unknown origin", "ChromeDriver extentions"
won't be affected by the PR since they are used by Selenium binding
and internal python tests.


Bug: chromedriver:2060
Change-Id: I1e09fd6f06e290f374ffde5bc3507defe9fb52cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504977Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Long Ly <loly@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#638186}

This CL adds code in LayoutSVGImage::WillBeDestroyed to notify
ImageElementTiming, similar to how it's done in LayoutImage. This
should prevent null dereferences in ImageElementTiming.

Bug: 879270
Change-Id: Idac6339b548ae59f971861a76367c082e55ca87c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506100Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638185}

This is a flag guarded feature for sending the screen context as a text
query. For more information, see go/screen-context-dialog.

Bug: b:123037261
Change-Id: Ibf6315450aad2f7ab89b04c37c47684e76be82f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493371
Commit-Queue: Eyor Alemayehu <eyor@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638184}

This patch reintroduces DidCommitProvisionalLoadInterceptor
(removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1455470),
renamed as DidCommitNavigationInterceptor, to work with the new
NavigationClient interface.

It does so by adding an interceptor to the RenderFrameHostImpl, called
directly after entering the callback.

Bug: 784904
Change-Id: I7cbba4e9220017625676c7679c8606ad425712e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477028
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638183}

Bug: 937430
Change-Id: Ibf7ac59bb75ba37c4bfca66bd55211b9cf01071e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492934
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638182}

Suppored on Chrome OS, Linux and Mac OS only.
Related CL:1479962

BUG=chromium:930019
TEST=newly added tests

Change-Id: I51933d47625f4cb19f006dad5218658d0d484280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486331Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638181}

This is a continuation of:
https://chromium-review.googlesource.com/c/chromium/src/+/1503133/5
where the condition before running |MaybeCreateLoaderForResponse| was
removed by mistake. This restores the condition and adds an
explanation about why it is useful.

Bug: 873269
Change-Id: Ieda17fca7baacfeec00468e01eb67332802ee905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505938Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638180}

Bug: 848942
Change-Id: Icf6d930686264edf14970d38f58485c4310f5ecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474750
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638179}

This CL implements the syntax string parser according to the new spec. The
parser operates on the "preprocessed input stream" described by css-syntax,
and while it reuses some algorithms used by the tokenizer, it does not
rely on actual tokens.

Overview of this CL:

 * Added CSSSyntaxStringParser, which can parse the syntax string into
   a CSSSyntaxDescriptor. Usage:
   auto descriptor = CSSSyntaxStringParser("<color>").Parse();
 * The previous syntax string parser functions were mixed together with
   functions for parsing a token stream against a registered syntax, which
   was a little confusing. Hence this CL splits the syntax string parsing
   into a separate class.
 * Moved a few parser algorithms from CSSTokenizer to css_parser_idioms,
   to make them usable without a tokenizer.
 * Unit tests: there is some overlap between the unit tests and WPT.
   However, the unit tests can (and do) check the resulting internal
   structure of the CSSSyntaxDescriptors, so they do add additional value
   over just WPT.

R=futhark@chromium.org, ikilpatrick@chromium.org

Change-Id: I2d671ca0e58cd123a7809a24a4e83aec3883b175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503755Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638178}

Bug: 938589
Change-Id: I400f8421ad95e14f781bc6555dd185898d19faa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506101Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638177}

This flag unleashes changes to how skia blits into colorspace-tagged
surfaces. The gist is that we try harder to stay in the legacy code-paths
(for speed), even though those might differ from the more correct
rasterpipeline path. Thus we can expect to see some image diffs with
this CL, but in general they should be very small.

Change-Id: I2441fe0249d4d358ea5adb844bcdbbeffd3baa07
Bug: skia:8793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496304
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638176}

Bug: 850947
Change-Id: I4745016ce722df5d2664215b16a5ab2a2ab69150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505999
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638175}

This CL reduces the size of each base::Value instance by
carefully controlling the layout of the internal tagged
union declared by the class, i.e.:

- Moving the |is_alive_| field just after the |type_|
  one, and changing their sizes to 24 and 8 bits
  respectively.

- Using a union of anonymous structs to control the
  padding of |double_value_| relative to the start
  of base::Value.

See the technical note in base::Value's declaration for
more details.

This saves 8 bytes on x86, x86_64 and arm64, and
16 bytes (!) on arm.

Comparisons of size/alignment pairs for various data
types:

                      arm     arm64     x86     x86_64
  double              8/8       8/8     8/4        8/4
  std::string        12/4      24/8    12/4       24/8
  ListStorage        12/4      24/8    12/4       24/8
  DictStorage        12/4      24/8    12/4       24/8
  BlobStorage        12/4      24/8    12/4       24/8

  Value (before)     32/8      40/8    20/4       40/8
  Value (this CL)    16/8      32/8    16/4       32/8

+ Add a unit-test to check that we don't regress in the
  future un-intentionally.

BUG=646113
R=dcheng@chromium.org, pasko@chromium.org, lizeb@chromium.org, mattcary@chromium.org, jdoerrie@chromium.org

Change-Id: I46b95f4478cc0a6978968fc1a877b5a92937352c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472716
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638174}

Disable the test on Mac and Win7.

Bug: 938884
Tbr: petewil@chromium.org
Change-Id: I107a836a9473df71ea6b70fe345d1156015fd89a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506005Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638173}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/028b41c5..359fddbf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Icc8a5bc23cf15da1898cebdfad62561a5db7d2a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506092Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638172}

This is to improve build throughput around js2gtest by removing
unnecessary build dependency.
Explanation of empty public is written in
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public

e.g. The number of build target for obj/chrome/test/browser_tests/profile_list_desktop_browsertest.o
reduced from 33553 to 5505 by this CL.

This dependency removal utilizes build parallelism well.

Bug: 937723
Change-Id: Ic92c80f2006578f9f43cc2e5d357809c414adfdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505512
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638171}

Bug: 863341
Change-Id: I81b851dbea17f1756136cde00d491ab750e5475b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494883
Commit-Queue: Karolina Soltys <ksolt@chromium.org>
Reviewed-by: Karolina Soltys <ksolt@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638170}

This will allow to implement the functionality of the policy that forces
the device to reboot on user sign out.

CQ-DEPEND=CL:1458577

Bug: b:77799573
Test: None
Change-Id: Ib01dd38a6db3608ba303ddbde44db5edfb26c629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477120
Commit-Queue: Igor <igorcov@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638169}

The NavigationURLLoader isn't supposed to call the NavigationRequest
anymore after forwarding the URLLoaderClient in OnResponseStarted or
after failing in OnRequestFailed.

This deletes the NavigationURLLoader to ensure the NavigationRequest
won't receives any call anymore after that.

Bug: 936962
Change-Id: I37e3fe6b1b7d9ff74a6e01d49b80a734d9b5a305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503135Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638168}

This reverts commit 6b7213a4.

Reason for revert: This CL will break per-CL coverage gathering without CL 1496002, and that other CL is not ready yet.

Original change's description:
> Adding an exclusion list to the coverage wrapper script.
> 
> The script now assumes GN adds coverage flags to the cflags for each
> source file. The script removes the flag if the file is in an exclusion
> list, or if `--files-to-instrument` is set it will also remove flags if
> the file is not listed in that argument.
> 
> The script supports multiple exclusion lists that can be selected with
> the `--target-os` flag.
> 
> It's expected that GN will set these flags correctly and invoke the
> script in all coverage builds. http://crrev.com/c/1496002 does that.
> 
> 
> Bug: 918215
> Change-Id: I4454f67067a083581f31a22cfef85368825789f9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994
> Commit-Queue: Sajjad Mirza <sajjadm@google.com>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#637892}

TBR=stgao@chromium.org,robertocn@chromium.org,mmoroz@chromium.org,liaoyuke@chromium.org,sajjadm@google.com

Change-Id: I0cadb9c3d3ed0600648e273ffe58e7dc3f6ef7f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504960Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638167}

spelling mistake fix.

TBR=mkwst@chromium.org

Bug: 938916
Change-Id: I16cb9a4ea0c2910fc5f354e541c9999abda76d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506002Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638166}

Bug: 912556
Change-Id: I24f09ad8af0207e9f56af066142965833a603ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505440
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638165}

Bug: 902354, 872096
Change-Id: Ia2d51f0dd702fdc201a35118b19085fd38dc7678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475112Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638164}

It is possible to detect the device's API level from native
code directly, so do it instead of relying on the client
passing the coresponding value through a special global
variable that must be set before anything else is called
in the linker library.

This simplifies the crazy linker API, its implementation
and linker_jni.cc all at the same time.

BUG=NONE
R=agrieve@chromium.org, pasko@chromium.org, cjgrant@chromium.org

Change-Id: I08a6afd82ef0e329957728f6004050bcc04fad18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502972
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638163}

This renames all code and comments referencing high contrast mode
except for the following:
 * Settings in renderer/core/frame/settings.json5. These are
   technically user-visible, so they are better suited to a separate,
   more focused CL that can be rolled back easily if needed. This
   includes the methods used to retrieve their values, since the
   names of those methods are automatically generated from the setting
   names. See https://crrev.com/c/1503904.
 * Calls to Skia code. Skia is a separate library used by projects
   other than Chrome; renaming that code is not feasible and not
   necessarily desirable.

Bug: 938511
Change-Id: I43891fb272fa3501ae31ad5454daf693f4615f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500255
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638162}

This CL adds how the user interacted with the interstitial to the
existing lookalike suggestion UKM. To facilitate this, it defers
recording the UKM event until the user has closed the interstitial (when
interstitials are enabled).

Bug: 936170
Change-Id: I839e18825c8e9007468ddb78791d71e4acb48094
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497337Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638161}

Obsolete the histograms that are unused and consume most data.

Change-Id: I5345039cb9d412a2af93f7cf8c0cc23f6cba659a
Bug: 933226,921869,893419,878206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491137Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638160}

This patch adds some trace information to Display locking to allow
keeping track of display lock state in traces.

R=chrishtr@chromium.org, rakina@chromium.org

Bug: 882663
Change-Id: I1e67370ab06b6eebda6efed0e8e3870cdc4bfc2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504163Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638159}

Setting isAccessibilityElement to YES and adding implementation for
accessibilityLabel for TableViewImageCell.

Bug: 938309
Change-Id: I63e2e204af773706bac26609015c2016fbd8c275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503754Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638158}

This function was added in the below CL.
https://chromium-review.googlesource.com/c/chromium/src/+/1504117

Change-Id: Ic8bd7d02ffcb4662aa1989a3f219b75eb944c2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505992
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638157}

Read the slides :)

Change-Id: Ie57099fdcc10fd6ba5c2d69eba85f552892c917e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504492Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638156}

I will deprecate deps in proto_library for improved build throughput.
And we can use link_deps here instead.

Bug: 938011
Change-Id: I03b3004c549986f302b36142dbf5dc2974bf9631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504482
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638155}

Bug: 853688
Change-Id: Ida7e28f1a6135b5aefde290b0b1e9c7687998d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505553
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638154}

This CL adds the initial URL and the response end from ResourceTiming
into ElementTiming. The information is currently only stored on the
ResourceTimingInfo object which is not accessible to ImageElementTiming
(and in fact, could be gone by the time the ElementTiming code is
executed). Thus, we store the information in ImageResourceContent.

Bug: 879270
Change-Id: I72a80c67956adb6e869f39ca3c77829bad86044e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483733Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638153}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/141258c373d9..0563888d3868


Created with:
  gclient setdep -r src-internal@0563888d3868

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: I09ec1c5e81fb90a9fdef838f0aee2e144146f5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505979Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638152}

- Disable the ability to sign on as a new user when only the "Other User"
tile appears on the sign in screen and the machine is enrolled to
MDM in single user mode and there is already an existing associated
user.
- Merged code to determine how many associated users exist on the system
into the AssociatedUserValidator since the code in reg_utils does not
check if a user really exists on the system.

Bug: 936846
Change-Id: If024dca7c4f5bb87ace389bb8bb6673fa95eb137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497173
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638151}

- Explicitly call out local Sync.
- Prefer SyncUserSettings::IsSyncRequested to checking disable reasons
  on the service.
- Remove some dead code from the end of GetStatusLabelsImpl.
- Fix a bug where the behavior depended on the presence of an output
  parameter.

Bug: 911153
Change-Id: Icaee9dae173e4c64b74ee65e346871c44c1897c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505495Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638150}

Use smart pointers to make the ownership transfer self-documenting.

Change-Id: Ia685023795257c648bfa44637c95e387626ca23a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503626Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638149}

This reverts commit da20fcb9.

All known connection state bugs have been fixed, so let's give this thing another shot.

Bug: chromium:6145
Change-Id: Ied1d4f136ee3c4bbfce73fce12976accfa553601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505533
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638148}