- 13 Jul, 2017 40 commits
-
-
skau authored
The header can be merged with the implementation. Removing the extra file will result in a little less maintenance. This is a pure refactor. No code was changed. BUG=734280 Review-Url: https://codereview.chromium.org/2963173003 Cr-Commit-Position: refs/heads/master@{#486526}
-
Quinten Yearsley authored
This reverts commit a66ebc8a. Reason for revert: Appears to have caused compile failure on Linux x64: https://luci-milo.appspot.com/buildbot/chromium/Linux%20x64/44132 Original change's description: > Persist broken and recently-broken alt-svcs to prefs in HttpServerPropertiesManager > > Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. > Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. > > Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng > > BUG=705029 > > Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 > Reviewed-on: https://chromium-review.googlesource.com/562604 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Yixin Wang <wangyix@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486519} TBR=rch@chromium.org,holte@chromium.org,zhongyi@chromium.org,wangyix@chromium.org Change-Id: I946b3205a67356c0130ef53efbba245a1768d601 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 705029 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/571259Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#486525}
-
Mircea Trofin authored
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/T8r1SrZUEZM Bug: chromium:711083 Change-Id: Ieb9c7b3fcf76d6b13ef0c89d676cecf02b0daa78 Reviewed-on: https://chromium-review.googlesource.com/513531Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#486524}
-
Derek Cheng authored
- Remove message queue / message handling logic from PresentationDispatcher. - Move Send{Text,Binary}Message methods from WebPresentationClient to WebPresentationConnectionProxy. - Remove unused DidReceive*Message methods from WebPresentationController. Note that there is behavior change; previously the sending of a message is blocked on the other side having processed the previous message successfully. This pattern was previously used for control flow purposes and is no longer deemed useful. Bug: 684116 Change-Id: I3589c4c047e7b5c16ff1a92a0d5e72bbf932023f Reviewed-on: https://chromium-review.googlesource.com/563766 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#486523}
-
Kent Tamura authored
Bug: 739091 Change-Id: Ifbc99e569813dfc2c2ae674beee3e1ea0c062666 TBR: keishi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/569838 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#486522}
-
Daniel Murphy authored
See doc for description: https://docs.google.com/document/d/1JC1RgMyxBAjUPSHjm2Bd1KPzcqpPPvxRomKevOkMPm0/edit Bug: 736501 Change-Id: I28d61d66948d7ae2403312489cf246247a3f50b3 Reviewed-on: https://chromium-review.googlesource.com/547016 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#486521}
-
mfomitchev authored
Creating RegisterInProcessServices() in BrowserProcessPlatformPart, and moving the CrOS-specific service registration code from ChromeContentBrowserClient to CrOS BrowserProcessPlatformPart. BUG=722527 Review-Url: https://codereview.chromium.org/2977043002 Cr-Commit-Position: refs/heads/master@{#486520}
-
Yixin Wang authored
Modify TickClock dependency injection for BrokenAlternativeServices to use a setter instead of a constructor param. Add TickClock dependency injection for HttpServerPropertiesImpl and HttpServerPropertiesManager for testing. Add BrokenAlternativeService::Clear() and update HttpServerPropertiesImpl::Clear() to call that. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng BUG=705029 Change-Id: Idb411192e47d275cde3362b479a6b9e9fa773a17 Reviewed-on: https://chromium-review.googlesource.com/562604Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#486519}
-
Zhenyao Mo authored
Reset ES3 pixel pack parameters and PIXEL_PACK_BUFFER binding in DrawingBuffer before ReadPixels() and recover them later. BUG=740603 TEST=new conformance test R=kbr@chromium.org,piman@chromium.org Change-Id: I3ea54c6cc34f34e249f7c8b9f792d93c5e1958f4 Reviewed-on: https://chromium-review.googlesource.com/570840Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#486518}
-
Fernando Serboncini authored
MSC doesn't define SSE, so this wasn't working properly on Windows Bug: 686253 Change-Id: I5e49e9dec43228288261160d8e9eede9b4a6bf75 Reviewed-on: https://chromium-review.googlesource.com/570351 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#486517}
-
Justin Carlson authored
This code was obsoleted with the PrinterDetector interface introduction, and is not referenced (nor even built). It should have been nuked in an earlier change but was overlooked, apparently. Bug: Change-Id: Iba5ca7a61e5e61ab27281ad7525204d8ceefc33c Reviewed-on: https://chromium-review.googlesource.com/570126Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Justin Carlson <justincarlson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486516}
-
Justin Schuh authored
This is a reland of f3a69e04 Bug: 672489 Change-Id: I7f4c6a679ced59e839650f372a3c79bea106534e Reviewed-on: https://chromium-review.googlesource.com/570508 Commit-Queue: Justin Schuh <jschuh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#486515}
-
Erik Chen authored
All projects that need to change the default mac min SDK now directly do so via a GN arg. Bug: chromium:740693 Change-Id: I99f04d482177e6ec8a5d1306f68cb2410b0beb0e Reviewed-on: https://chromium-review.googlesource.com/566078 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486514}
-
Michael van Ouwerkerk authored
Bug: 739664 Change-Id: I158511a9d8ccd85561adc1f59d67ee7f9386d343 Reviewed-on: https://chromium-review.googlesource.com/568818Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#486513}
-
Matt Wolenetz authored
This change adds UseCounter (for publicly visible % of Page Visits statistics) and RAPPOR reporting to help us gauge the frequency of these types of MSE API usages encountered in Chrome usage. Such data may assist subsequent work to clarify the spec, improve our implementation, and potentially deprecate support. "KeyframeTimeGreaterThanDependant" reporting: (Bug 739931) If nonkeyframe's PTS precedes the PTS of the keyframe necessary to decode it, this (in ISO-BMFF terminology) is not SAP Type 1 (though other bytestreams might also encounter this GOP structure, too.) Our buffering mechanism should gracefully handle this type of GOP, but the MSE spec is unclear for how to precisely report resulting buffered ranges and handle buffering/playback of overlaps of these types of streams. "MuxedSequenceMode" reporting: (Bug 737757) If a multitrack SourceBuffer is used in 'sequence' AppendMode, the spec leads to frequently surprising and undesirable results, usually due to automatic timestampOffset updates based on one track after a discontinuity are applied to all tracks. At least bug 739931 may impact current PTS/DTS compliance work tracked by bug 718641. BUG=739931,737757,718641 Change-Id: I4fabb4ae0b389c5ce2eecb361d4b67c6d4874b04 Reviewed-on: https://chromium-review.googlesource.com/567558Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#486512}
-
Khushal authored
Change-Id: I10e8f8bebfc0099e982610dc3a527f282d126cb8 Reviewed-on: https://chromium-review.googlesource.com/569455Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#486511}
-
Jenny Wong authored
There's already a MEDIA_EXPORT on everything else in media/audio/alsa/; this one was missed. BUG=NONE TEST=NONE Change-Id: Ia79046f0cee05b1da12074f0c69e073381644499 Reviewed-on: https://chromium-review.googlesource.com/570938Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Jenny Wong <jyw@chromium.org> Cr-Commit-Position: refs/heads/master@{#486510}
-
mfomitchev authored
When UI Service runs inside the browser process in its own separate thread, there is a few things it needs to do differently: 1. It shouldn't set its Screen as a global singleton. 2. It shouldn't set its ClientNativePixmapFactory as a global singleton. 3. It can't access the ResourceBundle from its own thread - that can only be done from the browser thread. The third point is the source of most of the complexity in this CL. UI Service needs to manipulate the cursor, which is done through the ui::ImageCursors object, which needs to load resources. Since resources can't be loaded on the UI Service's thread, a mechanism is introduced to let the UI Service do this by posting tasks to the browser's thread task runner, which is passed into the UI Service's constructor. This CL doesn't contain browser-side changes to run the UI Service in-process. BUG=722527 Review-Url: https://codereview.chromium.org/2979933002 Cr-Commit-Position: refs/heads/master@{#486509}
-
Wez authored
The FileDescriptorWatcher POSIX wrapper assumes that it is safe to call StopWatchingFileDescriptor() on a MessageLoopForIO::FDWatcher instance from within an FDWatcher event callback. The Fuchsia implementation was incorrectly keeping a record of the asynchronous IO |handle_| for the freshly-ended wait operation, which was causing StopWatchingFileDescriptor to try to re-cancel the already-ended wait. Bug: 741788 Change-Id: Id1572166fcdb166c6be5700ea7e137b486ebaf5d Reviewed-on: https://chromium-review.googlesource.com/569278Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486508}
-
James Cook authored
Always place it in the center of the "root window for new windows", which is the display where the user last interacted with a window. This fixes a regression where the dialog could be centered over a tabbed browser window. It also fixes a couple cases where adding a new Wi-Fi network from the status tray menu on a secondary monitor would open the dialog on the primary monitor. Added some basic test coverage to NetworkConfigView. Bug: 740316 Test: chrome browser_tests. Also manually add a new Wi-Fi network during OOBE, at the login screen, and after login on both primary and secondary displays. Change-Id: I60f2070dea9f39da586c97ff8b178fc34c5fb325 Reviewed-on: https://chromium-review.googlesource.com/569025 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486507}
-
Paul Irish authored
Bug: NONE Change-Id: Id7209e1084e4e493c8773552a753fb6656e83f5c Reviewed-on: https://chromium-review.googlesource.com/542944 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#486506}
-
Theresa Wellington authored
BUG=724695 Change-Id: Ibb733a5ac20664aa4bac20fe41e13ffe1523ffef Reviewed-on: https://chromium-review.googlesource.com/570665Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#486505}
-
Robert Hogan authored
When an inline has relative position we need to apply that to the ellipsis as well. We also need to be able to detect cases where relative position moves the inline so that it requires ellipsis in the first place. This means that we need to look at the layout overflow rather than the linebox edge when deciding if ellipsis is required - this is because the dimensions of the root inline box won't tell us if relative positioning makes it exceed the horizontal bounds. When flexbox applies line clamp it depends on the ellipsis logic to apply an ellipsis even when there's adequate space for the line box. We now make it force that rather than apply it in all cases, because where we're looking at a normal ellipsis we want to ensure we account for relative positioning on the line boxes before deciding to apply an ellipsis on a line box that would otherwise already fit on the line. The final complication to deal with here is cases where relative positioning changes a line box from having an overflow (e.g. text overflowing the left hand side of the box in an rtl flow) to not having an overflow. InlineFlowBox::ComputeOverflow needs to notice when this is happening, so we change it so that the dimensions of the root inline box are not used to initialize its layout overflow because shifting the box subsequently for relative positioning doesn't subtract the overflow they initially create. Bug: 737837 Change-Id: I66c848299a93b2b796f2f831d9237f41aa50e962 Reviewed-on: https://chromium-review.googlesource.com/563625Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#486504}
-
Albert J. Wong authored
This focuses primarily on getting a proof-of-concept working. The architecture for ProfilingProcess being the mojo service as separate from the various ReceiverPipeServers does not make sense. Those should be collapsed in a following CL. Change-Id: Ic851df75550831a50bda6c54da481ae0b32361bb Bug: Reviewed-on: https://chromium-review.googlesource.com/568700Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#486503}
-
Patrick Monette authored
This CL goes over the base/ and chrome/ directory. Bug: 579196 Change-Id: Icc97c5709072e833a62c1e0f75a28f2917d1dd19 Reviewed-on: https://chromium-review.googlesource.com/565962 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#486502}
-
Benjamin Pastene authored
Both with 8 shards and 16min timeout. Example release shard: https://chromium-swarm.appspot.com/task?id=375199b32dd47210 Example debug shard: https://chromium-swarm.appspot.com/task?id=37519aa55a5dae10 Will move some *-b4 bots over to the 1-device pool if necessary. Bug: 670879 Change-Id: I3b49ba2c34f37bc3ad2d283294d41e5dce4949d7 Reviewed-on: https://chromium-review.googlesource.com/569004Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yoland Yan <yolandyan@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#486501}
-
Daniel Murphy authored
R: jsbell@chromium.org Bug: 742503 Change-Id: I57bb42b891840c4100956f264e1dd19c4b2b1e8e Reviewed-on: https://chromium-review.googlesource.com/570951 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#486500}
-
Daniel Cheng authored
This will be superseded by base::ScopedPlatformFile, which is strictly target at files. base::ScopedPlatformHandle was originally going to support other types of scoped platform handles (such as Mach ports), but that was dropped due to the additional complexity it would incur. Change-Id: I3ec8324ce842aca3f64670b630255717ec6bbda0 Reviewed-on: https://chromium-review.googlesource.com/570599Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#486499}
-
Yash Malik authored
The data_deps require android, which cause a failure when running gn args for vr_common_unittests on linux. Bug: Change-Id: I7b44d0e62ada06b64ce50341ea46378c612b142e Reviewed-on: https://chromium-review.googlesource.com/568462Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#486498}
-
Scott Violet authored
Ash may recycle a WindowTreeHost for a different display. This means overriding OnDisplayAdded() and looking up a root window may result in getting a root already seen. Fix this by converting to ShellObserver::OnRootWindowAdded() which doesn't suffer from this problem. BUG=740589 TEST=none (this code is only used in non-production code) Change-Id: Ic4accf920cedfe0f6c9c3b2ce2ed27c7bf2a9f37 Reviewed-on: https://chromium-review.googlesource.com/570777Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#486497}
-
Yuwei Huang authored
Adding a first launch view to be shown when the user is not signed in. The view will also kick in if the user signs out. Bug: 741842 Change-Id: Ib80df93df428f9923834573b19f10cc4f973f42e Reviewed-on: https://chromium-review.googlesource.com/568858 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#486496}
-
Evan Stade authored
icons in a different size. Bug: 733301 Change-Id: Idf325b1849ef8cad471044c26b449fa9cbfbb5e0 Reviewed-on: https://chromium-review.googlesource.com/567206Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#486495}
-
Min Qin authored
For sucessfully downloaded items, add extras for origin and referrer when launching activities. This allows the security team to analyze malware data. see b/63351122 TBR=mdjones@chromium.org Bug: Change-Id: I9fb7d1df6fdce8bf6803723555270c7f36ac0637 Reviewed-on: https://chromium-review.googlesource.com/565653 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#486494}
-
Fady Samuel authored
This CL moves FrameSinkManager, FrameSinkManagerClient and FrameSinkManager's unittests to components/viz/service/frame_sinks. The rest of this CL updates includes, forward declarations, and namespaces. Note that there is confusion between cc::mojom::FrameSinkManager and viz::FrameSinkManager at the momenet and so viz:: needs to be used in FrameSinkManagerImpl to disambiguate. TBR=reveman@chromium.org Bug: 722935 Change-Id: I4497699fe7e3654d1562781263f836d983af2d2b Reviewed-on: https://chromium-review.googlesource.com/570000 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486493}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/3ec7568..c5af8ba BUG= TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie7d3864d6d00c4e6af2e3e61b54c05f40dddbe43 Reviewed-on: https://chromium-review.googlesource.com/570946Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#486492}
-
Emil A Eklund authored
Remove the ImagePaintContext class now that ImageQualityController is no more and move the remaining mask and blending logic into PaintFillLayer. Break out tiled image painting and text box painting from PaintFillLayer in to PaintFillLayerBackground & PaintFillLayerTextFillBox respectively. Share border rect logic between PaintFillLayer and PaintFastBottomLayer. Change-Id: Ie77fa832964941e2fee4732824db54042c9b47af Reviewed-on: https://chromium-review.googlesource.com/565024Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#486491}
-
Brian White authored
These are known offenders of the UMA.NegativeSamples.Histogram metric. https://bugs.chromium.org/p/chromium/issues/detail?id=739925 Bug: 682680,739925 Change-Id: Ie3e394baf5e1dfb2cf8f1028c5273c0a3d19ab4a Reviewed-on: https://chromium-review.googlesource.com/570262Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#486490}
-
Collin Baker authored
Bug: Change-Id: I376d927b3389c436611f924e1c324a7c38eecc5b Reviewed-on: https://chromium-review.googlesource.com/570125Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Collin Baker <collinbaker@google.com> Cr-Commit-Position: refs/heads/master@{#486489}
-
Fernando Serboncini authored
This is needed because PPAPI uses Platform without Core, so font names aren't initialized properly there. Bug: 742311 Change-Id: Ia0c89ffa9391759b54a73ec0d020ff437343e7a3 Reviewed-on: https://chromium-review.googlesource.com/570661Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#486488}
-
Siddhartha authored
This reverts commit 7e3d0c03. Reason for revert: The race was on second dump and shutdown. 1. The main thread starts a dump. Posts task on WP2 first for MPD1. 2. WP2-thread posts task to itself for MDP2. 3. WP2-thread posts task to WP1 for MDP1. At this point, WP2-thread is waiting on WP1 to create a new thread. 4. The test finishes with WP1-thread finalizing the dump, main thread returns. 5. The MDM destructor decides to delete it's reference to the task runner (MDPInfo). This clears the WP1 first. Step 5 calls WP1 destructor which calls thread destructor. The thread in Step 3 comes back to life and tries to check if the new thread has been created in WP1. MDM should not destroy the task runner when PostTask is not done. So, hold a reference in SetupNextMemoryDump(). Original change's description: > Revert "memory-infra: Move TracingObserver to service/" > > This reverts commit 15617f0b. > > Reason for revert: > https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20TSan%20Tests/builds/8765 > > base_unittest MemoryDumpManagerTest.PostTaskForSequencedTaskRunner is crashing due to the data race. > > Original change's description: > > memory-infra: Move TracingObserver to service/ > > > > The memory tracing observer along with peak detector and periodic > > scheduler should live in service/resource_coordinator since the peak > > detector needs to know about the OS dump providers. > > The tests were moved in previous CL. > > > > BUG=728199 > > > > Change-Id: Ib4934421d1d057fd7d062258179f17d3ca8209f7 > > Reviewed-on: https://chromium-review.googlesource.com/554280 > > Commit-Queue: Primiano Tucci <primiano@chromium.org> > > Reviewed-by: Helen Li <xunjieli@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Primiano Tucci <primiano@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#485968} > > TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org > > Change-Id: Iea202e6099216cb8ccad38d6f0d5354ea82643fe > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 728199 > Reviewed-on: https://chromium-review.googlesource.com/568401 > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486014} TBR=dcheng@chromium.org,primiano@chromium.org,dpranke@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org,hongchan@chromium.org Change-Id: Ic58718b4d4497f9cb28cb2962deb653b45f2f6da Bug: 728199 Reviewed-on: https://chromium-review.googlesource.com/568402 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#486487}
-