GitLab

A 2MB+ regression was introduced but a cause cannot be identified.

https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-xp&tests=sizes%2Fmini_installer.exe&checked=mini_installer.exe&rev=294272

BUG=413191
NOTRY=true
TBR=weitaosu,engedy

Review URL: https://codereview.chromium.org/569453002

Cr-Commit-Position: refs/heads/master@{#294512}

According to crbug.com/412186, there is some incorrect handle management in
NaClProcessHost. It's much easier to use base::File to manage closing the
socket handles, and it cleans up some weirdness with directly using NaClHandle
as well.

BUG=412186

Review URL: https://codereview.chromium.org/552183004

Cr-Commit-Position: refs/heads/master@{#294511}

BUG=314889

Review URL: https://codereview.chromium.org/557393003

Cr-Commit-Position: refs/heads/master@{#294510}

BUG=

Review URL: https://codereview.chromium.org/566753002

Cr-Commit-Position: refs/heads/master@{#294509}

[Findit] [Findit] Remove usage of sys.exit(0) because it still causes exception stack in clusterfuzz.

NOTRY=true

Review URL: https://codereview.chromium.org/561353002

Cr-Commit-Position: refs/heads/master@{#294508}

This typo could cause a false negative when we use
EXPECT_FILE_READ(kSuccess, NULL, 0)

This CL fixes the typo and all tests are still passing.

Review URL: https://codereview.chromium.org/562833002

Cr-Commit-Position: refs/heads/master@{#294507}

BUG=None

Review URL: https://codereview.chromium.org/555983002

Cr-Commit-Position: refs/heads/master@{#294506}

If the user initiates an app install via the app launcher, it is
possible to close the install dialog by clicking on the background.
The app launcher window and modal dialog are destroyed without
cancelling the dialog, therefore keeping the install active.

This patch ensures that ExtensionInstallPrompt::Delegate::
InstallUIAbort() is called in this scenario to allow the delegate
(WebstoreStandaloneInstaller) to abort the install.

BUG=409616
TEST=browser_tests

Review URL: https://codereview.chromium.org/547253002

Cr-Commit-Position: refs/heads/master@{#294505}

Just some additional code cleanup in preparation for adding a separate
requestor for carrier info and other remaining non ONC data.

BUG=279351

Review URL: https://codereview.chromium.org/563553004

Cr-Commit-Position: refs/heads/master@{#294504}

Followup to 475113005, use OVERRIDE macro instead of using override
directly.

Review URL: https://codereview.chromium.org/560353003

Cr-Commit-Position: refs/heads/master@{#294503}

Instead of manually constructing base::Value for event invocation, we should
use code generated from IDL just designed for that.

TEST=browser_test, unit_tests: *FileSystemProvider*
BUG=403673

Review URL: https://codereview.chromium.org/547313002

Cr-Commit-Position: refs/heads/master@{#294502}

This converts the view manager protocol over to specify view contents via
surfaces instead of shuffling a bitmap. To ease the transition, this provides a
wrapper in the client library that accepts an SkBitmap and uploads it into a
texture wrapped in a surface so existing code still works. Next I'll port the
clients over to providing surfaces themselves and remove this shim.

BUG=

Review URL: https://codereview.chromium.org/534843002

Cr-Commit-Position: refs/heads/master@{#294501}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/556263005

Cr-Commit-Position: refs/heads/master@{#294500}

This CL is a second CL to move mock URLRequestJob files
from content/test/net/ to net/test/url_request/. The first
CL is crrev.com/541743002. The reason for this refactoring
is that Cronet (go/cronet) will need to use url_request_failed_job
and url_request_mock_http_job for testing. It will be nice
if they can be in net/test, as Cronet wouldn't need to depend
on content.

BUG=

Review URL: https://codereview.chromium.org/567563002

Cr-Commit-Position: refs/heads/master@{#294499}

Extract the handling of the clean exit beacon from MetricsService. The extracted implementation supports the use of a backup storage location and reports consistency between the two locations.

BUG=412398

Review URL: https://codereview.chromium.org/558683002

Cr-Commit-Position: refs/heads/master@{#294498}

Also fix the type of death messages expected in these tests.

BUG=398611

Review URL: https://codereview.chromium.org/563913002

Cr-Commit-Position: refs/heads/master@{#294497}

https://chromium.googlesource.com/chromium/blink/+log/a1f6307669c32a40076d299272d220343ff74bb9..a6d61dbff0a4bce30fce5b29c2efb77a94ddc3ee
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/567803003

Cr-Commit-Position: refs/heads/master@{#294496}

Give the delegate class an ExtensionOptionsGuest member so that the
calls to the delegate do not require passing a WebContents.

BUG=409316

Review URL: https://codereview.chromium.org/562353002

Cr-Commit-Position: refs/heads/master@{#294495}

the request with a URLRequestRedirectJob. This is used by HSTS, the extension
webRequest API and protocol handlers.

These redirects are trusted and must be followed. However when such redirects are
triggered  for a cross-origin resource, e.g. <img src=".." crossorigin="anonymous">,
Blink blocks the redirect because the Access-Control-Allow-{Origin,Credentials}
response headers are missing.
This CL adds these headers to fix the problem.

Adding these CORS headers to the redirect response is safe, because CORS is still
enforced at the redirect target. For example, if HSTS is active for google.com and
an evil page embeds <img src="http://google.com/" crossorigin="use-credentials">,
then the image is not displayed because google.com does not reply with
"Access-Control-Allow-Origin: null".

BUG=387198
TEST=ExtensionWebRequestApiTest.WebRequestBlocking, HTTPSRequestTest.HSTSCrossOriginAddHeaders

Review URL: https://codereview.chromium.org/348253002

Cr-Commit-Position: refs/heads/master@{#294494}

* Move socket_permission_unittest.cc and usb_device_permission_unittest.cc
  into src/extensions -- they have no src/chrome dependencies.
* Move permissions_data_unittest.cc back into src/chrome -- its tests rely on
  extension manifest keys that aren't part of src/extensions yet.
* Rename the latter tests to PermissionsDataTest

BUG=397165
TEST=unit_tests PermissionsDataTest.* and extensions_unittests

Review URL: https://codereview.chromium.org/563663002

Cr-Commit-Position: refs/heads/master@{#294493}

Cr-Commit-Position: refs/heads/master@{#294492}

Apply WebUI styles to extension options pages that opt into using them
through a user agent stylesheet. The styles are copied from widgets.css
and chrome_shared.css in ui/webui/resources/css/ - this is intentional
so that WebUI changes won't break extensions.

The extension.css stylesheet will only be applied to extensions that
opt in using the "options_ui.chrome_style" manifest entry, and it will
only affect the options page specified in the manifest. The font
stylesheet for extensions have been moved to extension_fonts.css, and
are still applied to every extension page.

BUG=408271

Review URL: https://codereview.chromium.org/537773003

Cr-Commit-Position: refs/heads/master@{#294491}

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/566713004

Cr-Commit-Position: refs/heads/master@{#294490}

- Don't remove -fno-ident from gyp build (was added about 3y ago, seemingly unnecessary for current clang)
- Add -fno-slp-vectorize to GN to make builds match (both to be removed after next clang roll)
- Make usage of -Wno-reserved-user-defined-literal match (required for dbus pre-trusty)
- Add -march=x86-64 to gn cflags
- Default symbol_level based on is_debug, and turn it off by default in Release (same as gyp)

Also, fiddle with output of gyp_flag_compare.py.

R=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/562383002

Cr-Commit-Position: refs/heads/master@{#294489}

Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory. (patchset #5 id:100001 of https://codereview.chromium.org/551173004/)

Reason for revert:
Failed to compile on android builder.

http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/46485

In file included from ../../remoting/protocol/pseudotcp_channel_factory.h:11:0,
                 from ../../remoting/protocol/pseudotcp_channel_factory.cc:5:
../../remoting/protocol/stream_channel_factory.h:34:41:error: 'string' in namespace 'std' does not name a type
   virtual void CreateChannel(const std::string& name,
                                         ^
../../remoting/protocol/stream_channel_factory.h:40:49:error: 'string' in namespace 'std' does not name a type
   virtual void CancelChannelCreation(const std::string& name) = 0;
...

Original issue's description:
> Move PseudoTCP and channel auth out of LibjingleTransportFactory.
>
> Previously TransportFactory interface was responsible for creation
> and initialization of several protocol layers, including PseudoTCP and
> authentication (TLS). Simplified it so now it only creates raw datagram
> transport channel. PseudoTcpChannelFactory is now responsible for
> setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
> of channel authentication. Also added DatagramChannelFactory for
> Datagram channels.
>
> This change will make it possible to replace PseudoTcpChannelFactory
> with an object that creates SCTP-based channels.
>
> Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
> properly when deleted from the callback. (base::Callback objects
> shouldn't be deleted while being called because when deleted they
> also destroy reference parameters values they are holding).
>
> BUG=402993
>
> Committed: https://crrev.com/28d886c967e016a5d5812be43cd5916f577c2e10
> Cr-Commit-Position: refs/heads/master@{#294474}

TBR=wez@chromium.org,sergeyu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402993

Review URL: https://codereview.chromium.org/570463002

Cr-Commit-Position: refs/heads/master@{#294488}

This was not included, but was referenced by ps_main.c

BUG=none
R=sbc@google.com, sbc@chromium.org, noelallen@chromium.org

Review URL: https://codereview.chromium.org/563863003

Cr-Commit-Position: refs/heads/master@{#294487}

Allow sigaltstack on Android as it is needed for thread creation.
On AARCH64, we now restrict setpriority() like on any architecture.

BUG=398611

Review URL: https://codereview.chromium.org/568533002

Cr-Commit-Position: refs/heads/master@{#294486}

If interactive_ui_tests can't change the foreground window, print the name of the Window that is currently in the front.

This helps debug problems on bots.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/566723002

Cr-Commit-Position: refs/heads/master@{#294485}

Create a standalone executable that plumbs public Mojo API calls into a NaCl
sandbox.  This allows the public Mojo unit tests to run inside NaCl.

BUG=401761

Review URL: https://codereview.chromium.org/385983008

Cr-Commit-Position: refs/heads/master@{#294484}

Some Linux drivers implement the GLX_SGI_video_sync
extension in a way that eats a ton of CPU resources.
Only call it periodically to reduce CPU usage.

BUG=373489

Review URL: https://codereview.chromium.org/566663002

Cr-Commit-Position: refs/heads/master@{#294483}

https://skia.googlesource.com/skia/+log/790ffe3feb90370318f42b28eb9c6af6e38cd4f9..0b36e6b65f8c124f2ef2601294288219b3c3a1f0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/563013002

Cr-Commit-Position: refs/heads/master@{#294482}

When changing from software mirroring mode to sinlge display mode, it
is possible there is no need to update |displays_| and we early out
UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange()
cause there are some clients need to act on this, e.g.
TouchTransformerController needs to adjust the TouchTransformer when
switching from dual displays to single display.

BUG=chrome-os-partner:31868
TEST=tested on Big, after existing software mirroring mode, the touch location
     transformation is still correct.

Review URL: https://codereview.chromium.org/559213002

Cr-Commit-Position: refs/heads/master@{#294481}

Revert of Remove a broken link. (patchset #2 id:20001 of https://codereview.chromium.org/546713003/)

Reason for revert:
I found the link I thought didn't exist.

Original issue's description:
> Remove a broken link.
>
> BUG=none
> R=
> TEST=none
> NOTRY=true
> (documentation only change)
>
> Committed: https://crrev.com/3b9f3449861b9bfc196a152a2c74f6e7cdd18ef1
> Cr-Commit-Position: refs/heads/master@{#294234}

TBR=mkearney@chromium.org,smain@chromium.org,jfb@chromium.org,sbc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/560423002

Cr-Commit-Position: refs/heads/master@{#294480}

This brings in:
  12a9940 Check object type for objects used in the dictory of 'Index'
  9175bee Change the forced clear order of CPDF_DocPageData::Clear, and remove m_pDocument in CPDF_Color
  663af99 Fix uninitialized value in CPDF_ColorStateData
  6eee264 Revert of Fix uninitialized value in CPDF_ColorStateData
  a38d4c3 Fix uninitialized value in CPDF_ColorStateData
  0fb1b3d Fix un-initialized R G B value

TBR=inferno@chromium.org

Review URL: https://codereview.chromium.org/560403002

Cr-Commit-Position: refs/heads/master@{#294479}

Choose to put the UMA reporting code in content_decryptor_delegate.cc because:
- It's hard to do UMA in CdmAdapter due to pp::UMAPrivate limitations.
- I want to report system code for OnPromiseRejected() and OnSessionError() in
  one file. So I can't do it in CdmPromise.

BUG=412987
TEST=Tested by hacking Chromium to provide a wrong license. Then check about://histograms and I see the histogram generated.

Review URL: https://codereview.chromium.org/561643002

Cr-Commit-Position: refs/heads/master@{#294478}

BUG=406064

Review URL: https://codereview.chromium.org/558503005

Cr-Commit-Position: refs/heads/master@{#294477}

R=byungchul@chromium.org,lcwu@chromium.org,yfriedman@chromium.org
BUG=400876

Review URL: https://codereview.chromium.org/490603002

Cr-Commit-Position: refs/heads/master@{#294476}

WebCacheManager::ClearCacheOnNavigation() is used by webrequest api, which will be moved to //extensions. So we need to resolve its the dependency on WebCacheManager by moving WebCacheManager to //components.

There are two ipc messages sent in WebCacheManger:
-ChromeViewMsg_SetCacheCapacities
-ChromeViewMsg_ClearCache

Both ipc handlers were in ChromeRenderProcessObserver. These two ipcs are renamed as WebCacheMsg_XXX, and we introduce WebCacheRenderProcessObserver and handle these ipcs in //components.

BUG=352293,411437
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/528363002

Cr-Commit-Position: refs/heads/master@{#294475}

Previously TransportFactory interface was responsible for creation
and initialization of several protocol layers, including PseudoTCP and
authentication (TLS). Simplified it so now it only creates raw datagram
transport channel. PseudoTcpChannelFactory is now responsible for
setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
of channel authentication. Also added DatagramChannelFactory for
Datagram channels.

This change will make it possible to replace PseudoTcpChannelFactory
with an object that creates SCTP-based channels.

Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
properly when deleted from the callback. (base::Callback objects
shouldn't be deleted while being called because when deleted they
also destroy reference parameters values they are holding).

BUG=402993

Review URL: https://codereview.chromium.org/551173004

Cr-Commit-Position: refs/heads/master@{#294474}

Cr-Commit-Position: refs/heads/master@{#294473}