GitLab

Bug: 745939
Change-Id: Iba676c4a1dec33473f067a0bdf4074dc6b15c435
Reviewed-on: https://chromium-review.googlesource.com/577011
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488050}

Recently chrome://inspect started to open USB devices multiple times
while probing for ADB devices. On Chrome OS this causes a problem
because the permission_broker will disconnect the previous connection in
favor of the new connection. This caused an endless cycle of connection
failures.

This patch maintains a list of the devices that are currently open and
refused to reopen them during probing until the previous connection is
fully closed.

Bug: 725320
Change-Id: Id9b01d8d14c55ee2576499e2f1c778fea6c7dedc
Reviewed-on: https://chromium-review.googlesource.com/572300
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488049}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1761b6a028616327aa54efcff14b6df1e0761687

TBR=ericrk@chromium.org

Change-Id: I1761b6a028616327aa54efcff14b6df1e0761687
Reviewed-on: https://chromium-review.googlesource.com/578499Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488048}

Bug: 695304
Change-Id: I15980a86da734d08b783807efa722460ac75e29e
Reviewed-on: https://chromium-review.googlesource.com/576467Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488047}

In order to add serialization for PaintFlags internals, store the
SkPaint internals directly in PaintFlags instead of storing in
an SkPaint itself.

Bug: 737629
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I865752e0adc709595e0d3ed079d3158f5fb17084
Reviewed-on: https://chromium-review.googlesource.com/575511Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488046}

 * Order event files from oldest to newest
 * Remove the --num_files switch
 * Don't fail if end_netlog.json is missing (since it probably will be
   when using this)

Bug: 744815
Change-Id: I26307d3c293eb445b7e3456d6b359f8ef05a0204
Reviewed-on: https://chromium-review.googlesource.com/578484
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488045}

Version 0.8.32.0
  [0cc169a1af] Fix some VS2017 issues, adds support for the 10.0.15063.468 Windows
               SDK.
  [e94470d3ee] Adds the afl instrumenter.

Bug: 705133
Change-Id: If22afa4cdbb45ff25adee5fab614208eb6321c69
Reviewed-on: https://chromium-review.googlesource.com/577378Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488044}

Bug: 742641
Change-Id: Id786af8e12352e6a01f63fd52235f48c167571e5
Reviewed-on: https://chromium-review.googlesource.com/578323Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488043}

BUG=695285,280619

Review-Url: https://codereview.chromium.org/2950203002
Cr-Commit-Position: refs/heads/master@{#488042}

Using wpt-import in Chromium 7e56993a.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/343

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
dom-dev@chromium.org:
  external/wpt/html
hta@chromium.org:
  external/wpt/webrtc

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I93912b916565eb161a315737accd5e5291efaace
Reviewed-on: https://chromium-review.googlesource.com/577920
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488041}

Related to https://chromium-review.googlesource.com/c/575022, some of the added icons there are different size than the rest (20 vs. 16 for 1x). Revert those changes for now as they will cause a paint vector icon crash. New icons with the right size have been added.

Test: manual
Bug: 742524
Change-Id: I9d76ecb60b5cff8eec33b84670f345d1efc000a7
Reviewed-on: https://chromium-review.googlesource.com/577061
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488040}

fileSystem's "default_parent" entry has the same fields as some of its
children, so those children's fields don't need to be manually specified.

See chrome/common/extensions/api/_features.md and crrev.com/2939833002.

Bug: 729713
Change-Id: I1eed160c01fb139d1c1b75217e10a343a6308f24
Reviewed-on: https://chromium-review.googlesource.com/575912
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488039}

This CL ensures that it won't be possible for
"RTCPeerConnection.iceGatheringState" to return a new value until the
"icegatheringstatechange" event has been dispatched. This is something
the WebRTC specification guarantees.

This was previously fixed for iceConnectionState:
https://codereview.chromium.org/1523213002

This CL extends that logic to iceGatheringState.

This CL also ensures that the special "null" candidate (used
as another indication that gathering is complete) is emitted
at the proper time. To do this, the responsibility for creating this
special candidate is moved from the content layer to the Blink layer.

Lastly, this CL updates the "setConfiguration" test, resolving a TODO.

Bug: 742859
Change-Id: I55fb605913314ff5e780fa3ca30112180bdc7f37
Reviewed-on: https://chromium-review.googlesource.com/575849
Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488038}

R=rockot@chromium.org

Change-Id: I08ac6c9832663af5145fb6939677601eb3ceb7f0
Reviewed-on: https://chromium-review.googlesource.com/576548
Commit-Queue: Ben Goodger <ben@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488037}

Move LineContext to FlexLayoutAlgorithm.h and rename it to FlexLine
to be more clear on what it represents. This change also now uses
that struct as the out parameter for ComputeNextFlexLine, replacing
several individual variables.

This will enable moving more functionality to FlexLayoutAlgorithm with
the ultimate goal (besides making the code easier to understand) of
reusing it for LayoutNG.

R=eae@chromium.org

Change-Id: I1cc1f9a9090fbb7d3a3c10537133c698f875a01d
Reviewed-on: https://chromium-review.googlesource.com/576893
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488036}

[refactor] - Rename and Move WebWidget::CaretOrSelectionRange to WebInputMethodController::GetSelectionOffsets

Reasons for move:
1- This is a frame concept given (the two nontrivial calls are from
   render_frame_impl.cc and frame_input_handler_impl.cc).

2- It cleans up WebViewImpl/WebFrameWidgetImpl (and helps with the split)

3- The logic is simply calling the corresponding method on
   InputMethodController of the focused LocalFrame.

4- Jumping from RenderFrameImpl to RenderWidget for getting selection is futile
   and expecting a focused frame is incorrect. Note that
   GestureManager::HandleGestureLongPress first passes the hit test result to
   SelectionController and then to MouseEventManager where the former generates
   selection updates and the latter updates frame focus. Therefore, right now,
   long pressing text on an unfocused OOPIF will lead to an empty selection
   update which is incorrect.

Reason for rename:
1- The method calls GetSelectionOffsets on InputMethodController (core) and it
   makes sense to make the wrapper variant have the same name.

  This CL also adds a small change to TextSelectionControllerClientChildFrame
to use selection range instead of selection bounds (now that the update is
fixed after the refactor).

BUG=629721, 723790

Review-Url: https://codereview.chromium.org/2910223003
Cr-Commit-Position: refs/heads/master@{#488035}

Reland of acab8963, with test fix to
wait until time changes to RegisterExtraSyntheticTrial, so that it
doesn't flakily get collected into the proto.

TBR=olivierrobin

Bug: 507665
Change-Id: I735ec46b29611899090ccfc6af6df058e34762dd
Reviewed-on: https://chromium-review.googlesource.com/578087
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488034}

Also change section metrics from CreditCards to PaymentMethod
(Now include payment apps). Which removes the need for the
hadInitialFormOfPayment metrics.

Bug: 740546
Change-Id: If2e67b66e4c309654ae1ade64d51f1d070e13d1a
Reviewed-on: https://chromium-review.googlesource.com/565340Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488033}

This reverts commit c8bf13e0.

Reason for revert: It broke compile on a bunch of ChromiumOS bots, e.g. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full

Original change's description:
> reland: shelf: Add a back button to the shelf.
> 
> This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details.
> This approach of adding a back button expands the current app list button to be modal and have two functionalities
> depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what
> is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The
> exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the
> meantime.
> 
> Screenshots:
> https://screenshot.googleplex.com/ZVNP0aq0cc3
> https://screenshot.googleplex.com/fDcGTuoyZg5
> https://screenshot.googleplex.com/ZFBzk72LLVt
> 
> Test: ash_unittests --gtest_filter="AppListButtonInkDropTest.*"
> Bug: 721940
> Change-Id: I691c9fc15294d48a7a0da88ba78550e013d9b869
> Reviewed-on: https://chromium-review.googlesource.com/572434
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#487491}
> Reviewed-on: https://chromium-review.googlesource.com/576656
> Cr-Commit-Position: refs/heads/master@{#488025}

TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org

Change-Id: Ia137671938e7b2110c5cef0bd04fee4ecd46e232
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 721940
Reviewed-on: https://chromium-review.googlesource.com/578611Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488032}

+ Make DateDividedAdapter support multiple header items so that
  privacy disclaimers and clear browsing data button can be seperate
  items in recycler view to support show/hide animation.
+ Hide info button when info header is not visible on scrolling down
  in both history and downloads.
+ Remove header when history items are all deleted.

BUG=689322

Change-Id: Idbcae648ba277eb82b87bbe5a0667373bb09fc1a
Reviewed-on: https://chromium-review.googlesource.com/560672
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488031}

This was previously landed in:
https://chromium-review.googlesource.com/c/562018/

but was reverted in:
https://chromium-review.googlesource.com/c/574547/

due to a a Clusterfuzz bug. Turns out that calling UnregisterScrollbar
can erase the references we're holding in scrollbar_ids and
scrollbar_layer_id so we have to refresh those.

Bug: 739738
Change-Id: Ic80018212b1370be6a33a39add19da6848b59fb6
Reviewed-on: https://chromium-review.googlesource.com/578428Reviewed-by: Weiliang Chen <weiliangc@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488030}

Safebrowsing checks can be prevented for certain domains by passing
these domains via a whitelisting API. This code lands the plumbing for
using that whitelisting code.

Bug: 726770
Change-Id: I3e6278afb4900929bef6d05e81fae34529fe920e
Reviewed-on: https://chromium-review.googlesource.com/577921Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Selim Gurun <sgurun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488029}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5f09d557a14b..7de63c29970b

$ git log 5f09d557a..7de63c299 --date=short --no-merges --format='%ad %ae %s'
2017-07-19 benjhayden Draw hoverable dots in line charts.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1439fd1b888e6e2a32c4f02b641800232673a4d0
Reviewed-on: https://chromium-review.googlesource.com/578473
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488028}

Refactor the DiscardableSharedMemory implementation to put platform-
native discardable page management in separate LockPages/UnlockPages
functions.

This isolates the platform-specific calls from internal details of the
DiscardableSharedMemory implementation, in particular the need to allow
for the space occupied by the SharedState structure.

Also corrects "lock page" platform API errors to return FAILED rather
than PURGED result, and adds some DCHECKing for "unlock page" API
errors.

Bug: 716205
Change-Id: I572d65a0304816305053669ec81c78a3461d8325
Reviewed-on: https://chromium-review.googlesource.com/574901
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488027}

Moved all files related to old harness to inspector-protocol/css.

BUG=734762

Change-Id: Iee40b4f40ebd4e594e99e6ce1ce00b44e899e316
Reviewed-on: https://chromium-review.googlesource.com/576949
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488026}

This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details.
This approach of adding a back button expands the current app list button to be modal and have two functionalities
depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what
is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The
exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the
meantime.

Screenshots:
https://screenshot.googleplex.com/ZVNP0aq0cc3
https://screenshot.googleplex.com/fDcGTuoyZg5
https://screenshot.googleplex.com/ZFBzk72LLVt

Test: ash_unittests --gtest_filter="AppListButtonInkDropTest.*"
Bug: 721940
Change-Id: I691c9fc15294d48a7a0da88ba78550e013d9b869
Reviewed-on: https://chromium-review.googlesource.com/572434
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487491}
Reviewed-on: https://chromium-review.googlesource.com/576656
Cr-Commit-Position: refs/heads/master@{#488025}

This string is going to be used as a label for a checkbox that allows
triggering a TPM firmware update from the device reset (aka powerwash)
screen.

BUG=chromium:742985
TEST=None

Change-Id: I7079808dfb49959b60311aa0ced360ab604d1d61
Reviewed-on: https://chromium-review.googlesource.com/577854
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488024}

VR Shell needs to set a landscape orientation as part of the contract
with GVR. Currently ScreenOrientationProvider also sets the activities'
orientation in some situations, such as fullscreen video playback.
This leads to conflicts where a fullscreen video starts playing in VR
and then the orientation is no-longer locked to landscape.

This fix is to disable any other code from setting orientation
preferences while in VR.  Unlocking orientation will update the orientation
that VR will restore to.

BUG=736942

Change-Id: I3c52c6c3c2673eec5f9bdf091e3e8da70198df3a
Reviewed-on: https://chromium-review.googlesource.com/571099Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488023}

https://pdfium.googlesource.com/pdfium.git/+log/4442d453f570..67ccef73bf66

$ git log 4442d453f..67ccef73b --date=short --no-merges --format='%ad %ae %s'
2017-07-19 janeliulwq Use CFX_WideString in CPDF_NameTree functions to strip BOM
2017-07-19 hnakashima Converting CFX_ByteTextBuf to ostringstream in SAX.
2017-07-19 caryclark flush skia cache in progressive rendering
2017-07-19 hnakashima Revert "Converting CFX_ByteTextBuf to ostringstream in SAX."

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I09b4526500ffc9babd0b7b517c58b4861acc2de6
Reviewed-on: https://chromium-review.googlesource.com/578436
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488022}

Added unit test to verify that -[ReadingListCoordinator start] correctly
sends the "Viewed Reading List" event to the FeatureEngagementTracker.

R=edchin@chromium.org, gchatz@chromium.org, noyau@chromium.org

Bug: 558666
Change-Id: Ib286b0746e773e937881868444ba094bacdc5639
Reviewed-on: https://chromium-review.googlesource.com/569219Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Ed Chin <edchin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Cooper Knaak <cooperknaak@google.com>
Cr-Commit-Position: refs/heads/master@{#488021}

The new FastInkView class contains everything
required for low-latency rendering of pointer-like
objects.

Bug: 743083
Change-Id: I0d31451899078875acd906396dda945bb45f2189
Reviewed-on: https://chromium-review.googlesource.com/576389
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488020}

Bug: 
Change-Id: Icfe1de44e197f16ba90b7e81d09036ad97a56dd8
Reviewed-on: https://chromium-review.googlesource.com/578427
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488019}

This patch removes the --enable-inert-visual-viewport flag from Chrome.
This does *not* remove the inertVisualViewport setting from Blink. This
feature is currently on by default but it was accidentally forced to the
off state by the existence of the command line flag. By removing the
flag, the Blink setting controls the status of this switch - which is
currently set to on.

Note: we're not losing anything as the feature is intended to be on by
default and we didn't have a matching --disable-inert-visual-viewport
flag so this flag would have been useless as of M61.

This patch fixes some tests that were expecting the flag to be off and
removes others that were explicitly testing behavior of the flag when
disabled. I also added a new test to test the new flag-on behavior.

This also exposed a bug in document.rootScroller, window's scrollX
and scrollY properties reverted to returning the FrameView's rather
than the rootScroller's scroll offset. This was caught by the
set-root-scroller.html test, I've commented out the checks
(rootScroller isn't yet shipped), and I'll fix the behavior in a
followup patch.

Bug: 740956
Change-Id: I249a34b4ee67dfbe8230e6bc3048871a6325e43d
Reviewed-on: https://chromium-review.googlesource.com/575768Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488018}

While src= track change still suffer from http://crbug.com/709302,
MSE based track changes work fine. This change enables both pausing
and disable track for MSE content with a keyframe distance < 5s.

The experiment data suggests that in the 95th percentile we might
end up waiting ~980ms when disabling a track before the next video
frame is shown. The 25th percentile is ~66ms, 50th is ~155ms, and
75th is ~325ms.

For pausing, the percentiles results are ~10ms, ~32ms, ~116ms, and
~255ms. These compare favorably with control values.

A later CL will cleanup chrome://flags and switches entries once
we are confident in this release.

Notably this has been launch approved since M58 and experiments have
been running since then at 75% of dev, canary, beta. The discovery
of issue 70302 blocked launch for all playbacks, so this pieces out
the MSE portion which works properly.

BUG=663999,703411
TEST=experiment data looks good.

Change-Id: I07dfebb96d4a2c9147909bb7cdf96fa02469f801
Reviewed-on: https://chromium-review.googlesource.com/576488Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488017}

In https://codereview.chromium.org/6231550869897216 the setter for
these range attributes was removed. This finishes that cleanup and also
removes the actual attributes and their use.

Change-Id: I4b474be89358d2b3364016fd842933b39a557f94
Reviewed-on: https://chromium-review.googlesource.com/578129Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488016}

Since https://chromium-review.googlesource.com/c/544717, it is not
allowed to bind to an interface on a different thread than where it is
used. To fix that, the binding is now only done on the IO thread.

Bug: 662084

Change-Id: I4e361ae4853f2d0ace3d910e12bc32e0c9a80d5c
Reviewed-on: https://chromium-review.googlesource.com/576618Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488015}

The CL https://codereview.chromium.org/2791813003/ introduced two bugs
710673 and 710874. So currently, for format=GL_RED/GL_RED_INTEGER or
type=GL_FLOAT, it will not go GPU-GPU path. But by investigating that
CL, we still can go GPU-GPU path using CopySubTextureCHROMIUM instead of
CopyTextureCHROMIUM like the earlier code did.

Using copySubTextureCHROMIUM can bypass the potential bug in
CopyTextureCHROMIUM in MacOS. But still need to figure out the reason.

BUG=710673
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2896553003
Cr-Commit-Position: refs/heads/master@{#488014}

Bug: 743024
Change-Id: I50d581ed2e4c20ab9d222d897e407f0ef6606fb6
Reviewed-on: https://chromium-review.googlesource.com/570165Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488013}

(1) The user would click "connect", then the dialog would close temporarily
before reopening. The issue was as follows: When currentRouteChanged() was
called, we would store whether the dialog should be shown and wait for the
network to be updated with Tether properties (e.g., signal strength) before
showing the dialog in networkPropertiesChanged_(). However, once a connection
attempt started, we would receive an additional update on that network,
resulting in networkPropertiesChanged_() being called again and the dialog being
shown again by mistake.

(2) The user would attempt a connection attempt, which would bring up the
dialog. If the user clicked "not now" (closing the dialog), then clicked
"connect" again (opening the dialog), then "not now" again (closing the
dialog), the dialog would open again. The issue was that if the user opened the
dialog from the network detail page, we create a new location on the back stack,
then when we close the dialog, we would remove that item from the stack by
navigating backward; the handling for this route change would cause the dialog
to be opened again.

(3) The connection dialog called private function onDialogCanceled_() when it
was closed, but this function does not actually exist on the
TetherConnectionDialog Polymer element (I believe that this function was part of
an earlier version of this element that was eventually deleted). Since this
handler function was unused, I removed it.

Bug: 672263, 738501
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I396109a589956e616322ba8bc8b7e7867bf5ea66
Reviewed-on: https://chromium-review.googlesource.com/576116Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488012}

This CL introduces an AppInitializer class for initializing the app
differently in different builds before launching the app.

Previously we had two different main.mm for the Chromium and internal
build. It's a pain to keep them in sync and introduce some unnecessary
dependencies (e.g. base:i18n and ui/base) to the internal build target.
This is especially painful when I try to add initialization code for
i18n stuff.

This refactoring should help reducing redundant code and simplify the
dependency map of the internal build a bit.

This should be landed after internal CL:
https://chromereviews.googleplex.com/595547013/

Bug: 746105
Change-Id: I4e80ef92cb3f9f68a0f811a6e9d749c36b06b145
Reviewed-on: https://chromium-review.googlesource.com/575260
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488011}