- 15 Nov, 2019 40 commits
-
-
Hajime Hoshi authored
TBR=dpranke@chromium.org Bug: 1024767 Change-Id: I8fc0d6e2acbc7fbd723770cf8e5dce5b14feb3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918913Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715637}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3da910d55f20..c3f22f7cba60 git log 3da910d55f20..c3f22f7cba60 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 dneto@google.com Update README (#3047) 2019-11-14 pierremoreau@users.noreply.github.com Update README (#3048) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c3f22f7cba60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I34caf31cc9ef37a73b34fee70e8449855d23c542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715636}
-
Ioana Pandele authored
This is no longer active. Bug: 903249 Change-Id: Iaf30dfacc0e6216935aee86266e2716da6958a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916819Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#715635}
-
Robbie Gibson authored
The root cause of the crash is that it is now possible for the omnibox to not have a default match. Up until now, we've been using the selected match to get the icon to show in the omnibox, but if there is no default match, then there is no icon. We should have a better solution than showing the icon for the first match, but this prevents the crash. Bug: 1024885 Change-Id: Idd78aca12de8db026e353895bb7f665d97005101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917502Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#715634}
-
Gauthier Ambard authored
This is mostly to try to reproduce the breakage. Bug: 1013462 Change-Id: I806d8e78475bf343c35b4c1ab5459201ffdfff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876327Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715633}
-
Bret Sepulveda authored
MediaRouterContextualMenuUnitTest was creating a BrowserActionTestUtil, which when the feature is on relies on BrowserView::toolbar, which is not defined in a non-Views test. However, it appears BrowserActionTestUtil is not actually necessary for the tests, so this patch deletes it. Bug: 984654 Change-Id: I5c40a54ea2383dc7a1c47c0f244370f005692e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916464Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715632}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f4db6a76640..36fbe6029343 git log 5f4db6a76640..36fbe6029343 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b2407dd746de..102fd19c65f4 (4 commits) Created with: gclient setdep -r src/third_party/angle@36fbe6029343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: I1a16185166d6c76c787e1bc9dc4d289854fe55c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918964Reviewed-by:
-
Bret Sepulveda authored
Force ExtensionsToolbarMenu off in ToolbarActionsModelUnitTest.ActionsToolbarActionsVisibilityWithSwitch. The test is crashing because of the DCHECK_NE inside ToolbarActionsModel::SetActionVisibility; the actions no longer start visible in the way the test expects. The behavior of the test relevant to the new UI is already covered by the existing test TogglingVisibilityAppendsToPinnedExtensions, so it now forces the feature off. This patch also removes "WithSwitch" from the test name, to avoid confusion. Bug: 984654 Change-Id: Ifeb199156b90b311c4162d24cc5d62cd928fb98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916863Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715630}
-
Guido Urdaneta authored
The audio service is enabled by default on all platforms since M75. There is no need to keep the old codepaths anymore. Several parameterized tests running with and without service/process have been deparameterized so that they run with the default process configuration. Bug: 1019245 Change-Id: Icf02a989f4579a39d15dcd33094a94f422231e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887810Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#715629}
-
chrome://media-appTrent Apted authored
Adds "launch.js" to chrome://media-app Adds "receiver.js" to chrome://media-app-guest A simple protocol transfers a blob from the host to the guest over postMessage and invokes `app.loadFiles` to open the image. Imports media_app.externs.js into the open-source repo for coverage of the closure typechecking targets on a wider range of build configurations. This file exists for a src-internal checkout at media_app_ui/resources/app/app/media_app.externs.js . Currently it's copied and given a copyright header. b/144380429 tracks automation/checking for this. The actual fileHandler integration is deferred to https://crrev.com/c/1913282 due to a regression (https://crbug.com/1022677). This CL comes with a test that invokes `loadBlob` which will eventually be triggered by the fileHandler logic. Bug: 996088 Change-Id: I88a08de670690416f16874d0fbff3bf01f84e095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903109 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#715628}
-
Chris Hall authored
R=isandrk Change-Id: I94331c931ee71d4eeaf2f6e071479c9933870f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918899 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#715627}
-
Vadym Doroshenko authored
This reverts commit fc923406. Reason for revert: This CL breaks build https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/2959 Original change's description: > media/gpu: Add ImageProcessorWithPool class. > > This CL adds ImageProcessorWithPool class, which is a simple client of > ImageProcessor. By injecting a DmabufVideoFramePool for allocating > output frames and a callback for receiving processed frames, the > caller could process input frames by Process() without managing output > buffer. > > BUG=chromium:1004727 > TEST=ninja image_processor_test > > Change-Id: If1ad0d57d36c8f80e509f0cdfd87e3e3b572ac66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874069 > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715623} TBR=deanliao@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: I9717e687fb823af335989b4e5ca86b0b49f5be0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1004727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917768Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#715626}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 866cc02d. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." acea70b2 "[WebVTT] Improvements for matching inline VTT selectors" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I148ea1ae536338648b26a1efaa872102e96f4ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917044Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715625}
-
Malay Keshav authored
This patch removes the 128 device limit that was imposed on input devices. Instead of using a fixed size array, a flat_map is used. The DeviceDataManager also removes entries from the flat_map if a device has been disconnected. Test: Manually tested on the faulty device. Bug: b/137907174 Change-Id: I5e5803aa4fb853bf4129515767c60a2dec81686d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913717Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#715624}
-
Chih-Yu Huang authored
This CL adds ImageProcessorWithPool class, which is a simple client of ImageProcessor. By injecting a DmabufVideoFramePool for allocating output frames and a callback for receiving processed frames, the caller could process input frames by Process() without managing output buffer. BUG=chromium:1004727 TEST=ninja image_processor_test Change-Id: If1ad0d57d36c8f80e509f0cdfd87e3e3b572ac66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874069 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715623}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/716db02ba1e8..6e5f1021ae2c git log 716db02ba1e8..6e5f1021ae2c --date=short --no-merges --format='%ad %ae %s' 2019-11-15 fancl@chromium.org Allow scroll in paper-dialog Created with: gclient setdep -r src/third_party/catapult@6e5f1021ae2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1024975 Change-Id: I1c9eaab43f7ccf43cd7ecf5d3b2207023204c2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918959Reviewed-by:
-
Julie Jeongeun Kim authored
This CL gets rid of BindNewEndpointAndPassDedicatedReceiverForTesting() from EmbeddedSearchClientFactoryImpl which was added by [1] to replace MakeRequestAssociatedWithDedicatedPipe() with new Mojo types. It uses reset() instead of using DedicatedReceiver before connecting and checks if AssociatedRemote is bound whenever it's accessed to call interfaces. [1] https://crrev.com/1897399 Bug: 955171 Change-Id: Ia2bf4a33d6a8d4a871ce037b96b72d03bf97f2e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912789 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#715621}
-
Wez authored
CancelableTaskTracker was passing raw TaskCancellationFlag pointers to callback functions, using RetainedRef() to have the callbacks hold a reference to them. Remove this unnecessary complexity by having the functions take |const scoped_refptr<>&| for those parameters. (Passing the references by-value was avoided, due to the ref-count churn that would result for RepeatingCallbacks). Bug: 1009795 Change-Id: Icd5f87dbb182a8fbd043781b534db1cfe625544f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918088 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#715620}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/3bc4bdd87b2e..94591413f1fe $ git log 3bc4bdd87..94591413f --date=short --no-merges --format='%ad %ae %s' 2019-11-14 rch Rename QuicUtilsTest to QuicTypesTest in quic_types_test.cc to avoid build problems on Chromium. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Iee760ac45857cf8c9a45c9745ec709f196362572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918841Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#715619}
-
Luciano Pacheco authored
Add a robust way for tests to wait for a directory finish loading by adding a 'scan-completed' attribute to list container. Change the navigateWithDirectoryTree() integration test helper to use of this attribute. Bug: 992821 Change-Id: If03ade0de3921b93a652c438f20f17ae95be7991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918795 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715618}
-
Dave Tapuska authored
This change moves the definition of UpdateActiveSchedulerTrackedFeatures from FrameHost to LocalFrameHost in blink. It removes the public definition on the WebLocalFrameClient as it isn't necessary anymore. BUG=1008432 Change-Id: Idd14155fa43148cfb2411c1f965501489fdac85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897914 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715617}
-
Avi Drissman authored
Tbr: palmer@chromium.org Bug: 327804 Change-Id: I06ac9a7580d0c7b635b5bccfaeed602223abdac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900213 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#715616}
-
Chih-Yu Huang authored
Currently, we use VideoFrameLayout to store the physical layout of video frame buffers. VideoFrameLayout uses VideoFrameLayout to indicate the buffer format. However in GPU buffer usage, we have to handle proprietary format, which is not listed in VideoPixelFormat. This CL introduces a new class "GpuBufferLayout", which is planned to replace VideoFrameLayout inside media/gpu/chromeos. Bug: 1004727 Test: ninja media/gpu/chromeos:common Change-Id: Iaac1b1c76ac6b9dace7e4b790a9161de17e3342a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899228 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 992821 Change-Id: Ie5aa584a617de40288d057544834bf4cc630515c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918788Reviewed-by:
-
Xianzhu Wang authored
This is produced with the following script: #!/bin/bash c=0 find . -name "*-expected.*" | grep -v external/wpt/ | tee /tmp/expected-files | wc -l for i in `cat /tmp/expected-files`; do c=$((c+1)) echo $c base=${i%-expected.*} base=${base#./} base=${base#platform/*/} base=${base#flag-specific/*/} base=${base#virtual/*/} has_test=NO for j in $base.* platform/*/$base.* virtual/*/$base.*; do if [ -f "$j" ]; then has_test=YES break fi done if [ $has_test == "NO" ]; then rm $i echo REMOVED $i fi done TBR=wangxianzhu@chromium.org Change-Id: I432b1a4e92c98a68de38e604cf060260ced6c848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915962Reviewed-by:Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715613}
-
Chih-Yu Huang authored
Currently, in Reset() we only call TryCancelAll() on the client sequence to cancel tasks on device sequence. However, TryCancelAll() cancels tasks in a best-effort, meaning a few tasks on device sequence can still run. The tasks posts new tasks to the client sequence. Therefore, V4L2ImageProcessor might still return previous frames after Reset() is called. In this CL, we have these changes: 1. Post additional task ResetTask() to device sequence after cancelling previous tasks. 2. Clear |running_jobs_| at ResetTask(), and check the dequeued buffer id at Dequeue(). Only return the buffers at |running_jobs_|. 3. Invalidate WeakPtr of the client sequence to cancel pending tasks on the client sequence. With 1. and 2., we could guarantee that after ResetTask(), we don't post task to |client_task_runner_| for returning frames. With 3., we could guarantee the tasks on |client_task_runner_| posted by the tasks on |device_task_runner_| prior to ResetTask() are cancelled. Bug: 1004727 Test: Run video_decode_accelerator_tests on Kukui and Hana Test: Run video_encode_accelerator_unittest on Kukui and Hana Change-Id: Ic2f8084f7e7658488dac9e7d39b0f22be347795e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906858 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Jan Krcal authored
Bug: 978775 Change-Id: I858edbc6a08d5f8ce148f02c461cb0fba8d33a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886898 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715611}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eae1d5ed..b1d68d80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I994f067f2d20de4517c91e3d3a3375474057e23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917043Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715610}
-
nancy authored
BUG=998004 Change-Id: I0428b84e59d719be9ce7288a11094b5bb74ee3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918904Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715609}
-
Luciano Pacheco authored
Change #detail-table to have no outline when it has focus, this is only displayed during Files app initialization preventing the weird orange outline from being displayed. Bug: 1025121 Change-Id: Ieb3c66fe07f2ec064ad06acf27739aed4f8dd202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918789Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/588d23a98223..fe24d1e38c44 git log 588d23a98223..fe24d1e38c44 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 vapier@chromium.org run_tests: increase Ctrl-C timeouts 2019-11-15 vapier@chromium.org upload_prebuilts_unittest: get tests passing under Python 3 Created with: gclient setdep -r src/third_party/chromite@fe24d1e38c44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8bcf29d94cacc8d605243df9a8db56155a5602ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917952Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/21d0e38fc847..716db02ba1e8 git log 21d0e38fc847..716db02ba1e8 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 rmhasan@google.com [typ] Add Slow action specifier to typ's expectations parser Created with: gclient setdep -r src/third_party/catapult@716db02ba1e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:986447 Change-Id: I83e9c62f5c720624e484aaf72ecc48fd76adb65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918812Reviewed-by:
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/profile_resetter This CL was uploaded by git cl split. R=battre@chromium.org Bug: 1018667 Change-Id: Ib05a1b4e6df9e41126a2810d800be92907ee8639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917228 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#715605}
-
chrome://media-appchrome://flagTrent Apted authored
ChromeOS resource.pak increases: 26864016 -> 27594788 bytes (+713kiB) until we can remove the apps that this will replace. See go/media-app-size. Bug: 996088 Change-Id: I00c3435d428f18cf0e4e461738dcf8dc0d627fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916538 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#715604}
-
Chris Hall authored
R=aboxhall Change-Id: Ie73667890a0f30ecb7eaa16a7f2797287e1d841b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918792 Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715603}
-
Noel Gordon authored
The list check icon should be filled with Blue 600 #1A73E8. Add it to the files-ng 20px icon set. Minor fix: close the <g> tag on external- link item in the icon set. Bug: 1002393, 992821 Change-Id: Ic5bee0a90c1fdcfb8eb9b6c424c00001c8bb8f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918791Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715602}
-
Chih-Yu Huang authored
This CL uses SequencedTaskRunner, SequenceChecker, and WeakPtr to handle tasks on different sequences of V4L2ImageProcessor, without changing any logic. Also, we use function thunk to ensure a task is called on a certain sequence, instead of using media::BindToCurrentLoop. Bug: 1004727 Test: Run video_decode_accelerator_tests and video_encode_accelerator_unittests on Kukui Change-Id: I15bf1b2fa17bad75706bf0ecf543c31d813e8787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905043Reviewed-by: -
Dan Beam authored
This reverts commit 544412a4. Reason for revert: Performance and functional regressions https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5 Original change's description: > Friendly Privacy Setting Initial Redesign > > This CL does 3 things: > 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. > 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. > 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. > > Bug: 1014143 > Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714287} TBR=dpapad@chromium.org,msramek@chromium.org,harrisonsean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014143, 1024034 Change-Id: Ic95f592ad4913804ba738553091d907c61289e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917949Reviewed-by:
-
nancy authored
Add an InstanceRegistry pointer to ExtensionApps, to add the instance to the InstanceRegistry when launching apps. BUG=1011235 Change-Id: I85aea523ecd5e1ea68810bcc8e7e364d1798b5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913286 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
While working in the new file list I've faced this assert error and couldn't figure out what metadata property name was wrong. This CL makes easier to identify the invalid metadata property by adding the name in the assert message. Bug: 992821 Change-Id: I258867b9b33385667a9c45a5d59cc2cf4c76c246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918796 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
