GitLab

for Spanish keyboard.

Prior to this patch, only "es" is specified, thus the "Spanish keyboard"
only shows up in "input methods" settings when (generic) "Spanish" is selected,
but not for "Spanish-Spain". There doesn't seem to be locale fallback logic
in place. Many other entries already specify both generic and country-specific
variants of languages when necessary.

We're fixing this for both Chrome OS and open-source Chromium OS, although the
bug only concerns Chrome OS.

Bug: 1021222
Change-Id: I99fe160a89f4dc774c88104e62c8214e75a83737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898897Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712891}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f16e793858c4..2dfba53b8214

git log f16e793858c4..2dfba53b8214 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 9856269+sarahM0@users.noreply.github.com Add unit test for spvcir parser (#866)

Created with:
  gclient setdep -r src/third_party/shaderc/src@2dfba53b8214

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I8616ba2e19d2b02f248ff50aedde7888f20f0dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900588Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712890}

Also pass the NIK to SocksConnectJob through its parameters.

This only affects the DNS resolution of the destination's hostname, not
the SOCKS4 proxy's hostname, which continues to not use the NIK.

Bug: 997049
Change-Id: If0cc74bb28d82f4f6929ccb12f15691e22c40589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898389
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712889}

This CL converts remained old Mojo types of DnsConfigChangeManager
interface to new Mojo types. Major changes are as below,

  - Convert mojom::DnsConfigChangeManagerPtr to
    mojo::PendingRemote|Remote<mojom::DnsConfigChangeManager>
  - Convert mojo::DnsConfigChangeManagerRequest to
    mojo::PendingReceiver<mojom::DnsConfigChangeManager>
  - Convert mojo::Binding to mojo::Receiver

Bug: 955171
Change-Id: Iea32edc6bc502514792114d2adf71cdffb5f8c6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896490
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712888}

Bug: 987646
Change-Id: I8cb241950b86772c78ea6fdb9d1e8345b512161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890004
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712887}

This adds a test for the fix in r711622.

Bug: 1020082
Change-Id: I2caed1e0135844757fb648f183da1c2cf6e6f377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895093Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712886}

This test was added in the early days of mojo and has long been disabled
while mojo and media/mojo evolved. Now media/mojo and the mojo Renderer
path are covered by various other tests and there's no plan to revive
this test. Therefore this CL removes this test.

Bug: 597904
Change-Id: I3adde9430f2601eacca67d8bdde338c37a30e3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896054Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712885}

Bug: 1014771
Change-Id: Ie8cb8a929d8273faae6f13d31193ed433fc093ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900518
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712884}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=abdulsyed@chromium.org

Change-Id: Ib4f721bb596ec50d85bff4c026049d979c85699a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900747Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712883}

Using wpt-import in Chromium 73e55d76.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
40c01af7 "[Chromedriver] Fix PerformAction to support multi touch points cases"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bokan@chromium.org:
  external/wpt/visual-viewport

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I4e0628ec82b668b4f2ed8e0fa18b3673956ce84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899801Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712882}

This reverts commit 13908ddd.

Reason for revert: It prevents uploading a new patchset for an internal CL which does not change any xml file

Original change's description:
> [Snowflake] Prevent from adding hex color values outside color_palette.xml
>
> Moved some semantic names in color_palette.xml to semantic_colors.xml.
> And added some presubmit checks to prevent from adding more hex argb
> values in color resource files except color_palette.xml.
>
> Bug: 775198
> Change-Id: Ie27dd8dc0e4fa6506ed192c6f5f9c4b5b5f88566
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896241
> Commit-Queue: Lijin Shen <lazzzis@google.com>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712462}

TBR=twellington@chromium.org,jbudorick@chromium.org,lazzzis@google.com

Change-Id: Ib41c469abd121a3003bdd1b7047ff6dac9f0b93f
Bug: 775198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900657Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712881}

This CL adds UMA to the App Management page. It records:
- The actions a user takes in an app detail view.
- How a user accesses App Management.

Bug: 963326
Change-Id: Ib4b40cd372993263c8601cc2caf46abb50487e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893599Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712880}

This increases the sample rate for pre-stable channels (the stable
channel sample rate is still 2%). This change is not expected to have a
significant impact on total UMA volume, due to the relatively small size
of WebView's pre-stable channels.

This addresses privacy concerns (regarding fingerprint-ability for
low-usage applications) by limiting the package name field to 10% of the
population. When sample rate < 10%, we'll upload package name with all
UMA logs (this is the status quo). When sample rate > 10%, we'll only
upload package name for the clients which fall within a 10% group (using
similar logic to our existing sampling logic).

This continues to maintain the requirement that we only upload the
package name for system apps or Play Store-installed apps (ex. This will
not log the package name for sideloaded apps, even if the client falls
within the 10% package-name-logging group).

Bug: 969803
Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.*
Test: build with android_channel="beta", manually observe metrics are logged 99% of the time
Test: build with android_channel="stable", manually observe metrics are logged 2% of the time
Change-Id: I611c76b21f790251ab08de3f72cd0807f9a88f9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898711
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712879}

Previously, the accessibility component extensions did not follow the
bracket conventions for conditionals Chromium style guide, primarily due
to the history of the ChromeVox screen reader. This led to some
confusion, as well as competing requests from different reviewers.

This change modifies all of the accessibility component extensions to
use braces for all conditional statements.

This change is a pure refactor, there is no change to function or logic.

Bug: 706981
Change-Id: Iba6f4922332de7c4c09a0bc8fb14cbd3e45ba37d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898434Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#712878}

The device list header should be "Available devices" instead of
"Available devices will appear here." when there already is one or more
devices in the external storage list.

Bug: 1007202
Test: Manual test
Change-Id: Ib08103236d32ada77b8328f29eacb1ed0a6a7759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895252Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712877}

Convert all callers to use base::flat_map in the first place, instead of
using std::map and then converting them. Fix link errors along the way.

Change-Id: I34bd7b2c42cfb5cdcd68d4e0880b82633b989697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892437Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712876}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: If1c90517833e8d9bf63e7d59bd1de6dd2057c896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900628Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712875}

BUG=1021659
R=sky

Change-Id: Iec957bd6f0f1d182d7e467df188f9de7ea4fe0ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899565
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712874}

This patch changes |NGInlineCursor::MoveTo(const LayoutObject&)| to work with
rootless cursor for both |NGPaintFragment| and |NGFragmentItem| before this
patch it works only for |NGPaintFragment|.


[1] http://crrev.com/c/1895258 Introduce NGInlineCursor::
MoveTo{Next,Previous}InlineLeaf{,IgnoringLineBreak}()


Note: This is follow-up of the patch[1].
Bug: 982194
Change-Id: I87f868f23c51454b6b7fc94311a458bb46c88de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896477
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712873}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=jrummell@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I4bf2d6caee1e3a77f740d93a533cf021c68d6a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895645
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712872}

https://chromium.googlesource.com/catapult.git/+log/09a9385121be..1944f6e6df68

git log 09a9385121be..1944f6e6df68 --date=short --no-merges --format='%ad %ae %s'
2019-11-06 fancl@chromium.org Update outdated README.md for integration test and fix tests

Created with:
  gclient setdep -r src/third_party/catapult@1944f6e6df68

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: None
Change-Id: I7701daae5f25ebfc69d96cdf1fdd71028108c26c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900626Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712871}

Forgotten when I deleted the test in https://chromium-review.googlesource.com/c/chromium/src/+/1900404

TBR=cbiesinger@chromium.org

Change-Id: I371919d31ff08ffede168ff01db640ad71769c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900631Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712870}

Fix RunUntilNumberOfPortsIs() to execute RunLoop::Run() only once, so
that if the condition is never met then the test will fail in a timely
manner.

Change-Id: Ie766d56d532c4cc6b680ebb3a265b935fc3a9fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898279
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712869}

Expose a limited API through autotest private to interact with
Virtual Desks, so that we can later invoke those APIs from Tast
tests.

BUG=1016994
TEST=Added new tests

Change-Id: I43d0f4d8c85f95c1b2bfb4aa97107bdc2f24623c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895742
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712868}

This feature will be implemented as an alias of word-break: break-word,
which the CSS Text 3 declared as deprecated in future levels of the
spec.

There has been a long standing interoperability issues with the
'word-break: break-word' feature, implemented in Blink and WebKit but
not in Firefox, since it was declared as deprecated. This feature can't
be removed to avoid compatibility issues, but also because it provide
a behavior that web authors really need, which is that breaking
opportunities are considered in th min-content size of the box.

The CSS WG resolved [1] that the best approach is to add a new value to
the overflow-wrap CSS property, that provides basically the same behavior
than 'overflow-wrap: break-word' but allowing the breaking opportunities
to be part of the min-content size computation.

This CL will enable the feature by default in next release, since the
intent-to-implement-and-ship request [2] has been already approved.

[1] https://github.com/w3c/csswg-drafts/issues/2682
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CeGWh7l1Jq4/NeQXxZ4UCAAJ

Bug: 905315
Change-Id: I89bbc78f68f425dbad714c8546bc72c530887eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838194
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712867}

This CL converts mojom::CoordinatorConnectorRequest to
mojo::PendingReceiver<>.

Bug: 955171
Change-Id: I2d14476598074daafae0f45649ace88ce08c14e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895266
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712866}

Update the test expectations and re-enable the tests.

Bug: 1021499
Change-Id: I84eed7b0fac47ff069ee81c23e1e494a05337da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899926Reviewed-by: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712865}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/db6f5198..c761cf33

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5a7fc34a402eea84c1ee3584fc5c926a1e1420ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899800Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712864}

https://skia.googlesource.com/skia.git/+log/ce200acafa7a..cdc0c23f1a2e

git log ce200acafa7a..cdc0c23f1a2e --date=short --no-merges --format='%ad %ae %s'
2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-05 reed@google.com split out blendmodes for skvm
2019-11-05 reed@google.com split out serial functions for SkFont into separate impl

Created with:
  gclient setdep -r src/third_party/skia@cdc0c23f1a2e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: I3804115864dafd668ce2b40c554b253011dbfd2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712863}

The public API is not needed any more now that the WebRTC/Peerconnection
implementation resides solely in Blink.
Hence, this CL uses RtcVoidRequest directly.

Note that the CL removes the duplication of some template definitions
added temporarily in blink/renderer/modules/peerconnection/rtc_peer_connection_test.cc
by https://crrev.com/c/1897772

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I390f66f470cc4bf7aba7bf6c8b182c0749f8105b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899786Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#712862}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/38f84022167e..e7ebfec8c01c

git log 38f84022167e..e7ebfec8c01c --date=short --no-merges --format='%ad %ae %s'
2019-11-05 dburger@chromium.org Make the BinhostTest a noop.

Created with:
  gclient setdep -r src/third_party/chromite@e7ebfec8c01c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I5053aeaf96b3fe4f4bd3a52b6aadf9e25019be98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900103Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712861}

The bottom sheet version of the tab grid is obsolete and uses a
deprecated API (BottomSheetController#getBottomSheet). This patch
removes the unused code and marks the relevant metrics obsolete.

Bug: 986310, 1020711
Change-Id: I69f126e2d90139606410cfb0264a5a2c138ae972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895966
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712860}

Bug: 1021649
TBR: gambard@chromium.org
Change-Id: Iba5edac9846936924de134722594fb7b8efef2c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900357Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712859}

This enables the action mode bar, which has the "Copy", "Select", "Share
all" and "Web search" options when text is selected.

Change-Id: Id91ce30e7f389d9105626f1f463fa687751dfa65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900570
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712858}

Otherwise destructor which cleans up observers will not be called.

Fixed: 1011330
Change-Id: I62927c958757e8411b3a96e565617cb94547edd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900139Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712857}

Since private URLs can't really be checked for safety, there's no
benefit of checking their reputation with the server.

R=bdea

Bug: 963165
Change-Id: I927fa1fa82dd491cbb2171fa1c9d0ee6a80f0dd7
Fixed: 1021671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900256
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712856}

Bug: 997049
Change-Id: I7b04af65e0a4d8ed3e4c3c527dddad2bb06f6409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898302
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712855}

This change removes the "is_legacy_webvr" attribute from the mojom files
that used it, since this is now always false.  Any logic that depended
on it has been updated accordingly.

Note that the "IsLegacyWebVr" metric is still being logged to prevent
incompatiabilities with the data types while it is a value that is
needed for filters.

Bug: 1017872
Change-Id: Ie43c914a4bbac0c1b7beda02257865ac3e69f5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897857
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712854}

- Adds is_form_navigation member to the NavigationDetails struct. This
struct is sent to the InfobarDelegate after each Navigation.
- Dismisses the SaveCard Infobar unless the navigation was triggered
by a form submission or is a redirect.
- Creates kAutofillSaveCardDismissOnNavigation feature flag for the new
behaviour.

Bug: 1021412
Change-Id: I6cf5973a635586a8f21d65a50bb750a4ea0c4070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890734
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712853}

This patch updates the back button visibility for Assistant web
container.

Bug: b/141268413
Test: manual
Change-Id: I2dfd3209e4954e04295340d48f05516bde37d09a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873147
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712852}