- 26 Mar, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4b2e3d16. With Chromium commits locally applied on WPT: 685a1df9 "Extend canvas getContextAttributes WPTest" 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I502cc05b9c807246b67c4fe13fcdae2a7304d85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539870Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644519}
-
Hwanseung Lee authored
- remove kFixedBottomCenter which is only used at unittests - remove kSideCenter which is only used at unittests - remove kBubble* values which are not used. - drop "Touchable" in kBubbleTouchable* values. Bug: 940736 Change-Id: I2f136b04051dd075d0231fe8a26a0fb988f76206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534902 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#644518}
-
Filip Gorski authored
* Allows components using a Snackbar to choose a Theme. * Introduces a Google theme for the snackbar. Bug: 945376 Change-Id: Ia4fb4d580d4c2edbd65950a1211f97ec4805ef8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535130Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#644517}
-
Mike Dougherty authored
Bug: 936300 Change-Id: I54abbbc073841347b9afa0daa854d04a1fc2aa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539066 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#644516}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/71c6104a1739..1b12fa2c0ae1 git log 71c6104a1739..1b12fa2c0ae1 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 benjhayden@chromium.org Protect add_reserved_diagnostics against empty HistogramSets. Created with: gclient setdep -r src/third_party/catapult@1b12fa2c0ae1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:945517 TBR=sadrul@chromium.org Change-Id: I8221d31b49d22805ec9e02edc11ad9ce699ae871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644515}
-
Benedikt Meurer authored
The category was introduced in V8 as part of https://chromium-review.googlesource.com/1538135 and is used for detailed trace events of the TurboFan optimizing compiler. It should be listed here alongside the other V8 events for a better user experience. Bug: v8:8598, v8:9039 Change-Id: I2ac267af2083fb724e9e524a8e9ddfb6ba6b5611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539843 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#644514}
-
Benoît Lizé authored
Also move the loading metric recording to a background thread. Bug: 918946 Change-Id: Ibc6df868167435b07682f3a5bfb4bc33e0f1561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535884Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#644513}
-
David Benjamin authored
The CreateObject implementation should release the ppp_class_data when it goes out of scope. Bug: 258113 Change-Id: I563c6b5234f5ac94fed4fd43ce69c448e54866de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539692Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#644512}
-
rbpotter authored
Increasing side padding to 8px from 4px, and decreasing icon size from 20px to 16px, per UX input. Bug: 934061 Change-Id: Iab5761e7be3b5933a4481200a4de2f07b1f72c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540068Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#644511}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d3d3aa03e109..91e949292f59 git log d3d3aa03e109..91e949292f59 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 cwallez@chromium.org BUILD.gn: put public include dirs in all_dependent_configs 2019-03-26 brandon1.jones@intel.com Change Copy Validation To Allow Depth = 0 Copies Created with: gclient setdep -r src/third_party/dawn@91e949292f59 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:938895 TBR=cwallez@chromium.org Change-Id: I98a9e500fd4b9e0a1b9321658abfe3f56d4de806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540040Reviewed-by:
-
Jun Cai authored
This CL updates URLLoader::OpenFilesForUpload to open limited number of files at a time. Bug: 939606, 944218 Change-Id: I69f262e122fbdd9216393656d75645cd5b60f450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520317Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#644509}
-
John Abd-El-Malek authored
Add a regression test for r632725, which fixes renderer hangs if the network process crashes during a cookie request. Bug: 932305 Change-Id: If809f1e3d5fe2fec9d33daef2d5f627db92952a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539178Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#644508}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb0753640a07..2ff54e34ed37 git log fb0753640a07..2ff54e34ed37 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 33432579+alan-baker@users.noreply.github.com Handle function decls in Structured CFG analysis (#2474) 2019-03-26 33432579+alan-baker@users.noreply.github.com Add option to validate after each pass (#2462) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2ff54e34ed37 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ida77bb094cdab83e385c23c9f5e069018f27c81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540047Reviewed-by:
-
Erik Luo authored
Before, Console logs with an associated Network request would link all links to the request's URL. Now, it uses normal linkifier, for links with a different URL, allowing external ones. Bug: 925508 Change-Id: I96e7aaf75ad1597852a8dd5e1b2a5363df3ff844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540060Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#644506}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5ccc6eaadf1a..c8e39ebcf304 git log 5ccc6eaadf1a..c8e39ebcf304 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 jclinton@chromium.org config: Wipe build roots for non-paladin asan, ubsan, and fuzzer Created with: gclient setdep -r src/third_party/chromite@c8e39ebcf304 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Id6e0164a9e3adfb5f8835589668b85f23ed7df12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540046Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b66b4e0b328b..cadd2cc7ad7f git log b66b4e0b328b..cadd2cc7ad7f --date=short --no-merges --format='%ad %ae %s' 2019-03-26 fmayer@google.com Merge "Do not fail if ClientConfiguration cannot be read in one chunk." Created with: gclient setdep -r src/third_party/perfetto@cadd2cc7ad7f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0f40b9ea1aac676f7112f4f9ddb1896e48129b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540039Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/88a0c6d6..e9845b09 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9add0921fda99337c6a3ba84521be82df9317242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538824Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644503}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/213a8ce6d5c2..cc6473f7d80d git log 213a8ce6d5c2..cc6473f7d80d --date=short --no-merges --format='%ad %ae %s' 2019-03-26 capn@google.com Regenerate Windows LLVM configs 2019-03-26 capn@google.com Regenerate Linux LLVM configs 2019-03-26 capn@google.com Add Windows support to LLVM config generation script 2019-03-26 capn@google.com Disable LLVM_ENABLE_THREADS in config generation script Created with: gclient setdep -r src/third_party/swiftshader@cc6473f7d80d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I82d8e4db58f511f2b9dd6d44639ccb682724524b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540044Reviewed-by:
-
Elly Fong-Jones authored
This change removes the flag and the backing switch. Bug: None Change-Id: I169ca0f1460544e29771b148455d258c971acc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540095 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#644501}
-
Dave Tapuska authored
Determine if we are in a sandbox iframe preventing top level navigation. Add a histogram to count the number of navigations starting from such frames that stay within the subtree or affect frames outside of it, to determine if it is feasible to adjust the policy here. BUG=705583 Change-Id: Ie9c808035af367e868b1a422b549aa4a618654a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524624 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644500}
-
Robert Ogden authored
Some concerns came up during privacy review about how 'cloud technology' might be translated too literally so this improves the description. Bug: 929532 Change-Id: I82b424d90436e6ae94928f78c56cf0247d3c3a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540075Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#644499}
-
Elly Fong-Jones authored
This change just removes the flag; the backing switch remains (with an added TODO pointing at the cleanup bug). Bug: 945966 Change-Id: I7e6231fe1eb65cbadc580bb5a6538d49e42069c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540296 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#644498}
-
Tatiana Buldina authored
Bug: chromedriver:2414 Change-Id: I8a30cc59f1282d909da8ef03d5f34a0bbbefed38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531102Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#644497}
-
Daniel Cheng authored
Also add an OWNERS file for //third_party/smhasher. Next steps are to: - remove dependencies on the old header locations - add //base/hash/README.md - remove direct dependencies on smhasher and provide standard (but gated) interfaces in //base/hash. Bug: 902789 Change-Id: I36bab11b1e3383dc41814867e053e7ea3e0af5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535124 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#644496}
-
rajendrant authored
To start with the feature is enabled by default on Android. Bug: 945036 Change-Id: I9383194f5e10c0bc05834a2e5d3fc50934c22794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536681 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#644495}
-
David Tseng authored
TBR=sky@chromium.org Bug: 795840 Change-Id: Idc11aa884c29cd73960355e660ce2219aa674621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534283Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644494}
-
Jonathan Backer authored
This CL makes Android WebView use this mode explicitly whenever SkiaRenderer is asked for. This will allow some further clean of SkiaOutputSurfaceImpl* in follow up CLs. Change-Id: Ibcba761477bbe89829ae647ffd22ff7a80d4247b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539779 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#644493}
-
Gary Kacmarcik authored
When the default display is not leftmost, then the coordinates for the mouse events are not calculated correctly. This fixes that. Bug: 946001 Change-Id: I1d0124c2c5bbb828466ee306e60bb0aedaa2f5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536769 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#644492}
-
Siye Liu authored
The root cause of this issue is that there is a wrong assumption in current TSF implementations for JPN IMEs. IMEs may start new composition at offset prior to current composition. We should not commit current composition if the start of new composition is before current composition. This change also fix an issue in Confirm/cancel composition scenario. We should notify text change for the whole buffer to let IME to terminate composition. Bug: 944004 Change-Id: Iff8759481bfcb2da622483dabecfb6cc4c50da7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536637 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#644491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7175abb56021..c0b7cfc0b483 Created with: gclient setdep -r src-internal@c0b7cfc0b483 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I291b9c7a987803a113abc8bf0bde0b2ad6f17642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540045Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644490}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/17d55b5dc9ce..069b546ca7bf git log 17d55b5dc9ce..069b546ca7bf --date=short --no-merges --format='%ad %ae %s' 2019-03-26 tsepez@chromium.org Avoid signed integer overflow in CFGAS_StringFormatter::ParseNum. Created with: gclient setdep -r src/third_party/pdfium@069b546ca7bf The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:945836 TBR=dsinclair@chromium.org Change-Id: Ic58c62a296ad2e1b3490cb8faa7ec5f654a861f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540043Reviewed-by:
-
Paul Meyer authored
This makes it more clear that this policy applies only to lossy image types (for now, just JPEG). This patch also makes the implementation more generic in order to make the policy compatible with parsed policy values and to pave the way for implementing a lossless-enforcing version of the unoptimized-images policy as well. These changes have been pulled from a larger partially reviewed CL: https://chromium-review.googlesource.com/c/chromium/src/+/1524869 Bug: 942659 Change-Id: I0242ac900b1653b89d6d8dbd63616003dcaaba62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531354 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#644488}
-
Sahel Sharify authored
TBR: pkasting@chromium.org,twellington@chromium.org Bug: 945861 Change-Id: I4cff86cbcaf417a0a3025cb9a61c60fe3aaa461a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540074Reviewed-by:
-
Peter Boström authored
This dialog looks and quacks like a menu, similar to the profile chooser dialog. As a bonus the OK/Cancel buttons are also removed from this dialog, which gets shoehorned in to make this look more like a menu. Bug: chromium:943702 Change-Id: Idf1d617238d9e92f7e8ef5645d2e4938b11ff8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540065Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#644486}
-
Maks Orlovich authored
Change-Id: Ic5d27813b7388666a4f7a53fe4f641fde125d2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524998Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#644485}
-
Elly Fong-Jones authored
Bug: None Change-Id: I4bff537460b3e34a95631691d708af959f90d6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540091 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#644484}
-
Ushesh Desai authored
Removing out of date info in the change and will add the email lists once we figure out which ones to use. R=benhenry@chromium.org Bug: 909866 Change-Id: I06c559e430716b41af94859f1135e2fff10201e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540087Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ushesh Desai <ushesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#644483}
-
Alex Cooper authored
Windows was not allowing copying of the temp file while it was still open. However, calling close by default causes the file to get deleted automaticaly. This defers that deletion. Change-Id: I8ce712a4eb3de9d4d14f43389d341b016a64bae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539871Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#644482}
-
David Tseng authored
ChromeVox used a tree path based recovery strategy to work around issues on google.com (see crbug.com/885244). https://chromium-review.googlesource.com/c/chromium/src/+/1534283 As of https://chromium-review.googlesource.com/c/chromium/src/+/1889165 the above issue seems to have been resolved without using tree path based recovery. Revert ChromeVox back to using ordinary ancestry recovery. Bug: 945708 Change-Id: I6b8599d2daf42bc1bad036b911fa77d802e66451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539262Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644481}
-
Brandon Wylie authored
Opens the last tab when clicked. Uses the BrowsingHistoryBridge to query the history for the last browsed to URL. first launch/history clear: https://screenshot.googleplex.com/k0WpTH5e0Vt.png after click: https://screenshot.googleplex.com/VrtPDrcQs9Y.png Bug: 936052 Change-Id: Ia1c138d0a88d90ebe92589cc37e5e09ca7a6ade1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520884 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#644480}
-
