GitLab

Currently, ContentSettingsHandler::UpdateZoomLevelsExceptionsView(),
skips setting the origin for scheme and host zoom changes, but still
adds an entry to be displayed in the content settings page. This causes
an entry to be displayed with an origin of undefined. This CL changes
UpdateZoomLevelsExceptionsView() to skip adding an entry altogether.

BUG=453234

Review URL: https://codereview.chromium.org/883353003

Cr-Commit-Position: refs/heads/master@{#313839}

corrupted/missing in GCM store

BUG=453018
R=zea@chromium.org,miu@chromium.org

Review URL: https://codereview.chromium.org/884783003

Cr-Commit-Position: refs/heads/master@{#313838}

Profiles in bluez are not specific to a device.
When client code tries to connect to two different devices, only
one profile is created, managed by BluetoothAdapterChromeOS.

dbus messages are multiplexed based on the device desired using new
class BluetoothAdapterProfileChromeOS.

BUG=chromium:421207

Review URL: https://codereview.chromium.org/851123002

Cr-Commit-Position: refs/heads/master@{#313837}

BUG=448644

Review URL: https://codereview.chromium.org/853643002

Cr-Commit-Position: refs/heads/master@{#313836}

This should just make the docs available for convenient referece by devs
using the API. It need not be listed in any index.

BUG=none
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/893443002

Cr-Commit-Position: refs/heads/master@{#313835}

This patch copies apptest_runner from Mojo, stripping it down to parts that are
needed to run network service apptests on Linux. This allows us to run them in
a Chromium checkout.

BUG=450356

Review URL: https://codereview.chromium.org/874273002

Cr-Commit-Position: refs/heads/master@{#313834}

The permission spinner in the website settings popup had a black
background on certain devices. The bug was that the background was a
defined using a <shape> element that didn't have a <solid> element
inside of it (and certain devices default to a black fill color if
<solid> isn't specified).

Rather than fixing the immediate problem, this rewrites the code a bit:
The line under the Spinner is now a View with 1dp height rather than the
background of the Spinner's TextView. As a side-benefit, the underline
now extends all the way to the right edge of the spinner.

BUG=449643

Review URL: https://codereview.chromium.org/870143003

Cr-Commit-Position: refs/heads/master@{#313833}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/19d8f9f..527b287

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/883403003

Cr-Commit-Position: refs/heads/master@{#313832}

This target provides Chromium embedders with an elegant way to include
additional targets for all platforms.

BUG=453606

Review URL: https://codereview.chromium.org/882253007

Cr-Commit-Position: refs/heads/master@{#313831}

This also removes its handler and associated code. The use of this infobar has
been superseded by an Omnibox decoration and bubble.

BUG=none

Review URL: https://codereview.chromium.org/826553003

Cr-Commit-Position: refs/heads/master@{#313830}

It fails on the official builders.

BUG=446221
TEST=none
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/885973002

Cr-Commit-Position: refs/heads/master@{#313829}

Function is incorrectly copying a std::wstring into a buffer.

BUG=452886

Review URL: https://codereview.chromium.org/883003005

Cr-Commit-Position: refs/heads/master@{#313828}

This is a problem created by https://codereview.chromium.org/847733005.

BUG=445036
TEST=Lock a Profile, and the User Manager opens properly. Close all
other browsers then close the User Manager, ensure Chrome's completely
shut down, and re-open Chrome. The User Manager opens straight away.

Review URL: https://codereview.chromium.org/885493005

Cr-Commit-Position: refs/heads/master@{#313827}

This lets overlays display properly in the case of switching on/off

Review URL: https://codereview.chromium.org/812913003

Cr-Commit-Position: refs/heads/master@{#313826}

The GPU Times metric event names have been standardized to match the
names for other metrics. GPU Rasterization versions have also been
added for both GPU times tests. Here is the list of test names:
  gpu_times.gpu_rasterization.key_mobile_sites_smooth
  gpu_times.gpu_rasterization.top_25_smooth
  gpu_times.key_mobile_sites_smooth
  gpu_times.top_25_smooth

R=vmiura@chromium.org
BUG=none
test=trybots

Review URL: https://codereview.chromium.org/875473003

Cr-Commit-Position: refs/heads/master@{#313825}

This CL introduces JNI plumbing for one method of the FakeServer's
verification API. One test (testUploadTypedUrl) has been added to use
the API; it types a URL on the client and verifies that the URL was
sent to the server.

BUG=NONE

Review URL: https://codereview.chromium.org/862113005

Cr-Commit-Position: refs/heads/master@{#313824}

armansito@ is already an owner of device/bluetooth and device/nfc, so
make him and OWNER for the occasional unit test additions to device_tests.gyp.

BUG=none
R=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/886443003

Cr-Commit-Position: refs/heads/master@{#313823}

Review URL: https://codereview.chromium.org/889663004

Cr-Commit-Position: refs/heads/master@{#313822}

Now that AVX2 detection works turn on the code:
https://codereview.chromium.org/884013006

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/858153008

Cr-Commit-Position: refs/heads/master@{#313821}

BUG=412468

Review URL: https://codereview.chromium.org/859903002

Cr-Commit-Position: refs/heads/master@{#313820}

Now we are reusing code from components/policy, so we can get rid of the
self-shaming "hack" name in the policy_hack namespace and directory.

The changelist also:
- Inlines MockPolicyCallback into policy_watcher_unittest.cc
- Removes a misguided TODO comment in policy_watcher.h that used
  to say that components/policy filters out policies that do not
  match the schema (this is not true for polices from Chrome domain
  - see SchemaMap::FilterMap definition).

BUG=368321

Review URL: https://codereview.chromium.org/884243003

Cr-Commit-Position: refs/heads/master@{#313819}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a8902e8..4f92beb

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/874693005

Cr-Commit-Position: refs/heads/master@{#313818}

BUG=393291

Review URL: https://codereview.chromium.org/869133005

Cr-Commit-Position: refs/heads/master@{#313817}

So far, EarlyOut_DeferCommits is controlled by Proxy.
Because Scheduler doesn't know about this deferring, it triggers next
BeginMainFrame when main thread want to defer a commit.
This CL moves the EarlyOut_DeferCommits logic from Proxy to
Scheduler so Scheduler can stop next BeginMainFrame until defer commit is off.

R=brianderson@chromium.org, danakj@chromium.org, skyostil@chromium.org
BUG=382572
TEST=cc_unittests

Review URL: https://codereview.chromium.org/337693005

Cr-Commit-Position: refs/heads/master@{#313816}

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/889503002

Cr-Commit-Position: refs/heads/master@{#313815}

When sharing textures in mailboxes using MailboxManagerSync
there's an optimization that if textures are not updated then
there is no need to share it again. However the code that
checks whether textures are updated ignores the cleared
state, causing shared texture to remain uncleared
indefinitely.

Fix by check the cleared state. And add a unit test.

BUG=453199

Review URL: https://codereview.chromium.org/890453002

Cr-Commit-Position: refs/heads/master@{#313814}

Accelerated canvas and GPU raster both use the same Skia codepaths and
have generally displayed the same bugs.  It doesn't make sense to
blacklist one but not the other.  Since GPU raster sees more usage than
canvas nowadays, and I researched GPU raster compatibility as part of
https://codereview.chromium.org/760053003, it makes sense to fold canvas
into the same blacklist.

This immediately fixes an Adreno 225 canvas bug which slipped through a
driver-reported-version based blacklist, which is apparently unreliable
and which I deleted in this patch.  More generally it also should avoid
this kind of issue in the future.

BUG=453283
NOTRY=true

Review URL: https://codereview.chromium.org/877343008

Cr-Commit-Position: refs/heads/master@{#313813}

When "Choose what to sync" is clicked, we change the source to 3 in the
gaia continue url.

BUG=452440

Review URL: https://codereview.chromium.org/892493002

Cr-Commit-Position: refs/heads/master@{#313812}

BUG=449409

Review URL: https://codereview.chromium.org/889493002

Cr-Commit-Position: refs/heads/master@{#313811}

Those are not more used in chrome/browser and thus can be removed to
prevent others using them in chrome/browser land.

BUG=237267
TEST=checkdeps
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/880293003

Cr-Commit-Position: refs/heads/master@{#313810}

This adds controls to the C++ test server but doesn't use them yet. Also
ensure that tlslite never selects a 1.2 cipher suite when negotiating an
older version.

BUG=450733

Review URL: https://codereview.chromium.org/875683002

Cr-Commit-Position: refs/heads/master@{#313809}

GetWindowObject() get called during plugin initialization, Ignore that.

BUG=451197

Review URL: https://codereview.chromium.org/871113003

Cr-Commit-Position: refs/heads/master@{#313808}

This CL handles the case when a token is revoked, e.g. via
https://security.google.com/settings/security/permissions.

We need to instruct chrome.identity to remove the invalid cached
token and fetch a new one.  The app would then be reloaded app as
some of the app components (wcs sandbox) cached the invalid token
and cannot be cleanly reinitialized.

Summary of changes:
1. Implement app reloading using chrome.app.AppWindow API's and
   base.Ipc so that it can be called from foreground pages
2. Implement handleAuthFailure in remoting.identity and remoting.oauth2.
   In remoting.identity, we would remove the cached token and request a
   new one by prompting the user for consent.
3. Modify the call sites to use the new method.

BUG=339677

Review URL: https://codereview.chromium.org/868203002

Cr-Commit-Position: refs/heads/master@{#313807}

This will allow hardware video overlays to be enabled in the compositor

Review URL: https://codereview.chromium.org/806413004

Cr-Commit-Position: refs/heads/master@{#313806}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5444393..19d8f9f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/890703003

Cr-Commit-Position: refs/heads/master@{#313805}

Revert of Optimize all Chrome for Android PNG assets. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/889683002/)

Reason for revert:
Images got corrupted

Original issue's description:
> Optimize all Chrome for Android PNG assets.
>
> This change decreases our APK size by 67,065 bytes.
>
> R=newt@chromium.org
> TBR=tedchoc@chromium.org
> BUG=407781
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3952cc4232da78710734333340ae3181d5c20031

TBR=newt@chromium.org,tedchoc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=407781

Review URL: https://codereview.chromium.org/885743003

Cr-Commit-Position: refs/heads/master@{#313804}

Also add a TODO requested by Nico.

BUG=453195
R=thakis@chromium.org
CC=fdegans@chromium.org

Review URL: https://codereview.chromium.org/880403005

Cr-Commit-Position: refs/heads/master@{#313803}

BUG=440443

Review URL: https://codereview.chromium.org/885763002

Cr-Commit-Position: refs/heads/master@{#313802}

Currently we fetch the average character width from the GetTextExtentPoint32 API for DirectWrite as skia
does not return this value. The width returned by the GetTextExtentPoint32 API is 1 px larger than the one
reported by the TEXTMETRIC structure causing some dialogs like the bookmark editor to display much larger than that
with GDI.

We now use the average character width from the TEXTMETRIC structure while reporting back the metrics for DirectWrite
fonts. Longer term fix is to find out a way to calculate this from DirectWrite. Does not appear to be straigthforward.
Added a TODO to that effect in the code.

BUG=434588
TEST=Updated the PlatformFontWinTest.Metrics_SkiaVersusGDI test to validate the average character widths.
For manual test, launch Chrome and open the bookmark
editor on Windows 7+. Observe that the window size is larger than the window size when using GDI for fonts.

Review URL: https://codereview.chromium.org/875303003

Cr-Commit-Position: refs/heads/master@{#313801}

To match LTHI, change the max frames pending calculation to output DEFAULT_MAX_FRAMES_PENDING if the output surface reports 0.

Review URL: https://codereview.chromium.org/885933002

Cr-Commit-Position: refs/heads/master@{#313800}