- 19 Jun, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idac13e3dcb97f079284cfc0ad7160c4131b33629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780365}
-
rbpotter authored
- Add pak_base_dir option to map generated files based on a root directory other than the directory where the pak file is located. This is the case for the os settings build, where the pak file is under gen/c/b/r/settings/chromeos, but paths should be based on gen/c/b/r/settings. - Add exclude option to exclude certain files from being unpacked. This is to allow UIs like the NTP, downloads, and OS settings to keep files that should not be created by unpack_pak in their grd files. - Add an assert, ensure unpack_pak.py never creates files/directories outside of the unpak folder in future. Creating these directories can cause post-CQ build failures due to race conditions, as seen in the linked bug. Bug: 1093405 Change-Id: If85ea9f08c4dbe008ec16ca0a457390012833c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251050Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#780364}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/42f585a5ad09..f18c0ac2f735 2020-06-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-06-19 tvanderlippe@chromium.org Remove style three-dot menu in favor of autocompletions 2020-06-19 tvanderlippe@chromium.org Add missing e2e resources to BUILD.gn 2020-06-19 soxia@microsoft.com [DevTools] More info for Service Worker Fetch Responses 2020-06-19 petermarshall@chromium.org Disable tests to unblock chromium roller If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1066595,chromium:1088463,chromium:1097061 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9051e2654d1611b009d4df5ab50b15eaa921e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254210Reviewed-by:
-
Dave Tapuska authored
Convert these two messages to mojo messages on the blink WidgetHost interface. Calculation of the composition bounds, current input type are all moved from RenderWidget into WidgetBase. Some intermediate plumbing is required since not all input is in blink yet. BUG=1073560 Change-Id: I67bf118049d3bf186bdd4ff261f25917c097ee17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243531 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780362}
-
Chris Sharp authored
Change-Id: I2e8e6b066fee60218dcc8de247ea79a80318b842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252741 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780361}
-
Bailey Berro authored
Per discussion over email, change to "Small" and "Large" Change-Id: I3952847bcffd44202c3ec9dd6285e58d4e2de1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253204 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#780360}
-
chenjiadong authored
Previously,we judge whether the current media contains a video track to decide to pause the current playback after switching to the background. Because the media played through MediaPlayer are assumed to contain both audio and video tracks, they will all pause. In this scenario, we should judge whether the original size of the current media meta video is empty to determine whether it contains a video track. Bug: 1093697 Change-Id: I702465f677d9dd01b827051b21f77c20633a80c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241053Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#780359}
-
Vincent Boisselle authored
Bug: 1096614 Change-Id: Ib52bebaaca8cf2f361ed6ddf496e2ecb6fcc476f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252923Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#780358}
-
Maxime Charland authored
This CL is part of the Chrome Empties project for Bling. (Googlers only links) Design Doc: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing UX Specs with mocks: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1093575 Change-Id: I82b4914111f0b7a3f6050f8929b10bf7008e980b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246623Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#780357}
-
Mohamed Amir Yosef authored
When the account reauth fails, saving location is automatically switched to local store. In addition we should an IPH to make it clear to the user that the password will actually be stored locally. Namely this CL is doing the following: - Cache the results of reauth in ManagerPasswordState. - Adds plumbing for this value in UI controller and bubble controller. - Use the value in the view to show the IPH when the reauth fails. Screencast: https://screencast.googleplex.com/cast/NTk0NzE0NzA4ODI5Nzk4NHw0M2ZkYzk1Zi05OQ Bug: 1044038 Change-Id: I8ba4bc718fb322ec391b1292c1475eea3027dad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252239Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#780356}
-
Sean Gilhuly authored
This test needs a separate baseline on Windows using real GL. TBR=kbr@chromium.org Bug: 1096568 Change-Id: I20e8fbad74a0f1932bcc257137f851392327f724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254520Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#780355}
-
Michael Ludwig authored
Bug: 1097104 Change-Id: Id155df59b7e57cfc5db05988123d38197ba8d8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254083 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#780354}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/051c6fed884b..e20ac35adbfd 2020-06-19 johnkslang@users.noreply.github.com Merge pull request #2281 from ben-clayton/moar-kokoro If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I4ce39e968430f46df6e11b88cecefb3dbfc19a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254209Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6c42c47badbc59742f907f87d9e7223a8f3ed2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254340Reviewed-by:
-
Collin Baker authored
A previous UAF fix, https://chromium-review.googlesource.com/c/chromium/src/+/2242435, introduced this new UAF on browser shutdown. The new crash is likely caused by logging the session duration on Profile destruction. This logging was added in the previous fix but the new crash wasn't caught in the CQ. This CL drops the logging but still ensures ProfileActivityMetricsRecorder's Profile pointer is dropped when it's deleted. Fixed: 1096395 Change-Id: I3c357c18029c57a70f99a8be76fef376cda2b3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252657 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#780351}
-
chrome://internals/query-tiles.Hesen Zhang authored
Fixed closure build failure. set closure_compile = true in gn args and verified locally. This is a reland of 7981cdda Original change's description: > Setup chrome://internals/query-tiles. > > - Setup chrome://internals for future merge. > - Complete the front end code for chrome://internals/query-tiles. > > Bug: 1066556 > Change-Id: I51529f6e11dd37e15df2b7a3da1864dbbc5da58b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247544 > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780087} Bug: 1066556 Change-Id: I732e90165cf9a4489c84e3a364aaa063fb1a4218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253212Reviewed-by:
-
Khushal Sagar authored
R=zmo@chromium.org Bug: 10253933 Change-Id: I04269785755d7d606bde28375d8cd60fafddc0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253565 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#780349}
-
Regan Hsu authored
* Tooltip should be on RHS * Previously, refreshing DLC subpage would result in no DLCs being shown. Fixed: 1096354 Change-Id: I20feb64a36137cb22fa35b2e34526440728b8130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252847Reviewed-by:
-
Regan Hsu authored
Fixed: 1096430 Change-Id: Id2225cf0c19a55228adef2e207eca32c179cd16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251749 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3133dfdb809431669c15dc91e2a861cf85787298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254207Reviewed-by:
-
Andrew Xu authored
It is an issue exposed by the app scaling feature. Before app scaling, shelf icons re-layout usually animates a icon to the target bounds with the same size. It does not hold in app scaling where a shelf icon's size may shrink after shelf button addition. What's more, when a shelf button shrinks from the normal size (56*56) to the dense size (48*48), the button's icon image changes from 44*44 to 36*36. As a result, when scaling the shelf button, the icon image is not in the ideal bounds. It causes bad animation. In this CL, BoundsAnimator does not use transforms when the animated view's target bounds have a different size. Bug: 1019397 Change-Id: I57d9fbaf376e4a304ec3c6d0eedb33a8bb4e0c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242791Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780345}
-
Etienne Bergeron authored
This is a reland of 8e4ff348 The DCHECK in PlatformThreadLocalStorage::OnThreadExit(...) was incorrect for unittest. To trigger the issue that caused the revert of the original CL, an DCHECK needs to fail on a background thread. It is not necessary to set back the priority when the process is aborting. Relanding without DCHECK to get the fix right away. Will find another way than DCHECK of verifying code correctness since _exit() can legitimately be called by any code and hit that code path. (see: crbug/1097092 for followup) See: void Dummy() { DCHECK(false); } TEST(Broken, Priority) { base::test::TaskEnvironment task_environment_; base::ThreadPool::PostTask( FROM_HERE, {base::TaskPriority::BEST_EFFORT, base::MayBlock()}, base::BindOnce(&Dummy)); } This broken unittest will produce the following output: [ RUN ] Broken.Priority [16064:10444:0619/025028.262:543712406:FATAL:storage_queue_unittest.cc(30)] Check failed: false. Backtrace: base::debug::CollectStackTrace [0x00007FF90564E4B2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x00007FF9055568F2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x00007FF90556EE34+148] (C:\src\chromium\src\base\logging.cc:605) logging::LogMessage::~LogMessage [0x00007FF90556FBE0+16] (C:\src\chromium\src\base\logging.cc:598) Dummy [0x00007FF731A8E7A4+72] (C:\src\chromium\src\chrome\browser\policy\messaging_layer\storage\storage_queue_unittest.cc:30) base::TaskAnnotator::RunTask [0x00007FF9055DC156+454] (C:\src\chromium\src\base\task\common\task_annotator.cc:142) base::internal::TaskTracker::RunSkipOnShutdown [0x00007FF905614397+23] (C:\src\chromium\src\base\task\thread_pool\task_tracker.cc:769) base::internal::TaskTracker::RunTask [0x00007FF905613AA7+1335] (C:\src\chromium\src\base\task\thread_pool\task_tracker.cc:636) base::test::TaskEnvironment::TestTaskTracker::RunTask [0x00007FF734BF64D3+231] (C:\src\chromium\src\base\test\task_environment.cc:783) base::internal::TaskTracker::RunAndPopNextTask [0x00007FF9056131C2+498] (C:\src\chromium\src\base\task\thread_pool\task_tracker.cc:507) base::internal::WorkerThread::RunWorker [0x00007FF90562165C+1036] (C:\src\chromium\src\base\task\thread_pool\worker_thread.cc:349) base::internal::WorkerThread::RunBackgroundPooledWorker [0x00007FF905620FE8+24] (C:\src\chromium\src\base\task\thread_pool\worker_thread.cc:232) base::`anonymous namespace'::ThreadFunc [0x00007FF905667D0B+219] (C:\src\chromium\src\base\threading\platform_thread_win.cc:114) BaseThreadInitThunk [0x00007FF962404034+20] RtlUserThreadStart [0x00007FF964443691+33] Task trace: Backtrace: Broken_Priority_Test::TestBody [0x00007FF731A8E851+153] (C:\src\chromium\src\chrome\browser\policy\messaging_layer\storage\storage_queue_unittest.cc:35) [16064:10444:0619/025030.124:543714281:FATAL:thread_local_storage.cc(333)] Check failed: PlatformThread::GetCurrentThreadPriority() >= ThreadPriority::NORMAL (0 vs. 1) Backtrace: base::debug::CollectStackTrace [0x00007FF90564E4B2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x00007FF9055568F2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x00007FF90556EE34+148] (C:\src\chromium\src\base\logging.cc:605) logging::LogMessage::~LogMessage [0x00007FF90556FBE0+16] (C:\src\chromium\src\base\logging.cc:598) base::internal::PlatformThreadLocalStorage::OnThreadExit [0x00007FF9056322DF+175] (C:\src\chromium\src\base\threading\thread_local_storage.cc:335) RtlActivateActivationContextUnsafeFast [0x00007FF96440B583+291] RtlActivateActivationContextUnsafeFast [0x00007FF96440B67F+543] LdrShutdownProcess [0x00007FF964417F70+272] RtlExitUserProcess [0x00007FF964417E48+216] FatalExit [0x00007FF96240CA7A+10] exit [0x00007FF96156CC08+200] exit [0x00007FF96156CBBB+123] base::TestSuite::UnitTestAssertHandler [0x00007FF734BFB748+230] (C:\src\chromium\src\base\test\test_suite.cc:518) base::internal::Invoker<base::internal::BindState<void (base::TestSuite::*)(const char *, int, base::BasicStringPiece<std::__1::basic_string<char,std::__1::char_traits<char>,std::__1::allocator<char> > >, base::BasicStringPiece<std::__1::basic_string<char [0x00007FF734BFD2DE+68] (C:\src\chromium\src\base\bind_internal.h:691) logging::LogMessage::~LogMessage [0x00007FF90556F342+1442] (C:\src\chromium\src\base\logging.cc:914) logging::LogMessage::~LogMessage [0x00007FF90556FBE0+16] (C:\src\chromium\src\base\logging.cc:598) Dummy [0x00007FF731A8E7A4+72] (C:\src\chromium\src\chrome\browser\policy\messaging_layer\storage\storage_queue_unittest.cc:30) base::TaskAnnotator::RunTask [0x00007FF9055DC156+454] (C:\src\chromium\src\base\task\common\task_annotator.cc:142) base::internal::TaskTracker::RunSkipOnShutdown [0x00007FF905614397+23] (C:\src\chromium\src\base\task\thread_pool\task_tracker.cc:769) base::internal::TaskTracker::RunTask [0x00007FF905613AA7+1335] (C:\src\chromium\src\base\task\thread_pool\task_tracker.cc:636) base::test::TaskEnvironment::TestTaskTracker::RunTask [0x00007FF734BF64D3+231] (C:\src\chromium\src\base\test\task_environment.cc:783) base::internal::TaskTracker::RunAndPopNextTask [0x00007FF9056131C2+498] (C:\src\chromium\src\base\task\thread_pool\task_tracker.cc:507) base::internal::WorkerThread::RunWorker [0x00007FF90562165C+1036] (C:\src\chromium\src\base\task\thread_pool\worker_thread.cc:349) base::internal::WorkerThread::RunBackgroundPooledWorker [0x00007FF905620FE8+24] (C:\src\chromium\src\base\task\thread_pool\worker_thread.cc:232) base::`anonymous namespace'::ThreadFunc [0x00007FF905667D0B+219] (C:\src\chromium\src\base\threading\platform_thread_win.cc:114) BaseThreadInitThunk [0x00007FF962404034+20] RtlUserThreadStart [0x00007FF964443691+33] Original change's description: > Avoid running TLS destructors at background priority > > This CL is adding a ScopedThreadPriority that save the current > thread priority and restore it when leaving the scope. This is > required since it is possible to run code outside of the Run(...) > scope with Background priority. > > On Windows, this is causing shutdown hangs because the LoaderLock > can be held by a background thread while doing TLS destruction. > > > Without this fix, the DCHECK in the code run with Background priority > and fails: > > [9888:28656:0617/210735.064:FATAL:thread_local_storage.cc(331)] Check failed: PlatformThread::GetCurrentThreadPriority() != ThreadPriority::BACKGROUND (0 vs. 0) > Backtrace: > base::debug::CollectStackTrace [0x00007FF92445E7D2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284) > base::debug::StackTrace::StackTrace [0x00007FF9243668F2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:203) > logging::LogMessage::~LogMessage [0x00007FF92437F094+148] (C:\src\chromium\src\base\logging.cc:605) > logging::LogMessage::~LogMessage [0x00007FF92437FE40+16] (C:\src\chromium\src\base\logging.cc:598) > base::internal::PlatformThreadLocalStorage::OnThreadExit [0x00007FF9244425FA+170] (C:\src\chromium\src\base\threading\thread_local_storage.cc:333) > RtlActivateActivationContextUnsafeFast [0x00007FF96440B583+291] > RtlActivateActivationContextUnsafeFast [0x00007FF96440B67F+543] > LdrShutdownThread [0x00007FF964408B8C+348] > RtlExitUserThread [0x00007FF9644436FE+62] > BaseThreadInitThunk [0x00007FF96240403C+28] > RtlUserThreadStart [0x00007FF964443691+33] > > Bug: 1096203 > Change-Id: Ibc011ac370dde4b6a872da6ac81938f52965a5a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251199 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779932} Bug: 1096203 Change-Id: Ia0a5e01cd4d0918809b5262b2f6547880c0b5a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252880 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#780344}
-
Finnur Thorarinsson authored
This changes the SeekBar to have rounded edges. Screenshot: https://crbug.com/895776#c57 Bug: 895776, 656015 Change-Id: I440a539d9f80af53e672afd65927cff9cf40a13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250184 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#780343}
-
Colin Blundell authored
This TODO is not about the initial incorporation of translate in WebLayer. Bug: 1025620, 1073370 Change-Id: Iadfe5580464d90de7073a076ee59e97784d74aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254320 Commit-Queue: Colin Blundell <blundell@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#780342}
-
Natalie Chouinard authored
NativeLibraryTestRule doesn't use any TestRule behavior, so refactor it to a static util class so that it can be more easily referenced by other TestRules. Original class kept as a wrapper class until all usages (including downstream) are removed in follow-up CLs. Bug: 1096666 Change-Id: Ieacec3cc04b34be321b6eaa65f6c9a524b7f71c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251099Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#780341}
-
Andy Paicu authored
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse:media:googleplaystore:2018 benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:social:vk:2018 benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/browse_accessibility:tech:codesearch:2018 TBR=sullivan@chromium.org Bug: 1097065 Change-Id: Ibc1da2f9e0628177182eb61c16401368cae35ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253979Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780340}
-
Evan Stade authored
CookieControlsController also moves. The only code change is to change the construction parameters of CookieControlsController so that it doesn't depend on PermissionsClient. Bug: 1071775 Change-Id: Ifffb29e83b9d75823920652ce73f5aa0c2b0b5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240008Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#780339}
-
Will Cassella authored
If HTMLMediaElement::Play is called before HTMLMediaElement::LoadTimerFired is run, then LoadTimerFired will set the 'show-poster-flag' to 'true', and nothing will unset it even after playback begins. This was because the call to 'SetShowPosterFlag(true)' was in the wrong location, this CL moves it to the right location, and adds a test to prevent regression. Bug: 1094778, 1095320 Change-Id: Ia1c558a35f2816136994c0013061d2e00ae90ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249459 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#780338}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/693e88ae8516..be637db5897d 2020-06-19 cwallez@chromium.org Vulkan: Correctly request 16bit shader features. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I439dc753de2b0ea0ffb8df3aba302684fea81e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254200Reviewed-by:
-
Eric Seckler authored
The "TtsPlatformImpl:initialize" event is used around an async task that executes in the background, thus should be an async trace event outside the current thread's track. Change-Id: Icc89048a1c7e2a9659e12fbe74d5b0600b6becf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252166 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#780336}
-
Peter Kotwicz authored
Disable DiskWrite Strict Mode checking in DecoderServiceHost#dispatchDecodeImageRequest() BUG=1095374 Change-Id: Id6a501aaba0fbfebd7833efcb48e22103d665a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247381Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#780335}
-
Olya Kalitova authored
Replaces recommended free disk space message with required free disk space message when there is not enough free disk space for Plugin VM installation. Also updates confirmation message for setup flow before it is started. Bug: b/157584005 Change-Id: Ie95058e21d086cd34b8b31b115b602b9c27a71b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236354 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780334}
-
Anthony Vallee-Dubois authored
This also renames the kCBCMServiceAccounts feature to kCBCMPolicyInvalidations. Bug:1026261 Change-Id: Iae54bca447e3af263fc3fd1840639c04ed3652d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175542Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c137c524b78..d43ba60f648c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aaronhk@google.com,andypaicu@google.com Change-Id: I8439c1a4743a6940c9db6cd5064ad9009ebe20ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254199Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780332}
-
Bartek Nowierski authored
This are needed when Chrome codebase is automatically rewritten to use CheckedPtr (see go/miracleptr for project description). Bug: 1080832 Change-Id: I1ca4ac87d37f57de8304fc22e0ba36cb60ca323a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243072 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#780331}
-
Rushan Suleymanov authored
This patch introduces two histograms for initial merge and remote update which counts number of remote specifics without full title: * Sync.BookmarkWithoutFullTitle.OnRemoteUpdate * Sync.BookmarkWithoutFullTitle.OnInitialMerge Bug: 1061411 Change-Id: Ife656adc183473a4860ee15a4941d9b25cb01061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252048Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#780330}
-
Stephen Roe authored
Build times for the arm64 CQ 10% bot experiment over the last 6 days are similar to the existing x64 CQ trybot: builder fuchsia_arm64 fuchsia_x64 builds 487 5109 build_minutes_p50 31.42 24.98 build_minutes_p70 46.82 40.13 build_minutes_p90 56.05 51.45 Stability is good at 10% https://ci.chromium.org/p/chromium/builders/try/fuchsia_arm64 Capacity is also good at 10%. The average number of arm64 bots running at one time at 10% CQ varies from 8 to 15 by day out of 240 bots. Typical spikes are 50 to 60 bots active when a CL build is in progress or 100 to 120 bots active when two CL builds overlap. Pending times at 10% CQ are low. p90 is 2 seconds, p95 is 8 seconds. There is more build time info at https://docs.google.com/spreadsheets/d/1Z_iOiX-9mTDxJrZJri97A-JY-goYkTHlKU4M9EDXLpA There is more pending time info at https://docs.google.com/spreadsheets/d/1YdszSQlLDi5X4Qnakess7YIfSLBu4hzZJ3aZ6cKPFX4 There is more capacity and bot usage info at https://docs.google.com/spreadsheets/d/1Zfn5w9yMB1oINtinS1KMblRbB209YfkqQsHRUKxdk7Q Bug: 1042511 Change-Id: I0b37c7602ddc8fa853dc6e18eeceb2ef396b8e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252634Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#780329}
-
Yue Zhang authored
Since intents from YouTube don't have an app ID attached, this CL uses URL prefix as a proxy to support recording external intent related UMA for YouTube by checking if the url starts with "www.youtube.com/redirect?". Bug: 1095515 Change-Id: I610d5b62470fb8ef4273a3d82abf991205d035af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249045Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#780328}
-
Alexander Hendrich authored
The new API is only available to force-installed (see intro) extensions running on Chrome OS. Bug: 1081333 Change-Id: I5388e0d7e9af1150415226a11c4152d2196bb9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250001 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#780327}
-
Ken MacKay authored
Bug: internal b/158335072 Change-Id: Ic3413ccd9722a8fadc05fb36a8a2e9c821cf65ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240275Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#780326}
-
