GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202854 0039d316-1c4b-4281-b951-d872f2087c98

r1636 Android backend: fix references to source top dir.

BUG=
TBR=sbc@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16168007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202853 0039d316-1c4b-4281-b951-d872f2087c98

This patch implements the Shell::Close() method for Content Shell on Android.

BUG=138226

Review URL: https://chromiumcodereview.appspot.com/14977010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202852 0039d316-1c4b-4281-b951-d872f2087c98

At the same time this
- removes a lot of unnecessary code testing_automation_provider* and pyauto,
- removes the dependency of testing_automation_provider* on ProxyConfigServiceImpl.

BUG=234982
TEST=New browser_tests. Ran pyauto test testCachedCredentialsAddUser locally.

Review URL: https://chromiumcodereview.appspot.com/16045005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202849 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land after first version (r202580) was reverted. The problem was
that extra invalidations occurred due to a call to SetNeedsCommit(). The
solution is to avoid calling SetNeedsCommit(), and accept that this debug info
will be stale on the impl-thread until something else commits.

BUG=240946

Review URL: https://chromiumcodereview.appspot.com/16023024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202848 0039d316-1c4b-4281-b951-d872f2087c98

Also adds a way of generically making any textfield or combobox disabled if necessary.

R=estade@chromium.org
BUG=180147

Review URL: https://chromiumcodereview.appspot.com/15979002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202847 0039d316-1c4b-4281-b951-d872f2087c98

Also remove unnecessary code in local_file_util.cc.

BUG=241701

Review URL: https://chromiumcodereview.appspot.com/15686005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244102
TBR=bruening
NOTRY=true

Review URL: https://codereview.chromium.org/16072011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202845 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
BUG=163314
NOTRY=true

Review URL: https://codereview.chromium.org/15924008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241113
TEST=browser_tests --gtest_filter="*FileManager*"

Review URL: https://chromiumcodereview.appspot.com/15919006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202843 0039d316-1c4b-4281-b951-d872f2087c98

To be able to use input method just after log-in, we should notify the end of
ime initialization to input method engine, otherwise onActivate event will be
missed.

The right way to fix this issue is migrating packaged app and working with lazy 
background page, but it requires much effort both for chrome and extension side
so and hard to merge to M28. So please let me add this temporary hack.

BUG=242864
TEST=Manually checked on link

Review URL: https://chromiumcodereview.appspot.com/15912004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202842 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163314
R=glider@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15870005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237277

Review URL: https://chromiumcodereview.appspot.com/15810003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242989

Review URL: https://chromiumcodereview.appspot.com/15747009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202839 0039d316-1c4b-4281-b951-d872f2087c98

Adds a flag for --enable-app-launcher-shim to chrome://flags. Enable to 
ensure an OSX app bundle for the App Launcher exists under the 
Applications folder. If the flag is not present any previously created 
app bundle for the App Launcher will be deleted on startup. 

BUG=138633
TEST=Tested enabling and disabling the flag in chrome://flags.

Review URL: https://chromiumcodereview.appspot.com/15675008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202838 0039d316-1c4b-4281-b951-d872f2087c98

This patch moves the file type select drop-down list towards right by putting it inside of the button bar.

TEST=Open an image in a browser window. Hit CTRL+S.
BUG=242195

Review URL: https://chromiumcodereview.appspot.com/15674006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202837 0039d316-1c4b-4281-b951-d872f2087c98

1) Deprecated the UMA key "Translate.ServerReportedUnsupportedLanguage" (the internal histograms.xml should be modified later).

2) Added the UMA key "Translate.UnavailableLanguage" which is sent when the language is reported by the server but not available for the user locale.
[We decided to implement a new UMA instead of 2) in another CL]

3) Added the UMA key "Translate.UnsupportedLanguageAtInitiation" which is sent when the language was unsupported during initialization.

BUG=242142
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/15311006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202836 0039d316-1c4b-4281-b951-d872f2087c98

> Protect WebURLLoaderImpl::Context while receiving responses.
> 
> A client's didReceiveResponse can cancel a request; by protecting the
> Context we avoid a use after free in this case.
> 
> Interestingly, we really had very good warning about this problem, see 
> https://codereview.chromium.org/11900002/ back in January.
> 
> R=darin
> BUG=241139
> 
> Review URL: https://chromiumcodereview.appspot.com/15738007

TBR=gavinp@chromium.org

Review URL: https://codereview.chromium.org/15859009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202835 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes the title no bold and 15 pixels size to match the recent specs.

TBR=yoshiki@chromium.org
TEST=Tested manually. Invoke the open with dialog on a file which has more than one handler.
BUG=239304

Review URL: https://chromiumcodereview.appspot.com/16014003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202830 0039d316-1c4b-4281-b951-d872f2087c98

This patch add basic tests for the video player. It opens an OGV video in both: drive and downloads and checks if the video is loaded properly and the window size is set to the video size.

TEST=browser_tests
BUG=244146

Review URL: https://chromiumcodereview.appspot.com/15984003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202829 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15848005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202828 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Remove fileapi::FileSystemMountPointProvider::InitializeCopyOrMoveFileValidatorFactory() and make it a method only in TestMountPointProvider.

Review URL: https://chromiumcodereview.appspot.com/15729007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202827 0039d316-1c4b-4281-b951-d872f2087c98

This appears on the new tab page.

BUG=243203
R=dbeam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15825003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202826 0039d316-1c4b-4281-b951-d872f2087c98

r201206 caused a regression. It broke animation cursors, because SkBitmap.extractSubset() doesn't extract a frame of animation cursor image. This patch fixes the regression, using SkBitmapOperations::CreateTiledBitmap to extract a frame of animation image instead of SkBitmap.extractSubset().

BUG=126942
TEST=The wait cursor animates correctly.

Review URL: https://chromiumcodereview.appspot.com/15896012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202825 0039d316-1c4b-4281-b951-d872f2087c98

Allows for custom name to be passed to GPU process,
where it can be used for debugging.

BUG=181711

Review URL: https://chromiumcodereview.appspot.com/15673005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202824 0039d316-1c4b-4281-b951-d872f2087c98

How come this code got in... anyway fixing.

BUG=243753
R=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/16097005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202823 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the selection was getting gray when using the 'select-all' checkbox, because it was taking the focus. This patch fixes this issue by preventing from stealing the focus when clicking anywhere on the header. Moreover, the separating lines in the file list have been removed to match the recent specs.

TEST=Tested manually. Go to Files.app, select all using the checkbox.
BUG=239284

Review URL: https://chromiumcodereview.appspot.com/16007004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202822 0039d316-1c4b-4281-b951-d872f2087c98

A client's didReceiveResponse can cancel a request; by protecting the
Context we avoid a use after free in this case.

Interestingly, we really had very good warning about this problem, see 
https://codereview.chromium.org/11900002/ back in January.

R=darin
BUG=241139

Review URL: https://chromiumcodereview.appspot.com/15738007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202821 0039d316-1c4b-4281-b951-d872f2087c98

Binary files from https://codereview.chromium.org/14631022/

BUG=159733
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/15848008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202820 0039d316-1c4b-4281-b951-d872f2087c98

This CL added assets of checkbox and updated CSS to use them.

BUG=239281
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/15651004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202819 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the alignment so the text in the rows is properly vertically centered.

TBR=yoshiki@chromium.org
TEST=Run Files.app, select an item.
BUG=none

Review URL: https://chromiumcodereview.appspot.com/16168003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202818 0039d316-1c4b-4281-b951-d872f2087c98

This increases the minimum dimensions that ash uses when
detecting video for the purpose of preventing the screen
from being dimmed. It's unlikely that any given set of
numbers will be perfect here, but this may help avoid some
false positives caused by animated advertisements.

BUG=171456

Review URL: https://chromiumcodereview.appspot.com/16174002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202817 0039d316-1c4b-4281-b951-d872f2087c98

The comments on the SelectFile() method says it is safe to pass NULL to the arg params. However, this is not true on the Android implementation of the function, SelectFileDialogImpl::SelectFileImpl() for Android.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/16082002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202816 0039d316-1c4b-4281-b951-d872f2087c98

AutofillDialogController is self-destroying on ViewClosed. Thus,
TestAutofillDialogController::runner_ is not available after ViewClosed,
and RunMessageLoop must live on the TestFixture instead, since it is
potentially run after the view has been closed (via controller->Hide)

BUG=234008
TEST=none
R=avi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16054005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202815 0039d316-1c4b-4281-b951-d872f2087c98

Because the display scale factor and the window size are sent in two different
IPCs, and because the window size (ViewMsg_Resize) may be delayed (to avoid
spamming the renderer with resize messages while dragging), the renderer can
think it's using a different resolution than it is.

This merges the ViewMsg_ScreenInfoChanged and ViewMsg_Resize messages,
so that the renderer cannot not have a consistent view of the window size and
DPI.

BUG=239624

Review URL: https://chromiumcodereview.appspot.com/16048003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202814 0039d316-1c4b-4281-b951-d872f2087c98

This patch replaces line-height with padding to avoid an ugly, not centered selection.

TBR=yoshiki@chromium.org
TEST=Go to Files.app, edit a file.
BUG=239305

Review URL: https://chromiumcodereview.appspot.com/16007010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202813 0039d316-1c4b-4281-b951-d872f2087c98

If styles.xml has paddingStart and exists in values/, it will cause
crashes on Galaxy Tab&Note because style resources are not overrided by
the generated styles.xml (generate_v14_compatible_resources.py), which is to
avoid crashes on Galaxy Tab&Note (crbug.com/235118). So make
generate_v14_compatible_resource.py use styles.xml under values-v17/ not values/

BUG=243952

Review URL: https://chromiumcodereview.appspot.com/16125003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202812 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of issue 14299011, which broke GLSurfaceGLX, in turn breaking Chrome Linux/Aura.

This CL changes WeakPtr in the following ways: 
* Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them. 
* Removes WeakPtrFactory::DetachFromThread. 
* Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.

Calling code changes to allow this: 
* Unnecessary use of SupportsWeakPtr removed from SGIVideoSyncProviderThreadShim.
* Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
* DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx. 

WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use. 

TBR=darin,awong
BUG=232143, 234964, 243914

Review URL: https://chromiumcodereview.appspot.com/16007009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202811 0039d316-1c4b-4281-b951-d872f2087c98

In particular, remove STATE_SEND_BODY,
STATE_SEND_BODY_COMPLETE, SPDY_WAITING_FOR_RESPONSE and
instead add logic to detect when we receive an out-of-place
response.

Fix tests that were using the wrong SpdyStreamType and
weren't using a delegate.

Add various TODOs.

BUG=243643
R=rch@chromium.org

Review URL: https://codereview.chromium.org/15892015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202810 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202809 0039d316-1c4b-4281-b951-d872f2087c98